{"id":2233202,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2233202/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505201905.997996-27-zycai@linux.ibm.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260505201905.997996-27-zycai@linux.ibm.com>","list_archive_url":null,"date":"2026-05-05T20:18:58","name":"[v11,26/32] hw/s390x/ipl: Set IPIB flags for secure IPL","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5e9f50fccc4289c7c3eb334e8e7e3d97798b1ee2","submitter":{"id":90643,"url":"http://patchwork.ozlabs.org/api/1.2/people/90643/?format=json","name":"Zhuoying Cai","email":"zycai@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505201905.997996-27-zycai@linux.ibm.com/mbox/","series":[{"id":502896,"url":"http://patchwork.ozlabs.org/api/1.2/series/502896/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502896","date":"2026-05-05T20:18:37","name":"Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices","version":11,"mbox":"http://patchwork.ozlabs.org/series/502896/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233202/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233202/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=bpNP4kTd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g991k1sY2z1yJx\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 06 May 2026 06:23:06 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wKMFr-0001Fl-1y; Tue, 05 May 2026 16:20:31 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1wKMFh-00010f-WF; Tue, 05 May 2026 16:20:22 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1wKMFg-0000Kt-CR; Tue, 05 May 2026 16:20:21 -0400","from pps.filterd (m0356516.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 645F4lOO2204349; Tue, 5 May 2026 20:19:56 GMT","from ppma11.dal12v.mail.ibm.com\n (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dw9w6d6rp-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 05 May 2026 20:19:56 +0000 (GMT)","from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1])\n by ppma11.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 645K9Qra015552;\n Tue, 5 May 2026 20:19:55 GMT","from smtprelay04.dal12v.mail.ibm.com ([172.16.1.6])\n by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dwx9yb272-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 05 May 2026 20:19:55 +0000 (GMT)","from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com\n [10.39.53.229])\n by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 645KJsA327132646\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Tue, 5 May 2026 20:19:55 GMT","from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id A1A9C58059;\n Tue,  5 May 2026 20:19:54 +0000 (GMT)","from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 0F3A05805C;\n Tue,  5 May 2026 20:19:53 +0000 (GMT)","from fedora-workstation.pok.ibm.com (unknown [9.12.79.241])\n by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Tue,  5 May 2026 20:19:52 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=Bgyq104mrphet7nAN\n WLHEuSdqvbcalxtebGqiXGB5Qk=; b=bpNP4kTdLvPNun6nfArXSc9n11FlpCjN5\n 3Gn4v0uGZ98u5cVKW0xhD0CIZrX2xS1GU0+pHt3VtYpSGKReZu5VSTjh2Fo3oUpZ\n dvRaa2UWQ0KZxJM5BBNWbm8p2zHQHz8zIt7tigTpqwQX2m/EQKA2kZpaoU51Sqve\n ZE1nxI/Cxw7bxJcW+c/b9poR852uxm+GHYEpKjeRwVPwlybuHsoMDxbYRaVKN4KA\n TuWKmpADYzTQ2fdt2mP3kfTBB18iKaIUdU67Cm+Tlny85A8qiKhVvx6/QFUKtkNq\n xS2o3rGMrqcN9vxa8Vvq/4Uns/1Sd6bSx8GyqQI86DH2NKADx2vcQ==","From":"Zhuoying Cai <zycai@linux.ibm.com>","To":"qemu-s390x@nongnu.org, qemu-devel@nongnu.org","Cc":"jrossi@linux.ibm.com, cohuck@redhat.com, berrange@redhat.com,\n richard.henderson@linaro.org, david@kernel.org, walling@linux.ibm.com,\n jjherne@linux.ibm.com, pasic@linux.ibm.com, borntraeger@linux.ibm.com,\n farman@linux.ibm.com, mjrosato@linux.ibm.com, iii@linux.ibm.com,\n eblake@redhat.com, armbru@redhat.com, zycai@linux.ibm.com,\n alifm@linux.ibm.com, brueckner@linux.ibm.com,\n pierrick.bouvier@oss.qualcomm.com, jdaley@linux.ibm.com","Subject":"[PATCH v11 26/32] hw/s390x/ipl: Set IPIB flags for secure IPL","Date":"Tue,  5 May 2026 16:18:58 -0400","Message-ID":"<20260505201905.997996-27-zycai@linux.ibm.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260505201905.997996-1-zycai@linux.ibm.com>","References":"<20260505201905.997996-1-zycai@linux.ibm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Authority-Analysis":"v=2.4 cv=XPQAjwhE c=1 sm=1 tr=0 ts=69fa50ec cx=c_pps\n a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17\n a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8\n a=MUQpW0jNMHjpGy_Q9scA:9","X-Proofpoint-ORIG-GUID":"Ywa-zkVj39GO9M8X6BuUWukAYiJYHEId","X-Proofpoint-GUID":"Ywa-zkVj39GO9M8X6BuUWukAYiJYHEId","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTA1MDE5NSBTYWx0ZWRfX1YYR47QrZq/R\n DfO6bHDp+gOw5scE7ZF3Onlu6z3+hyCgAU6HNA0u2i5bziQ4ls+9uLaJyiV0NGPIlLKWbqlki8S\n eLsquXKSe0QEzlK//A0bUmOAkCRTPNqP18U0QM+MGZt2sYCu1lSjxTwxOveg0UEQrQiKfuS/Pc6\n H+UgfiejpahD4/16xWNB2YaTM5jGPLUzOZk1pFh4ISjVg2RVKW5W86ORpIE54uKNNsO3exPqveh\n 4g6+Y9XdBLcSl/jlJk3gSNzdjq1gzBH9LPq2ZsVIszj+OJeGXzTiM8a2JoxbqBYfDkkxwW2qyp9\n OYby29KkCbRoISpAuVWCqdfQVum09ajkkD2ePckNbyqS+fE5QPb+MwAkm/0gQ5F0hrxw2Ue2AAV\n Z92ytX/c6BkmISCSFDltkve5lA+bFooZt2OoUlkJUz+R6j3Z/a5n0xlnjObLt0GBcY2wIIwiK2Z\n 1ZQaOsN1R6PH9wWYEag==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-05_02,2026-04-30_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n bulkscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 spamscore=0\n priorityscore=1501 impostorscore=0 phishscore=0 malwarescore=0 clxscore=1015\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050195","Received-SPF":"pass client-ip=148.163.158.5; envelope-from=zycai@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"If `-M secure-boot=on` is specified on the command line option, indicating\ntrue secure IPL enabled, set Secure-IPL bit and IPL-Information-Report\nbit on in IPIB Flags field, and trigger true secure IPL in the S390 BIOS.\n\nAny error that occurs during true secure IPL will cause the IPL to\nterminate.\n\nSigned-off-by: Zhuoying Cai <zycai@linux.ibm.com>\nReviewed-by: Thomas Huth <thuth@redhat.com>\nReviewed-by: Collin Walling <walling@linux.ibm.com>\n---\n hw/s390x/ipl.c | 19 ++++++++++++++++++-\n 1 file changed, 18 insertions(+), 1 deletion(-)","diff":"diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c\nindex f4311f6d62..67e8231c76 100644\n--- a/hw/s390x/ipl.c\n+++ b/hw/s390x/ipl.c\n@@ -468,6 +468,11 @@ static bool s390_has_certificate(void)\n     return ipl->cert_store.count > 0;\n }\n \n+static bool s390_secure_boot_enabled(void)\n+{\n+    return S390_CCW_MACHINE(qdev_get_machine())->secure_boot;\n+}\n+\n static bool s390_build_iplb(DeviceState *dev_st, IplParameterBlock *iplb)\n {\n     CcwDevice *ccw_dev = NULL;\n@@ -524,6 +529,18 @@ static bool s390_build_iplb(DeviceState *dev_st, IplParameterBlock *iplb)\n         s390_ipl_convert_loadparm((char *)lp, iplb->loadparm);\n         iplb->flags |= DIAG308_FLAGS_LP_VALID;\n \n+        /*\n+         * If secure-boot is enabled, then toggle the secure IPL flags to\n+         * trigger secure boot in the s390 BIOS.\n+         *\n+         * Boot process will terminate if any error occurs during secure boot.\n+         *\n+         * If SIPL is on, IPLIR must also be on.\n+         */\n+        if (s390_secure_boot_enabled()) {\n+            iplb->hdr_flags |= (DIAG308_IPIB_FLAGS_SIPL | DIAG308_IPIB_FLAGS_IPLIR);\n+            iplb->len = cpu_to_be32(S390_IPLB_MAX_LEN);\n+        }\n         /*\n          * Secure boot in audit mode will perform\n          * if certificate(s) exist in the key store.\n@@ -533,7 +550,7 @@ static bool s390_build_iplb(DeviceState *dev_st, IplParameterBlock *iplb)\n          *\n          * Results of secure boot will be stored in IIRB.\n          */\n-        if (s390_has_certificate()) {\n+        else if (s390_has_certificate()) {\n             iplb->hdr_flags |= DIAG308_IPIB_FLAGS_IPLIR;\n             iplb->len = cpu_to_be32(S390_IPLB_MAX_LEN);\n         }\n","prefixes":["v11","26/32"]}