{"id":2233199,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2233199/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505201905.997996-7-zycai@linux.ibm.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260505201905.997996-7-zycai@linux.ibm.com>","list_archive_url":null,"date":"2026-05-05T20:18:38","name":"[v11,06/32] s390x/diag: Refactor address validation check from diag308_parm_check","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"70d9fb05daf4aea056826a96bdd95634d072e53f","submitter":{"id":90643,"url":"http://patchwork.ozlabs.org/api/1.2/people/90643/?format=json","name":"Zhuoying Cai","email":"zycai@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505201905.997996-7-zycai@linux.ibm.com/mbox/","series":[{"id":502896,"url":"http://patchwork.ozlabs.org/api/1.2/series/502896/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502896","date":"2026-05-05T20:18:37","name":"Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices","version":11,"mbox":"http://patchwork.ozlabs.org/series/502896/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233199/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233199/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=lIlsFLpW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g99146S74z1yJx\n\tfor ; Wed, 06 May 2026 06:22:32 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKMEu-0007bP-AO; Tue, 05 May 2026 16:19:32 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKMEp-0007Us-Qz; Tue, 05 May 2026 16:19:28 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKMEn-0000C4-Lu; Tue, 05 May 2026 16:19:26 -0400","from pps.filterd (m0356516.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 645JkhQD3254680; Tue, 5 May 2026 20:19:22 GMT","from ppma13.dal12v.mail.ibm.com\n (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dw9w6d6pe-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 05 May 2026 20:19:21 +0000 (GMT)","from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1])\n by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 645K9aoK030299;\n Tue, 5 May 2026 20:19:20 GMT","from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68])\n by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dwwtgb51x-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 05 May 2026 20:19:20 +0000 (GMT)","from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com\n [10.39.53.229])\n by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 645KJJWZ4260620\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Tue, 5 May 2026 20:19:19 GMT","from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 38F955805C;\n Tue, 5 May 2026 20:19:19 +0000 (GMT)","from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 99F0958059;\n Tue, 5 May 2026 20:19:17 +0000 (GMT)","from fedora-workstation.pok.ibm.com (unknown [9.12.79.241])\n by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Tue, 5 May 2026 20:19:17 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=tvtfr74wkw/Lg/VqL\n +CKXfMty2R0apkHvo7zbUmO+tw=; b=lIlsFLpWaJJKg9sp8QwmIzbj0llYM2lZd\n KDwIYrVLsYRn7j8QMyvCa2P0ivvHQc7cCgXKXXkCQuBAmP2nFUJ3udsdvDsCj9eu\n emVvu5sREn4bcg8dewdPrhBnalsVlrBgzKCEzcIFsRjfncYkqriRVBCcFSODiYN1\n fnTjKDmkBBvXnb5HuPsZfNKx3u654pFDaA86LKVvkNHPDwSQpzly2WQnaJUv0IHS\n 3fmMp5sd8xDZo2zm/H/g1Kf6arZ2dz6aSUa2rZMsFLtvWCEyeS8P/2GtxWZOotsS\n 9cQMHwkJp5rRiNylPy/QhvwLuDckw8x3/f9pZeVylWqjL8qCqeKIA==","From":"Zhuoying Cai ","To":"qemu-s390x@nongnu.org, qemu-devel@nongnu.org","Cc":"jrossi@linux.ibm.com, cohuck@redhat.com, berrange@redhat.com,\n richard.henderson@linaro.org, david@kernel.org, walling@linux.ibm.com,\n jjherne@linux.ibm.com, pasic@linux.ibm.com, borntraeger@linux.ibm.com,\n farman@linux.ibm.com, mjrosato@linux.ibm.com, iii@linux.ibm.com,\n eblake@redhat.com, armbru@redhat.com, zycai@linux.ibm.com,\n alifm@linux.ibm.com, brueckner@linux.ibm.com,\n pierrick.bouvier@oss.qualcomm.com, jdaley@linux.ibm.com","Subject":"[PATCH v11 06/32] s390x/diag: Refactor address validation check from\n diag308_parm_check","Date":"Tue, 5 May 2026 16:18:38 -0400","Message-ID":"<20260505201905.997996-7-zycai@linux.ibm.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260505201905.997996-1-zycai@linux.ibm.com>","References":"<20260505201905.997996-1-zycai@linux.ibm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Authority-Analysis":"v=2.4 cv=XPQAjwhE c=1 sm=1 tr=0 ts=69fa50c9 cx=c_pps\n a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17\n a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8\n a=130TwiEZxdn8fhqcL5YA:9","X-Proofpoint-ORIG-GUID":"PjR2kMF8vi2YyAlKmGbRO9-gDBGhVwhn","X-Proofpoint-GUID":"PjR2kMF8vi2YyAlKmGbRO9-gDBGhVwhn","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTA1MDE5NSBTYWx0ZWRfX2n5G16eadA5U\n tkaU6oEf9AsKX2GF22A+PFSjGzZTXvH+lZJN5MbWAi5JkcGgjL8rd+bUKS8OBZhYoNSixzMrcpL\n fEzm00c5Zf2mFSBJXT+S9BMmR93PCIEU2dPvpBO75HkKI1hqbXuAR4jfsUZV2neITT9LurYz+/p\n xzJ2pgvMLwFIjM2ccF5wfYJ+A2IDLjuAZ0f8S+I230h2y2bA7xApbaMQVnEJ1XwNxdXw2kndK8L\n eYTEoNLoSMb9G4iv1wdE6guJAn9mHYiSpvErkDc8krt6b8/r0FxnI0v0gcJeE5YrhhrLOHckhp8\n pSOPFihdhZ/uQyrwsTYgbKajqvmG6Tgud4RmA+wvZI3PshS5T+6VpDcHVKnSgHTY/+ds7oRTO4b\n BrqYmor88R7aRkMWZ4r4ZXi4Qmmf3PEa1zIscG8FuVZusqdQCo1nrbkuSMM5O03RtUkCLOSesL+\n JcwG+gRjok0Hb5+z9KA==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-05_02,2026-04-30_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n bulkscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 spamscore=0\n priorityscore=1501 impostorscore=0 phishscore=0 malwarescore=0 clxscore=1015\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050195","Received-SPF":"pass client-ip=148.163.158.5; envelope-from=zycai@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Create a function to validate the address parameter of DIAGNOSE.\n\nRefactor the function for reuse in the next patch, which allows address\nvalidation in read or write operation of DIAGNOSE.\n\nSigned-off-by: Zhuoying Cai \nReviewed-by: Farhan Ali \nReviewed-by: Collin Walling \nReviewed-by: Hendrik Brueckner \nReviewed-by: Thomas Huth \n---\n target/s390x/diag.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/target/s390x/diag.c b/target/s390x/diag.c\nindex 6373544bb2..8ab40437a2 100644\n--- a/target/s390x/diag.c\n+++ b/target/s390x/diag.c\n@@ -26,6 +26,12 @@\n #include \"qemu/error-report.h\"\n \n \n+static inline bool diag_parm_addr_valid(uint64_t addr, size_t size, bool write)\n+{\n+ return address_space_access_valid(&address_space_memory, addr,\n+ size, write, MEMTXATTRS_UNSPECIFIED);\n+}\n+\n int handle_diag_288(CPUS390XState *env, uint64_t r1, uint64_t r3)\n {\n uint64_t func = env->regs[r1];\n@@ -65,9 +71,7 @@ static int diag308_parm_check(CPUS390XState *env, uint64_t r1, uint64_t addr,\n s390_program_interrupt(env, PGM_SPECIFICATION, ra);\n return -1;\n }\n- if (!address_space_access_valid(&address_space_memory, addr,\n- sizeof(IplParameterBlock), write,\n- MEMTXATTRS_UNSPECIFIED)) {\n+ if (!diag_parm_addr_valid(addr, sizeof(IplParameterBlock), write)) {\n s390_program_interrupt(env, PGM_ADDRESSING, ra);\n return -1;\n }\n","prefixes":["v11","06/32"]}