{"id":2233194,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2233194/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505201905.997996-23-zycai@linux.ibm.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260505201905.997996-23-zycai@linux.ibm.com>","list_archive_url":null,"date":"2026-05-05T20:18:54","name":"[v11,22/32] pc-bios/s390-ccw: Add signed component address overlap checks","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"69c765508102d77c6c45e482bd9ef3657f6f9fc1","submitter":{"id":90643,"url":"http://patchwork.ozlabs.org/api/1.2/people/90643/?format=json","name":"Zhuoying Cai","email":"zycai@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505201905.997996-23-zycai@linux.ibm.com/mbox/","series":[{"id":502896,"url":"http://patchwork.ozlabs.org/api/1.2/series/502896/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502896","date":"2026-05-05T20:18:37","name":"Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices","version":11,"mbox":"http://patchwork.ozlabs.org/series/502896/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233194/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233194/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=L19YUfsz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g990Y0BB7z1yK2\n\tfor ; Wed, 06 May 2026 06:22:05 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKMFi-00010x-5D; Tue, 05 May 2026 16:20:22 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKMFc-0000YG-T0; Tue, 05 May 2026 16:20:16 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKMFa-0000Jl-P1; Tue, 05 May 2026 16:20:16 -0400","from pps.filterd (m0360072.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 645EYhBe1105811; Tue, 5 May 2026 20:19:50 GMT","from ppma13.dal12v.mail.ibm.com\n (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dw9y4n72t-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 05 May 2026 20:19:49 +0000 (GMT)","from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1])\n by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 645K9dGT030408;\n Tue, 5 May 2026 20:19:49 GMT","from smtprelay03.wdc07v.mail.ibm.com ([172.16.1.70])\n by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dwwtgb53r-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 05 May 2026 20:19:49 +0000 (GMT)","from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com\n [10.39.53.229])\n by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 645KJK3l17302126\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Tue, 5 May 2026 20:19:20 GMT","from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 8E5715805C;\n Tue, 5 May 2026 20:19:47 +0000 (GMT)","from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id EF25958059;\n Tue, 5 May 2026 20:19:45 +0000 (GMT)","from fedora-workstation.pok.ibm.com (unknown [9.12.79.241])\n by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Tue, 5 May 2026 20:19:45 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=HNYxZnCJCo9ZIXZpG\n Ks+l+hALoNGl093Esyq4xS6QDg=; b=L19YUfszlfXu/GEd2GVS0JUDJ4TrGmUxE\n 8TQTl4ZuYr1owDtQBPuVSl8r6mQfHKQ+YgYfot9mGflVRqy33gNt17Nzo+cA7rYW\n /ArAZdnn8GQIhdi6JqTxxNZ5+fhgJBkfBW4sVViTwrqpDdO7bukANCBXmgH7soDh\n RvHieYM8arfvPZwp46amCf3sUJpu1BqUK5Ai8mb+/tR9Kwc51uf6YuwP0tSW9Zyz\n /HZ8tF053wZ4sSwmO9qyAoAekJfKtDWk+69+bVam5mENmthIatpUkMpTB9yi1OZX\n DEQPVKFp/vFUhf0uJ5AHOfSb6fQYxI5iy2eBgGpBFPqvKMLIWFOZQ==","From":"Zhuoying Cai ","To":"qemu-s390x@nongnu.org, qemu-devel@nongnu.org","Cc":"jrossi@linux.ibm.com, cohuck@redhat.com, berrange@redhat.com,\n richard.henderson@linaro.org, david@kernel.org, walling@linux.ibm.com,\n jjherne@linux.ibm.com, pasic@linux.ibm.com, borntraeger@linux.ibm.com,\n farman@linux.ibm.com, mjrosato@linux.ibm.com, iii@linux.ibm.com,\n eblake@redhat.com, armbru@redhat.com, zycai@linux.ibm.com,\n alifm@linux.ibm.com, brueckner@linux.ibm.com,\n pierrick.bouvier@oss.qualcomm.com, jdaley@linux.ibm.com","Subject":"[PATCH v11 22/32] pc-bios/s390-ccw: Add signed component address\n overlap checks","Date":"Tue, 5 May 2026 16:18:54 -0400","Message-ID":"<20260505201905.997996-23-zycai@linux.ibm.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260505201905.997996-1-zycai@linux.ibm.com>","References":"<20260505201905.997996-1-zycai@linux.ibm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTA1MDE5NSBTYWx0ZWRfX6tM6nnQ6tlgE\n 5tpaMnzK8lxf4M2oca25NqSjlUmNgdvgb/rLwxAYztJZAfU0qXIk5tTGFAKz0DnZaB35pghBG1j\n idRZPONgZq5MoyhFXM4+q3FH1KIih2maeNPI5I7LU94halnHzCZVIld+vSIxRU9G6JadDBpOGwk\n B5t0TcSubG/557RVmfOVoFqfljS6V+oBs1gvRMlU7NY/aTGsc/tr5zQoVulMKic1dRb1p+EQrCl\n LCMm4LeE0wnBEuiPSzsBK/AN+pHNvNrLmBXWfqDxp2vFrfnrSj4TX0en8gOXiVJznYbfLcyX/QD\n w/kzUbQHo7Cgoh1IEcHcse3ZLMekQWTGMxSXGzXqdnxjWUybc5lwC6CpBnVYSvK2xMPotiJIz9E\n ozRUQIP3gnf/UV47lffj3a0G7nYQvx7aMr6wdvGsSZiX+WEST/O4juP4dT7kxYFxS9Zqpeo5Btu\n ccyAvKRd9sJW8AujpHA==","X-Authority-Analysis":"v=2.4 cv=J4GaKgnS c=1 sm=1 tr=0 ts=69fa50e6 cx=c_pps\n a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17\n a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=id9pkdgl0szQWdF34qoA:9","X-Proofpoint-GUID":"yhyLgwM0mj0WYkxINw1xsKaUoPT0Yqa1","X-Proofpoint-ORIG-GUID":"yhyLgwM0mj0WYkxINw1xsKaUoPT0Yqa1","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-05_02,2026-04-30_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n impostorscore=0 clxscore=1015 malwarescore=0 bulkscore=0 suspectscore=0\n priorityscore=1501 spamscore=0 phishscore=0 adultscore=0 lowpriorityscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050195","Received-SPF":"pass client-ip=148.163.158.5; envelope-from=zycai@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Add address range tracking and overlap checks to ensure that no\ncomponent overlaps with a signed component during secure IPL.\n\nSigned-off-by: Zhuoying Cai \n---\n pc-bios/s390-ccw/secure-ipl.c | 49 +++++++++++++++++++++++++++++++++++\n pc-bios/s390-ccw/secure-ipl.h | 15 +++++++++++\n 2 files changed, 64 insertions(+)","diff":"diff --git a/pc-bios/s390-ccw/secure-ipl.c b/pc-bios/s390-ccw/secure-ipl.c\nindex 6e943446a7..fdac74aa97 100644\n--- a/pc-bios/s390-ccw/secure-ipl.c\n+++ b/pc-bios/s390-ccw/secure-ipl.c\n@@ -220,6 +220,51 @@ static void init_lists(IplDeviceComponentList *comp_list,\n cert_list->ipl_info_header.len = sizeof(IplInfoBlockHeader);\n }\n \n+static void check_comp_overlap(SecureIplCompAddrRangeList *range_list,\n+ SecureIplCompEntryInfo comp_entry_info)\n+{\n+ uint64_t start_addr;\n+ uint64_t end_addr;\n+\n+ start_addr = comp_entry_info.addr;\n+ end_addr = comp_entry_info.addr + comp_entry_info.len;\n+\n+ /*\n+ * Check component's address range does not overlap with any\n+ * signed component's address range.\n+ */\n+ for (int i = 0; i < range_list->num; i++) {\n+ if (range_list->comp_addr_range[i].is_signed &&\n+ (range_list->comp_addr_range[i].start_addr < end_addr &&\n+ start_addr < range_list->comp_addr_range[i].end_addr)) {\n+ zipl_secure_error(\"Component addresses overlap\");\n+ }\n+ }\n+}\n+\n+static void comp_addr_range_add(SecureIplCompAddrRangeList *range_list,\n+ SecureIplCompEntryInfo comp_entry_info,\n+ bool is_signed)\n+{\n+ uint64_t start_addr;\n+ uint64_t end_addr;\n+\n+ start_addr = comp_entry_info.addr;\n+ end_addr = comp_entry_info.addr + comp_entry_info.len;\n+\n+ if (range_list->num >= MAX_COMP_ENTRIES) {\n+ zipl_secure_error(\"Component address range update failed due to out-of-range\"\n+ \" index; Overlapping validation cannot be guaranteed\");\n+ return;\n+ }\n+\n+ range_list->comp_addr_range[range_list->num].is_signed = is_signed;\n+ range_list->comp_addr_range[range_list->num].start_addr = start_addr;\n+ range_list->comp_addr_range[range_list->num].end_addr = end_addr;\n+\n+ range_list->num += 1;\n+}\n+\n static int zipl_load_signature(ComponentEntry *entry, uint64_t sig)\n {\n if (entry->compdat.sig_info.format != DER_SIGNATURE_FORMAT) {\n@@ -261,6 +306,7 @@ int zipl_run_secure(ComponentEntry **entry_ptr, uint8_t *tmp_sec)\n * exists for the certificate).\n */\n int cert_list_table[MAX_CERTIFICATES] = { [0 ... MAX_CERTIFICATES - 1] = -1 };\n+ SecureIplCompAddrRangeList range_list = { 0 };\n int signed_count = 0;\n \n init_lists(&comp_list, &cert_list);\n@@ -292,6 +338,9 @@ int zipl_run_secure(ComponentEntry **entry_ptr, uint8_t *tmp_sec)\n comp_entry_info.addr = comp_addr;\n comp_entry_info.len = (uint64_t)comp_len;\n \n+ check_comp_overlap(&range_list, comp_entry_info);\n+ comp_addr_range_add(&range_list, comp_entry_info, !!sig_len);\n+\n /* no signature present (unsigned component) */\n if (!sig_entry_info.len) {\n break;\ndiff --git a/pc-bios/s390-ccw/secure-ipl.h b/pc-bios/s390-ccw/secure-ipl.h\nindex cc0302f56b..29bbf65c6c 100644\n--- a/pc-bios/s390-ccw/secure-ipl.h\n+++ b/pc-bios/s390-ccw/secure-ipl.h\n@@ -24,6 +24,21 @@ typedef struct SecureIplCompEntryInfo {\n uint8_t flags;\n } SecureIplCompEntryInfo;\n \n+typedef struct SecureIplCompAddrRange {\n+ bool is_signed;\n+ uint64_t start_addr;\n+ uint64_t end_addr;\n+} SecureIplCompAddrRange;\n+\n+/*\n+ * Custom struct for managing a list of secure IPL component address ranges.\n+ * Tracks up to MAX_COMP_ENTRIES address ranges with an num counter.\n+ */\n+typedef struct SecureIplCompAddrRangeList {\n+ SecureIplCompAddrRange comp_addr_range[MAX_COMP_ENTRIES];\n+ int num;\n+} SecureIplCompAddrRangeList;\n+\n static inline void zipl_secure_error(const char *message)\n {\n switch (boot_mode) {\n","prefixes":["v11","22/32"]}