{"id":2233179,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2233179/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505201905.997996-3-zycai@linux.ibm.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260505201905.997996-3-zycai@linux.ibm.com>","list_archive_url":null,"date":"2026-05-05T20:18:34","name":"[v11,02/32] crypto/x509-utils: Refactor with GNUTLS fallback","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7ad2cdc9b4c4456cd73ae6c27695b9052e21f289","submitter":{"id":90643,"url":"http://patchwork.ozlabs.org/api/1.2/people/90643/?format=json","name":"Zhuoying Cai","email":"zycai@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505201905.997996-3-zycai@linux.ibm.com/mbox/","series":[{"id":502896,"url":"http://patchwork.ozlabs.org/api/1.2/series/502896/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502896","date":"2026-05-05T20:18:37","name":"Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices","version":11,"mbox":"http://patchwork.ozlabs.org/series/502896/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233179/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233179/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=NTDXT1B7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g98yp0xDNz1yK2\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 06 May 2026 06:20:34 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wKMEl-0007Rn-LL; Tue, 05 May 2026 16:19:23 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1wKMEj-0007QD-64; Tue, 05 May 2026 16:19:21 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1wKMEh-00007R-AD; Tue, 05 May 2026 16:19:20 -0400","from pps.filterd (m0360072.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 645JuB7N3826217; Tue, 5 May 2026 20:19:14 GMT","from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dw9y4n70n-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 05 May 2026 20:19:14 +0000 (GMT)","from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 645K9Sxb002880;\n Tue, 5 May 2026 20:19:13 GMT","from smtprelay07.wdc07v.mail.ibm.com ([172.16.1.74])\n by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dwvkju9un-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 05 May 2026 20:19:13 +0000 (GMT)","from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com\n [10.39.53.229])\n by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 645KJCOL32178890\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Tue, 5 May 2026 20:19:12 GMT","from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 303CF5805B;\n Tue,  5 May 2026 20:19:12 +0000 (GMT)","from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 89A9058059;\n Tue,  5 May 2026 20:19:10 +0000 (GMT)","from fedora-workstation.pok.ibm.com (unknown [9.12.79.241])\n by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Tue,  5 May 2026 20:19:10 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=pp1; bh=SRItF3\n Rpj3r/qWUSqrHn8Lr/8FzyN807OwVIui3tyWE=; b=NTDXT1B7cq7XAe7FWeuS/6\n x7fAwC/mvtnsfF4VTBs9u3gyOplIygOLkGQUT0ElLKesV0l7FTtUbW+k4YfrOQ4T\n mhW7zfDK9cPSwlEel/YmMLVPnFmu70B2Od4I58hVjEYp6EzPRyRKKNc894ePyROb\n QcAni1eBklzO/ZDD8zpmVn7Z5rTeC7c/0HOv/jKVgf0lwBwrElN/65NEAxT9NteE\n G7zMRknvjERwDr32i4I7WmvztfAJo9N8ewjdfrTYBoO5WLVg5FrZTqbptOTOKRSz\n W/JOpSoqeMKcJCLq+q0uEBMeS+n9Y8ASH6gUOGfBVL4cvWmHN425YQjZNbHGlrEg\n ==","From":"Zhuoying Cai <zycai@linux.ibm.com>","To":"qemu-s390x@nongnu.org, qemu-devel@nongnu.org","Cc":"jrossi@linux.ibm.com, cohuck@redhat.com, berrange@redhat.com,\n richard.henderson@linaro.org, david@kernel.org, walling@linux.ibm.com,\n jjherne@linux.ibm.com, pasic@linux.ibm.com, borntraeger@linux.ibm.com,\n farman@linux.ibm.com, mjrosato@linux.ibm.com, iii@linux.ibm.com,\n eblake@redhat.com, armbru@redhat.com, zycai@linux.ibm.com,\n alifm@linux.ibm.com, brueckner@linux.ibm.com,\n pierrick.bouvier@oss.qualcomm.com, jdaley@linux.ibm.com","Subject":"[PATCH v11 02/32] crypto/x509-utils: Refactor with GNUTLS fallback","Date":"Tue,  5 May 2026 16:18:34 -0400","Message-ID":"<20260505201905.997996-3-zycai@linux.ibm.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260505201905.997996-1-zycai@linux.ibm.com>","References":"<20260505201905.997996-1-zycai@linux.ibm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTA1MDE5NSBTYWx0ZWRfX8aPR+EJ4GxcP\n T2aXd9hpKXXHwC/kbVtH1WNSbtNHDJnIh8CKi8/FeduXBWegqdFBTqFZMiIPDtkCYheKkVfbUcd\n eNXBZ5INMVcWtKDXZJgZjHJhrRn2/GV5DHDc9gs9oF2ui0JMijUu9rbdPZ5EApD+fSyf3ZwdHo8\n bhXbrsnvZ2jjZZp77btgAwvG1tqExv8Mat/tJRIc5Fvs7Jm5OMPJnCZOh1yPI8fOTsO4UNGV2WO\n EbPFw1wCJv/pqxp6knk9PUUN978dtFEw6JUF+Fk2yDX7egqSPZ5dvfm/EcAu2DGqEfnlJi/iIMg\n j/p7c5jiIZzlAjBpb64TtmDD0gxyXHWqOWMRR1yEc3KFsBxiJ9TqHiyUnEGCEmFBZPZTJEqLwSi\n O/JvmlLkH0XQClRqMoGXpLibljiUivySY5LqiQPl77evMbGXv/opLPu923Oy+XZBQbHlfUz9Zpp\n gIo2IKdTfaP1ZMC0w7g==","X-Authority-Analysis":"v=2.4 cv=J4GaKgnS c=1 sm=1 tr=0 ts=69fa50c2 cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8\n a=20KFwNOVAAAA:8 a=FUyA0-9y5A7gcD0mOlIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10","X-Proofpoint-GUID":"i6OZQkfixzjqjDPnJ_FLDvKbMk0Usaf-","X-Proofpoint-ORIG-GUID":"i6OZQkfixzjqjDPnJ_FLDvKbMk0Usaf-","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-05_02,2026-04-30_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n impostorscore=0 clxscore=1011 malwarescore=0 bulkscore=0 suspectscore=0\n priorityscore=1501 spamscore=0 phishscore=0 adultscore=0 lowpriorityscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050195","Received-SPF":"pass client-ip=148.163.158.5; envelope-from=zycai@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Always compile x509-utils.c and add a fallback when GNUTLS is\nunavailable.\n\nThese functions will be needed in the s390x code regardless of whether\nGNUTLS is available.\n\nSigned-off-by: Zhuoying Cai <zycai@linux.ibm.com>\nAcked-by: Daniel P. Berrangé <berrange@redhat.com>\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nReviewed-by: Farhan Ali <alifm@linux.ibm.com>\nReviewed-by: Thomas Huth <thuth@redhat.com>\n---\n crypto/meson.build  |  2 +-\n crypto/x509-utils.c | 16 ++++++++++++++++\n 2 files changed, 17 insertions(+), 1 deletion(-)","diff":"diff --git a/crypto/meson.build b/crypto/meson.build\nindex b51597a879..fda85543de 100644\n--- a/crypto/meson.build\n+++ b/crypto/meson.build\n@@ -22,12 +22,12 @@ crypto_ss.add(files(\n   'tlscredsx509.c',\n   'tlssession.c',\n   'rsakey.c',\n+  'x509-utils.c',\n ))\n \n if gnutls.found()\n   crypto_ss.add(files(\n     'tlscredsbox.c',\n-    'x509-utils.c',\n   ))\n endif\n \ndiff --git a/crypto/x509-utils.c b/crypto/x509-utils.c\nindex 39bb6d4d8c..6176a88653 100644\n--- a/crypto/x509-utils.c\n+++ b/crypto/x509-utils.c\n@@ -11,6 +11,8 @@\n #include \"qemu/osdep.h\"\n #include \"qapi/error.h\"\n #include \"crypto/x509-utils.h\"\n+\n+#ifdef CONFIG_GNUTLS\n #include <gnutls/gnutls.h>\n #include <gnutls/crypto.h>\n #include <gnutls/x509.h>\n@@ -78,3 +80,17 @@ int qcrypto_get_x509_cert_fingerprint(uint8_t *cert, size_t size,\n     gnutls_x509_crt_deinit(crt);\n     return ret;\n }\n+\n+#else /* ! CONFIG_GNUTLS */\n+\n+int qcrypto_get_x509_cert_fingerprint(uint8_t *cert, size_t size,\n+                                      QCryptoHashAlgo hash,\n+                                      uint8_t *result,\n+                                      size_t *resultlen,\n+                                      Error **errp)\n+{\n+    error_setg(errp, \"GNUTLS is required to get fingerprint\");\n+    return -1;\n+}\n+\n+#endif /* ! CONFIG_GNUTLS */\n","prefixes":["v11","02/32"]}