{"id":2233167,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2233167/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260505200510.2954-8-alifm@linux.ibm.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.2/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260505200510.2954-8-alifm@linux.ibm.com>","list_archive_url":null,"date":"2026-05-05T20:05:10","name":"[v15,7/7] vfio/pci: Remove the pcie check for VFIO_PCI_ERR_IRQ_INDEX","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7edb0e1820a58c686ff3c4e7f6b7837713f55fa8","submitter":{"id":73785,"url":"http://patchwork.ozlabs.org/api/1.2/people/73785/?format=json","name":"Farhan Ali","email":"alifm@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260505200510.2954-8-alifm@linux.ibm.com/mbox/","series":[{"id":502892,"url":"http://patchwork.ozlabs.org/api/1.2/series/502892/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=502892","date":"2026-05-05T20:05:06","name":"Error recovery for vfio-pci devices on s390x","version":15,"mbox":"http://patchwork.ozlabs.org/series/502892/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233167/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233167/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=YpFLIFHZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-53787-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=\"YpFLIFHZ\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=148.163.156.1","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.ibm.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g98lM518zz1yJV\n\tfor ; Wed, 06 May 2026 06:10:39 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id AE1393047E80\n\tfor ; Tue, 5 May 2026 20:06:17 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7B5FB4C0408;\n\tTue, 5 May 2026 20:05:24 +0000 (UTC)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id F10094968F7;\n\tTue, 5 May 2026 20:05:22 +0000 (UTC)","from pps.filterd (m0360083.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 645Ik4Og3003512;\n\tTue, 5 May 2026 20:05:19 GMT","from ppma11.dal12v.mail.ibm.com\n (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dw9v7dkv5-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tTue, 05 May 2026 20:05:18 +0000 (GMT)","from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1])\n\tby ppma11.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 645JsW1Q031825;\n\tTue, 5 May 2026 20:05:18 GMT","from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8])\n\tby ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dwx9yb0bx-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tTue, 05 May 2026 20:05:18 +0000 (GMT)","from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com\n [10.241.53.105])\n\tby smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 645K5HBl27788004\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tTue, 5 May 2026 20:05:17 GMT","from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 2CC5158055;\n\tTue, 5 May 2026 20:05:17 +0000 (GMT)","from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 6F30758043;\n\tTue, 5 May 2026 20:05:16 +0000 (GMT)","from IBM-D32RQW3.ibm.com (unknown [9.61.242.219])\n\tby smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP;\n\tTue, 5 May 2026 20:05:16 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778011524; cv=none;\n b=fMFYjNvY8pdfp4SMWI7Otk/8w/lv5Raopp1XdoTapHP77V8BzgnaGECryS5mZOH9qkKzx8MJc0JjzPOPPtH9pvpCrJU4yMh6Zwn3cfbOwy7l02teSEhS0gnh/leN5tE6PWsqnN15DzmWddGQ4guYr8q1aBz5YygZcEkq+r9p3/M=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778011524; c=relaxed/simple;\n\tbh=3TYFc6itqVc3zvA3ORsy9QJMk5peLve+M+b/RlDFXR0=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=LixYqwHf5ObtKwnUVATKIf5GvI14RWrzfsYIltNTAeJokw6JU4WnkKlTbLBTSc02h2hiWyx2vF9v+XDJe2c6G4iFzzEv+xyRRW6QZed/jlfqSb94HNAgty10akdyAB8aDy7tLnJe7isDZ/V8XbYBy9djtv6kJqPDKxl0wmL3wh8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n spf=pass smtp.mailfrom=linux.ibm.com;\n dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=YpFLIFHZ; arc=none smtp.client-ip=148.163.156.1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=pp1; bh=2t4MJ6w9XSNqCnRGI\n\tTK3LALBDAsPD/NV/iok/YHO6WA=; b=YpFLIFHZiNsU/NAM4KuGa2tiF2Sl1LV7x\n\tgoDtHNWUS9QahSwr5wXD1BLLobyw6dNVB5fV6Z3fNNxAxi1YrQcn9Mt99lBMXXAJ\n\tkXvjiQW8WyKqeL38mb75IOblXA0kc1wvZ3OTaH5TcvA5D+qu2LXYicriDrsHxZg2\n\tbNRPB2qpYpK5/xwMocwohoXfywk6vllpZ0e0l6OmnybFmk32l0QgwwJsuu/yfIKe\n\tE5fbk3lNhnF8OI0GoElV0sV4WsYQS2MyiA2jz9rL9fm9CcWklhSosKJlRC/qylyA\n\t2wL8WmArutenpkLtsnbuFiqKInmzJT+ZeK2LFPykmL54m2kP8lOvA==","From":"Farhan Ali ","To":"linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-pci@vger.kernel.org","Cc":"helgaas@kernel.org, alex@shazbot.org, alifm@linux.ibm.com,\n schnelle@linux.ibm.com, mjrosato@linux.ibm.com,\n Julian Ruess ","Subject":"[PATCH v15 7/7] vfio/pci: Remove the pcie check for\n VFIO_PCI_ERR_IRQ_INDEX","Date":"Tue, 5 May 2026 13:05:10 -0700","Message-ID":"<20260505200510.2954-8-alifm@linux.ibm.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260505200510.2954-1-alifm@linux.ibm.com>","References":"<20260505200510.2954-1-alifm@linux.ibm.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTA1MDE5MSBTYWx0ZWRfX2XRQLX0TPHU8\n mQCFEFqhBgeVqkMGFjMXi+lt3xo9JZ3gjEuhBQyObqH+jQ2R+D7Ta/QVJc54cOY87MdX6aWFqVH\n jhNrsGmQuGkgpOhQA1OfpekDC0QhnHXRyiRoS755MkpsHjxSsfbrhj07BzFJvKWvZUNhEGOdBG/\n 8K/HBcThaReiqinalowRWXSMSKPOwMLZSjKFXwbjclKesupYHwvHHMdNHo+VEts2hGL6lym06lu\n U9UDDUa2VBeD5q9X6zOGg/LBxdtxO9n0KrURiodsAazNeLGUK0pLbloFy8n4/GIVFNHlEbVf/+i\n zt+UYD9zXMsBhxr8f3dR65tR7PwFy3ZQoKp7xC/rssewE5gRGZRgZ49UWlt9uL+s3TBttccRxxo\n 1KPQIPTsQXvkqXxknm2pFGYs5EDn9UsiZdq6r7Guv5nWxt6DNnGFb4BHifcquQw5wFqmaimYWWy\n 892AKGpEMi/AF0UCr4Q==","X-Proofpoint-GUID":"MEF0f7QDnVG_OcqCANNG0VD9zgWmsNrW","X-Proofpoint-ORIG-GUID":"MEF0f7QDnVG_OcqCANNG0VD9zgWmsNrW","X-Authority-Analysis":"v=2.4 cv=eu/vCIpX c=1 sm=1 tr=0 ts=69fa4d7f cx=c_pps\n a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17\n a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8 a=r1p2_3pzAAAA:8\n a=bf5i11FZjm5gBOpVircA:9 a=r_pkcD-q9-ctt7trBg_g:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-05_02,2026-04-30_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0\n suspectscore=0 malwarescore=0 bulkscore=0 impostorscore=0 spamscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050191"},"content":"The error signaling is configured for the vast majority of devices and it's\nextremely rare that it fires anyway. Removing the pcie check will allow\nuserspace to be notified on errors for legacy PCI devices. The Internal\nShared Memory (ISM) device on s390 is one such device. For PCI devices on\nIBM s390 error recovery involves platform firmware and notification to\noperating system is done by architecture specific way. So the ISM device\ncan still be recovered when notified of an error.\n\nReviewed-by: Julian Ruess \nReviewed-by: Niklas Schnelle \nReviewed-by: Alex Williamson \nSigned-off-by: Farhan Ali \n---\n drivers/vfio/pci/vfio_pci_core.c | 8 ++------\n drivers/vfio/pci/vfio_pci_intrs.c | 3 +--\n 2 files changed, 3 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c\nindex 6358b59fab2b..cd9f31b28160 100644\n--- a/drivers/vfio/pci/vfio_pci_core.c\n+++ b/drivers/vfio/pci/vfio_pci_core.c\n@@ -786,8 +786,7 @@ static int vfio_pci_get_irq_count(struct vfio_pci_core_device *vdev, int irq_typ\n \t\t\treturn (flags & PCI_MSIX_FLAGS_QSIZE) + 1;\n \t\t}\n \t} else if (irq_type == VFIO_PCI_ERR_IRQ_INDEX) {\n-\t\tif (pci_is_pcie(vdev->pdev))\n-\t\t\treturn 1;\n+\t\treturn 1;\n \t} else if (irq_type == VFIO_PCI_REQ_IRQ_INDEX) {\n \t\treturn 1;\n \t}\n@@ -1163,11 +1162,8 @@ static int vfio_pci_ioctl_get_irq_info(struct vfio_pci_core_device *vdev,\n \tswitch (info.index) {\n \tcase VFIO_PCI_INTX_IRQ_INDEX ... VFIO_PCI_MSIX_IRQ_INDEX:\n \tcase VFIO_PCI_REQ_IRQ_INDEX:\n-\t\tbreak;\n \tcase VFIO_PCI_ERR_IRQ_INDEX:\n-\t\tif (pci_is_pcie(vdev->pdev))\n-\t\t\tbreak;\n-\t\tfallthrough;\n+\t\tbreak;\n \tdefault:\n \t\treturn -EINVAL;\n \t}\ndiff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c\nindex 33944d4d9dc4..64f80f64ff57 100644\n--- a/drivers/vfio/pci/vfio_pci_intrs.c\n+++ b/drivers/vfio/pci/vfio_pci_intrs.c\n@@ -859,8 +859,7 @@ int vfio_pci_set_irqs_ioctl(struct vfio_pci_core_device *vdev, uint32_t flags,\n \tcase VFIO_PCI_ERR_IRQ_INDEX:\n \t\tswitch (flags & VFIO_IRQ_SET_ACTION_TYPE_MASK) {\n \t\tcase VFIO_IRQ_SET_ACTION_TRIGGER:\n-\t\t\tif (pci_is_pcie(vdev->pdev))\n-\t\t\t\tfunc = vfio_pci_set_err_trigger;\n+\t\t\tfunc = vfio_pci_set_err_trigger;\n \t\t\tbreak;\n \t\t}\n \t\tbreak;\n","prefixes":["v15","7/7"]}