{"id":2233135,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2233135/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260505181300.223439-3-sjg@chromium.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260505181300.223439-3-sjg@chromium.org>","list_archive_url":null,"date":"2026-05-05T18:12:53","name":"[v2,2/4] binman: Flesh out the pkcs11-tool bintool docstring","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7e81ec7383d3ff4776c573c8666298a78ebab2a7","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/1.2/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"delegate":{"id":3184,"url":"http://patchwork.ozlabs.org/api/1.2/users/3184/?format=json","username":"sjg","first_name":"Simon","last_name":"Glass","email":"sjg@chromium.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260505181300.223439-3-sjg@chromium.org/mbox/","series":[{"id":502878,"url":"http://patchwork.ozlabs.org/api/1.2/series/502878/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=502878","date":"2026-05-05T18:12:51","name":"binman: Tidy up some missing bintool docs","version":2,"mbox":"http://patchwork.ozlabs.org/series/502878/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233135/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233135/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=FRh8rfP9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"FRh8rfP9\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g968D4lzwz1yJV\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 06 May 2026 04:13:32 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 0ECC2849D1;\n\tTue,  5 May 2026 20:13:19 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id C909F849E4; Tue,  5 May 2026 20:13:17 +0200 (CEST)","from mail-oa1-x44.google.com (mail-oa1-x44.google.com\n [IPv6:2001:4860:4864:20::44])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 6F4F8849D1\n for <u-boot@lists.denx.de>; Tue,  5 May 2026 20:13:15 +0200 (CEST)","by mail-oa1-x44.google.com with SMTP id\n 586e51a60fabf-40ef10ec84cso3444835fac.2\n for <u-boot@lists.denx.de>; Tue, 05 May 2026 11:13:15 -0700 (PDT)","from chromium.org ([174.51.25.52]) by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-434549540b2sm14585754fac.6.2026.05.05.11.13.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 May 2026 11:13:12 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1778004793; x=1778609593; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=R8bhKVqfd2hHyxBE7tSTuIPnxphdGTIEWrB8lUiWq9c=;\n b=FRh8rfP9WqIRshykFh1Z1hKJi+Avind5ellVFATDuEXldMbsszOKDfSCwgo/I4C+X6\n f3qsioBV1baHEebBDpB2ggIBi33w5ip0pm2/Q5ZT0ulNsPzzzxHmxd/85N49SjjEhZ1k\n pSu9O7SpR5Hck8YZZNtn6KzpwRPYp3nIo026k=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778004793; x=1778609593;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=R8bhKVqfd2hHyxBE7tSTuIPnxphdGTIEWrB8lUiWq9c=;\n b=UqGvWj4MUfya/MMEenBtllVpQP0YNAo8/8ep8HeNS2Z4TNmVqjikXciEnOZXgFiPM8\n MJfMr+8iT9B8JKjdCEQLohoZwJzIC+Ugz+BLgQAYpxPesBKbMO9XubqAiFZH9kp2DOzT\n aaqWbd8BWGBHWbTfKICcUnrOmDWgvcUBZbShLnaxB0/4b6GT5WIrlMzCCW/3Q2ltMYU9\n ipH2qKbbx+ZJ9v3Vb/KhzBe/FqOyBFI9c0OJ+m7alPMWqApBhhjxrzR+9CBeMKgB/BXC\n QU8QhfUBVRzQvXi/9/uM6xLZnDewVRM9dZAVM3eBNqI7JkzOKlAqiz0H8cXwzMg6JwZM\n 7+6A==","X-Gm-Message-State":"AOJu0YwXIEAgutWAo2cPURG3wLFN3MJ7wKZsC83RaNQHcSbSWkNrpIK7\n PhWRvnGSjolUlorMeH4ajUrnMh7U0TvImWjqG744/lBWu2zIYp27igR198wG9U2Pa1Gl8pV9ZkJ\n HAOpFwj/c","X-Gm-Gg":"AeBDietlXlovb7Wno5pqAkHbPaEr5YurVh2+vspc297Vn53rfKTPlgMzDMl5ujDtSKT\n VrIjpilwtxzjGDDUxUhrr54o3uS2dRgxUZtjBsiXzsoqhTFVhWk92QWdcmMD2tQ1k8fwTCKbOeP\n kv0sQYtvWAq/mOSizpaFCJytDZPghHW+f9KKdQOge+/VXeMNzGl4m6iCKBkK0yKO5EogPjRIEUO\n Py/jFrpZ54JMf9QW6OihmTm3nZ6i76S2LoHGvi7NrwmJfYVyATlXll3hbROcRiFLOtKZYRUNlAQ\n plMv8hhSYxP36uBUv5/u7g6o3gOyfaj1TOyOZgrzBTIRqzzHkhX/sTZNf8W5Jx7EE9qJk5X/uWx\n bho/uUJ72kTh7fKs8kDxRbUYRj+f70SpHY/sNj7Djud25k71D2krSWvcJq3Vk3k5SByFdD/YUhw\n jvQaNo25mKK7ogwxq3vV9rxZ55V60s","X-Received":"by 2002:a05:6871:e1:b0:428:ba6:c5da with SMTP id\n 586e51a60fabf-434f65f3d81mr260571fac.24.1778004793526;\n Tue, 05 May 2026 11:13:13 -0700 (PDT)","From":"Simon Glass <sjg@chromium.org>","To":"u-boot@lists.denx.de","Cc":"Heinrich Schuchardt <xypron.glpk@gmx.de>, Simon Glass <sjg@chromium.org>,\n Alper Nebi Yasak <alpernebiyasak@gmail.com>,\n Neha Malcom Francis <n-francis@ti.com>, Peng Fan <peng.fan@nxp.com>,\n Philippe Reynes <philippe.reynes@softathome.com>,\n Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>,\n Tom Rini <trini@konsulko.com>, Wojciech Dubowik <Wojciech.Dubowik@mt.com>","Subject":"[PATCH v2 2/4] binman: Flesh out the pkcs11-tool bintool docstring","Date":"Tue,  5 May 2026 12:12:53 -0600","Message-ID":"<20260505181300.223439-3-sjg@chromium.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260505181300.223439-1-sjg@chromium.org>","References":"<20260505181300.223439-1-sjg@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"The Sphinx-generated bintools.rst currently produces an empty section\nfor this bintool, since its class docstring is only a single line and\nso the body under the heading is blank.\n\nExtend the docstring with a short description of what pkcs11-tool does\nand how binman uses it, so the generated documentation has useful\ncontent.\n\nSuggested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\nChanges in v2:\n- Reword the docstring per Quentin's review: binman uses this bintool\n  only as an availability check, not for runtime PKCS#11 operations\n\n tools/binman/btool/pkcs11_tool.py | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)","diff":"diff --git a/tools/binman/btool/pkcs11_tool.py b/tools/binman/btool/pkcs11_tool.py\nindex 673c0ea0ac3..ca80943f98c 100644\n--- a/tools/binman/btool/pkcs11_tool.py\n+++ b/tools/binman/btool/pkcs11_tool.py\n@@ -7,7 +7,16 @@ from binman import bintool\n \n \n class Bintoolpkcs11_tool(bintool.Bintool):\n-    \"\"\"pkcs11-tool -- support tool for managing pkcs#11 tokens\"\"\"\n+    \"\"\"pkcs11-tool -- support tool for managing pkcs#11 tokens\n+\n+    This bintool wraps the `pkcs11-tool` command from the OpenSC project for\n+    managing objects stored in PKCS#11 tokens. Binman uses this wrapper only\n+    to check that pkcs11-tool is installed (and to fetch it if missing); any\n+    actual key or token management for signing FIT images or capsules is done\n+    outside binman.\n+\n+    See https://github.com/OpenSC/OpenSC/wiki for more details.\n+    \"\"\"\n     def __init__(self, name):\n         super().__init__('pkcs11-tool',\n                          'PKCS #11 tokens managing tool',\n","prefixes":["v2","2/4"]}