{"id":2233134,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2233134/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260505181300.223439-2-sjg@chromium.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260505181300.223439-2-sjg@chromium.org>","list_archive_url":null,"date":"2026-05-05T18:12:52","name":"[v2,1/4] binman: Flesh out the p11-kit bintool docstring","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"42171d5e34436836ca3f33b9a765daffbbc2e54f","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/1.2/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"delegate":{"id":3184,"url":"http://patchwork.ozlabs.org/api/1.2/users/3184/?format=json","username":"sjg","first_name":"Simon","last_name":"Glass","email":"sjg@chromium.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260505181300.223439-2-sjg@chromium.org/mbox/","series":[{"id":502878,"url":"http://patchwork.ozlabs.org/api/1.2/series/502878/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=502878","date":"2026-05-05T18:12:51","name":"binman: Tidy up some missing bintool docs","version":2,"mbox":"http://patchwork.ozlabs.org/series/502878/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233134/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233134/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=Z+OCNaDb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"Z+OCNaDb\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g96844PrSz1yJV\n\tfor ; Wed, 06 May 2026 04:13:24 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C82DC849D2;\n\tTue, 5 May 2026 20:13:16 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id B3455849D2; Tue, 5 May 2026 20:13:15 +0200 (CEST)","from mail-ot1-x341.google.com (mail-ot1-x341.google.com\n [IPv6:2607:f8b0:4864:20::341])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 54118849B2\n for ; Tue, 5 May 2026 20:13:13 +0200 (CEST)","by mail-ot1-x341.google.com with SMTP id\n 46e09a7af769-7dcc9b506d9so5363197a34.1\n for ; Tue, 05 May 2026 11:13:13 -0700 (PDT)","from chromium.org ([174.51.25.52]) by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-434549540b2sm14585754fac.6.2026.05.05.11.13.10\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 May 2026 11:13:10 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1778004791; x=1778609591; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ym9HUpKzPOqn4X6sWTWvqzozbNU9Zl944RE/uQTNg50=;\n b=Z+OCNaDbtBL8+2JN9QfpOjdWLbNkGrhLCXcgLrIbpNYBL5oiSjzAmWFG2WH8LvgsWp\n 8gShPpHYNzu3qMxN/azBI0ogH3Z8Oi4Q34DlP3M7yCCw2nBT8v5WMvhv5O7Iu+7HMZNa\n bwwL10NkFk0DZTHLERY56H3rLfFtbd/pP/oIo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778004791; x=1778609591;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ym9HUpKzPOqn4X6sWTWvqzozbNU9Zl944RE/uQTNg50=;\n b=kLUtolDN3rWT7+fFf0bnvFl6Hs9uXXPAr9HILKVFoqg83sfyoqpNmYfe1JLmD1weOY\n T9zPFebQ6DcPLtttH3TE9ltxr3JsEffSMWz5cGmUNEyUiYn7NKCrIYJ5vP+KfNjyO7zO\n jUMonWFfGehA10OjtYj0lZAHx2JKxixWQuI5CjEZurzaxiqkQDQ01KOSCdE5gaBjmb09\n mBgV/wroMxSjuDgBGhkQ0PbX8upsVbjyxo1kTpDbevJ7JAHuSwVaOlwc3aPzY3cxY52P\n 7oDQRIIPNqzo0NHcK10wtucw4yFWPZc9bW5sU+XeieqqbhOK/kkf3DbODXeeYtXBrYdf\n 2xRw==","X-Gm-Message-State":"AOJu0YyrsHK/uOU4dMpFsEwgQOiOO/26dEIlHKJ5nDuyGsyd1kvpmPS3\n SGOFMm7z75RcsmD7qdBeGsiK/KWshUJBwbAIb6A+9c8u3GR+p4/YeZmoZFVcfeDhuSDVl7MBgpk\n XQ3f5DrSg","X-Gm-Gg":"AeBDiev4NvA0dIcXE8hMXur1JodKVv5pAr8OYsM81WrpWqDhG7/gm92IWWLaO9sAk1s\n FiFuqGSNWATHRzNBohQ3NL+EILzRlNIbSTk+GdpOVnM2CYw8m47pC1TiedcCPsNiW0KRJvOCZmE\n zZMb+duCsAzlr7DC6XYc6ojtgjR+HRAr0HsuOT/r40FsfcAe8klzKZ1oMIQtSZ3VRhQB2mfWZA+\n AWSP1HllNuUyalhliNGNTIRwNU5oPluAvew8CdGptMI0IoD1ZAKbMz2OHb9gGBGsdB3fQQtfDCP\n QCm+3zURwl2xUbiSxkvJa+ghtcXwYq9yyh1Vaqd1zX9nw8YVsWv8wpWJ22cd7zqUO4q+JV7sXP1\n mHreOiJqJXKJ+rJ7qidlMHqRqVREMt6VTkJGw7096LMLbEI+PHRVWdUXjHooiGLBOPZ8Eaq3EEy\n smH4bAceksA1ix8gwVHHqFRCyrQG4x","X-Received":"by 2002:a05:6820:178a:b0:687:d4de:1f9d with SMTP id\n 006d021491bc7-69998105a77mr416314eaf.24.1778004791416;\n Tue, 05 May 2026 11:13:11 -0700 (PDT)","From":"Simon Glass ","To":"u-boot@lists.denx.de","Cc":"Heinrich Schuchardt , Simon Glass ,\n Alper Nebi Yasak ,\n Neha Malcom Francis , Peng Fan ,\n Philippe Reynes ,\n Stefan Herbrechtsmeier ,\n Tom Rini , Wojciech Dubowik ","Subject":"[PATCH v2 1/4] binman: Flesh out the p11-kit bintool docstring","Date":"Tue, 5 May 2026 12:12:52 -0600","Message-ID":"<20260505181300.223439-2-sjg@chromium.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260505181300.223439-1-sjg@chromium.org>","References":"<20260505181300.223439-1-sjg@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"The Sphinx-generated bintools.rst currently produces an empty section\nfor this bintool, since its class docstring is only a single line and\nso the body under the heading is blank.\n\nExtend the docstring with a short description of what p11-kit does and\nhow binman uses it, so the generated documentation has useful content.\n\nSuggested-by: Heinrich Schuchardt \nSigned-off-by: Simon Glass \n---\n\nChanges in v2:\n- Reword the docstring per Quentin's review: binman uses this bintool\n only as an availability check, not for runtime PKCS#11 operations\n\n tools/binman/btool/p11_kit.py | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)","diff":"diff --git a/tools/binman/btool/p11_kit.py b/tools/binman/btool/p11_kit.py\nindex 9d8d5d848b4..1bbece5bb2b 100644\n--- a/tools/binman/btool/p11_kit.py\n+++ b/tools/binman/btool/p11_kit.py\n@@ -7,7 +7,16 @@ from binman import bintool\n \n \n class Bintoolp11_kit(bintool.Bintool):\n- \"\"\"p11-kit -- support tool for pkcs#11 libraries\"\"\"\n+ \"\"\"p11-kit -- support tool for pkcs#11 libraries\n+\n+ This bintool wraps the `p11-kit` command, a support tool for PKCS#11\n+ modules. Binman uses this wrapper only to check that p11-kit is installed\n+ (and to fetch it if missing); any actual PKCS#11 module discovery for\n+ signing FIT images or capsules is done outside binman, by mkimage and the\n+ OpenSSL PKCS#11 engine.\n+\n+ See https://p11-glue.github.io/p11-glue/p11-kit.html for more details.\n+ \"\"\"\n def __init__(self, name):\n super().__init__('p11-kit',\n 'Pkcs11 library modules tool',\n","prefixes":["v2","1/4"]}