{"id":2233110,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2233110/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505170105.228162-4-alex.bennee@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260505170105.228162-4-alex.bennee@linaro.org>","list_archive_url":null,"date":"2026-05-05T17:00:58","name":"[RFC,03/10] .agents/skills: add qemu-code-reviewer skill","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c8b9af08ea7611b6fc2c8657668e5a533fb5f744","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/1.2/people/39532/?format=json","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505170105.228162-4-alex.bennee@linaro.org/mbox/","series":[{"id":502869,"url":"http://patchwork.ozlabs.org/api/1.2/series/502869/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502869","date":"2026-05-05T17:01:00","name":"AGENTS.md and associated skills","version":1,"mbox":"http://patchwork.ozlabs.org/series/502869/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233110/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233110/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=s76VmUb2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g94bP3mT3z1yJ0\n\tfor ; Wed, 06 May 2026 03:03:29 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKJ9B-0007xn-2u; Tue, 05 May 2026 13:01:25 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKJ94-0007ws-KY\n for qemu-devel@nongnu.org; Tue, 05 May 2026 13:01:20 -0400","from mail-wr1-x432.google.com ([2a00:1450:4864:20::432])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wKJ8z-0003TC-NL\n for qemu-devel@nongnu.org; Tue, 05 May 2026 13:01:18 -0400","by mail-wr1-x432.google.com with SMTP id\n ffacd0b85a97d-44c4cc7c1cfso2372349f8f.0\n for ; Tue, 05 May 2026 10:01:11 -0700 (PDT)","from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-45055e2d3d0sm5676376f8f.34.2026.05.05.10.01.06\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 May 2026 10:01:07 -0700 (PDT)","from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id 48B285FC94;\n Tue, 05 May 2026 18:01:06 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778000470; x=1778605270; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Jvc2PGTEz9rVEoAiSxMM6GT3z58PvEK27HCUa8g8+jE=;\n b=s76VmUb211UfhLOekv5Rw7E3x1g+H1uIt226NnyGJcdZKj8R48b/4+4DoMrLSA0jv6\n SgY59AIpMfLsUe/lqVMpQBhm/lnXKuSIcN1Iin/heHghgB9prW9RJh8UllUnjDSqVfiT\n rG9caimIoyaH8E8vPU+umLLQBX7zfEcyfExqu90FFiiqrfLlgCl7VLPuR4ofR7lt3BiT\n 6yfosWJatLhhhgWzauPoKGI7H6OdZMuRzfB1QJxHLkRxlhEncP2O7/DgRlyMYQpYzOgn\n knMH5VlMtA+hmNOOdx+6u7pYdQ20xLDJJ9d6plAVgXe1dhhw7bs5nAwH9aSmlIugvsxz\n ADRg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778000470; x=1778605270;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Jvc2PGTEz9rVEoAiSxMM6GT3z58PvEK27HCUa8g8+jE=;\n b=rQvkvZkjks846BwKpO5i5ZUBGLsmHmWQZLfv20bmMdRJdOdlQyQ7QW1go8vgK/I1+A\n n2vLQemleVCxQVOJJOu9nDONKNBmhkLeyzvE22ew5XP4pYIM4I5cAj3RVwfEdu7uxDib\n 0ajzgf2HDzmHZwdllTldfWofi19WEwAKEw7opVbV/VWJ7hnpC04bdxDwKf2XozXckW82\n 1ziioKkEzCKLhnaU9lZ3a3TyNAWWLT//izB5kmvOu75WNWeE+ADHTMlS68DYCpbmHSAX\n 5/ARw8NPUrK9caYTK53Pf5xtMuSBy7dWZEcYOUAI40ssenXGSvnNAX4cLx+Af3Hm+kYy\n p+SA==","X-Gm-Message-State":"AOJu0Yz48IImT0Org8aiiXi/oTOhj77KZ4zc3RfQSx1YEmXulgpMdrXE\n vCE5rUQ8OEC4d+efWukXv9kYBVDgH2pM4kesyCX3mZeCfh+YxRYnfHs5lSdee/OD0QPnwqWvhSf\n OHeSE0+Y=","X-Gm-Gg":"AeBDies5kEsKyOXu8LuSrOd7Iq0ArDj/CksFygy0K7tt/ZZhr/FEFZlrPlftq2kUbi6\n Ac1ToGD2yiEBNlDhafHnbjx4lesX3DUS9+nuK29f0U76gqWZG2WA4X+zXzH8NP+SbmCfqqlIJ5H\n Rir/mg+Uk9dI+lOxs54Q04dC+GUe0yNMaHt7fKuPjQNTlw6civnKuXI2WknAPe/44Y/LBFtQi9d\n YpYt+8yDJYYljLB/PiZXnoIXGwlxZMPtD1pP0Y4qnhA4R/KVIriDNGvl7Dp1I4eBekCa0b9/nLe\n sD2mI1MDbUHgNEdaYZZLd6TMqOYIvd/tQpm+oxWKDdwQ8yMsBOodkH+/jm6AIx6CWBwl+mAT1/7\n xVTmN6j/qHwU73rjvCRZLY5eADkrr2CN8KDactq1IaDmIaGHmZVQqEPCdYZzXssx6ih5N1+rzmm\n tV83T//LNaEK7zm1vEObzV6I/kaXDzZ0C1EA==","X-Received":"by 2002:a05:6000:2088:b0:441:239e:2bb8 with SMTP id\n ffacd0b85a97d-44bb2f282d3mr25321673f8f.7.1778000469980;\n Tue, 05 May 2026 10:01:09 -0700 (PDT)","From":"=?utf-8?q?Alex_Benn=C3=A9e?= ","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Alex_Benn=C3=A9e?= ","Subject":"[RFC PATCH 03/10] .agents/skills: add qemu-code-reviewer skill","Date":"Tue, 5 May 2026 18:00:58 +0100","Message-ID":"<20260505170105.228162-4-alex.bennee@linaro.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260505170105.228162-1-alex.bennee@linaro.org>","References":"<20260505170105.228162-1-alex.bennee@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::432;\n envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x432.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This provides basic instructions for how to download and apply a\npatch series from the mailing list. It currently doesn't outline any\ndetails about how to do the review.\n\nSigned-off-by: Alex Bennée \n---\n .agents/skills/qemu-code-explorer/SKILL.md | 3 +-\n .../qemu-code-explorer/evals/evals.json | 1 +\n .agents/skills/qemu-code-reviewer/SKILL.md | 74 +++++++++++++++++++\n 3 files changed, 77 insertions(+), 1 deletion(-)\n create mode 100644 .agents/skills/qemu-code-reviewer/SKILL.md","diff":"diff --git a/.agents/skills/qemu-code-explorer/SKILL.md b/.agents/skills/qemu-code-explorer/SKILL.md\nindex d41b21179c1..13cb71dd55c 100644\n--- a/.agents/skills/qemu-code-explorer/SKILL.md\n+++ b/.agents/skills/qemu-code-explorer/SKILL.md\n@@ -1,6 +1,7 @@\n ---\n name: qemu-code-explorer\n description: Comprehensive guide for exploring the QEMU codebase using tagging systems (gtags, ctags, cscope), git grep, and build-directory grep for generated files. Use this skill when the user asks to find where something is defined, how it's used, or wants to understand a specific subsystem.\n+license: GPL-2.0-or-later\n ---\n \n # QEMU Code Base Explorer\n@@ -26,7 +27,7 @@ make gtags # or make ctags, make cscope, make TAGS\n \n `git grep` is the preferred tool for general text searches within the source tree.\n \n-- **Best for**: \n+- **Best for**:\n - Searching for local variables within a function.\n - Searching for string literals or comments.\n - Finding occurrences of symbols defined in system headers (e.g., `optarg`).\ndiff --git a/.agents/skills/qemu-code-explorer/evals/evals.json b/.agents/skills/qemu-code-explorer/evals/evals.json\nindex dff7afa52fa..131cf46e1cc 100644\n--- a/.agents/skills/qemu-code-explorer/evals/evals.json\n+++ b/.agents/skills/qemu-code-explorer/evals/evals.json\n@@ -1,3 +1,4 @@\n+# SPDX-License-Identifier: GPL-2.0-or-later\n {\n \"skill_name\": \"qemu-code-explorer\",\n \"evals\": [\ndiff --git a/.agents/skills/qemu-code-reviewer/SKILL.md b/.agents/skills/qemu-code-reviewer/SKILL.md\nnew file mode 100644\nindex 00000000000..0c088fdda04\n--- /dev/null\n+++ b/.agents/skills/qemu-code-reviewer/SKILL.md\n@@ -0,0 +1,74 @@\n+---\n+name: qemu-code-reviewer\n+description: Pull and apply patch series from mailing lists for review and testing in QEMU.\n+license: GPL-2.0-or-later\n+---\n+\n+# QEMU Code Reviewer Skill\n+\n+This skill provides instructions on how to retrieve patch series submitted to the QEMU mailing list (`qemu-devel@nongnu.org`) using `b4` or manual methods.\n+\n+## Using b4 (Recommended)\n+\n+`b4` is the preferred tool for working with patch series from public-inbox instances like `lore.kernel.org`.\n+\n+### 1. Fetching a series\n+To download a series and prepare it for `git am`:\n+```bash\n+b4 am \n+```\n+This creates a `.mbx` file containing the entire series, properly ordered.\n+\n+### 2. Applying a series directly\n+To apply a series directly to your current branch:\n+```bash\n+b4 shazam \n+```\n+This is often the fastest way to get a series ready for testing.\n+\n+### 3. Creating a local branch for the series\n+```bash\n+b4 am -t \n+git am ./*.mbx\n+```\n+The `-t` flag (or `--trust-all`) can be useful if you know the source.\n+\n+## Manual mbox Retrieval (Alternative)\n+\n+If `b4` is unavailable, you can fetch the mbox manually from `lore.kernel.org`.\n+\n+### 1. Locate the thread\n+Find the patch series on [lore.kernel.org/qemu-devel/](https://lore.kernel.org/qemu-devel/).\n+\n+### 2. Download the mbox\n+Every thread on lore has an `mbox.gz` link. You can use `curl` or `wget`:\n+```bash\n+curl -L \"https://lore.kernel.org/qemu-devel//raw\" -o series.mbox\n+```\n+*Note: Appending `/raw` to the message URL usually provides the mbox format.*\n+\n+### 3. Apply with git am\n+```bash\n+git am series.mbox\n+```\n+\n+## Post-Application Steps\n+\n+Once the patches are applied, you should perform initial validation:\n+\n+### 1. Style Check\n+Run the QEMU checkpatch script:\n+```bash\n+./scripts/checkpatch.pl master..HEAD\n+```\n+\n+### 2. Build and Test\n+Refer to the `AGENTS.md` or the `qemu-code-explorer` skill for build and test instructions.\n+- Ensure you are in a clean build directory.\n+- Run `ninja` or `make`.\n+- Run relevant tests (e.g., `make check-qtest`).\n+\n+## Common Troubleshooting\n+\n+- **Applying fails**: If `git am` fails due to conflicts, you may need to use `git am --3way` or manually resolve conflicts.\n+- **Missing dependencies**: Ensure your tree is up to date with the base branch the patches were intended for (usually `master`).\n","prefixes":["RFC","03/10"]}