{"id":2233089,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2233089/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505160915.25558-7-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260505160915.25558-7-farosas@suse.de>","list_archive_url":null,"date":"2026-05-05T16:09:05","name":"[v1,06/15] tests/qtest/migration: Use a default TCP URI for precopy","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7cb60bcda6fab5305bff28babc8d96f46c02cd71","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/1.2/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505160915.25558-7-farosas@suse.de/mbox/","series":[{"id":502864,"url":"http://patchwork.ozlabs.org/api/1.2/series/502864/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502864","date":"2026-05-05T16:09:07","name":"tests/qtest/migration: Always defer","version":1,"mbox":"http://patchwork.ozlabs.org/series/502864/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233089/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233089/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=CYO1tLJW;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=MYrHhsBJ;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=CYO1tLJW;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=MYrHhsBJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CYO1tLJW;\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=MYrHhsBJ"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g93S149J0z1yMh\n\tfor ; Wed, 06 May 2026 02:12:01 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKIMG-0008WS-G6; Tue, 05 May 2026 12:10:52 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wKILW-00087R-0H\n for qemu-devel@nongnu.org; Tue, 05 May 2026 12:10:06 -0400","from smtp-out1.suse.de ([195.135.223.130])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wKILT-0000Fs-1x\n for qemu-devel@nongnu.org; Tue, 05 May 2026 12:10:04 -0400","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id A539D6B765;\n Tue, 5 May 2026 16:09:32 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 812A2593A3;\n Tue, 5 May 2026 16:09:31 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id MKFRFDsW+mmNcgAAD6G6ig\n (envelope-from ); Tue, 05 May 2026 16:09:31 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777997372;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=RvQCMVyCnjQXWQYttKYnop1DT8sWT0Mzcw0AThqmErA=;\n b=CYO1tLJW+iwUtI0QfY1LU5Jr8mrE0+K1qjksPHJQDJdae4MLXNVq0aaoQ3M4WL2NezOv2z\n PZcteI4LSvD1wgcD6IOXaYBNEGFIS/a9LgsGkoWD4NmP8po6tVVTn3vUIgfb4+4INlTeJM\n FyNxDjeXzspzg4C+eZp69ubfvdWEVr0=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777997372;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=RvQCMVyCnjQXWQYttKYnop1DT8sWT0Mzcw0AThqmErA=;\n b=MYrHhsBJ24iPcMvuiFs6ORfu2/QBTcAv4tdtIR52VHD5LvNh15ZZSPXa9A1ay58umGx/OM\n +altg7PmgGtu8GCQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777997372;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=RvQCMVyCnjQXWQYttKYnop1DT8sWT0Mzcw0AThqmErA=;\n b=CYO1tLJW+iwUtI0QfY1LU5Jr8mrE0+K1qjksPHJQDJdae4MLXNVq0aaoQ3M4WL2NezOv2z\n PZcteI4LSvD1wgcD6IOXaYBNEGFIS/a9LgsGkoWD4NmP8po6tVVTn3vUIgfb4+4INlTeJM\n FyNxDjeXzspzg4C+eZp69ubfvdWEVr0=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777997372;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=RvQCMVyCnjQXWQYttKYnop1DT8sWT0Mzcw0AThqmErA=;\n b=MYrHhsBJ24iPcMvuiFs6ORfu2/QBTcAv4tdtIR52VHD5LvNh15ZZSPXa9A1ay58umGx/OM\n +altg7PmgGtu8GCQ=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu , Laurent Vivier ,\n Paolo Bonzini ","Subject":"[PATCH v1 06/15] tests/qtest/migration: Use a default TCP URI for\n precopy","Date":"Tue, 5 May 2026 13:09:05 -0300","Message-ID":"<20260505160915.25558-7-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260505160915.25558-1-farosas@suse.de>","References":"<20260505160915.25558-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Score":"-3.01","X-Rspamd-Action":"no action","X-Spamd-Result":"default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_MISSING_CHARSET(0.50)[];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[];\n DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:email,suse.de:dkim,suse.de:mid];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DKIM_TRACE(0.00)[suse.de:+]","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Rspamd-Queue-Id":"A539D6B765","Received-SPF":"pass client-ip=195.135.223.130; envelope-from=farosas@suse.de;\n helo=smtp-out1.suse.de","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Using a localhost TCP URI for testing is quite common. Set it as a\ndefault for precopy tests that don't provide an URI.\n\nSigned-off-by: Fabiano Rosas \n---\n tests/qtest/migration/framework.c | 4 ++++\n tests/qtest/migration/precopy-tests.c | 3 ---\n tests/qtest/migration/tls-tests.c | 9 ---------\n 3 files changed, 4 insertions(+), 12 deletions(-)","diff":"diff --git a/tests/qtest/migration/framework.c b/tests/qtest/migration/framework.c\nindex 73bb015f64..b77889de7f 100644\n--- a/tests/qtest/migration/framework.c\n+++ b/tests/qtest/migration/framework.c\n@@ -834,6 +834,10 @@ int test_precopy_common(MigrateCommon *args)\n void *data_hook = NULL;\n QObject *channels = NULL;\n \n+ if (!args->listen_uri) {\n+ args->listen_uri = \"tcp:127.0.0.1:0\";\n+ }\n+\n if (migrate_start(&from, &to, args->listen_uri, &args->start)) {\n return -1;\n }\ndiff --git a/tests/qtest/migration/precopy-tests.c b/tests/qtest/migration/precopy-tests.c\nindex 54e45e2a02..0d538bcd1a 100644\n--- a/tests/qtest/migration/precopy-tests.c\n+++ b/tests/qtest/migration/precopy-tests.c\n@@ -180,14 +180,11 @@ static void test_precopy_rdma_plain_ipv6(char *name, MigrateCommon *args)\n \n static void test_precopy_tcp_plain(char *name, MigrateCommon *args)\n {\n- args->listen_uri = \"tcp:127.0.0.1:0\";\n-\n test_precopy_common(args);\n }\n \n static void test_precopy_tcp_switchover_ack(char *name, MigrateCommon *args)\n {\n- args->listen_uri = \"tcp:127.0.0.1:0\";\n /*\n * Source VM must be running in order to consider the switchover ACK\n * when deciding to do switchover or not.\ndiff --git a/tests/qtest/migration/tls-tests.c b/tests/qtest/migration/tls-tests.c\nindex 0677ca661e..4a3c404349 100644\n--- a/tests/qtest/migration/tls-tests.c\n+++ b/tests/qtest/migration/tls-tests.c\n@@ -459,7 +459,6 @@ static void test_precopy_unix_tls_x509_override_host(char *name,\n \n static void test_precopy_tcp_tls_psk_match(char *name, MigrateCommon *args)\n {\n- args->listen_uri = \"tcp:127.0.0.1:0\";\n args->start_hook = migrate_hook_start_tls_psk_match;\n args->end_hook = migrate_hook_end_tls_psk;\n \n@@ -468,7 +467,6 @@ static void test_precopy_tcp_tls_psk_match(char *name, MigrateCommon *args)\n \n static void test_precopy_tcp_tls_psk_mismatch(char *name, MigrateCommon *args)\n {\n- args->listen_uri = \"tcp:127.0.0.1:0\";\n args->start_hook = migrate_hook_start_tls_psk_mismatch;\n args->end_hook = migrate_hook_end_tls_psk;\n args->result = MIG_TEST_FAIL;\n@@ -488,7 +486,6 @@ static void *migrate_hook_start_no_tls(QTestState *from, QTestState *to)\n \n static void test_precopy_tcp_no_tls(char *name, MigrateCommon *args)\n {\n- args->listen_uri = \"tcp:127.0.0.1:0\";\n args->start_hook = migrate_hook_start_no_tls;\n /* the no_tls start hook requires no cleanup actions */\n args->end_hook = NULL;\n@@ -529,7 +526,6 @@ static void test_precopy_tcp_tls_no_hostname(char *name, MigrateCommon *args)\n static void test_precopy_tcp_tls_x509_default_host(char *name,\n MigrateCommon *args)\n {\n- args->listen_uri = \"tcp:127.0.0.1:0\";\n args->start_hook = migrate_hook_start_tls_x509_default_host;\n args->end_hook = migrate_hook_end_tls_x509;\n \n@@ -539,7 +535,6 @@ static void test_precopy_tcp_tls_x509_default_host(char *name,\n static void test_precopy_tcp_tls_x509_override_host(char *name,\n MigrateCommon *args)\n {\n- args->listen_uri = \"tcp:127.0.0.1:0\";\n args->start_hook = migrate_hook_start_tls_x509_override_host;\n args->end_hook = migrate_hook_end_tls_x509;\n \n@@ -563,7 +558,6 @@ static void test_precopy_tcp_tls_x509_mismatch_host(char *name,\n static void test_precopy_tcp_tls_x509_friendly_client(char *name,\n MigrateCommon *args)\n {\n- args->listen_uri = \"tcp:127.0.0.1:0\";\n args->start_hook = migrate_hook_start_tls_x509_friendly_client;\n args->end_hook = migrate_hook_end_tls_x509;\n \n@@ -573,7 +567,6 @@ static void test_precopy_tcp_tls_x509_friendly_client(char *name,\n static void test_precopy_tcp_tls_x509_hostile_client(char *name,\n MigrateCommon *args)\n {\n- args->listen_uri = \"tcp:127.0.0.1:0\";\n args->start_hook = migrate_hook_start_tls_x509_hostile_client;\n args->end_hook = migrate_hook_end_tls_x509;\n args->result = MIG_TEST_FAIL;\n@@ -586,7 +579,6 @@ static void test_precopy_tcp_tls_x509_hostile_client(char *name,\n static void test_precopy_tcp_tls_x509_allow_anon_client(char *name,\n MigrateCommon *args)\n {\n- args->listen_uri = \"tcp:127.0.0.1:0\";\n args->start_hook = migrate_hook_start_tls_x509_allow_anon_client;\n args->end_hook = migrate_hook_end_tls_x509;\n \n@@ -596,7 +588,6 @@ static void test_precopy_tcp_tls_x509_allow_anon_client(char *name,\n static void test_precopy_tcp_tls_x509_reject_anon_client(char *name,\n MigrateCommon *args)\n {\n- args->listen_uri = \"tcp:127.0.0.1:0\";\n args->start_hook = migrate_hook_start_tls_x509_reject_anon_client;\n args->end_hook = migrate_hook_end_tls_x509;\n args->result = MIG_TEST_FAIL;\n","prefixes":["v1","06/15"]}