{"id":2233083,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2233083/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505160915.25558-3-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260505160915.25558-3-farosas@suse.de>","list_archive_url":null,"date":"2026-05-05T16:09:01","name":"[v1,02/15] tests/qtest/migration: Make file-tests defer by default","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8510b0e601d1170b7eea440913de613d62a428b1","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/1.2/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505160915.25558-3-farosas@suse.de/mbox/","series":[{"id":502864,"url":"http://patchwork.ozlabs.org/api/1.2/series/502864/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502864","date":"2026-05-05T16:09:07","name":"tests/qtest/migration: Always defer","version":1,"mbox":"http://patchwork.ozlabs.org/series/502864/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233083/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233083/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=vcBZUgYP;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=ojyGKt2e;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=vcBZUgYP;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=ojyGKt2e;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g93R16HZSz1yJx\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 06 May 2026 02:11:08 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wKILT-00086G-4M; Tue, 05 May 2026 12:10:03 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wKIKx-0007oF-FD\n for qemu-devel@nongnu.org; Tue, 05 May 2026 12:09:36 -0400","from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wKIKu-0007IC-OS\n for qemu-devel@nongnu.org; Tue, 05 May 2026 12:09:31 -0400","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 75CFF5CAF0;\n Tue,  5 May 2026 16:09:26 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EB464593A3;\n Tue,  5 May 2026 16:09:24 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id OHVHLjQW+mmNcgAAD6G6ig\n (envelope-from <farosas@suse.de>); Tue, 05 May 2026 16:09:24 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777997366;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=6X3ByejEazZO/IkJ6RU0S63fNUcklMp24fSVi0bmCsk=;\n b=vcBZUgYPOU0S4z02ZV02P7FKukVQUv9tjEHwGdabqyA2x4/1xuFlQn19VGaA7BLmnuffUD\n oXyjtgqfLNDnu+eA6W9C8Ou+AAYpkmWfBpm9uB/+prCYqjxyM6pMjNpIpRtzWx0qOneFGw\n tcjXtw+XeG24SsUjiZHslDcuT1X3Vvo=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777997366;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=6X3ByejEazZO/IkJ6RU0S63fNUcklMp24fSVi0bmCsk=;\n b=ojyGKt2eT1Wi8AASiB0METQsDmIC/jXxI8fPP3C8sb492yfQjdeJ1wOKouUWICC4suZigC\n 6EEZ9g3C3pHpuCAw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777997366;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=6X3ByejEazZO/IkJ6RU0S63fNUcklMp24fSVi0bmCsk=;\n b=vcBZUgYPOU0S4z02ZV02P7FKukVQUv9tjEHwGdabqyA2x4/1xuFlQn19VGaA7BLmnuffUD\n oXyjtgqfLNDnu+eA6W9C8Ou+AAYpkmWfBpm9uB/+prCYqjxyM6pMjNpIpRtzWx0qOneFGw\n tcjXtw+XeG24SsUjiZHslDcuT1X3Vvo=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777997366;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=6X3ByejEazZO/IkJ6RU0S63fNUcklMp24fSVi0bmCsk=;\n b=ojyGKt2eT1Wi8AASiB0METQsDmIC/jXxI8fPP3C8sb492yfQjdeJ1wOKouUWICC4suZigC\n 6EEZ9g3C3pHpuCAw=="],"From":"Fabiano Rosas <farosas@suse.de>","To":"qemu-devel@nongnu.org","Cc":"Peter Xu <peterx@redhat.com>, Mark Kanda <mark.kanda@oracle.com>,\n Ben Chaney <bchaney@akamai.com>, Laurent Vivier <lvivier@redhat.com>,\n Paolo Bonzini <pbonzini@redhat.com>","Subject":"[PATCH v1 02/15] tests/qtest/migration: Make file-tests defer by\n default","Date":"Tue,  5 May 2026 13:09:01 -0300","Message-ID":"<20260505160915.25558-3-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260505160915.25558-1-farosas@suse.de>","References":"<20260505160915.25558-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Score":"-2.80","X-Spamd-Result":"default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000];\n MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_SOME(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:helo];\n RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RCPT_COUNT_FIVE(0.00)[6]; RCVD_TLS_ALL(0.00)[]","Received-SPF":"pass client-ip=2a07:de40:b251:101:10:150:64:2;\n envelope-from=farosas@suse.de; helo=smtp-out2.suse.de","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"All file: tests use listen_uri=\"defer\". Make this the default in the\ncommon function.\n\nSigned-off-by: Fabiano Rosas <farosas@suse.de>\n---\n tests/qtest/migration/cpr-tests.c  |  1 -\n tests/qtest/migration/file-tests.c | 14 --------------\n tests/qtest/migration/framework.c  |  2 +-\n 3 files changed, 1 insertion(+), 16 deletions(-)","diff":"diff --git a/tests/qtest/migration/cpr-tests.c b/tests/qtest/migration/cpr-tests.c\nindex 48c98f0089..18217f0460 100644\n--- a/tests/qtest/migration/cpr-tests.c\n+++ b/tests/qtest/migration/cpr-tests.c\n@@ -36,7 +36,6 @@ static void test_mode_reboot(char *name, MigrateCommon *args)\n                                            FILE_TEST_FILENAME);\n \n     args->connect_uri = uri;\n-    args->listen_uri = \"defer\";\n     args->start_hook = migrate_hook_start_mode_reboot;\n \n     args->start.mem_type = MEM_TYPE_SHMEM;\ndiff --git a/tests/qtest/migration/file-tests.c b/tests/qtest/migration/file-tests.c\nindex fef172068f..75135447f8 100644\n--- a/tests/qtest/migration/file-tests.c\n+++ b/tests/qtest/migration/file-tests.c\n@@ -70,8 +70,6 @@ static void test_precopy_file(char *name, MigrateCommon *args)\n     g_autofree char *uri = g_strdup_printf(\"file:%s/%s\", tmpfs,\n                                            FILE_TEST_FILENAME);\n     args->connect_uri = uri;\n-    args->listen_uri = \"defer\";\n-\n     test_file_common(args, true);\n }\n \n@@ -114,7 +112,6 @@ static void test_precopy_file_offset_fdset(char *name, MigrateCommon *args)\n     g_autofree char *uri = g_strdup_printf(\"file:/dev/fdset/1,offset=%d\",\n                                            FILE_TEST_OFFSET);\n     args->connect_uri = uri;\n-    args->listen_uri = \"defer\";\n     args->start_hook = migrate_hook_start_file_offset_fdset;\n \n     test_file_common(args, false);\n@@ -128,8 +125,6 @@ static void test_precopy_file_offset(char *name, MigrateCommon *args)\n                                            FILE_TEST_OFFSET);\n \n     args->connect_uri = uri;\n-    args->listen_uri = \"defer\";\n-\n     test_file_common(args, false);\n }\n \n@@ -140,7 +135,6 @@ static void test_precopy_file_offset_bad(char *name, MigrateCommon *args)\n                                            tmpfs, FILE_TEST_FILENAME);\n \n     args->connect_uri = uri;\n-    args->listen_uri = \"defer\";\n     args->result = MIG_TEST_QMP_ERROR;\n \n     test_file_common(args, false);\n@@ -152,7 +146,6 @@ static void test_precopy_file_mapped_ram_live(char *name, MigrateCommon *args)\n                                            FILE_TEST_FILENAME);\n \n     args->connect_uri = uri;\n-    args->listen_uri = \"defer\";\n \n     args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;\n \n@@ -165,7 +158,6 @@ static void test_precopy_file_mapped_ram(char *name, MigrateCommon *args)\n                                            FILE_TEST_FILENAME);\n \n     args->connect_uri = uri;\n-    args->listen_uri = \"defer\";\n \n     args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;\n \n@@ -177,7 +169,6 @@ static void test_multifd_file_mapped_ram_live(char *name, MigrateCommon *args)\n     g_autofree char *uri = g_strdup_printf(\"file:%s/%s\", tmpfs,\n                                            FILE_TEST_FILENAME);\n     args->connect_uri = uri;\n-    args->listen_uri = \"defer\";\n \n     args->start.caps[MIGRATION_CAPABILITY_MULTIFD] = true;\n     args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;\n@@ -191,7 +182,6 @@ static void test_multifd_file_mapped_ram(char *name, MigrateCommon *args)\n                                            FILE_TEST_FILENAME);\n \n     args->connect_uri = uri;\n-    args->listen_uri = \"defer\";\n \n     args->start.caps[MIGRATION_CAPABILITY_MULTIFD] = true;\n     args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;\n@@ -213,7 +203,6 @@ static void test_multifd_file_mapped_ram_dio(char *name, MigrateCommon *args)\n     g_autofree char *uri = g_strdup_printf(\"file:%s/%s\", tmpfs,\n                                            FILE_TEST_FILENAME);\n     args->connect_uri = uri;\n-    args->listen_uri = \"defer\";\n     args->start_hook = migrate_hook_start_multifd_mapped_ram_dio;\n \n     args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;\n@@ -285,7 +274,6 @@ static void test_multifd_file_mapped_ram_fdset(char *name, MigrateCommon *args)\n                                            FILE_TEST_OFFSET);\n \n     args->connect_uri = uri;\n-    args->listen_uri = \"defer\";\n     args->start_hook = migrate_hook_start_multifd_mapped_ram_fdset;\n     args->end_hook = migrate_hook_end_multifd_mapped_ram_fdset;\n \n@@ -301,7 +289,6 @@ static void test_multifd_file_mapped_ram_fdset_dio(char *name,\n     g_autofree char *uri = g_strdup_printf(\"file:/dev/fdset/1,offset=%d\",\n                                            FILE_TEST_OFFSET);\n     args->connect_uri = uri;\n-    args->listen_uri = \"defer\";\n     args->start_hook = migrate_hook_start_multifd_mapped_ram_fdset_dio;\n     args->end_hook = migrate_hook_end_multifd_mapped_ram_fdset;\n \n@@ -332,7 +319,6 @@ test_precopy_file_mapped_ram_ignore_shared(char *name, MigrateCommon *args)\n     g_autofree char *uri = g_strdup_printf(\"file:%s/%s\", tmpfs,\n                                            FILE_TEST_FILENAME);\n     args->connect_uri = uri;\n-    args->listen_uri = \"defer\";\n \n     args->start.caps[MIGRATION_CAPABILITY_MAPPED_RAM] = true;\n     args->start.caps[MIGRATION_CAPABILITY_X_IGNORE_SHARED] = true;\ndiff --git a/tests/qtest/migration/framework.c b/tests/qtest/migration/framework.c\nindex 4ef5e1de83..edd3d0b165 100644\n--- a/tests/qtest/migration/framework.c\n+++ b/tests/qtest/migration/framework.c\n@@ -972,7 +972,7 @@ void test_file_common(MigrateCommon *args, bool stop_src)\n     void *data_hook = NULL;\n     bool check_offset = false;\n \n-    if (migrate_start(&from, &to, args->listen_uri, &args->start)) {\n+    if (migrate_start(&from, &to, \"defer\", &args->start)) {\n         return;\n     }\n \n","prefixes":["v1","02/15"]}