{"id":2233081,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2233081/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505160915.25558-9-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260505160915.25558-9-farosas@suse.de>","list_archive_url":null,"date":"2026-05-05T16:09:07","name":"[v1,08/15] tests/qtest/migration: Set compression method in compression-tests","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bcb63cdb7c9277585fce40d2a133a27e734a04f2","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/1.2/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505160915.25558-9-farosas@suse.de/mbox/","series":[{"id":502864,"url":"http://patchwork.ozlabs.org/api/1.2/series/502864/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502864","date":"2026-05-05T16:09:07","name":"tests/qtest/migration: Always defer","version":1,"mbox":"http://patchwork.ozlabs.org/series/502864/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233081/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233081/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=wNFLssce;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=xJ6u2P74;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=k7l+D8pF;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=w5m/Yzqq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=k7l+D8pF;\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=\"w5m/Yzqq\""],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g93R16Lwmz1yK2\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 06 May 2026 02:11:08 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wKIMG-00004w-Gh; Tue, 05 May 2026 12:10:52 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wKIM0-0008GP-FD\n for qemu-devel@nongnu.org; Tue, 05 May 2026 12:10:37 -0400","from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wKILv-0000ZE-Q1\n for qemu-devel@nongnu.org; Tue, 05 May 2026 12:10:36 -0400","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id EA4B66B767;\n Tue,  5 May 2026 16:09:35 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C79C5593A3;\n Tue,  5 May 2026 16:09:34 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id iDGUJT4W+mmNcgAAD6G6ig\n (envelope-from <farosas@suse.de>); Tue, 05 May 2026 16:09:34 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777997376;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=oOXl+Kg4Ekn8eRhNqDeLTfbVre71RRbBJww/DujlEyo=;\n b=wNFLsscelt0/z5quOYMs2eiDNKSVaun+tvxiNnnnAnMKnN60N1gRytA4BGTg/khbIWHld4\n CDepdQjoSr9JtdoKCwIaTjf1yYCjem6x9mTSrmYYaiywLzDm7EUvVVRta7n8i97nEyt4i6\n xLsRggUTFouo+ZXX++gfR4trCQbM6Zg=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777997376;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=oOXl+Kg4Ekn8eRhNqDeLTfbVre71RRbBJww/DujlEyo=;\n b=xJ6u2P742M/joxUWfi0TiWhMZ9EzKxem/b1pfKa8uwdKm+jwAgvbPWThJeYnaoOlRipBR9\n pUtMHyYE5YkIREAA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777997375;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=oOXl+Kg4Ekn8eRhNqDeLTfbVre71RRbBJww/DujlEyo=;\n b=k7l+D8pFf4CYcVR6ok27xnEZ9vJJOopa0mkQYt6oLR6VYb0hrSp7M8qTFJzCtfO/NnAg2q\n uZiSV02Bq53wzG3DNK0YM72D7HbLe34kUJhDJNy9SIVCQnqjQ/FzoxTN05NQKdmMcx0jIi\n aLMDSfOl+ucMlIri2MQMor9AiurIWY0=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777997375;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=oOXl+Kg4Ekn8eRhNqDeLTfbVre71RRbBJww/DujlEyo=;\n b=w5m/YzqqPu1ktmIO+1tCTwePhdQEjrYHotPUGQ/VNhrW0xyN7lap1WvIuVIb7rUpo7lRbS\n YabHz6RtksXMVEBg=="],"From":"Fabiano Rosas <farosas@suse.de>","To":"qemu-devel@nongnu.org","Cc":"Peter Xu <peterx@redhat.com>, Laurent Vivier <lvivier@redhat.com>,\n Paolo Bonzini <pbonzini@redhat.com>","Subject":"[PATCH v1 08/15] tests/qtest/migration: Set compression method in\n compression-tests","Date":"Tue,  5 May 2026 13:09:07 -0300","Message-ID":"<20260505160915.25558-9-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260505160915.25558-1-farosas@suse.de>","References":"<20260505160915.25558-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Rspamd-Action":"no action","X-Spamd-Result":"default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_MISSING_CHARSET(0.50)[];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,suse.de:email,suse.de:mid];\n FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[];\n RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[];\n RCPT_COUNT_THREE(0.00)[4]; DKIM_TRACE(0.00)[suse.de:+]","X-Rspamd-Queue-Id":"EA4B66B767","X-Rspamd-Server":"rspamd2.dmz-prg2.suse.org","X-Spam-Score":"-3.01","Received-SPF":"pass client-ip=2a07:de40:b251:101:10:150:64:1;\n envelope-from=farosas@suse.de; helo=smtp-out1.suse.de","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Stop calling a common function to set the multifd compression\nmethod. The default method is \"none\", so the common function is not\nnecessary for tests that don't set compression and will be removed.\n\nSigned-off-by: Fabiano Rosas <farosas@suse.de>\n---\n tests/qtest/migration/compression-tests.c | 22 +++++++++++++++++-----\n 1 file changed, 17 insertions(+), 5 deletions(-)","diff":"diff --git a/tests/qtest/migration/compression-tests.c b/tests/qtest/migration/compression-tests.c\nindex 134bf44db6..848576054f 100644\n--- a/tests/qtest/migration/compression-tests.c\n+++ b/tests/qtest/migration/compression-tests.c\n@@ -20,6 +20,13 @@\n \n static char *tmpfs;\n \n+static void set_multifd_compression(QTestState *from, QTestState *to,\n+                                    const char *method)\n+{\n+    migrate_set_parameter_str(from, \"multifd-compression\", method);\n+    migrate_set_parameter_str(to, \"multifd-compression\", method);\n+}\n+\n #ifdef CONFIG_ZSTD\n static void *\n migrate_hook_start_precopy_tcp_multifd_zstd(QTestState *from,\n@@ -27,8 +34,9 @@ migrate_hook_start_precopy_tcp_multifd_zstd(QTestState *from,\n {\n     migrate_set_parameter_int(from, \"multifd-zstd-level\", 2);\n     migrate_set_parameter_int(to, \"multifd-zstd-level\", 2);\n+    set_multifd_compression(from, to, \"zstd\");\n \n-    return migrate_hook_start_precopy_tcp_multifd_common(from, to, \"zstd\");\n+    return NULL;\n }\n \n static void test_multifd_tcp_zstd(char *name, MigrateCommon *args)\n@@ -58,8 +66,9 @@ migrate_hook_start_precopy_tcp_multifd_qatzip(QTestState *from,\n {\n     migrate_set_parameter_int(from, \"multifd-qatzip-level\", 2);\n     migrate_set_parameter_int(to, \"multifd-qatzip-level\", 2);\n+    set_multifd_compression(from, to, \"qatzip\");\n \n-    return migrate_hook_start_precopy_tcp_multifd_common(from, to, \"qatzip\");\n+    return NULL;\n }\n \n static void test_multifd_tcp_qatzip(char *name, MigrateCommon *args)\n@@ -77,7 +86,8 @@ static void *\n migrate_hook_start_precopy_tcp_multifd_qpl(QTestState *from,\n                                            QTestState *to)\n {\n-    return migrate_hook_start_precopy_tcp_multifd_common(from, to, \"qpl\");\n+    set_multifd_compression(from, to, \"qpl\");\n+    return NULL;\n }\n \n static void test_multifd_tcp_qpl(char *name, MigrateCommon *args)\n@@ -95,7 +105,8 @@ static void *\n migrate_hook_start_precopy_tcp_multifd_uadk(QTestState *from,\n                                             QTestState *to)\n {\n-    return migrate_hook_start_precopy_tcp_multifd_common(from, to, \"uadk\");\n+    set_multifd_compression(from, to, \"uadk\");\n+    return NULL;\n }\n \n static void test_multifd_tcp_uadk(char *name, MigrateCommon *args)\n@@ -141,8 +152,9 @@ migrate_hook_start_precopy_tcp_multifd_zlib(QTestState *from,\n      */\n     migrate_set_parameter_int(from, \"multifd-zlib-level\", 2);\n     migrate_set_parameter_int(to, \"multifd-zlib-level\", 2);\n+    set_multifd_compression(from, to, \"zlib\");\n \n-    return migrate_hook_start_precopy_tcp_multifd_common(from, to, \"zlib\");\n+    return NULL;\n }\n \n static void test_multifd_tcp_zlib(char *name, MigrateCommon *args)\n","prefixes":["v1","08/15"]}