{"id":2233058,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2233058/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260505152923.1040589-6-aleksander.lobakin@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260505152923.1040589-6-aleksander.lobakin@intel.com>","list_archive_url":null,"date":"2026-05-05T15:29:23","name":"[iwl-next,v5,5/5] ice: add support for transmitting unreadable frags","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"536788c8c8de18fc85280f548db69def5a762018","submitter":{"id":85827,"url":"http://patchwork.ozlabs.org/api/1.2/people/85827/?format=json","name":"Alexander Lobakin","email":"aleksander.lobakin@intel.com"},"delegate":{"id":109701,"url":"http://patchwork.ozlabs.org/api/1.2/users/109701/?format=json","username":"anguy11","first_name":"Anthony","last_name":"Nguyen","email":"anthony.l.nguyen@intel.com"},"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260505152923.1040589-6-aleksander.lobakin@intel.com/mbox/","series":[{"id":502856,"url":"http://patchwork.ozlabs.org/api/1.2/series/502856/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=502856","date":"2026-05-05T15:29:18","name":"ice: add support for devmem/io_uring Rx and Tx","version":5,"mbox":"http://patchwork.ozlabs.org/series/502856/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233058/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233058/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=5oCPEyi9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g92Xj2Vz8z1yJx\n\tfor ; Wed, 06 May 2026 01:31:01 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 02C5140AA7;\n\tTue, 5 May 2026 15:31:00 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id oW8mLUE-pHOv; Tue, 5 May 2026 15:30:58 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 1397140AAB;\n\tTue, 5 May 2026 15:30:58 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id D05B4280\n for ; Tue, 5 May 2026 15:30:56 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id C29AA608B1\n for ; Tue, 5 May 2026 15:30:56 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Q5ixX79gko9T for ;\n Tue, 5 May 2026 15:30:56 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.7])\n by smtp3.osuosl.org (Postfix) with ESMTPS id D434F607CE\n for ; Tue, 5 May 2026 15:30:55 +0000 (UTC)","from orviesa010.jf.intel.com ([10.64.159.150])\n by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 May 2026 08:30:56 -0700","from newjersey.igk.intel.com ([10.102.20.203])\n by orviesa010.jf.intel.com with ESMTP; 05 May 2026 08:30:52 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1397140AAB","OpenDKIM Filter v2.11.0 smtp3.osuosl.org D434F607CE"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777995058;\n\tbh=J1Q3fzB5XNbph2E1xsV4hQ21IssjaM3EziS1VC0d6PI=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=5oCPEyi9MYZfny/fNTCYNp5wh2ng9mHQnhxHmNL/a7GYaIoUWKwvUqBrWzzX95pjP\n\t VOo7OMu5qoehs8rGraDdh+McGl3H+tS637EtnBAtrzCz/aWm/Zu1crn9lmmrPV4Es9\n\t HJGoemHaij7NSmhcg4E8oBFNRIlTbnO0axnl6gR4X74Gz2Oblx3GDNj6fkTOCTXsyj\n\t bbI9T16QjwdUcwnR9SiXQGAuidE8cPZcw+ALFNmZCbl14RrUv/ASRiza0PRj4Tqmhk\n\t SO2riu7mro++RF5pIttuv3QU7xrbOJY/QukRURVG2bchEOE4b4glfage3uOcsqVIHd\n\t ACVvo1fkvL5jQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.7;\n helo=mgamail.intel.com; envelope-from=aleksander.lobakin@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org D434F607CE","X-CSE-ConnectionGUID":["MLpuMPkRSwyPotSEbPX7Zg==","J+89BIQLSxCDVTtwL6SppA=="],"X-CSE-MsgGUID":["PdpS/iQUQwGk9ghxGHPn/w==","1YPaHPv+TBayVn3P2FxvRQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11777\"; a=\"104317054\"","E=Sophos;i=\"6.23,217,1770624000\"; d=\"scan'208\";a=\"104317054\"","E=Sophos;i=\"6.23,217,1770624000\"; d=\"scan'208\";a=\"234971648\""],"X-ExtLoop1":"1","From":"Alexander Lobakin ","To":"intel-wired-lan@lists.osuosl.org","Cc":"Alexander Lobakin ,\n Tony Nguyen ,\n Przemek Kitszel ,\n Andrew Lunn ,\n \"David S. Miller\" ,\n Eric Dumazet , Jakub Kicinski ,\n Paolo Abeni , Simon Horman ,\n Kohei Enju , Jacob Keller ,\n Aleksandr Loktionov ,\n nxne.cnse.osdt.itp.upstreaming@intel.com, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org","Date":"Tue, 5 May 2026 17:29:23 +0200","Message-ID":"<20260505152923.1040589-6-aleksander.lobakin@intel.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260505152923.1040589-1-aleksander.lobakin@intel.com>","References":"<20260505152923.1040589-1-aleksander.lobakin@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777995056; x=1809531056;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=HolT7PXCy5cF9qjppvnXYtGVJsuEn+G2B+l3YMhtWus=;\n b=Tlhsz0eNRdmcblcqwMHWU8JAvU1iC3ledRo8eDEKkZGz0qiBN2ScmyaN\n DK+EIWytA4AER8pMPV6xeXkjWvB+9qxr/Ll8Uz4H0FbL9XSbEfA9Hvop0\n K9NyBuL6rhNf0/M06/PGI3NcIswypQdAzxUxOlZLYKbeTC1hEGgsu57VX\n tl/vDcXG3JUefDfCdagiDnpXngc+rhCMZLaZ6kBERMgQ/eaim1zueycFY\n YfMgQQY2TJzyhnf3cJvI4EadvaMc7gHNQdn4tDlVRSba3P6bW8GVvrnyL\n 8Tpk3vWWHhJ1wJLo/AFikyECsDbOGczk3aFmLoSw2Nrnzn6N2dFaLS+xB\n g==;","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=Tlhsz0eN"],"Subject":"[Intel-wired-lan] [PATCH iwl-next v5 5/5] ice: add support for\n transmitting unreadable frags","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Advertise netmem Tx support in ice. The only change needed is to set\nICE_TX_BUF_FRAG conditionally, only when skb_frag_is_net_iov() is\nfalse. Otherwise, the Tx buffer type will be ICE_TX_BUF_EMPTY and\nthe driver will skip the DMA unmapping operation.\n\nReviewed-by: Jacob Keller \nReviewed-by: Aleksandr Loktionov \nSigned-off-by: Alexander Lobakin \n---\n drivers/net/ethernet/intel/ice/ice_main.c | 1 +\n drivers/net/ethernet/intel/ice/ice_sf_eth.c | 1 +\n drivers/net/ethernet/intel/ice/ice_txrx.c | 17 +++++++++++++----\n 3 files changed, 15 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex a88f9e3c0077..0e61b38e53a5 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -3453,6 +3453,7 @@ static void ice_set_ops(struct ice_vsi *vsi)\n \n \tnetdev->netdev_ops = &ice_netdev_ops;\n \tnetdev->queue_mgmt_ops = &ice_queue_mgmt_ops;\n+\tnetdev->netmem_tx = true;\n \tnetdev->udp_tunnel_nic_info = &pf->hw.udp_tunnel_nic;\n \tnetdev->xdp_metadata_ops = &ice_xdp_md_ops;\n \tice_set_ethtool_ops(netdev);\ndiff --git a/drivers/net/ethernet/intel/ice/ice_sf_eth.c b/drivers/net/ethernet/intel/ice/ice_sf_eth.c\nindex 8d1541712abc..fdf98aa431ba 100644\n--- a/drivers/net/ethernet/intel/ice/ice_sf_eth.c\n+++ b/drivers/net/ethernet/intel/ice/ice_sf_eth.c\n@@ -59,6 +59,7 @@ static int ice_sf_cfg_netdev(struct ice_dynamic_port *dyn_port,\n \tether_addr_copy(netdev->perm_addr, dyn_port->hw_addr);\n \tnetdev->netdev_ops = &ice_sf_netdev_ops;\n \tnetdev->queue_mgmt_ops = &ice_queue_mgmt_ops;\n+\tnetdev->netmem_tx = true;\n \tSET_NETDEV_DEVLINK_PORT(netdev, devlink_port);\n \n \terr = register_netdev(netdev);\ndiff --git a/drivers/net/ethernet/intel/ice/ice_txrx.c b/drivers/net/ethernet/intel/ice/ice_txrx.c\nindex 43b467076027..1d97e2cc2ade 100644\n--- a/drivers/net/ethernet/intel/ice/ice_txrx.c\n+++ b/drivers/net/ethernet/intel/ice/ice_txrx.c\n@@ -113,11 +113,17 @@ ice_prgm_fdir_fltr(struct ice_vsi *vsi, struct ice_fltr_desc *fdir_desc,\n static void\n ice_unmap_and_free_tx_buf(struct ice_tx_ring *ring, struct ice_tx_buf *tx_buf)\n {\n-\tif (tx_buf->type != ICE_TX_BUF_XDP_TX && dma_unmap_len(tx_buf, len))\n+\tswitch (tx_buf->type) {\n+\tcase ICE_TX_BUF_DUMMY:\n+\tcase ICE_TX_BUF_FRAG:\n+\tcase ICE_TX_BUF_SKB:\n+\tcase ICE_TX_BUF_XDP_XMIT:\n \t\tdma_unmap_page(ring->dev,\n \t\t\t dma_unmap_addr(tx_buf, dma),\n \t\t\t dma_unmap_len(tx_buf, len),\n \t\t\t DMA_TO_DEVICE);\n+\t\tbreak;\n+\t}\n \n \tswitch (tx_buf->type) {\n \tcase ICE_TX_BUF_DUMMY:\n@@ -338,12 +344,14 @@ static bool ice_clean_tx_irq(struct ice_tx_ring *tx_ring, int napi_budget)\n \t\t\t}\n \n \t\t\t/* unmap any remaining paged data */\n-\t\t\tif (dma_unmap_len(tx_buf, len)) {\n+\t\t\tif (tx_buf->type != ICE_TX_BUF_EMPTY) {\n \t\t\t\tdma_unmap_page(tx_ring->dev,\n \t\t\t\t\t dma_unmap_addr(tx_buf, dma),\n \t\t\t\t\t dma_unmap_len(tx_buf, len),\n \t\t\t\t\t DMA_TO_DEVICE);\n+\n \t\t\t\tdma_unmap_len_set(tx_buf, len, 0);\n+\t\t\t\ttx_buf->type = ICE_TX_BUF_EMPTY;\n \t\t\t}\n \t\t}\n \t\tice_trace(clean_tx_irq_unmap_eop, tx_ring, tx_desc, tx_buf);\n@@ -1495,7 +1503,8 @@ ice_tx_map(struct ice_tx_ring *tx_ring, struct ice_tx_buf *first,\n \t\t\t\t DMA_TO_DEVICE);\n \n \t\ttx_buf = &tx_ring->tx_buf[i];\n-\t\ttx_buf->type = ICE_TX_BUF_FRAG;\n+\t\tif (!skb_frag_is_net_iov(frag))\n+\t\t\ttx_buf->type = ICE_TX_BUF_FRAG;\n \t}\n \n \t/* record SW timestamp if HW timestamp is not available */\n@@ -2377,7 +2386,7 @@ void ice_clean_ctrl_tx_irq(struct ice_tx_ring *tx_ring)\n \t\t}\n \n \t\t/* unmap the data header */\n-\t\tif (dma_unmap_len(tx_buf, len))\n+\t\tif (tx_buf->type != ICE_TX_BUF_EMPTY)\n \t\t\tdma_unmap_single(tx_ring->dev,\n \t\t\t\t\t dma_unmap_addr(tx_buf, dma),\n \t\t\t\t\t dma_unmap_len(tx_buf, len),\n","prefixes":["iwl-next","v5","5/5"]}