{"id":2233042,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2233042/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260505151030.1749548-3-waffl3x@baylibre.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.2/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260505151030.1749548-3-waffl3x@baylibre.com>","list_archive_url":null,"date":"2026-05-05T15:01:55","name":"[02/12] OpenMP/C: Change repetitive allocator clause diagnostic wording","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8f9c83fab5fa8e709e832d17758ecc9ca5d5c545","submitter":{"id":90070,"url":"http://patchwork.ozlabs.org/api/1.2/people/90070/?format=json","name":"Waffl3x","email":"waffl3x@baylibre.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260505151030.1749548-3-waffl3x@baylibre.com/mbox/","series":[{"id":502853,"url":"http://patchwork.ozlabs.org/api/1.2/series/502853/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=502853","date":"2026-05-05T15:01:54","name":"OpenMP/C++: 'allocate' directive","version":1,"mbox":"http://patchwork.ozlabs.org/series/502853/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233042/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233042/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=VBY5xZOM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=VBY5xZOM","sourceware.org;\n dmarc=none (p=none dis=none) header.from=baylibre.com","sourceware.org; spf=pass smtp.mailfrom=baylibre.com","server2.sourceware.org;\n arc=none smtp.remote-ip=2607:f8b0:4864:20::434"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g92835Mghz1yJ0\n\tfor ; Wed, 06 May 2026 01:13:07 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id BEFB64BA79BA\n\tfor ; Tue, 5 May 2026 15:13:05 +0000 (GMT)","from mail-pf1-x434.google.com (mail-pf1-x434.google.com\n [IPv6:2607:f8b0:4864:20::434])\n by sourceware.org (Postfix) with ESMTPS id 3FC284BA2E39\n for ; Tue, 5 May 2026 15:10:38 +0000 (GMT)","by mail-pf1-x434.google.com with SMTP id\n d2e1a72fcca58-835451c5debso112978b3a.2\n for ; Tue, 05 May 2026 08:10:38 -0700 (PDT)","from waffl3x-prestige.lan ([2001:56a:f98a:b800:1f67:ce08:3cbd:86b8])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-83965645140sm2674956b3a.12.2026.05.05.08.10.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 May 2026 08:10:36 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org BEFB64BA79BA","OpenDKIM Filter v2.11.0 sourceware.org 3FC284BA2E39"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 3FC284BA2E39","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 3FC284BA2E39","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777993838; cv=none;\n b=fR1+OnCqFR/dX4k8i6PmHNofwzkpuXrckL2Iw3Kh/Sui3HtJ5vMhkGbqbA/OW7nUn7LaYBUzDbVNh0MP59zLd5KgCHgLrCv7UWgWOXWIjCGLNjbIIXuadeDtGi0GAib93+n/8dgFiskwJaTQRBz1KU3vYBffeYC/8xhbid/VNrE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777993838; c=relaxed/simple;\n bh=rG6qG13soUXe1TDomKUaMJn5EPPhhQtDJs+rZWsCPk8=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=RHJsTticgGkctjSJvzyelwBSQ/NL5zNdLUl6HcYI8ifNSrp8bgDwaRMuI1UyEXsUqNO0ho5dJnHo2jLFe3J0ktmvj+kgdaT9dxUa10zlP+R7FjUfaPOFM5Ldb7xNcOSPZQ3Mze3naPRxpYT7ocguyi5w8BmmpPYgttvpx7HmusQ=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1777993837;\n x=1778598637;\n darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=LwZpOnZ2H+00GK4nNSp5wPrrd0izJyeyEHey1wkZGs4=;\n b=VBY5xZOMmldNkjX4fLpNnzfJOf3jOU/hlePF4sRvATVcQYziLkLA3EqhKEb/y/BHqj\n ADec5t+ln0JtVlYArr4TmzFhJNxAfo6UTvkS3QdNVLPVg7LtbcGiCMHUN++LZruF1yBr\n p+BLOSe7GkRky04TJAHmbwWKlNtxhkqBw+9HS/y/eb8XURPqK4vUAmaU0iLXq01b4EOo\n Mcd3OL8KHdkpaUJoC2IAVEPhUap+cI/XAqvS4nctF5pAhM/rGNOGXfhdBtcw1RoqO9TH\n Ll5SD3yDNGITbOAUCWtx7K+Z0etJO+S6rt0yy9pFDiJ8jAhr9r3pibD/Y+sqRDBLM6lC\n 3TuA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777993837; x=1778598637;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=LwZpOnZ2H+00GK4nNSp5wPrrd0izJyeyEHey1wkZGs4=;\n b=ki1wlr9cz/2E2TGnvLigIK2KLufFrnmD/cSA2qoYfJs0j+l5QSmSzFfB+LLitOddip\n qrHa1wMSnWY+FqQk1iLfxH3Uj1TVc6C/xzZV+hCl9Ki1iEUL193fgwvB8f9mXwDl9nZh\n hQG8rkzn2udBBfZQb2/aJ9uYMgRvPfgeO2O85KFtw23bsXBrjpDrBvt+53Hn9Oho/rva\n jTIuPg3gJ83AimRiUi4FSNBpow1exi/+KOzuxlJ36v+0CMS1TNxtXsZ8Mkujc/7Ufg/o\n gQi8mAHLt4d4bmgC02rToG+FK1wo8XiXgIzjI7jCvdqalpUTRy8Idly2ZkGMm+Ak50lq\n JL2A==","X-Gm-Message-State":"AOJu0Yz4aHB19MTVQn6RzSlHqPgr6ane+/V6a9gSyZEN/rbTJjkgvR/o\n nafu6M42kOzBtRDA2kWpJ7TwqdPyX1dgIjNHrO0Ex2niX3VZtAGXmFgv5T8chzR6Tu8wlWdw/I8\n e6efq","X-Gm-Gg":"AeBDieu9WN2CDGnCXX5Qjo6RLcE8XnyQzkYmCqfd1z6ho11jnEJXhadXggfDGT+nJCB\n qi/p+mnYHVUSjKMbXblWCRslETxDbWlu7WpNJMlWGF8jzB3WCXXGf2LnnnQQg19pI3cG7JhfUJt\n oFt1sEN5LqW92+eOd4S5Mum73McoS4zAr/hRx8o7bWV9PRjTVCP0wHD6vM92OfUF55KjRe+qwyL\n mZl+S/zIeaJooceQG9y+3wJ/HHZUzxaoosbaIpT1hHYFkHhEqo+hfFjxBVtFv6C3zIh4HRnfZie\n KzR7qH9yQQBWSnmyzO2B/TH5Qi+kGgzoQh8977p9zSPNKKYds15e5Ph8oNa2bF5Ds/SCo/aHeP5\n usAcHbEkquwmvApcps9RwvDddfa3qzYBJaPDhwXXIIlwMWpG0mKtF5OzxJdM47WiGhlCIgrojtZ\n Vk9UV6BMIpZtqVm8uKnWalczWV0a0GTmFwglE4KujSJhnsCF8QpN5taJRXFZYy","X-Received":"by 2002:a05:6a00:a803:b0:837:95fc:148d with SMTP id\n d2e1a72fcca58-83795fc19aamr4420700b3a.0.1777993837252;\n Tue, 05 May 2026 08:10:37 -0700 (PDT)","From":"Waffl3x ","To":"gcc-patches@gcc.gnu.org","Cc":"Waffl3x ","Subject":"[PATCH 02/12] OpenMP/C: Change repetitive allocator clause diagnostic\n wording","Date":"Tue, 5 May 2026 09:01:55 -0600","Message-ID":"<20260505151030.1749548-3-waffl3x@baylibre.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260505151030.1749548-1-waffl3x@baylibre.com>","References":"\n \n <20260505151030.1749548-1-waffl3x@baylibre.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"This is specifically for an allocator clause in an allocate directive.\n\nThe old text, 'allocator' clause allocator expression, does not flow very\nwell. This patch removes the redundant second allocator from the diagnostic.\nThis case reads poorly because the two words are the same, but there are\nother diagnostics that use the same pattern that we could consider changing\nas well. For example, 'allocate' clause allocator expression, despite being\ntwo different words still feels rather redundant.\n\ngcc/c/ChangeLog:\n\n\t* c-parser.cc (c_parser_omp_allocate): Change diagnostic.\n\ngcc/testsuite/ChangeLog:\n\n\t* c-c++-common/gomp/allocate-5.c: Match new diagnostic.\n\nSigned-off-by: Waffl3x \n---\n gcc/c/c-parser.cc | 2 +-\n gcc/testsuite/c-c++-common/gomp/allocate-5.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/gcc/c/c-parser.cc b/gcc/c/c-parser.cc\nindex 0b8b2387109..c7b04fb5cf9 100644\n--- a/gcc/c/c-parser.cc\n+++ b/gcc/c/c-parser.cc\n@@ -23488,7 +23488,7 @@ c_parser_omp_allocate (c_parser *parser)\n \t\t != get_identifier (\"omp_allocator_handle_t\"))\n \t {\n \t error_at (expr_loc,\n-\t\t\t\"% clause allocator expression has type \"\n+\t\t\t\"% clause expression has type \"\n \t\t\t\"%qT rather than %\",\n \t\t\tTREE_TYPE (allocator));\n \t allocator = NULL_TREE;\ndiff --git a/gcc/testsuite/c-c++-common/gomp/allocate-5.c b/gcc/testsuite/c-c++-common/gomp/allocate-5.c\nindex 2ca4786264f..09c8e4342f0 100644\n--- a/gcc/testsuite/c-c++-common/gomp/allocate-5.c\n+++ b/gcc/testsuite/c-c++-common/gomp/allocate-5.c\n@@ -40,7 +40,7 @@ bar ()\n #pragma omp allocate(a) foo(my_allocator) /* { dg-error \"expected 'allocator'\" } */\n /* { dg-error \"expected end of line before '\\\\(' token\" \"\" { target *-*-* } .-1 } */\n /* { dg-message \"sorry, unimplemented: '#pragma omp allocate' not yet supported\" \"\" { target c++ } .-2 } */\n-#pragma omp allocate(a2) allocator(b) /* { dg-error \"'allocator' clause allocator expression has type 'int' rather than 'omp_allocator_handle_t'\" \"todo: cp/semantics.c\" { xfail c++ } } */\n+#pragma omp allocate(a2) allocator(b) /* { dg-error \"'allocator' clause expression has type 'int' rather than 'omp_allocator_handle_t'\" \"todo: cp/semantics.c\" { xfail c++ } } */\n /* { dg-message \"sorry, unimplemented: '#pragma omp allocate' not yet supported\" \"\" { target c++ } .-1 } */\n }\n \n","prefixes":["02/12"]}