{"id":2232928,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2232928/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505103649.68361-3-alex.bennee@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260505103649.68361-3-alex.bennee@linaro.org>","list_archive_url":null,"date":"2026-05-05T10:36:46","name":"[2/5] accel/tcg: move jit thread manipulation into do_tb_phys_invalidate","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e282d781b3c14944123921a2d0cd2c4e07da0440","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/1.2/people/39532/?format=json","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260505103649.68361-3-alex.bennee@linaro.org/mbox/","series":[{"id":502809,"url":"http://patchwork.ozlabs.org/api/1.2/series/502809/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502809","date":"2026-05-05T10:36:48","name":"testing/next: macos updates","version":1,"mbox":"http://patchwork.ozlabs.org/series/502809/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232928/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232928/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Ekp2u3j2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8w2T0fbYz1y04\n\tfor ; Tue, 05 May 2026 20:37:53 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKD9Y-0001SE-HA; Tue, 05 May 2026 06:37:24 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKD99-0001KN-5N\n for qemu-devel@nongnu.org; Tue, 05 May 2026 06:37:00 -0400","from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wKD94-0007wJ-7w\n for qemu-devel@nongnu.org; Tue, 05 May 2026 06:36:58 -0400","by mail-wm1-x32b.google.com with SMTP id\n 5b1f17b1804b1-48a3e9862f0so34074015e9.1\n for ; Tue, 05 May 2026 03:36:53 -0700 (PDT)","from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a8eb3427fsm560770615e9.0.2026.05.05.03.36.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 05 May 2026 03:36:50 -0700 (PDT)","from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id CF4DE5F94B;\n Tue, 05 May 2026 11:36:49 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777977412; x=1778582212; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=NyZKew4HYVFYSLa3t/vamd7rM3LzAyISeCAdtoKuGXA=;\n b=Ekp2u3j2fLLQtCo5/Yjk3A4L7mqf/JPOurH3RPdkyhBbJWqJ2F1R7t9+gx4yFIpSxs\n eoPLxfVOlIaF6KM/d5ixCqB+lhZ0+7P748Of2Xwcreya+pQzAToxy3Rv3tXzRePlm+V8\n PKNcdGtz6qPdsdHJgxzBVig80wA0sUiHwVmhW8EvM3bEqHE9b35d5OrkvUej6sNUFZlP\n GTqwsBaNKYv4GG+YCutP77/OvuYU+4mlOM2pvrpRFuTkjonbfJh+52yUGxBuUlg2FJy3\n z7sTt7VPbdHBaRSEhsYaGOQcjW9cI10tri/Bn0XgXb4kp5WYWviitx6kj1aT7C9a2raK\n b1LA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777977412; x=1778582212;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=NyZKew4HYVFYSLa3t/vamd7rM3LzAyISeCAdtoKuGXA=;\n b=XqK4bkwHN7761ok64MWzuZqAVVbv78+ZpsqPpZNz/c17+v50iHCmAnYkSSTe+Tg/oE\n q+pH1PH6VJRs4rdt+Yiuyq6lVu16yUlRKqBf9MumI5UXxSwOxlezLny5BaXUyF29yMA4\n PWu022CIDagzmEAN5amAjzpyoxxQXowjuosQIWqT9hm/6wN/sLtkGIT0yU1x7kdvHEnu\n h4ul3PkJ3ULxes2tSu1tEmMDKKTqpLqZUlsosofec5xuoj4zTgiJjYCk5hTi1iyPZvCR\n Zp4O8PlnhUKUYnzHSNVUXmJ8ZYI67YZtn6mxhWxUyS4ktNSySp4TmZ3Nsh2zqxJon87X\n GODw==","X-Gm-Message-State":"AOJu0YyHrWyWq2L7UHQN829a++zF6un0CRtxKaRT3+AtxOUNdMfAlLZR\n dVk9FxBifmfiLFLvxJm4CZ1sFAJe6DAjS7PDyYEGRNfSSPqLGJA90z2VevEgVylituM=","X-Gm-Gg":"AeBDiev7eveRkykEejO4NyC0xi8cNn9iJCvvg2uhMkWPkrTTg8P0hgWc0hZrsYN9FOv\n 0gthoPfDIBwdN9nqidr/00tLypRERzSSQMwCpfcB0QDfk98R65kQC7fb7aPQX57IOOPzLkiYpEq\n +6xJjXreahk/uyppXluW4LbdYcqlJ7CuGFp9+8bcAW0iESL0LI8fg7OXiCHnL4z5A/ZJ24c1Zcu\n O8gcBAvdxiaooR/81TUrQTi6GswR24/n0fLfP0+x1T4b3HHGxel2o9Rcg3gp5Litc9dwLE8i0Z1\n LLbQqtd78XeQ3i74FgJ3WfgyzrsjbLX9cr8SxxLFFxMvP+Kkgw3DmmBIJo4ckxZm67NuvNZ8wV8\n vRxC3N6q1omKbTbcjOzaoAnXfunz41E+kSQRAh56K7yAS9274UQ/MlUmG5vrvXz7w53icMZ72oS\n kijGC1QRy6myHd4rFbnd6LvY4DXdVIRkgCMw==","X-Received":"by 2002:a05:600d:a:b0:489:1abb:5559 with SMTP id\n 5b1f17b1804b1-48d142331f5mr41076895e9.5.1777977412167;\n Tue, 05 May 2026 03:36:52 -0700 (PDT)","From":"=?utf-8?q?Alex_Benn=C3=A9e?= ","To":"qemu-devel@nongnu.org","Cc":"Thomas Huth , Thomas Huth ,\n Pierrick Bouvier , qemu-arm@nongnu.org,\n Peter Xu ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ,\n Pierrick Bouvier ,\n Brad Smith , Fabiano Rosas ,\n Kyle Evans ,\n =?utf-8?q?Alex_Benn=C3=A9e?= ,\n Peter Maydell ,\n Paolo Bonzini , Warner Losh ,\n Richard Henderson , =?utf-8?q?Philippe_Mathie?=\n\t=?utf-8?q?u-Daud=C3=A9?= ","Subject":"[PATCH 2/5] accel/tcg: move jit thread manipulation into\n do_tb_phys_invalidate","Date":"Tue, 5 May 2026 11:36:46 +0100","Message-ID":"<20260505103649.68361-3-alex.bennee@linaro.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260505103649.68361-1-alex.bennee@linaro.org>","References":"<20260505103649.68361-1-alex.bennee@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32b;\n envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"To invalidate a TB on MacOS we need to enable write access to the JIT\nbuffer. We were doing this for tb_phys_invalidate__locked but that is\nnot the only path into do_tb_phys_invalidate. Move the manipulation\ninto the shared function that does the work.\n\nThis enables watchpoints to work in MacOS TCG guests.\n\nResolves: https://gitlab.com/qemu-project/qemu/-/work_items/3444\nSigned-off-by: Alex Bennée \n---\n accel/tcg/tb-maint.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/accel/tcg/tb-maint.c b/accel/tcg/tb-maint.c\nindex cd7c32361bb..9a648f97865 100644\n--- a/accel/tcg/tb-maint.c\n+++ b/accel/tcg/tb-maint.c\n@@ -925,6 +925,7 @@ static void do_tb_phys_invalidate(TranslationBlock *tb, bool rm_from_page_list)\n uint32_t orig_cflags = tb_cflags(tb);\n \n assert_memory_lock();\n+ qemu_thread_jit_write();\n \n /* make sure no further incoming jumps will be chained to this TB */\n qemu_spin_lock(&tb->jmp_lock);\n@@ -954,15 +955,15 @@ static void do_tb_phys_invalidate(TranslationBlock *tb, bool rm_from_page_list)\n /* suppress any remaining jumps to this TB */\n tb_jmp_unlink(tb);\n \n+ qemu_thread_jit_execute();\n+\n qatomic_set(&tb_ctx.tb_phys_invalidate_count,\n tb_ctx.tb_phys_invalidate_count + 1);\n }\n \n static void tb_phys_invalidate__locked(TranslationBlock *tb)\n {\n- qemu_thread_jit_write();\n do_tb_phys_invalidate(tb, true);\n- qemu_thread_jit_execute();\n }\n \n /*\n","prefixes":["2/5"]}