{"id":2232915,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2232915/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260505100523.1922388-18-vladimir.oltean@nxp.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.2/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260505100523.1922388-18-vladimir.oltean@nxp.com>","list_archive_url":null,"date":"2026-05-05T10:05:09","name":"[v8,phy-next,17/31] usb: gadget: tegra-xudc: avoid direct dereference of phy->dev.of_node","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6d5103c16b91582f2d1a6f6f2377b5c4c906b02b","submitter":{"id":75582,"url":"http://patchwork.ozlabs.org/api/1.2/people/75582/?format=json","name":"Vladimir Oltean","email":"vladimir.oltean@nxp.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260505100523.1922388-18-vladimir.oltean@nxp.com/mbox/","series":[{"id":502803,"url":"http://patchwork.ozlabs.org/api/1.2/series/502803/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=502803","date":"2026-05-05T10:04:53","name":"Split Generic PHY consumer and provider API","version":8,"mbox":"http://patchwork.ozlabs.org/series/502803/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232915/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232915/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256\n header.s=selector1 header.b=UcyW/2TH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-gpio+bounces-36158-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com\n header.b=\"UcyW/2TH\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.72.37","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=nxp.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=nxp.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nxp.com;"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8vsd3g7Dz1yK2\n\tfor ; Tue, 05 May 2026 20:30:13 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 09E6131CA619\n\tfor ; Tue, 5 May 2026 10:14:14 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id ECF2A42B74B;\n\tTue, 5 May 2026 10:06:27 +0000 (UTC)","from AM0PR02CU008.outbound.protection.outlook.com\n (mail-westeuropeazon11013037.outbound.protection.outlook.com [52.101.72.37])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F42B425CE1;\n\tTue, 5 May 2026 10:06:24 +0000 (UTC)","from AM9PR04MB8585.eurprd04.prod.outlook.com (2603:10a6:20b:438::13)\n by DB9PR04MB8363.eurprd04.prod.outlook.com (2603:10a6:10:24b::11) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.26; Tue, 5 May\n 2026 10:06:13 +0000","from AM9PR04MB8585.eurprd04.prod.outlook.com\n ([fe80::f010:fca8:7ef:62f4]) by AM9PR04MB8585.eurprd04.prod.outlook.com\n ([fe80::f010:fca8:7ef:62f4%4]) with mapi id 15.20.9870.023; Tue, 5 May 2026\n 10:06:13 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777975587; cv=fail;\n b=ikJyoVFJqwYsvhLletXKvhAEmjXD5LIv6PjkTZOKXt2fx7SlZkwEBY4VYuKQIsTVZG6Nxo41DbImgjDo9zHW2aBVIGoa3Ltupbea4x2saqLiVjZTWZYmqZmm0QsSqUudxqCWsq5zhpVseXOrXZyKGs3gnum7qPXPgERqWZZXq/I=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=f5d9SVnTONC0Qk5yDsJZbiXHf2d7mXGDQz2B7iaq5gIN7dUKicPNUuZMfaftrg4tFpDR6fKNnt36HdkyT+ZZhRQgYy/nralJ/k3gEhPR/HsfHrXfeF6RGYvyHzidCcc+bFqu91QMpXIjzaSh17l1j4W5wA8zXfdKoQwdlfj96FCKQXQVs+OeAAkok7P9whFnrcUBRtmgrnBdkGzuSsVQdHPuY60SAyxLd1x2cDNkwFW7cpJXWm5cUN0CHdTA0ktnZvinOQNw/Wyt7KamzaHPVI5sGs9ojykiDCjqRneHP/0ZalVi0t8kdhgF6H7aCGl6UJ9IDiyRlDAqofzmK8P7ig=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777975587; c=relaxed/simple;\n\tbh=YzA8mfijQ2A21QlziYuh4n8NM8/eDcjGDSWH0mvQx/E=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=gUNyDdT2cH+YGJ+IiGB94gKm0ql5R7r4B28Lg5GtyEbBcaK0UP+UOJwx3Og4pTF6CAekkhVvFA57QVsNPCffoaQgV63s/qEP++vPos/ddH9KnRWy1TBdTaVHar7c+DN81wSS5mCOWGwd6nF7r3wVMHemADOBoCN/BCZ6XRHle/Y=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=NDybnB3UNtSjaXyKFcIZ/N44VcjPS1MoxizI85eNGkQ=;\n b=jU69uJWSEuQVt5lqHVb90Wc0GID/41HsAr7JB3IfNV4Sto5cK/xe16SzSGcidm81vHi17+KS32P4lV+r6HHQuAJgR89OpFObjn15JwUoftXAB2HUjLdy6UX1X83xkpdvLmyCLBxkx0Xx1S5txiYvMuSBN53GnaGvVdiVfiHTmQQcCFjRx0nACIraoKgLh+fYZNWYmsgaH+n2zhHRm+kvnpavnsOcP/2tt+KL43v2HfiKw4vYCd+fTTHIU9lO+USQ9KwdhmDtPC4pu/kfN5NyWAC89BUj/4g4UY3qD6vhIV3fVxvZJHiYBEV8ZM9ae0wPaYwKDE4+DhvHlkqyiwUIBw=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=nxp.com;\n spf=pass smtp.mailfrom=nxp.com;\n dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com\n header.b=UcyW/2TH; arc=fail smtp.client-ip=52.101.72.37","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=NDybnB3UNtSjaXyKFcIZ/N44VcjPS1MoxizI85eNGkQ=;\n b=UcyW/2TH7SIJ3eYeGCxzkkM0I7k6lK38WS9M1C40A7v2vigaEoHT+p/iBJ/NgQwnwS218ulwaNlWss11yGcyeEfHEmpKMJWS1OogT6eukS0P/J8Tj3AKjg5WGm7ODMW0sNbOc+szpn1j0RNdAPHwoC2uE1jiyDPHMx3Btitoh+lg7tqDlA+uqAbv0Ljlj30xZ2zcU2PQAPL53sJ9MJzXVtJ7jji4GJEcLUbYuT6hSByXuxBf9azJOo41dl0+uwug9HjCzl7+W7qlOQ2NC3F1oI4Wrx2DtjhiHKIR74lnwTQu4IKr5jzCv2meIqiJLVUaiBgTBa4qvLD2y2Hz/U5lRQ==","From":"Vladimir Oltean ","To":"linux-phy@lists.infradead.org","Cc":"Vinod Koul ,\n\tNeil Armstrong ,\n\tdri-devel@lists.freedesktop.org,\n\tfreedreno@lists.freedesktop.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-arm-msm@vger.kernel.org,\n\tlinux-can@vger.kernel.org,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-ide@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tlinux-media@vger.kernel.org,\n\tlinux-pci@vger.kernel.org,\n\tlinux-renesas-soc@vger.kernel.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-rockchip@lists.infradead.org,\n\tlinux-samsung-soc@vger.kernel.org,\n\tlinux-scsi@vger.kernel.org,\n\tlinux-sunxi@lists.linux.dev,\n\tlinux-tegra@vger.kernel.org,\n\tlinux-usb@vger.kernel.org,\n\tnetdev@vger.kernel.org,\n\tspacemit@lists.linux.dev,\n\tUNGLinuxDriver@microchip.com,\n\tGreg Kroah-Hartman ,\n\tJC Kuo ,\n\tJohan Hovold ,\n\tJonathan Hunter ,\n\tMathias Nyman ,\n\tThierry Reding ","Subject":"[PATCH v8 phy-next 17/31] usb: gadget: tegra-xudc: avoid direct\n dereference of phy->dev.of_node","Date":"Tue, 5 May 2026 13:05:09 +0300","Message-Id":"<20260505100523.1922388-18-vladimir.oltean@nxp.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260505100523.1922388-1-vladimir.oltean@nxp.com>","References":"<20260505100523.1922388-1-vladimir.oltean@nxp.com>","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-ClientProxiedBy":"FR4P281CA0018.DEUP281.PROD.OUTLOOK.COM\n (2603:10a6:d10:c9::10) To AM9PR04MB8585.eurprd04.prod.outlook.com\n (2603:10a6:20b:438::13)","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AM9PR04MB8585:EE_|DB9PR04MB8363:EE_","X-MS-Office365-Filtering-Correlation-Id":"5e8003b9-860f-4f21-8db8-08deaa8df066","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|376014|1800799024|19092799006|7416014|366016|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n\t+43zuyaWtPW7n9G02XNQ8SeWPaM6OkchNGuE3B4VBZ1FxHr/n1wvNmr5aIkd9J5R8gnayR+ZHlk0+DymxVjQ+vKOn3CcgUaWocRq0A/iqqeQ93A3QE7IHTbiYsTwF+gyVrpt/jNH1YvQ9wqsivPXvHr1B0veWT48nuozIEE4CN79iL1n3uvyOWyPn1CYhDXH1UCX0kaI8rneg2WpYQs0HFTTSsQGTex5hQ+6axU8rMSexdw8AkGoSRRn5p23jFjTxQObqoRPnnSYEUXNdm0ugpOgW1Jfm3sQxSOBncHAfjE0qJDAX53S7TmyAKF7ZG028z1MAoAL+5CUNu2C/+H9EaSLfmyQa9CEcv+XrXBblYNbzMcsPC58vav4beXOQhkXqHjbDmzlNft9hjx7QIzXgAuM05X/YXxUuIILaYkEBnkIvSxZWLeQ+MpF2F7SclfSII3s3vFBMCh08BmssicsrTv8Z4+eEvypgvknCMkVrZAmehEtZ9iC7buzuW4vVcaPqPiV3oYmN1/SX7Y0KeEJ5rju0xUgVyTuhLxtGWhI7CDJ6D1/D0VUS2atYCa0MeeoTslhEugNwO+VEaXrxbu+1Xy/yX9DJiL9efnkHilhqMqNTuhbJ6icgpx9WHLyNB4ULxqIypLG0aDOoxc/xCwoGx29HQiy8d5HDeLLj4SjXrTBtmkZKajJ0xnyULo9MyFU","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB8585.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(19092799006)(7416014)(366016)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n jVz6d8aTwnL3r+AoxBV3pYRGlJMFQE7CnvIjbAYmO4LHOadyk62C6fCFfcr/k2V7CAg4Zmr/S1StEUoHf/MAWhj3JQo9OS49s/ovFxnfK+Cu//UAAMYdI3xwxLRA+GWKoCpyNU+j5SO9KSzS1ee5Txr08gwlTcGmspz/BgFkfIExxsRBujnj/mS3tH0AcMbH6s5KNgjrNKrkJJRQvbiosGXBQIecbL3TmFC7+KWKKKQ2me/xPAJLukMO/vjYDjAxcqtnnLau82lQPV3avIl2h0VC4yoPg96PcCbpjid41j7vcioHkb5oLy5AFI7+rniG0fBnkRNJcvQsWGH8G0mnH+IjqLUcAZkca5DOJaDHB7sOxKUbVoU+SLBKbz0yfxh4wdMYnOByhlsEGEjzJA4+V0KY4o1U04svMalOaCnxt45TUO8+HTQ8B1hNuKYGatpFnemNP4RT5E6Zgc1maqCblT9FkpbTtOVlK490+VLCmXs2v3z/YPHrQLxxPaW7ThGbBmekSW0dGcS2WrD63C0N3K1yWxstXbtqaQ0gj2Mj+KocfiGB0U3QQLcVME3x/2nTyDgdPmka3VXIjUeW7zolSP0krFVQn2gbUjMHhYJZKjkcld39myXmaUk+1zseeJLVe2qOAno8sD6gdRtGStBoUvQHayFfPpmAIuQJHBrI7MUivvxPPQL4F9uDVQ4X66UbuUV0o/Pv9yunvBt7wNbgKeVcR2Nrs01LmbwiocU3s3Cz6yS2pl5Xt4o5kuZznZ+ID2qtHtH6MDrBvwkzaiS4I76DBigDraeLINwmpK95lczjXJr5X8uUGyDIPAkpgmF0BVXkLEiSpOITghnI7FCX/lSHOLCqxc901+mRE2TioRlfibVOuichgowh/tLQgCiwKle7eKSIoW+GcQ1qVB1FIeFMUK9WeCXIWgAJ/RuxYwofivUbbfTkBLQ6FbPvxLtsKJuOdpwXz1vRljWy4RfjVcfaNtMnSEkcAJ4IdRUj0cv+D1RUB2X3bpB6D4BoErrk52zlSCUPnu7eP1g9uV3e6+uW1OAnWw8H4zQRijpRGG7P5oRJw0Mg3YsmBknvRAVxFQ2HVCgBItAIFLdRaavZ3eoSs67CNqKELv388P4B1GN+geHdT187JQNkAkxGGVTiGexCGOgXDMuqAMFFTh+aX0fGrJYBZMpKgyzcFi65bUOBNut96PVOo/4pkeGaXBWi/dz6cY3zaHDphlb3suKo2wxO9jX5K0hahvPudPaulk1gVtXahv6fWsUz4f3e5f1P6qBmAdEo6R+7KF9OaP2/10iwQcH2UY4RPGcLT3boPLIIfYF8zUT27kMOpDQBKeSuWZYoI6+Gt8SDm8XmtcvQ8+yMg5Bvzsw5FQpO89HtYb6G4jhjR8qFQ1jx+c5WK4dg0eXNPCMeF2HoYpJLXpIoAfVMTd1GzJpPJo8Tx3Gb+FHV/ldlv+KNcxIk6bmc3GG4aLaKLXYdiyceA37wbk6rSeYxfhQ8++8dBX2+EZ8A3m5Pfh1yGRIvlVsOmGfDMnziNB4G4dyLRpRZTzQKQdZwMf78UeZDyJ9ZO/I3M/ON5lw6XujVoBbbbX+3EjEfvg9F8jpUWs5H8koZ/zE+Om9MDvKzIRMBwfJ/L+uFWPO2eHL1t/xQpWPCBEW+Yni2ZmQzR6qGFbMWfU6WZAIqIt/Own4EvJm4hx2Mo6bX2SdpxJKcFSlNnM3gLfsMCQGc5qlZAhxHvsByun8rMyzG+zCgLg==","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 5e8003b9-860f-4f21-8db8-08deaa8df066","X-MS-Exchange-CrossTenant-AuthSource":"AM9PR04MB8585.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"05 May 2026 10:06:13.5888\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n Q08+RyOZNT3PkBbB/ySI9fKoKcPt+mIkDhUJ8xAoCnJbmDIw8r7uAZgmXbpkb28giwoK4CB0CrQt+jK/bc2YxA==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DB9PR04MB8363"},"content":"In a somewhat similar situation as the Tegra USB host controller driver,\nthe Tegra XUDC driver for USB gadget mode needs to get to a struct\nusb_phy that sits behind the same OF node as the Generic PHY. It does\nthat directly, which will no longer be possible. The PHY provider is\nalso the xusb padctl driver.\n\nThe rework here is also to implement a parallel OF node lookup path\nbased on the \"phys\" phandle and the #phy-cells of the padctl provider.\n\nSome further notes:\n- create a local \"usbphy\" variable to hold the devm_usb_get_phy_by_node()\n output. This makes the error checks more obvious (avoids keeping an\n error-encoded pointer in xudc->usbphy[i] even temporarily).\n- the \"if (IS_ERR(utmi_phy)) .. else if (utmi_phy) .. else if (!utmi_phy)\"\n pattern can be simplified, considering that neither the IS_ERR() nor\n the NULL case continue execution in the current block. Therefore, we\n can move the case where the \"utmi_phy\" is a valid pointer outside the\n \"if\" checks, and this reduces the code indentation level.\n\nSigned-off-by: Vladimir Oltean \n---\nCc: Greg Kroah-Hartman \nCc: JC Kuo \nCc: Johan Hovold \nCc: Jonathan Hunter \nCc: Mathias Nyman \nCc: Thierry Reding \n\nv7->v8:\n- remove duplicated variable \"err\" which shadows existing one\n- stop execution on of_property_match_string() and\n of_parse_phandle_with_args() errors, instead of silently continuing\nv5->v7: none\nv4->v5: patch is new\n---\n drivers/usb/gadget/udc/tegra-xudc.c | 43 +++++++++++++++++++++--------\n 1 file changed, 32 insertions(+), 11 deletions(-)","diff":"diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c\nindex e9d33be02866..f93e0a5651ab 100644\n--- a/drivers/usb/gadget/udc/tegra-xudc.c\n+++ b/drivers/usb/gadget/udc/tegra-xudc.c\n@@ -3494,6 +3494,7 @@ static void tegra_xudc_device_params_init(struct tegra_xudc *xudc)\n \n static int tegra_xudc_phy_get(struct tegra_xudc *xudc)\n {\n+\tstruct device_node *np = dev_of_node(xudc->dev);\n \tint err = 0, usb3_companion_port;\n \tunsigned int i, j;\n \n@@ -3515,7 +3516,10 @@ static int tegra_xudc_phy_get(struct tegra_xudc *xudc)\n \txudc->vbus_nb.notifier_call = tegra_xudc_vbus_notify;\n \n \tfor (i = 0; i < xudc->soc->num_phys; i++) {\n+\t\tstruct of_phandle_args args;\n \t\tchar phy_name[] = \"usb.-.\";\n+\t\tstruct usb_phy *usbphy;\n+\t\tint index;\n \n \t\t/* Get USB2 phy */\n \t\tsnprintf(phy_name, sizeof(phy_name), \"usb2-%d\", i);\n@@ -3525,22 +3529,39 @@ static int tegra_xudc_phy_get(struct tegra_xudc *xudc)\n \t\t\tdev_err_probe(xudc->dev, err,\n \t\t\t\t\"failed to get PHY for phy-name usb2-%d\\n\", i);\n \t\t\tgoto clean_up;\n-\t\t} else if (xudc->utmi_phy[i]) {\n-\t\t\t/* Get usb-phy, if utmi phy is available */\n-\t\t\txudc->usbphy[i] = devm_usb_get_phy_by_node(xudc->dev,\n-\t\t\t\t\t\txudc->utmi_phy[i]->dev.of_node,\n-\t\t\t\t\t\tNULL);\n-\t\t\tif (IS_ERR(xudc->usbphy[i])) {\n-\t\t\t\terr = PTR_ERR(xudc->usbphy[i]);\n-\t\t\t\tdev_err_probe(xudc->dev, err,\n-\t\t\t\t\t \"failed to get usbphy-%d\\n\", i);\n-\t\t\t\tgoto clean_up;\n-\t\t\t}\n \t\t} else if (!xudc->utmi_phy[i]) {\n \t\t\t/* if utmi phy is not available, ignore USB3 phy get */\n \t\t\tcontinue;\n \t\t}\n \n+\t\tindex = of_property_match_string(np, \"phy-names\", phy_name);\n+\t\tif (index < 0) {\n+\t\t\tdev_err(xudc->dev,\n+\t\t\t\t\"no \\\"phy-names\\\" entry for \\\"%s\\\": %pe\\n\",\n+\t\t\t\tphy_name, ERR_PTR(index));\n+\t\t\tgoto clean_up;\n+\t\t}\n+\n+\t\terr = of_parse_phandle_with_args(np, \"phys\", \"#phy-cells\",\n+\t\t\t\t\t\t index, &args);\n+\t\tif (err) {\n+\t\t\tdev_err(xudc->dev,\n+\t\t\t\t\"failed to follow \\\"%s\\\" reference\\n: %pe\\n\",\n+\t\t\t\tphy_name, ERR_PTR(err));\n+\t\t\tgoto clean_up;\n+\t\t}\n+\n+\t\t/* Get usb-phy, if utmi phy is available */\n+\t\tusbphy = devm_usb_get_phy_by_node(xudc->dev, args.np, NULL);\n+\t\tof_node_put(args.np);\n+\t\tif (IS_ERR(usbphy)) {\n+\t\t\terr = PTR_ERR(usbphy);\n+\t\t\tdev_err_probe(xudc->dev, err,\n+\t\t\t\t \"failed to get usbphy-%d\\n\", i);\n+\t\t\tgoto clean_up;\n+\t\t}\n+\t\txudc->usbphy[i] = usbphy;\n+\n \t\t/* Get USB3 phy */\n \t\tusb3_companion_port = tegra_xusb_padctl_get_usb3_companion(xudc->padctl, i);\n \t\tif (usb3_companion_port < 0)\n","prefixes":["v8","phy-next","17/31"]}