{"id":2232811,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2232811/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260505100523.1922388-2-vladimir.oltean@nxp.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.2/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260505100523.1922388-2-vladimir.oltean@nxp.com>","list_archive_url":null,"date":"2026-05-05T10:04:53","name":"[v8,phy-next,01/31] PCI: cadence: Preserve all error codes in cdns_plat_pcie_probe()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"727210167377be0842ae3d608428dbbfe5e5ef32","submitter":{"id":75582,"url":"http://patchwork.ozlabs.org/api/1.2/people/75582/?format=json","name":"Vladimir Oltean","email":"vladimir.oltean@nxp.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260505100523.1922388-2-vladimir.oltean@nxp.com/mbox/","series":[{"id":502805,"url":"http://patchwork.ozlabs.org/api/1.2/series/502805/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=502805","date":"2026-05-05T10:04:53","name":"Split Generic PHY consumer and provider API","version":8,"mbox":"http://patchwork.ozlabs.org/series/502805/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232811/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232811/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256\n header.s=selector1 header.b=BiDZx0Qh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-53712-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com\n header.b=\"BiDZx0Qh\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.83.59","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=nxp.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=nxp.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nxp.com;"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8vSj30bRz1yK2\n\tfor ; Tue, 05 May 2026 20:12:05 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 835BD30A3BB8\n\tfor ; Tue, 5 May 2026 10:06:15 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4C2F533D511;\n\tTue, 5 May 2026 10:05:41 +0000 (UTC)","from GVXPR05CU001.outbound.protection.outlook.com\n (mail-swedencentralazon11013059.outbound.protection.outlook.com\n [52.101.83.59])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 668003368BE;\n\tTue, 5 May 2026 10:05:39 +0000 (UTC)","from AM9PR04MB8585.eurprd04.prod.outlook.com (2603:10a6:20b:438::13)\n by PA1PR04MB11083.eurprd04.prod.outlook.com (2603:10a6:102:484::20) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.25; Tue, 5 May\n 2026 10:05:33 +0000","from AM9PR04MB8585.eurprd04.prod.outlook.com\n ([fe80::f010:fca8:7ef:62f4]) by AM9PR04MB8585.eurprd04.prod.outlook.com\n ([fe80::f010:fca8:7ef:62f4%4]) with mapi id 15.20.9870.023; Tue, 5 May 2026\n 10:05:33 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777975541; cv=fail;\n b=Ov5Fj4WuGCQbcIo/4TTreH/8KSE91Gv8bQyQAdK+4KprrZOaUQ6f0HgVE9Se431gZz3zsw4fO08eOy5kARQmP110NPtcvTWjn5Oat4zd2mSmOH5zx3toIRmy5w+0D3ww/0JIg1qD1HkQyIVi4Kmbprwce94K3HbN5eQSAQOSPgI=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=Yjaj4QIImRPS+jmYPy115uiJoy0IwI9AosQSvi+2pA4eMrS2sw2sKgsInzsZZ+Y0WHW9PdJrntxHQEpmpa8ptb86KbmU3LuLjJxReG0H6Ft1nKR2OXE3uVDA9T/XbVwfJR9olz6ncpX6FKHizh9kRoI/Yt15QhyjX/AIJOAazuPEbDXkBqbpjHZZ2HJRJ0HsjvZdD7149XZmqn43TGJZEfJAl9RML9xmKw3RLdPcdqIlB51C/poIvVW4PzVNEkP7UrZIi9UP/0q5zc6963f5W5DugV+jpnEp1XBEYU3+hrF2cw3Qn//5Te5eNtb2jjCpmLGFcs+WuikV8z+7PqXXow=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777975541; c=relaxed/simple;\n\tbh=52WfOApgZhgq4vYqoLAu19NyYZC18d/0hAWXaH14FtM=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=VbgvcDQnjjXr0RzldR8wUldixlLP8ixiV+mnOPixhdgWhz2OjU8lcU9W0U2Rla/7OMqYv1GxRcV/jBFP9Lk2C4nDjRG9xTSd/AUNjh+vOksEozzi2s82J0/KgPNIOaqmXohv38m12Whtmg9C72nc4YS0eXNl5S5E6PcAnZt4/Gs=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=fgvdQDNjHvv/zsrLcjoCqZz5W4uogTGw4FSj0SzBEkY=;\n b=v88fmhrtW149Wx0IAJJB0BgC4eu1UyrjoIKK6oavX4RzfNASrBcksYmEk1NkkJ+lbPtIVfF6Jnpe69LftBFJN3rX2wfVgkDucHkoueva1z5Kr2JRQaKGdRpPPwCNrkRhUOY6ME/I+5/KNxQ+d4gwdYRJTtSelVM5sIu7q7VuSE5Dup9ca1uxcrW7zdSsBbQM9sXwqQxVeprcI7IrkBVQdzzfEqbRjVVS8EDsxTClFFRw83bBwcsKmNPc5mOKilyYqKasaOaMTS+6Miu18qnlutJssjlnz7nO1sRlX+MT86uWfjpYREjdjfx6IIPoDjRjDI+PkWMYXFZNUlVvTYUsPg=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=nxp.com;\n spf=pass smtp.mailfrom=nxp.com;\n dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com\n header.b=BiDZx0Qh; arc=fail smtp.client-ip=52.101.83.59","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=fgvdQDNjHvv/zsrLcjoCqZz5W4uogTGw4FSj0SzBEkY=;\n b=BiDZx0QhBm+caMA4ybmL8pGn74os8MS2h0l3VgrZg2o63HmovDa5bz551wx4bfCT+Th/hJsNyKE/wPZaM6KY+YjiudhWH4mC9cztibPg1y18F9LTwbX/BOqa7f0yAyjiZK77FKUc0CO9JZdij/iqK6ndBflPFhqCDa85XeR3XISil5bGVwqb6sVaCh1MagiKXpR0wthCnEW8H4dH/mX2FL7cL6TedHASfcIoU0QI5Y633xDGX9dtUCGOvQh3WRsLss7Y2LM/bqaoUXQ2m2JltWeIggvN2JIzwUfdki/ZOhU4gHeesHfJ80vhYNYhQ5h21cU6BoTcr6X6sgV0URDjEw==","From":"Vladimir Oltean ","To":"linux-phy@lists.infradead.org","Cc":"Vinod Koul , Neil Armstrong ,\n dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,\n linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org,\n linux-can@vger.kernel.org, linux-gpio@vger.kernel.org,\n linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-media@vger.kernel.org, linux-pci@vger.kernel.org,\n linux-renesas-soc@vger.kernel.org, linux-riscv@lists.infradead.org,\n linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org,\n linux-scsi@vger.kernel.org, linux-sunxi@lists.linux.dev,\n linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org,\n netdev@vger.kernel.org, spacemit@lists.linux.dev,\n UNGLinuxDriver@microchip.com, Bjorn Helgaas ,\n\t=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ,\n Lorenzo Pieralisi ,\n Manikandan K Pillai ,\n Manivannan Sadhasivam , Rob Herring ","Subject":"[PATCH v8 phy-next 01/31] PCI: cadence: Preserve all error codes in\n cdns_plat_pcie_probe()","Date":"Tue, 5 May 2026 13:04:53 +0300","Message-Id":"<20260505100523.1922388-2-vladimir.oltean@nxp.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260505100523.1922388-1-vladimir.oltean@nxp.com>","References":"<20260505100523.1922388-1-vladimir.oltean@nxp.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-ClientProxiedBy":"AS4P189CA0054.EURP189.PROD.OUTLOOK.COM\n (2603:10a6:20b:659::18) To AM9PR04MB8585.eurprd04.prod.outlook.com\n (2603:10a6:20b:438::13)","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AM9PR04MB8585:EE_|PA1PR04MB11083:EE_","X-MS-Office365-Filtering-Correlation-Id":"450bf4aa-a2a4-4339-4d3b-08deaa8dd88b","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|376014|1800799024|19092799006|366016|7416014|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n\t105wNgbdpicT4f2b89LnMCTcdnd1q3oavkS1xKQO9VaEZzAi2cRP5Q9ftUvmmoJhebuOnPsLvS/m0j/zblucoE1bq+tZGWU3X0u/gqm9nzrUD/GEdtykY45GxR2x+qtk4H6J4BIusB4BgA9esr1z+nwqCdooL1VHCe1uL0nFldcTURUpt3yHXIQ5B9Rj4nqpiP/1xY3GMb8XeBfkg/gBNhqkbNDhFZkBxpQgM1KzIFBhfWyOMqkeHGHGu541mN7z/ZNszkvqgR64o+a1czK782ld8qO4S2qWznt1S6WGKxjgcPZIc51Z7ftQojPvfTlFQyBk1um3M8W6+lmw/bSEd4UPNz12dwkOOmZgenuxMu+6bMZbbNYgOjYRoigo04D2A4yog73uCa7qnmnhd5GEQUMxul5ePtGCBvreldRdF/dvydGWJ73ljQyTVPfA4b35FLjeSZbvIoffeuCDOmz/rbKYa7l3H0sZoO9Y5p9xPpRDxK4UYPUR+z+VyyZEm1YGb0npn1Hd6V/dLQjoPRzL4M6XD0/7xRnai+RQs1JJHZhlVse0eyGpPqSPPZddEKzH5bPQ4lvDIQHdnCp6jt5S2iDJQ5cSvAfoAF4cDak4rq051dOhNsW7Cpi2TEoEC19m3k5JqZLCmhEZ64S9J3CCkg==","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB8585.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(19092799006)(366016)(7416014)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?lHVnwVGbzYZJvp5qB9NzLHGK8+0l?=\n\t=?utf-8?q?+10Vkj+2IDjUCJcKJOY3tMmGbaq91bN2K1SAExyZr3lfBmZvmUNKzJIC+TWI3eAGU?=\n\t=?utf-8?q?yDHflBp4BJ+IcNNWidlG2eERo0TL5sWmcHwElHUtQtxd40T6w9T/khnYOT6VV5a9K?=\n\t=?utf-8?q?rsWTafjrgG2mJ0K09X/rdL/quN4BByHfbJ7+Z31XtEkOVYxEgzcL30FcYyGDcXemz?=\n\t=?utf-8?q?yrTtrBEn86ntez3dhrGluGbEkoYSC99qkOlmyHOyxItc1k/el++WiMHrdGl6mpEfT?=\n\t=?utf-8?q?NjATr4WM1x5nt1P+a2XyBSYUd0JxmJjykcmaZrCefJdMc9gGmFvsTe1fUSJqxxs7Q?=\n\t=?utf-8?q?gnW5NReI9XYUn/9HO6wVmvRBRS/DW1aPEsvo5Z84a2U+dgMIZm55wB69JQ261o4cT?=\n\t=?utf-8?q?YRuRERa3wZ1hU4YXeY6gw5Rm2jismUsPrCp/jCjXK5HP+T8MzZPmrQYY1nqb29o2C?=\n\t=?utf-8?q?KVFxJ+h/uYtJ/qilMTLHnTHQrGZzR9rvBHTaap8gEFfhJWb5Esd3kGQBXhnAUymDD?=\n\t=?utf-8?q?eF1JdbQTC7GTRa7ZL/P2ARbiN4sT4d4Uo72aFwiAfJZqnAYoIGyps7kvana18Vjxa?=\n\t=?utf-8?q?7TgKgVydpXC/E6tzIOgOuXBy9SdF34CV/CpZkwn1G8Vq4KI7KDhkiPB3nakUV0pWX?=\n\t=?utf-8?q?GvctYIRBCl2Ohsdp54GWOx77pvGaE0ys6LmlS0jYKswDV1TIQjP+GPLL93qoo0Ut0?=\n\t=?utf-8?q?NoInT35xsNcTnzR3LiD7V9ZKTl7/QkfP9rklw9TyktG5Fcctu6TPpBfBRmqshqFHu?=\n\t=?utf-8?q?PmO/5Uq1NzHZMZ+SfNn3Js6NRRBNGyuvOAdVWEtOyMdLiwtOXBdq7Gvg3BK2uLejQ?=\n\t=?utf-8?q?/8dNSuf6bh5So4ILxTU5gpd2ICgxVnMffIP5fWH5iCOFp5n+mGT7UiKHsI33G3Sz7?=\n\t=?utf-8?q?P/E0LAiONJ1shDvErgxINOtpxynEUGn12PsQh8KGuF0hvz05M98nuhtOdYpzAlonS?=\n\t=?utf-8?q?bBayLwYS/MzWGYOKFd9QldOQYpYI/QfGe7UA6Z9V1dm6IIH3eGNhnOtbDXKU1FsCb?=\n\t=?utf-8?q?Iog9geNsoreNYcJIt+9VC3CmBIriehJaOWhu6QaV+qs21deScstyiNijBkPzES0yj?=\n\t=?utf-8?q?vEa8D5EMqid2+a2mcVb10E5e//hqBsA0Ob+/PwNis0WXfsdfHvZ/H2nFWh67MQ6Ro?=\n\t=?utf-8?q?GQk+IDl7O0edzFSIThBCFqpvqh1P8V/ON16N6v9gQLfsEdQVGilL0I6v1x5SOoetk?=\n\t=?utf-8?q?ZyFCTL85bjC09+Sz7l0Uh4agXq7SaSRjQ8+VdlcER2QRfGjDAse9ht7Zl3NsGloJ2?=\n\t=?utf-8?q?OOKGKsMRfOV7QjSgla+Z2reRnoARN5yI34OK/e+ANhzUwT6exP1o2zlM6TIy66O0c?=\n\t=?utf-8?q?Va95dC0yxHy2+FYVgnH1PbUHTE5xm39ZNsvChna8ETQNZoOImS5+O4OIC8RJ2Up8t?=\n\t=?utf-8?q?ao4aa5j3dwFG1JFHrA6EyZJElDo+as0FPP0ulYCFLQVA1IDKVsgYVTgRWq2S23mkK?=\n\t=?utf-8?q?44pjg6CsKzW4ciA/AvjiI0AL7W4BGRCGcCQRcI4doAJb2ncEepM6gydRQbaZylGV4?=\n\t=?utf-8?q?loPLdcE1BkJocdwFvhPJCBP+9XVg/5PIckLYuL44ujNeKx4NXa8L65SCaFiOx1w8Z?=\n\t=?utf-8?q?TJsBMP+Ap2s+2pDaLhxQcgJ/3x2FX7P3XYU/X6hvc+4KfLbRqwmEnpdcYRPkyzNvP?=\n\t=?utf-8?q?ZkaBfvTD1FXbZoyFrQ5wzi+8uMmLCe3g=3D=3D?=","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 450bf4aa-a2a4-4339-4d3b-08deaa8dd88b","X-MS-Exchange-CrossTenant-AuthSource":"AM9PR04MB8585.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"05 May 2026 10:05:33.5661\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n O7I834rn8G2VHkN2OXvP0Zt86b/FZ12h8ktzk+GjOyLVyl5+rBES8wnBDLiT3tpYQOyM99O4pGAtLBy6qUsqkA==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PA1PR04MB11083"},"content":"The blamed commit functionally changed the error path of\ncdns_pcie_host_probe(), now cdns_plat_pcie_probe().\n\nWhen the old code path executed \"goto err_get_sync\", the PCIe controller\nprobe function propagated the pm_runtime_get_sync() error code. The new\ncode doesn't, and returns 0.\n\nSimilarly for the \"goto err_init\" previously triggered by\ncdns_pcie_host_init() errors, and now triggered by\ncdns_pcie_host_setup() and cdns_pcie_ep_setup() errors. These are not\npropagated and will result in probing success, which is incorrect.\n\nFixes: bd22885aa188 (\"PCI: cadence: Refactor driver to use as a core library\")\nSigned-off-by: Vladimir Oltean \n---\nCc: Bjorn Helgaas \nCc: \"Krzysztof Wilczyński\" \nCc: Lorenzo Pieralisi \nCc: Manikandan K Pillai \nCc: Manivannan Sadhasivam \nCc: Rob Herring \n\nv7->v8: patch is new, issue was flagged by Sashiko\nhttps://sashiko.dev/#/patchset/20260430110652.558622-1-vladimir.oltean@nxp.com\n---\n drivers/pci/controller/cadence/pcie-cadence-plat.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/pci/controller/cadence/pcie-cadence-plat.c b/drivers/pci/controller/cadence/pcie-cadence-plat.c\nindex b067a3296dd3..8b12a46b5601 100644\n--- a/drivers/pci/controller/cadence/pcie-cadence-plat.c\n+++ b/drivers/pci/controller/cadence/pcie-cadence-plat.c\n@@ -126,7 +126,7 @@ static int cdns_plat_pcie_probe(struct platform_device *pdev)\n \twhile (phy_count--)\n \t\tdevice_link_del(cdns_plat_pcie->pcie->link[phy_count]);\n \n-\treturn 0;\n+\treturn ret;\n }\n \n static void cdns_plat_pcie_shutdown(struct platform_device *pdev)\n","prefixes":["v8","phy-next","01/31"]}