{"id":2232254,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2232254/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20260504041108.88774-2-matthew.ruffell@canonical.com/","project":{"id":15,"url":"http://patchwork.ozlabs.org/api/1.2/projects/15/?format=json","name":"Ubuntu Kernel","link_name":"ubuntu-kernel","list_id":"kernel-team.lists.ubuntu.com","list_email":"kernel-team@lists.ubuntu.com","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260504041108.88774-2-matthew.ruffell@canonical.com>","list_archive_url":null,"date":"2026-05-04T04:10:56","name":"[SRU,J,1/3] SUNRPC: Check if the xprt is connected before handling sysfs reads","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"168ce981a6cf557e72a3b47f58bf775d252b0874","submitter":{"id":76884,"url":"http://patchwork.ozlabs.org/api/1.2/people/76884/?format=json","name":"Matthew Ruffell","email":"matthew.ruffell@canonical.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20260504041108.88774-2-matthew.ruffell@canonical.com/mbox/","series":[{"id":502608,"url":"http://patchwork.ozlabs.org/api/1.2/series/502608/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/list/?series=502608","date":"2026-05-04T04:10:58","name":"SUNRPC: System wide grep leads to NULL pointer deference in sysfs reads","version":1,"mbox":"http://patchwork.ozlabs.org/series/502608/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232254/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232254/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=e8HVtOx/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=kernel-team-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g87WY0Svzz1yKY\n\tfor ; Mon, 04 May 2026 14:11:53 +1000 (AEST)","from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1wJkeP-0001Tk-VF; Mon, 04 May 2026 04:11:21 +0000","from smtp-relay-internal-1.internal ([10.131.114.114]\n helo=smtp-relay-internal-1.canonical.com)\n by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.86_2) (envelope-from )\n id 1wJkeO-0001TS-7K\n for kernel-team@lists.ubuntu.com; Mon, 04 May 2026 04:11:20 +0000","from mail-pj1-f71.google.com (mail-pj1-f71.google.com\n [209.85.216.71])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 23B7F3F181\n for ; Mon, 4 May 2026 04:11:20 +0000 (UTC)","by mail-pj1-f71.google.com with SMTP id\n 98e67ed59e1d1-35845fcf0f5so4226305a91.0\n for ; Sun, 03 May 2026 21:11:20 -0700 (PDT)","from Garunix (122-58-201-163-adsl.sparkbb.co.nz. [122.58.201.163])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-364ec027690sm9665264a91.13.2026.05.03.21.11.16\n for \n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 03 May 2026 21:11:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1777867880;\n bh=4M8MDG2m99DxzTnhOyemLABqoZNeDE+ozS0axiblZF0=;\n h=From:To:Subject:Date:Message-ID:In-Reply-To:References:\n MIME-Version;\n b=e8HVtOx/4H+pMAShDKcCPXP0483tkqD3Ay/AM7Ac7qRSoS2CM6xPKd/sfIaHgF7e5\n rs6lAOsHYQiSnAI5fQ+T0Kgye2Ck88ZeXpprBObi4PnTaHNhCUb9QYhcmzh/SK+vVF\n KQVD1wEqMOfrY7cmNg0XrVNzEk4q1gj1nWf6gycqiAUQsxAupckGZpGgFtgBLZSg/C\n H+xTG2+UQpLrtvYtOfm+N2/mNlEriWxxszwUUDSE8GVemyUqS5xCenc8qoxNzj7skr\n tM5D9la0XSKu8ndO7esOfNykghbvGOa4+8T1YKBuM2NMbRKIosfxYtLPJA5rcyZLS4\n OjLgefc9iPVZFS3NnSg9/nwiE8Vu4JM/igm+36joNbsDpOd6jpeTuxMrC849o3PwDq\n rlLbho7CEsu/1CLHs6eIrTZ3YPHPv2lOLTztpKIqdrbRBAV+lfiYtTBHgPXYzhZeX9\n FeedBgkavBDT4F0s+Xs2l/rJCCA+4f9XaRRGN5vbl6J7Z7jxxqEadZtLgl6p+vggbn\n lmdSIls/vSj6r5Y9WzaHnm+gCoQkOdV3ZBWNdJu3nngGF/sdQt8C1rHgozvln53C0q\n e6z5gDRdYNe2u7FUNvY6Qv8i4EKUsCY5r2kWu9b02FNp/JHbbVXHAD/Ssy6t27Olq/\n DYsU3rfdfvyzA5n58hTSYerg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777867879; x=1778472679;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=4M8MDG2m99DxzTnhOyemLABqoZNeDE+ozS0axiblZF0=;\n b=llGTRjeNfr9wliOvjbTvSTdCnWWgg8yqEAXg6erLgPNLF+v+0LnVAN4ltFoStwsOrA\n /EQ2XaVjEYrJtLukLheh99I2l0rL14QuXFs0T0HI4C7fkLpraJgwz8DFkTsHpnBPxf24\n qmW/eh2GNTVJHXnPsHGZ80ppyn4zd8g2h88NS+PNpd55ha0Fcrw/SNaC+06eiKimIOow\n AlOxLwTKTQSo7t7qUeERCQAHnUce0SkXvv4iraPT6rlj4hpiFe8aZcSroioifsg3QOpc\n tGsjHwfVAVd0bGUt0w6XzyDj5x55VDRW1KYU+JIUYiGFEmDzvPrhpcx7QLir0uCH3ulL\n c0cQ==","X-Gm-Message-State":"AOJu0Yx26/HjhbT0gra7N/fZ9/ufn+1qlIL1Rk9Yc0wSTf1WGWVZu+Vw\n yBjbdRv4YGJ8YfxqYcEs1Wkb1IFYYpOBCFqF64C7PiMwQyoyGGlMgfGKyTAbAplnpsa+fwHWojh\n B3FdQEDC09CTBFno9D9XdQv2LDOqVtvOWV465EOjBUaZaGoMJ4mY9LyexQ+UbSNO+wmCjmbf8p1\n sRZmRLIgZe7rJ0Mg==","X-Gm-Gg":"AeBDievXa1RLYrBTHYT7pEgBWowhv9BqmG+P9Vczj3/Rq9wMmo+H96GFE6aP6ClKiQ6\n wmeCBbxQfh250oHm1mnWvZc8vR87VlVYmlaX6AnIn5pLYBkQlFGOhWeNoh5k6K4JkOxxAO8VvuK\n xsfzOxl8F5uhtH9fevzxvnxU+Z7TwLBn6Xg33ctCoEEVuINqGA/wD3fxyLEpfujm58gBRob4v3C\n y9tLWd9TVW9Ia4PmcwqGLEDrE3rWfJBgSfoAm+9VTokZ9RJ8ycnUn3ZfTuftwTyQU2TQl61T44O\n VQ47gZdSnebbjWk1hz9wIlgnn5nchNgTcLvFqIkxdiELhloZZCIvyL9+N/pkc2pzixLSKBcYK6E\n ThSJ3WjvNBTwGBkZgwQU+kztO0huPse83wklQK5RaJQwA9lFBDyX4DarNA16T8LnKcyLFylEiF4\n tT","X-Received":["by 2002:a17:90b:2787:b0:356:21e9:73ff with SMTP id\n 98e67ed59e1d1-3650c4ca08amr6835899a91.11.1777867878807;\n Sun, 03 May 2026 21:11:18 -0700 (PDT)","by 2002:a17:90b:2787:b0:356:21e9:73ff with SMTP id\n 98e67ed59e1d1-3650c4ca08amr6835881a91.11.1777867878372;\n Sun, 03 May 2026 21:11:18 -0700 (PDT)"],"From":"Matthew Ruffell ","To":"kernel-team@lists.ubuntu.com","Subject":"[SRU][J][PATCH 1/3] SUNRPC: Check if the xprt is connected before\n handling sysfs reads","Date":"Mon, 4 May 2026 16:10:56 +1200","Message-ID":"<20260504041108.88774-2-matthew.ruffell@canonical.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260504041108.88774-1-matthew.ruffell@canonical.com>","References":"<20260504041108.88774-1-matthew.ruffell@canonical.com>","MIME-Version":"1.0","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "},"content":"From: Anna Schumaker \n\nBugLink: https://bugs.launchpad.net/bugs/2149767\n\nxprts don't immediately reconnect when changing the \"dstaddr\" property,\ninstead this gets handled the next time an operation uses the transport.\nThis could lead to NULL pointer dereferences when trying to read sysfs\nfiles between the disconnect and reconnect operations. Fix this by\nreturning an error if the xprt is not connected.\n\nSigned-off-by: Anna Schumaker \nSigned-off-by: Trond Myklebust \n(cherry picked from commit 17f09d3f619a7ad2d2b021b4e5246f08225b1b0f)\nSigned-off-by: Matthew Ruffell \n---\n net/sunrpc/sysfs.c | 12 ++++++++----\n 1 file changed, 8 insertions(+), 4 deletions(-)","diff":"diff --git a/net/sunrpc/sysfs.c b/net/sunrpc/sysfs.c\nindex 55da1b627a7d..66785d1f90b8 100644\n--- a/net/sunrpc/sysfs.c\n+++ b/net/sunrpc/sysfs.c\n@@ -109,8 +109,10 @@ static ssize_t rpc_sysfs_xprt_srcaddr_show(struct kobject *kobj,\n \tstruct sock_xprt *sock;\n \tssize_t ret = -1;\n \n-\tif (!xprt)\n-\t\treturn 0;\n+\tif (!xprt || !xprt_connected(xprt)) {\n+\t\txprt_put(xprt);\n+\t\treturn -ENOTCONN;\n+\t}\n \n \tsock = container_of(xprt, struct sock_xprt, xprt);\n \tif (kernel_getsockname(sock->sock, (struct sockaddr *)&saddr) < 0)\n@@ -129,8 +131,10 @@ static ssize_t rpc_sysfs_xprt_info_show(struct kobject *kobj,\n \tstruct rpc_xprt *xprt = rpc_sysfs_xprt_kobj_get_xprt(kobj);\n \tssize_t ret;\n \n-\tif (!xprt)\n-\t\treturn 0;\n+\tif (!xprt || !xprt_connected(xprt)) {\n+\t\txprt_put(xprt);\n+\t\treturn -ENOTCONN;\n+\t}\n \n \tret = sprintf(buf, \"last_used=%lu\\ncur_cong=%lu\\ncong_win=%lu\\n\"\n \t\t \"max_num_slots=%u\\nmin_num_slots=%u\\nnum_reqs=%u\\n\"\n","prefixes":["SRU","J","1/3"]}