{"id":2232207,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2232207/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260503204936.3151124-3-sjg@chromium.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260503204936.3151124-3-sjg@chromium.org>","list_archive_url":null,"date":"2026-05-03T20:49:20","name":"[2/6] ti: Quote board_init in ti_common.env","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"414dab103d40cf2cf54e4882dd3486c92b932ded","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/1.2/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260503204936.3151124-3-sjg@chromium.org/mbox/","series":[{"id":502588,"url":"http://patchwork.ozlabs.org/api/1.2/series/502588/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=502588","date":"2026-05-03T20:49:18","name":"test: Quote variables in 'test -n' expressions across boards","version":1,"mbox":"http://patchwork.ozlabs.org/series/502588/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232207/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232207/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=Myypq/sm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"Myypq/sm\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g7xk41v7Xz1yJ0\n\tfor ; Mon, 04 May 2026 06:50:20 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 49D7884605;\n\tSun, 3 May 2026 22:50:13 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id A7390845E9; Sun, 3 May 2026 22:50:12 +0200 (CEST)","from mail-oo1-xc36.google.com (mail-oo1-xc36.google.com\n [IPv6:2607:f8b0:4864:20::c36])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 8B9CD8460B\n for ; Sun, 3 May 2026 22:50:10 +0200 (CEST)","by mail-oo1-xc36.google.com with SMTP id\n 006d021491bc7-69489b43d66so981365eaf.2\n for ; Sun, 03 May 2026 13:50:10 -0700 (PDT)","from chromium.org ([174.51.25.52]) by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-696aacbb5bbsm1142940eaf.15.2026.05.03.13.50.06\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 03 May 2026 13:50:08 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1777841409; x=1778446209; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=cWZ7Xz4jAxM8W8VuBQJGUdGj5BDEOSDKr+YBWjcwJ2Y=;\n b=Myypq/sm8R8XuFIOEDrqQT5iU+gte2pplJRR1i/xmb3yLigJoBhVbFWUzofLPwsxDx\n OmxxVmYaGEpUVyC3MUzQjTR/GibjVCtsM1VcH6C+1KyPHZ6MYnQnw09D+YOLzfAHBhaW\n zY6RDCh9otIi2Sx9xeDZQ5CxnWxpw1Bu7LuUo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777841409; x=1778446209;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=cWZ7Xz4jAxM8W8VuBQJGUdGj5BDEOSDKr+YBWjcwJ2Y=;\n b=rZycuaaxAvCWcHr77eDnAhFgT8aEfLyDT5CIxorW6zf5LyajiWsp5j1GyUq410Xk8F\n pCPbhr38ELJ0onCcTFb3+oxoFuBgkX7xuFDkSAUzhjpqWWwcw7z/aaMuM+9F4r3/Yzat\n F4ytsrZIYq9Rx5KOWqZZ5iNdfeX3bsZ+qI9xe19U9eZeC77KQ+DUlF0w14sEv0G6dt/n\n vsd+d7Rm7puzz+JIv0AlMBePjPc8TDRL17lpciAc1SYvDP2g8um9KeH65M24zG8SOjTP\n lo59+tAboGqVyc0O7T9GWfnXmqnPLzdDWlG/Jrt9YNYuYEYaroElfLnrlSkDJUODHelK\n 3uDg==","X-Gm-Message-State":"AOJu0YzsxQhchdQADRceJSOoMOBcTzr9wctVgzyo8Yd2bgFur5PCmYYV\n UXyqZLSjfMZVs8ULFjesZ0Xb1Ge4aqrfhiR25D0IM5GYGKHyGssWjrXwdI0aVe42Au4mnMjKs9H\n itacvbw==","X-Gm-Gg":"AeBDievwe8t1fBvUt4F6yr2Gylw72aNPHnCd9LOUWXTMVoYAJf1KQDyAi5kSrpFfKO8\n sy6nzEwahva5TD8PcYY9eZd90w+23dcpcOxIBBxduKsBDFF0Gr2DBbWqBCc5w2Y9dqVDrEIrOxf\n 5+8BgT41X1F3uGmn39GIVJATnVABLeGmmfM5nq44EiYgkXCvH9T46QiKFhewJmW8SAL//UYPIeF\n CHYDWKgN3HTjzt2mryNF99q52y0u4mVx0t6fFWjj713In1Xph39Ny4zdqBkycXYp1sJfnt3/PAT\n cy4yqa+BQwvmA5PsLwK3uXP0JBqDgVEAvhRAHN+geBDdPe4CbDUOmADlNR7aT9+Y86E0vKMF5KC\n ZxoXmIuRWkQFvjr8V55ZzF5u0gQeJi8IBmL3dbAPbjpzathSh2HZvol0rko4PgqXdoknmPrp0BH\n rCVdrY2hj3m/qkCIHfpE7JWtehNg0H","X-Received":"by 2002:a05:6820:1b05:b0:696:89d2:fc92 with SMTP id\n 006d021491bc7-69697dfa8eamr3527888eaf.59.1777841408731;\n Sun, 03 May 2026 13:50:08 -0700 (PDT)","From":"Simon Glass ","To":"u-boot@lists.denx.de","Cc":"Simon Glass , Anshul Dalal ,\n Bryan Brattlof , Rasmus Villemoes ,\n Siddharth Vadapalli , Tom Rini ","Subject":"[PATCH 2/6] ti: Quote board_init in ti_common.env","Date":"Sun, 3 May 2026 14:49:20 -0600","Message-ID":"<20260503204936.3151124-3-sjg@chromium.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260503204936.3151124-1-sjg@chromium.org>","References":"<20260503204936.3151124-1-sjg@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"bootcmd_ti_mmc skips a per-board init hook with:\n\n if test -n ${board_init}; then run board_init; fi;\n\nThe default case is \"no board override\", i.e. board_init unset. The\nexpression then expands to 'test -n' with no operand and relies on a\nU-Boot 'test' quirk that treats a missing operand as false to skip the\nrun.\n\nQuote the variable so an unset board_init expands to 'test -n \"\"' and\nthe emptiness check is explicit.\n\nFixes: 8b0619579b22 (\"cmd: test: fix handling of single-argument form of test\")\nSigned-off-by: Simon Glass \n---\n\n include/env/ti/ti_common.env | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/include/env/ti/ti_common.env b/include/env/ti/ti_common.env\nindex 62b93eb25c4..e6ceaa17adc 100644\n--- a/include/env/ti/ti_common.env\n+++ b/include/env/ti/ti_common.env\n@@ -24,7 +24,7 @@ get_fit_config=setexpr name_fit_config gsub / _ conf-${fdtfile}\n run_fit=run get_fit_config; bootm ${addr_fit}#${name_fit_config}${overlaystring}\n bootcmd_ti_mmc=\n \trun init_${boot};\n-\tif test -n ${board_init}; then\n+\tif test -n \"${board_init}\"; then\n \t\techo Running board_init ...;\n \t\trun board_init;\n \tfi;\n","prefixes":["2/6"]}