{"id":2232023,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2232023/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260502083422.2955909-3-zisenye@stu.xidian.edu.cn/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.2/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260502083422.2955909-3-zisenye@stu.xidian.edu.cn>","list_archive_url":null,"date":"2026-05-02T08:34:22","name":"[2/2] smb/client: fix out-of-bounds read in symlink_data()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"59d5f8337855fc1be054c9656e0de5758e7d39b4","submitter":{"id":93303,"url":"http://patchwork.ozlabs.org/api/1.2/people/93303/?format=json","name":"Zisen Ye","email":"zisenye@stu.xidian.edu.cn"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260502083422.2955909-3-zisenye@stu.xidian.edu.cn/mbox/","series":[{"id":502519,"url":"http://patchwork.ozlabs.org/api/1.2/series/502519/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=502519","date":"2026-05-02T08:34:21","name":"smb/client: fix out-of-bounds read","version":1,"mbox":"http://patchwork.ozlabs.org/series/502519/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232023/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232023/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" header.d=stu.xidian.edu.cn\n header.i=@stu.xidian.edu.cn header.a=rsa-sha256 header.s=dkim\n header.b=ebu46EIZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11351-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key)\n header.d=stu.xidian.edu.cn header.i=@stu.xidian.edu.cn header.b=\"ebu46EIZ\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=162.243.164.118","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=stu.xidian.edu.cn","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=stu.xidian.edu.cn"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g71Zy38pQz1yJw\n\tfor ; Sat, 02 May 2026 18:40:58 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 75AA3300F1A0\n\tfor ; Sat, 2 May 2026 08:40:56 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A0D41209F43;\n\tSat, 2 May 2026 08:40:53 +0000 (UTC)","from zg8tmtyylji0my4xnjqumte4.icoremail.net\n (zg8tmtyylji0my4xnjqumte4.icoremail.net [162.243.164.118])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 246AA2D2486\n\tfor ; Sat, 2 May 2026 08:40:50 +0000 (UTC)","from Jason.localdomain (unknown [113.200.174.116])\n\tby hzbj-edu-front-3.icoremail.net (Coremail) with SMTP id\n BbQMCkDG7TcQt_VpG0ziAQ--.40690S4;\n\tSat, 02 May 2026 16:40:18 +0800 (CST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777711253; cv=none;\n b=s/uEiRVCPj7rLNy7866bpEtmkSh4BpjOwZfZvKRapQvEhcBzLRJkZFF53HA2IujfP8R219+4y2LvvGPIGuHD8vAoPvKVG3QDarb5JZ6aPX2SXeTHc75Ti+2dHfqtaebSIuA0kIFYjNCapTBiSdB64I6IdFNIkJTVY7J7S3Xlj80=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777711253; c=relaxed/simple;\n\tbh=7H8y9A1nbISR9+ATnWwo2ISNaaVufWYm0zgy4Yj/r8Q=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=pmTL91lTR+ZftHrNc9x8HsO/CGF1+kIHsC5hMNU/YAZOqB5Dz0N2LED/QCwHanxXoPmtLIjd4y57rN22pLWEYvu6riETq5O5MnujupoPODJy8l8//dZ81KSY/RE5LeGvAvmaXAdz099yNMGkRTrtH3n6YmbzXV4g0/4JowzYUV4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=stu.xidian.edu.cn;\n spf=pass smtp.mailfrom=stu.xidian.edu.cn;\n dkim=fail (0-bit key) header.d=stu.xidian.edu.cn header.i=@stu.xidian.edu.cn\n header.b=ebu46EIZ reason=\"key not found in DNS\";\n arc=none smtp.client-ip=162.243.164.118","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=stu.xidian.edu.cn; s=dkim; h=Received:From:To:Cc:Subject:Date:\n\tMessage-ID:In-Reply-To:References:MIME-Version:\n\tContent-Transfer-Encoding; bh=YXTdTGEyywm3orBUhc8LzdOU/IYL0oItTq\n\tiixELzVz4=; b=ebu46EIZcM4Hdm4d7UhYKzUJ7nUAhYbvQc/+7PG1YLlqQj3z+O\n\tQ8OMbtVXJ0jJbha7KCuyOqc7G3FF5OjaH+ipvwb+Z9z0obMZNOXNaDIq5b05NaHK\n\tsh7lOw7LDKJUC/n2tcLKxgNiVgtwUXqDTvgvXKm1JCpLP8WLdvjucUGXc=","From":"Zisen Ye ","To":"smfrench@gmail.com,\n\tlinkinjeon@kernel.org,\n\tpc@manguebit.org,\n\tronniesahlberg@gmail.com,\n\tsprasad@microsoft.com,\n\ttom@talpey.com,\n\tbharathsm@microsoft.com,\n\tsenozhatsky@chromium.org,\n\tdhowells@redhat.com,\n\tchenxiaosong@chenxiaosong.com,\n\tgregkh@linuxfoundation.org","Cc":"linux-cifs@vger.kernel.org,\n\tZisen Ye ,\n\tChenXiaoSong ","Subject":"[PATCH 2/2] smb/client: fix out-of-bounds read in symlink_data()","Date":"Sat, 2 May 2026 16:34:22 +0800","Message-ID":"<20260502083422.2955909-3-zisenye@stu.xidian.edu.cn>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260502083422.2955909-1-zisenye@stu.xidian.edu.cn>","References":"<20260502083422.2955909-1-zisenye@stu.xidian.edu.cn>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"BbQMCkDG7TcQt_VpG0ziAQ--.40690S4","X-Coremail-Antispam":"1UD129KBjvJXoW7CF4xCryUJrWrArW7Cr1Dtrb_yoW8Gr18pF\n\t15G3yDGw13t3srAanrCF4UX3Wru3WDCF97CFW3Ka48Ars8ArnY9F1ktrn0ga4Sya4kJ3Wr\n\tXF1qvFZIva4jkFDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDU0xBIdaVrnRJUUUQq14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0\n\trVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_Jryl82xGYIkIc2\n\tx26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0\n\tY4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1l84\n\tACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UM2AI\n\txVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20x\n\tvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xv\n\tr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E8cxan2IY04\n\tv7MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMxAqzxv26xkF7I0En4kS14v2\n\t6r1q6r43MxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxV\n\tCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY\n\t6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6x\n\tAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY\n\t1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUbH5lUUUUUU==","X-CM-SenderInfo":"ysvqjiqsrsjkus6v33wo0lvxldqovvfxof0/1tbiAgUBEGn0w2ZVKgAAsR"},"content":"Since smb2_check_message() returns success without length validation for\nthe symlink error response, in symlink_data() it is possible for\niov->iov_len to be smaller than sizeof(struct smb2_err_rsp). If the buffer\nonly contains the base SMB2 header (64 bytes), accessing\nerr->ErrorContextCount (at offset 66) or err->ByteCount later in\nsymlink_data() will cause an out-of-bounds read.\n\nLink: https://lore.kernel.org/linux-cifs/297d8d9b-adf7-42fd-a1c2-5b1f230032bc@chenxiaosong.com/\nSigned-off-by: Zisen Ye \nReviewed-by: ChenXiaoSong \n---\n fs/smb/client/smb2misc.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/fs/smb/client/smb2misc.c b/fs/smb/client/smb2misc.c\nindex 973fce3c959c..2a7355ce1a07 100644\n--- a/fs/smb/client/smb2misc.c\n+++ b/fs/smb/client/smb2misc.c\n@@ -241,7 +241,8 @@ smb2_check_message(char *buf, unsigned int pdu_len, unsigned int len,\n \tif (len != calc_len) {\n \t\t/* create failed on symlink */\n \t\tif (command == SMB2_CREATE_HE &&\n-\t\t shdr->Status == STATUS_STOPPED_ON_SYMLINK)\n+\t\t shdr->Status == STATUS_STOPPED_ON_SYMLINK &&\n+\t\t len > calc_len)\n \t\t\treturn 0;\n \t\t/* Windows 7 server returns 24 bytes more */\n \t\tif (calc_len + 24 == len && command == SMB2_OPLOCK_BREAK_HE)\n","prefixes":["2/2"]}