{"id":2231977,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2231977/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260501200026.22784-4-oelghoul@linux.ibm.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260501200026.22784-4-oelghoul@linux.ibm.com>","list_archive_url":null,"date":"2026-05-01T20:00:24","name":"[RFC,v1,3/5] hw/virtio: Add DMA counters for virtio-pci devices","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"86d40b814735272cc1035dc8612d01202bbecd61","submitter":{"id":93299,"url":"http://patchwork.ozlabs.org/api/1.2/people/93299/?format=json","name":"Omar Elghoul","email":"oelghoul@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260501200026.22784-4-oelghoul@linux.ibm.com/mbox/","series":[{"id":502493,"url":"http://patchwork.ozlabs.org/api/1.2/series/502493/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502493","date":"2026-05-01T20:00:21","name":"s390x/pci: Improved zPCI Function Measurement Support","version":1,"mbox":"http://patchwork.ozlabs.org/series/502493/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231977/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231977/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=orD4z5+a;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6hpN1LqQz1yHZ\n\tfor ; Sat, 02 May 2026 06:04:44 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIu67-0001TA-Jw; Fri, 01 May 2026 16:04:27 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIu5M-0001C9-EP; Fri, 01 May 2026 16:03:52 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIu5J-0001QO-DL; Fri, 01 May 2026 16:03:40 -0400","from pps.filterd (m0360072.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 641EkLAq2006058; Fri, 1 May 2026 20:03:34 GMT","from ppma22.wdc07v.mail.ibm.com\n (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4drn8vv61p-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Fri, 01 May 2026 20:03:33 +0000 (GMT)","from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 641Js0Jo019209;\n Fri, 1 May 2026 20:03:33 GMT","from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72])\n by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4ds8aw91kk-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Fri, 01 May 2026 20:03:33 +0000 (GMT)","from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com\n [10.241.53.105])\n by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 641K3T9b63242744\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Fri, 1 May 2026 20:03:29 GMT","from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 87BCA58043;\n Fri, 1 May 2026 20:03:29 +0000 (GMT)","from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 629E158059;\n Fri, 1 May 2026 20:03:28 +0000 (GMT)","from Mac.ibm.com (unknown [9.61.247.25])\n by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP;\n Fri, 1 May 2026 20:03:28 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=IwvvP9MY8WoGYhdgJ\n WzLy3S2sw6QZcbw07ZcxAXwF0I=; b=orD4z5+arMyNKir+beBy1SzHib6xjAfUd\n ABeVKu5cJRWkM0zRjXl7eMkmHc5csg8sHJdglin/DU0CVGI/gD1mzNkS8gfykPQt\n 2rRUY2P5g4EX3FKMM8Hb2x0Zs7VFKC4OJZH7KdRPRjgsvYFe6g40A7K/vU/lP8n+\n MaODRc2wJhZ/zpl+VltwxEs4mtxw0PjU8yR9L4FhaWpwo1wahfLYEEb8ae07bSRZ\n ehpCZBH0XElLBq0Pf/l4RPmM06azyHerbvR8h6CZRtzrYcfmSuKa+7nJWseusQR1\n g3P5z9AMvcN0s1oWzKKVPKcfQTVQCjkI41xHYAUuuGxc0S+yoAPrw==","From":"Omar Elghoul ","To":"qemu-devel@nongnu.org, qemu-s390x@nongnu.org","Cc":"oelghoul@linux.ibm.com, mjrosato@linux.ibm.com, alifm@linux.ibm.com,\n farman@linux.ibm.com, pasic@linux.ibm.com, borntraeger@linux.ibm.com,\n richard.henderson@linaro.org, iii@linux.ibm.com, david@kernel.org,\n cohuck@redhat.com, mst@redhat.com, pbonzini@redhat.com, clg@redhat.com","Subject":"[RFC PATCH v1 3/5] hw/virtio: Add DMA counters for virtio-pci devices","Date":"Fri, 1 May 2026 16:00:24 -0400","Message-ID":"<20260501200026.22784-4-oelghoul@linux.ibm.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260501200026.22784-1-oelghoul@linux.ibm.com>","References":"<20260501200026.22784-1-oelghoul@linux.ibm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Authority-Analysis":"v=2.4 cv=CIIamxrD c=1 sm=1 tr=0 ts=69f50715 cx=c_pps\n a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17\n a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=456z7t5ePv1a_L0t-noA:9","X-Proofpoint-ORIG-GUID":"jUlSoWcWBnFT_KLsUJPayO9F9xhYjKfW","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTAxMDE5NSBTYWx0ZWRfXyGg/RRSSQxjs\n dBwExYQDxtalSUcB4LnfalVhB/hQLfgnzOMtDiilkdlBNzX1mcHo/U0qjz93uNnuvMs6ngcwUG2\n 9iXaXn3KIXnp9L5qcKQWoDq9GCfmKhXrx9Nv9WekHPvMR4GVdZwLRkThPmdqFYV5q+8LHj7q3wW\n ypBUgabiYGOg/I7gJEvklVRqc1rQeZMraPzs4zrP3S9Ol2uFJAWTGRuW9ZxdoSNCjNWR+jH/CYZ\n lb8GggUBrHvSY1WczqJG4tDiCwbE/Zbm+uS3tOvMyRC4mhqyrOgZ2EDFLtROx3KBCRxoOcugVnM\n eyQvQkR6I1pSVFo8/bu5LIB1Rft83I/rl9bWjh2A5v6ABckO7dyra8BAJgE+Pr5Q1AH4SbOI+T5\n yc7Nal88cuxjXVcZr6bsyUE9+s1UnNjwOi7X/IX/smx7MfwcwD0y4Pw/mksycvkj+iGmTceETRL\n 8LPxB1Lkn+8O7ntQBpw==","X-Proofpoint-GUID":"jUlSoWcWBnFT_KLsUJPayO9F9xhYjKfW","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-01_05,2026-04-30_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n spamscore=0 phishscore=0 malwarescore=0 suspectscore=0 adultscore=0\n impostorscore=0 lowpriorityscore=0 clxscore=1011 bulkscore=0\n priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2605010195","Received-SPF":"pass client-ip=148.163.158.5;\n envelope-from=oelghoul@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Internally track DMA read/write byte counters for virtio-pci devices by\nassigning them a DMA owner bus. This will allow an implementation of the\nFMB format-0 for zPCI. The assignment of an owner bus is also done from\ns390x-specific realization such that other architectures do not need to\ninternally track unutilized counters.\n\nSigned-off-by: Omar Elghoul \n---\n hw/s390x/s390-pci-bus.c | 7 +++++++\n hw/virtio/virtio.c | 16 ++++++++++++++++\n include/hw/pci/pci_device.h | 4 ++++\n include/hw/virtio/virtio.h | 1 +\n 4 files changed, 28 insertions(+)","diff":"diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c\nindex 128814f4c5..7eee1efeb7 100644\n--- a/hw/s390x/s390-pci-bus.c\n+++ b/hw/s390x/s390-pci-bus.c\n@@ -20,6 +20,7 @@\n #include \"hw/s390x/s390-pci-kvm.h\"\n #include \"hw/s390x/s390-pci-vfio.h\"\n #include \"hw/s390x/s390-virtio-ccw.h\"\n+#include \"hw/virtio/virtio-pci.h\"\n #include \"hw/core/boards.h\"\n #include \"hw/pci/pci_bus.h\"\n #include \"hw/core/qdev-properties.h\"\n@@ -1192,6 +1193,12 @@ static void s390_pcihost_plug(HotplugHandler *hotplug_dev, DeviceState *dev,\n pbdev->rtr_avail = false;\n }\n \n+ if (object_dynamic_cast(OBJECT(dev), TYPE_VIRTIO_PCI)) {\n+ VirtIOPCIProxy *virtio_proxy = VIRTIO_PCI(pbdev->pdev);\n+ VirtIODevice *vdev = virtio_bus_get_device(&virtio_proxy->bus);\n+ vdev->dma_owner = OBJECT(virtio_proxy);\n+ }\n+\n if (s390_pci_msix_init(pbdev) && !pbdev->interp) {\n error_setg(errp, \"MSI-X support is mandatory \"\n \"in the S390 architecture\");\ndiff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c\nindex 8fcf6cfd0b..f61ad57821 100644\n--- a/hw/virtio/virtio.c\n+++ b/hw/virtio/virtio.c\n@@ -24,6 +24,7 @@\n #include \"qom/object_interfaces.h\"\n #include \"hw/core/cpu.h\"\n #include \"hw/virtio/virtio.h\"\n+#include \"hw/virtio/virtio-pci.h\"\n #include \"hw/virtio/vhost.h\"\n #include \"migration/qemu-file-types.h\"\n #include \"qemu/atomic.h\"\n@@ -1617,9 +1618,16 @@ static bool virtqueue_map_desc(VirtIODevice *vdev, unsigned int *p_num_sg,\n hwaddr pa, size_t sz)\n {\n bool ok = false;\n+ PCIDevice *pdev = NULL;\n unsigned num_sg = *p_num_sg;\n assert(num_sg <= max_num_sg);\n \n+ if (vdev->dma_owner &&\n+ object_dynamic_cast(vdev->dma_owner, TYPE_VIRTIO_PCI)) {\n+ VirtIOPCIProxy *proxy = VIRTIO_PCI(vdev->dma_owner);\n+ pdev = &proxy->pci_dev;\n+ }\n+\n if (!sz) {\n virtio_error(vdev, \"virtio: zero sized buffers are not allowed\");\n goto out;\n@@ -1650,6 +1658,14 @@ static bool virtqueue_map_desc(VirtIODevice *vdev, unsigned int *p_num_sg,\n sz -= len;\n pa += len;\n num_sg++;\n+\n+ if (pdev) {\n+ if (is_write) {\n+ pdev->dma_wbytes += len;\n+ } else {\n+ pdev->dma_rbytes += len;\n+ }\n+ }\n }\n ok = true;\n \ndiff --git a/include/hw/pci/pci_device.h b/include/hw/pci/pci_device.h\nindex 5cac6e1688..5a4fd4f605 100644\n--- a/include/hw/pci/pci_device.h\n+++ b/include/hw/pci/pci_device.h\n@@ -98,6 +98,10 @@ struct PCIDevice {\n MemoryRegion bus_master_container_region;\n MemoryRegion bus_master_enable_region;\n \n+ /* DMA statistics */\n+ uint64_t dma_rbytes;\n+ uint64_t dma_wbytes;\n+\n /* do not access the following fields */\n PCIConfigReadFunc *config_read;\n PCIConfigWriteFunc *config_write;\ndiff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h\nindex 6344bd7b68..e9e7e437f9 100644\n--- a/include/hw/virtio/virtio.h\n+++ b/include/hw/virtio/virtio.h\n@@ -161,6 +161,7 @@ struct VirtIODevice\n */\n bool use_guest_notifier_mask;\n AddressSpace *dma_as;\n+ Object *dma_owner;\n QLIST_HEAD(, VirtQueue) *vector_queues;\n QTAILQ_ENTRY(VirtIODevice) next;\n /**\n","prefixes":["RFC","v1","3/5"]}