{"id":2231880,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2231880/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260501133924.3100680-3-houminxi@gmail.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/1.2/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260501133924.3100680-3-houminxi@gmail.com>","list_archive_url":null,"date":"2026-05-01T13:39:23","name":"[ovs-dev,net-next,v2,2/2] selftests: openvswitch: add pop_vlan test","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0640ad9148e61cce3ae27fd1d0ac081f40c5141e","submitter":{"id":93141,"url":"http://patchwork.ozlabs.org/api/1.2/people/93141/?format=json","name":"Minxi Hou","email":"houminxi@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260501133924.3100680-3-houminxi@gmail.com/mbox/","series":[{"id":502459,"url":"http://patchwork.ozlabs.org/api/1.2/series/502459/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=502459","date":"2026-05-01T13:39:21","name":"selftests: openvswitch: add pop_vlan test","version":2,"mbox":"http://patchwork.ozlabs.org/series/502459/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231880/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231880/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=lZ60mzpM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp1.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key)\n header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104\n header.b=lZ60mzpM","smtp3.osuosl.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.a=rsa-sha256 header.s=20251104 header.b=lZ60mzpM"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6XGS4vjqz1y04\n\tfor ; Fri, 01 May 2026 23:40:00 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 1696F82314;\n\tFri, 1 May 2026 13:39:59 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id WQU_Dz4Ix2Ye; Fri, 1 May 2026 13:39:58 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id EFE8984175;\n\tFri, 1 May 2026 13:39:57 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id CEC54C04E8;\n\tFri, 1 May 2026 13:39:57 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 19889C04E7\n for ; Fri, 1 May 2026 13:39:57 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id CBD3661B9E\n for ; Fri, 1 May 2026 13:39:48 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id NwTDfur0mdiV for ;\n Fri, 1 May 2026 13:39:48 +0000 (UTC)","from mail-pg1-x530.google.com (mail-pg1-x530.google.com\n [IPv6:2607:f8b0:4864:20::530])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 1423061AC3\n for ; Fri, 1 May 2026 13:39:47 +0000 (UTC)","by mail-pg1-x530.google.com with SMTP id\n 41be03b00d2f7-c796163fac5so1141997a12.1\n for ; Fri, 01 May 2026 06:39:47 -0700 (PDT)","from houminxi ([38.207.130.223]) by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-835158aa1ffsm2548386b3a.22.2026.05.01.06.39.42\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 May 2026 06:39:46 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org EFE8984175","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1423061AC3"],"Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::530; helo=mail-pg1-x530.google.com;\n envelope-from=houminxi@gmail.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 1423061AC3","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777642787; x=1778247587; darn=openvswitch.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=S9dujcCTcBtWqsxKxFY2R1ovfB7aW0cYQVgKhmNRcsw=;\n b=lZ60mzpM2RDevx2KUknFtz4BhyPqJmEXycitkSLwjaln0VJo5gVxksUneuh4jUXTBJ\n G0iUUchTqW1jhhjGE2P2gt+5s76jZDkR+xWIV1+ENo7NrTmVoiZZPteSeNDHQVkSvvab\n GIICrRh7OMRyzAU9bLYpAfqpWTitnwZwbnar/g43d5C54yD3pCQ74IMvlo0aZ2Ti6GmA\n RjuwHjeNiO7QoJzX18/QWcWeZhgVvOj8JtFf9O0uulEPRXFeSCmdL124amnZcHA6Btpw\n f1QaVnZ1r2MDZ//1qtmZbI4aRGWm1bf95jtJvtnd+Dvy8xmmk5Fn/YGSBeWLaCKNitOJ\n BgXA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777642787; x=1778247587;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=S9dujcCTcBtWqsxKxFY2R1ovfB7aW0cYQVgKhmNRcsw=;\n b=FbZt+Rtt/qWNs9r6bU8thxYTmdN6unkX1AypdF7NouNYEBAqI7/43fxv4Ixf9cKA8C\n 6Cm+efYsI3oDzvhW7N53dsz6RW7E+p6R7+ZwI9+o1wp4nCSELzZBODepeD2S8pvCytiQ\n YvhUvqQcamOpNJ6R0S+MEm51K+ljIDQ4Ug4bu8pH7Ip/dDNeNMDBxlxyg5qAAbGucuTG\n SJBMdgPUK20RoevrYjej/WmXoNmNJD0JaUehoqCV2ZiHOm7gktzPfs2UqJrrZH8Jq11m\n aRQ8yQH6WGQ5M5CQCuaW8FYfrohrum2mzdSAEAzIOwSvo6Ls8UNE0357P/8Ay82B6WJm\n pB/Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/3VUEtYHI4S6+puZeIYciX2bbHtJwmvbz4a1WSXj+v/B9ptDEo9ggCuYFShQme0sgvN1M=@openvswitch.org","X-Gm-Message-State":"AOJu0YzG3BFLGT4zILnPCDO1jZDJeO08jrNOViu+jucdpaORM/jrkiT+\n cgyQcqvYVKHO9D2JA3KfLkdGu4eWhmvevy/YZNhC+RMtixDWp8cIL3NX","X-Gm-Gg":"AeBDietnWxmLCLFmDJ2DAZoeKuWOhl0tKiwV+wo00jl066lbeL77h+pG9IXrHnWGRQb\n jKGIsNhVixje8Q7g9N5TRVK7+vsMtTUjI3LfDEOxoYuNmzFYw9/LYc1RWiAYMB/MXf9tYb3Co/W\n tD1uqMZcRPD+bPT+ZKkEOJEIWRqo96qIAuTKFEt8Dzs3IkPs+cKtBqB7TqxtFrKgDH5/jT+X9Lw\n DU5jHqJahIIljej+7gDrNNDm084A+1Xw1H6T9ijTR0CS9fYHetOr86qMkhYuU2xGVJSXON6qEZE\n Nli4mut3n0Qf23iSBbL3GXA+dBw9KHT86+KWdsxwpAPdQ6eKtFTQscnNb4nfltHr3xHDFq/aLOe\n LRjCygnofOiZW3kq+fdua+IDGq9A6GXFaSYhis1kqS8t8+eWKDpyec6NUMICg0Az+UrYb8AsY2n\n HbRdX8UZ9pOx44mr+69hOy0GM6A0Y=","X-Received":"by 2002:a05:6a20:6a0a:b0:3a2:d838:bfda with SMTP id\n adf61e73a8af0-3a45fe26b94mr3744683637.46.1777642787200;\n Fri, 01 May 2026 06:39:47 -0700 (PDT)","From":"Minxi Hou ","To":"netdev@vger.kernel.org","Date":"Fri, 1 May 2026 21:39:23 +0800","Message-ID":"<20260501133924.3100680-3-houminxi@gmail.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260501133924.3100680-1-houminxi@gmail.com>","References":"<20260501133924.3100680-1-houminxi@gmail.com>","MIME-Version":"1.0","Subject":"[ovs-dev] [PATCH net-next v2 2/2] selftests: openvswitch: add\n pop_vlan test","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"dev@openvswitch.org, Simon Horman ,\n Minxi Hou , linux-kernel@vger.kernel.org,\n Ilya Maximets , Eric Dumazet ,\n linux-kselftest@vger.kernel.org, Jakub Kicinski ,\n Paolo Abeni , Shuah Khan ,\n \"David S. Miller\" ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"Add a test for the OVS datapath POP_VLAN action. The test uses\nthe VLAN sub-interface of a veth pair to generate 802.1Q tagged\nframes and verifies that pop_vlan correctly strips the VLAN tag\nbefore delivery via pcap frame capture.\n\nThe test has two verifications:\n- Negative: forward tagged frames without pop_vlan, verify the\n VLAN tag is still present on the egress interface.\n- Positive: apply pop_vlan, verify the tag is removed and an\n untagged ICMP echo request arrives at the egress interface.\n\nStatic ARP entries avoid the complexity of VLAN-tagged ARP\nresolution (the egress side has no VLAN sub-interface and cannot\nprocess tagged ARP).\n\nSigned-off-by: Minxi Hou \n---\nv1 -> v2: rebase to latest net-next/main, drop --base=auto\n\n .../selftests/net/openvswitch/openvswitch.sh | 132 ++++++++++++++++++\n 1 file changed, 132 insertions(+)","diff":"diff --git a/tools/testing/selftests/net/openvswitch/openvswitch.sh b/tools/testing/selftests/net/openvswitch/openvswitch.sh\nindex b327d3061ed5..cd614ff7b740 100755\n--- a/tools/testing/selftests/net/openvswitch/openvswitch.sh\n+++ b/tools/testing/selftests/net/openvswitch/openvswitch.sh\n@@ -27,6 +27,7 @@ tests=\"\n \tupcall_interfaces\t\t\tovs: test the upcall interfaces\n \ttunnel_metadata\t\t\t\tovs: test extraction of tunnel metadata\n \tdrop_reason\t\t\t\tdrop: test drop reasons are emitted\n+\tpop_vlan\t\t\t\t\tvlan-pop: POP_VLAN action strips 802.1Q tag\n \tpsample\t\t\t\t\tpsample: Sampling packets with psample\"\n \n info() {\n@@ -830,6 +831,137 @@ test_tunnel_metadata() {\n \treturn 0\n }\n \n+test_pop_vlan() {\n+\tmodprobe -q openvswitch 2>/dev/null || true\n+\t[ -d /sys/module/openvswitch ] || return $ksft_skip\n+\tip netns add __test_pop_vlan_netns__ 2>/dev/null || \\\n+\t\t{ info \"CONFIG_NET_NS missing\"; return $ksft_skip; }\n+\tip netns del __test_pop_vlan_netns__ 2>/dev/null\n+\tmodprobe -q 8021q 2>/dev/null || true\n+\t[ -d /sys/module/8021q ] || { info \"CONFIG_VLAN_8021Q missing\"; return $ksft_skip; }\n+\n+\tlocal sbx=\"test_pop_vlan\"\n+\tsbx_add \"$sbx\" || return $ksft_skip\n+\tovs_add_dp \"$sbx\" vlandp || return 1\n+\n+\t# --- baseline: untagged forwarding ---\n+\tovs_add_netns_and_veths \"$sbx\" vlandp ns1 veth1 ns1veth 192.0.2.1/24 || return 1\n+\tovs_add_netns_and_veths \"$sbx\" vlandp ns2 veth2 ns2veth 192.0.2.2/24 || return 1\n+\n+\t# ARP + IPv4 bidirectional (all untagged)\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(1),eth(),eth_type(0x0806),arp()' '2' || return 1\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(2),eth(),eth_type(0x0806),arp()' '1' || return 1\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(1),eth(),eth_type(0x0800),ipv4()' '2' || return 1\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(2),eth(),eth_type(0x0800),ipv4()' '1' || return 1\n+\tip netns exec ns1 ping -c 3 -W 2 192.0.2.2 || return 1\n+\n+\t# --- POP_VLAN test ---\n+\t# Register cleanup before creating resources (safe on failure paths)\n+\ton_exit \"ip -n ns1 link del ns1veth.10 2>/dev/null || true\n+\t\t ip -n ns2 addr del 198.51.100.2/24 dev ns2veth 2>/dev/null || true\"\n+\n+\t# ns1: VLAN sub-interface generates tagged frames\n+\tip -n ns1 link add link ns1veth name ns1veth.10 type vlan id 10\n+\tip -n ns1 addr add 198.51.100.1/24 dev ns1veth.10\n+\tip -n ns1 link set ns1veth.10 up\n+\n+\t# ns2: no VLAN sub-interface. POP delivers untagged frames to ns2veth\n+\tip -n ns2 addr add 198.51.100.2/24 dev ns2veth\n+\n+\t# veth disable VLAN offload + GRO (ensure kernel software tag processing)\n+\tif command -v ethtool >/dev/null 2>&1; then\n+\t\tip netns exec ns1 ethtool -k ns1veth 2>/dev/null | grep -q vlan-offload && \\\n+\t\t\tip netns exec ns1 ethtool -K ns1veth rx-vlan-offload off \\\n+\t\t\t\ttx-vlan-offload off gro off 2>/dev/null || true\n+\t\tip netns exec ns2 ethtool -k ns2veth 2>/dev/null | grep -q vlan-offload && \\\n+\t\t\tip netns exec ns2 ethtool -K ns2veth rx-vlan-offload off \\\n+\t\t\t\ttx-vlan-offload off gro off 2>/dev/null || true\n+\tfi\n+\n+\tovs_del_flows \"$sbx\" vlandp\n+\n+\t# Static ARP avoids VLAN-tagged ARP complexity (ns2 has no VLAN\n+\t# sub-interface, so tagged ARP would be invisible to ns2).\n+\tlocal ns1veth10mac ns2mac\n+\tns1veth10mac=$(ip -n ns1 link show ns1veth.10 | \\\n+\t\tawk '/link\\/ether/ {print $2}')\n+\tns2mac=$(ip -n ns2 link show ns2veth | \\\n+\t\tawk '/link\\/ether/ {print $2}')\n+\t[ -n \"$ns1veth10mac\" ] && echo \"$ns1veth10mac\" | \\\n+\t\tgrep -qE \"^([0-9a-fA-F]{2}:){5}[0-9a-fA-F]{2}$\" || return 1\n+\t[ -n \"$ns2mac\" ] && echo \"$ns2mac\" | \\\n+\t\tgrep -qE \"^([0-9a-fA-F]{2}:){5}[0-9a-fA-F]{2}$\" || return 1\n+\tip -n ns1 neigh replace 198.51.100.2 lladdr \"$ns2mac\" \\\n+\t\tdev ns1veth.10 nud permanent || return 1\n+\tip -n ns2 neigh replace 198.51.100.1 lladdr \"$ns1veth10mac\" \\\n+\t\tdev ns2veth nud permanent || return 1\n+\n+\t# --- Negative check: fwd without pop_vlan, VLAN tag stays ---\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(1),eth(),eth_type(0x8100),vlan(vid=10),encap(eth_type(0x0800),ipv4(src=198.51.100.1,proto=1),icmp())' \\\n+\t\t'2' || return 1\n+\n+\tlocal pcap_no_pop\n+\tpcap_no_pop=$(mktemp --suffix=.pcap)\n+\ton_exit \"rm -f $pcap_no_pop\"\n+\tip netns exec ns2 tcpdump -nei ns2veth -w \"$pcap_no_pop\" -U &\n+\tlocal tpid_no_pop=$!\n+\ton_exit \"kill $tpid_no_pop 2>/dev/null || true\"\n+\tsleep $((WAIT_TIMEOUT / 5 < 2 ? 2 : WAIT_TIMEOUT / 5))\n+\n+\tip netns exec ns1 ping -I ns1veth.10 -c 3 -W 1 198.51.100.2 \\\n+\t\t>/dev/null 2>&1 || true\n+\tkill $tpid_no_pop 2>/dev/null || true; wait $tpid_no_pop 2>/dev/null || true\n+\n+\t# assert: VLAN tag still present (no pop_vlan in action)\n+\ttcpdump -nr \"$pcap_no_pop\" 'vlan' 2>/dev/null | grep -q . || {\n+\t\tinfo \"FAIL: negative check: no VLAN tag (expected tag present)\"; return 1\n+\t}\n+\n+\tovs_del_flows \"$sbx\" vlandp\n+\n+\t# --- Positive: pop_vlan strips tag ---\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(1),eth(),eth_type(0x8100),vlan(vid=10),encap(eth_type(0x0800),ipv4(src=198.51.100.1,proto=1),icmp())' \\\n+\t\t'pop_vlan,2' || return 1\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(2),eth(),eth_type(0x0800),ipv4()' '1' || return 1\n+\n+\tlocal pcap\n+\tpcap=$(mktemp --suffix=.pcap)\n+\ton_exit \"rm -f $pcap\"\n+\tip netns exec ns2 tcpdump -nei ns2veth -w \"$pcap\" -U &\n+\tlocal tpid=$!\n+\ton_exit \"kill $tpid 2>/dev/null || true\"\n+\tsleep $((WAIT_TIMEOUT / 5 < 2 ? 2 : WAIT_TIMEOUT / 5))\n+\n+\t# ping reply unreachable: ns1veth.10 only accepts tagged frames,\n+\t# ns2 sends untagged reply -> dropped by ns1veth.10.\n+\tlocal ping_rc=0\n+\tip netns exec ns1 ping -I ns1veth.10 -c 3 -W 1 198.51.100.2 \\\n+\t\t>/dev/null 2>&1 || ping_rc=$?\n+\tkill $tpid 2>/dev/null || true; wait $tpid 2>/dev/null || true\n+\n+\t# ping failure is expected (reply path asymmetric)\n+\t[ \"$ping_rc\" -ne 0 ] || \\\n+\t\tinfo \"NOTE: ping succeeded unexpectedly (reply reached ns1veth.10)\"\n+\n+\t# assert: no VLAN tag (POP succeeded), untagged ICMP echo request arrived\n+\ttcpdump -nr \"$pcap\" 'vlan' 2>/dev/null | grep -q . && {\n+\t\tinfo \"FAIL: POP_VLAN: VLAN tag still present\"; return 1\n+\t}\n+\ttcpdump -nr \"$pcap\" 'icmp and icmp[icmptype]=8' \\\n+\t\t2>/dev/null | grep -q . || {\n+\t\tinfo \"FAIL: POP_VLAN: no untagged ICMP echo request\"; return 1\n+\t}\n+\n+\treturn 0\n+}\n+\n run_test() {\n \t(\n \ttname=\"$1\"\n","prefixes":["ovs-dev","net-next","v2","2/2"]}