{"id":2231785,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2231785/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260501122756.3081754-3-houminxi@gmail.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/1.2/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260501122756.3081754-3-houminxi@gmail.com>","list_archive_url":null,"date":"2026-05-01T12:27:56","name":"[ovs-dev,2/2] selftests: openvswitch: add pop_vlan test","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0640ad9148e61cce3ae27fd1d0ac081f40c5141e","submitter":{"id":93141,"url":"http://patchwork.ozlabs.org/api/1.2/people/93141/?format=json","name":"Minxi Hou","email":"houminxi@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260501122756.3081754-3-houminxi@gmail.com/mbox/","series":[{"id":502450,"url":"http://patchwork.ozlabs.org/api/1.2/series/502450/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=502450","date":"2026-05-01T12:27:54","name":"selftests: openvswitch: add pop_vlan test","version":1,"mbox":"http://patchwork.ozlabs.org/series/502450/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231785/comments/","check":"warning","checks":"http://patchwork.ozlabs.org/api/patches/2231785/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=deJvWfeK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp3.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key)\n header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104\n header.b=deJvWfeK","smtp1.osuosl.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.a=rsa-sha256 header.s=20251104 header.b=deJvWfeK"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6Vgw52clz1xqf\n\tfor ; Fri, 01 May 2026 22:28:28 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 1981461C09;\n\tFri, 1 May 2026 12:28:27 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 57Y6-bKN0l-e; Fri, 1 May 2026 12:28:26 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id 0195061C39;\n\tFri, 1 May 2026 12:28:26 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id D568FC04E8;\n\tFri, 1 May 2026 12:28:25 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 60555C04E7\n for ; Fri, 1 May 2026 12:28:25 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 32D4085628\n for ; Fri, 1 May 2026 12:28:21 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 6VB7mpqRcQog for ;\n Fri, 1 May 2026 12:28:20 +0000 (UTC)","from mail-pl1-x636.google.com (mail-pl1-x636.google.com\n [IPv6:2607:f8b0:4864:20::636])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 4E4BB85622\n for ; Fri, 1 May 2026 12:28:20 +0000 (UTC)","by mail-pl1-x636.google.com with SMTP id\n d9443c01a7336-2b7d3ecc10dso16016325ad.2\n for ; Fri, 01 May 2026 05:28:20 -0700 (PDT)","from houminxi ([38.207.130.223]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b9ca953894sm23370395ad.0.2026.05.01.05.28.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 May 2026 05:28:18 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0195061C39","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4E4BB85622"],"Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::636; helo=mail-pl1-x636.google.com;\n envelope-from=houminxi@gmail.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 4E4BB85622","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777638499; x=1778243299; darn=openvswitch.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zj0JPXxTGf48PQ3BkUTecnOYQMvofllCVE1YB6aW9do=;\n b=deJvWfeKI/2g9hlVpc3WHDrHA5JEe8YtdYz1VFIMTGsiPySKVmFoiJlUloLoc3YmXt\n c9mxyeyHwhNo97OpzAu2/7zYng3pKmUP+9CY9Px/OdBvC2IVdeXYGcJ8BPCRmA1M4OTk\n GFTPgM8yqvx176+8U1xEb6+Gr4HEXCOvEdFRwda1JrqbiD1GOnLxCPVi0tZsbpSL/9Ui\n dnFJIlqC58FXad1Mulp/khzqCp/ZSeFJb/4+/wqAUVbNodchkx6tWhPfo87qJrO7g2OJ\n pRBdNy3uq3KZzGK5T2uk5vgxRlk9R2/GNTg+F4hcfAPnZSnn5vC3M7cUnrJYBdzBpmOx\n a/PA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777638499; x=1778243299;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=zj0JPXxTGf48PQ3BkUTecnOYQMvofllCVE1YB6aW9do=;\n b=Assf6nAoV+g3ZMpFWTY/JuSLpLEgECsASULDhuSDV9HS2s35mMNFDzIO+CHBxuzSGa\n zaYQf31yQ3wGQPRMs01cX156B4eE048Y5Chq0vXs4zz0IyUg9pOE7QTjKjC0y1nZq3ni\n LO/KxIG31q8uod1GLM40Dxw0L86k9G0uQhIkGuU/wwV1Zjfflh0ErRJJNF0+oNfIVjLl\n sbNVzriutQLzTOFBM/bEIBPsu/YXYIduq2jUo5S7nP4q+csA4haSsNDaGs0Cu92GOFcV\n uF9eV7V1H6YRW9nGM1Pism8UpB050WOCJP7z5+4bqptw+WPvq2GrtJeKNChnBtSkIDWC\n WXPg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8V3AkKaazsZ6vbV38uyKPzw6ZNDVJwVB6KMKZqdoaPdphxEuN2cUfznpD2NU0LeCjaa6w=@openvswitch.org","X-Gm-Message-State":"AOJu0YzQevoH2m2A1f1s/yPKwEbJl+5QYGnCZyN/XGnarSqCRD4ALaTJ\n gwrptTDYoRn5hng2rHcxDqkO4wnCP0oW30K4WOBrfcmcSt6Wn5WUTnBL","X-Gm-Gg":"AeBDiesTOEe2jznqbGl/RCsW0KLsxtdwVhxaVtk5IZjH43Ac4oWQ/dzrp2olvFYf5Fq\n Lkpuu4ihBbBp83pLiXlFw0O2VyGgdaenIyYGxQJkY25SzUna1Ja60tbFxn2fDmQegV1A4eBfmBH\n hEEd6/iHPh+95JzoOXe3xLRRjp/Gu1Oqb80HsuBPmdqz0BebHjJHiMKmvjK0qqEDlcTxDHl2L2h\n Dajf3bv5qcQfAIsHBGDXn+9JWna2J1E5tdseSdbHs0W/qiIQSXLNYqQWmy5kah1KUxpmTCrnaAu\n LRbglDI/fVVvKnk6e+vz3j2po1+9niLSAtlVSSSQAPjrGgCHJKbMbs3uyslktqCTFfeQDNqzy9s\n RCQTlsgO9DJ1jXl+VNMycn5fyaDzT4PRRVi4E/273O5AcZxLwJN7td8z/u24ipyAZgZ/cVcC1Mt\n D3G54Dr+YGpCErs2ZymRUznhsJb/eugSHqTn+AZA==","X-Received":"by 2002:a17:903:70c:b0:2b9:6458:1a2c with SMTP id\n d9443c01a7336-2b9d3dccc79mr16955145ad.13.1777638499405;\n Fri, 01 May 2026 05:28:19 -0700 (PDT)","From":"Minxi Hou ","To":"netdev@vger.kernel.org","Date":"Fri, 1 May 2026 20:27:56 +0800","Message-ID":"<20260501122756.3081754-3-houminxi@gmail.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260501122756.3081754-1-houminxi@gmail.com>","References":"<20260501122756.3081754-1-houminxi@gmail.com>","MIME-Version":"1.0","Subject":"[ovs-dev] [PATCH 2/2] selftests: openvswitch: add pop_vlan test","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"dev@openvswitch.org, Simon Horman ,\n Minxi Hou , linux-kernel@vger.kernel.org,\n Ilya Maximets , Eric Dumazet ,\n linux-kselftest@vger.kernel.org, Jakub Kicinski ,\n Paolo Abeni , Shuah Khan ,\n \"David S. Miller\" ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"Add a test for the OVS datapath POP_VLAN action. The test uses\nthe VLAN sub-interface of a veth pair to generate 802.1Q tagged\nframes and verifies that pop_vlan correctly strips the VLAN tag\nbefore delivery via pcap frame capture.\n\nThe test has two verifications:\n- Negative: forward tagged frames without pop_vlan, verify the\n VLAN tag is still present on the egress interface.\n- Positive: apply pop_vlan, verify the tag is removed and an\n untagged ICMP echo request arrives at the egress interface.\n\nStatic ARP entries avoid the complexity of VLAN-tagged ARP\nresolution (the egress side has no VLAN sub-interface and cannot\nprocess tagged ARP).\n\nSigned-off-by: Minxi Hou \n---\n .../selftests/net/openvswitch/openvswitch.sh | 132 ++++++++++++++++++\n 1 file changed, 132 insertions(+)","diff":"diff --git a/tools/testing/selftests/net/openvswitch/openvswitch.sh b/tools/testing/selftests/net/openvswitch/openvswitch.sh\nindex b327d3061ed5..cd614ff7b740 100755\n--- a/tools/testing/selftests/net/openvswitch/openvswitch.sh\n+++ b/tools/testing/selftests/net/openvswitch/openvswitch.sh\n@@ -27,6 +27,7 @@ tests=\"\n \tupcall_interfaces\t\t\tovs: test the upcall interfaces\n \ttunnel_metadata\t\t\t\tovs: test extraction of tunnel metadata\n \tdrop_reason\t\t\t\tdrop: test drop reasons are emitted\n+\tpop_vlan\t\t\t\t\tvlan-pop: POP_VLAN action strips 802.1Q tag\n \tpsample\t\t\t\t\tpsample: Sampling packets with psample\"\n \n info() {\n@@ -830,6 +831,137 @@ test_tunnel_metadata() {\n \treturn 0\n }\n \n+test_pop_vlan() {\n+\tmodprobe -q openvswitch 2>/dev/null || true\n+\t[ -d /sys/module/openvswitch ] || return $ksft_skip\n+\tip netns add __test_pop_vlan_netns__ 2>/dev/null || \\\n+\t\t{ info \"CONFIG_NET_NS missing\"; return $ksft_skip; }\n+\tip netns del __test_pop_vlan_netns__ 2>/dev/null\n+\tmodprobe -q 8021q 2>/dev/null || true\n+\t[ -d /sys/module/8021q ] || { info \"CONFIG_VLAN_8021Q missing\"; return $ksft_skip; }\n+\n+\tlocal sbx=\"test_pop_vlan\"\n+\tsbx_add \"$sbx\" || return $ksft_skip\n+\tovs_add_dp \"$sbx\" vlandp || return 1\n+\n+\t# --- baseline: untagged forwarding ---\n+\tovs_add_netns_and_veths \"$sbx\" vlandp ns1 veth1 ns1veth 192.0.2.1/24 || return 1\n+\tovs_add_netns_and_veths \"$sbx\" vlandp ns2 veth2 ns2veth 192.0.2.2/24 || return 1\n+\n+\t# ARP + IPv4 bidirectional (all untagged)\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(1),eth(),eth_type(0x0806),arp()' '2' || return 1\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(2),eth(),eth_type(0x0806),arp()' '1' || return 1\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(1),eth(),eth_type(0x0800),ipv4()' '2' || return 1\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(2),eth(),eth_type(0x0800),ipv4()' '1' || return 1\n+\tip netns exec ns1 ping -c 3 -W 2 192.0.2.2 || return 1\n+\n+\t# --- POP_VLAN test ---\n+\t# Register cleanup before creating resources (safe on failure paths)\n+\ton_exit \"ip -n ns1 link del ns1veth.10 2>/dev/null || true\n+\t\t ip -n ns2 addr del 198.51.100.2/24 dev ns2veth 2>/dev/null || true\"\n+\n+\t# ns1: VLAN sub-interface generates tagged frames\n+\tip -n ns1 link add link ns1veth name ns1veth.10 type vlan id 10\n+\tip -n ns1 addr add 198.51.100.1/24 dev ns1veth.10\n+\tip -n ns1 link set ns1veth.10 up\n+\n+\t# ns2: no VLAN sub-interface. POP delivers untagged frames to ns2veth\n+\tip -n ns2 addr add 198.51.100.2/24 dev ns2veth\n+\n+\t# veth disable VLAN offload + GRO (ensure kernel software tag processing)\n+\tif command -v ethtool >/dev/null 2>&1; then\n+\t\tip netns exec ns1 ethtool -k ns1veth 2>/dev/null | grep -q vlan-offload && \\\n+\t\t\tip netns exec ns1 ethtool -K ns1veth rx-vlan-offload off \\\n+\t\t\t\ttx-vlan-offload off gro off 2>/dev/null || true\n+\t\tip netns exec ns2 ethtool -k ns2veth 2>/dev/null | grep -q vlan-offload && \\\n+\t\t\tip netns exec ns2 ethtool -K ns2veth rx-vlan-offload off \\\n+\t\t\t\ttx-vlan-offload off gro off 2>/dev/null || true\n+\tfi\n+\n+\tovs_del_flows \"$sbx\" vlandp\n+\n+\t# Static ARP avoids VLAN-tagged ARP complexity (ns2 has no VLAN\n+\t# sub-interface, so tagged ARP would be invisible to ns2).\n+\tlocal ns1veth10mac ns2mac\n+\tns1veth10mac=$(ip -n ns1 link show ns1veth.10 | \\\n+\t\tawk '/link\\/ether/ {print $2}')\n+\tns2mac=$(ip -n ns2 link show ns2veth | \\\n+\t\tawk '/link\\/ether/ {print $2}')\n+\t[ -n \"$ns1veth10mac\" ] && echo \"$ns1veth10mac\" | \\\n+\t\tgrep -qE \"^([0-9a-fA-F]{2}:){5}[0-9a-fA-F]{2}$\" || return 1\n+\t[ -n \"$ns2mac\" ] && echo \"$ns2mac\" | \\\n+\t\tgrep -qE \"^([0-9a-fA-F]{2}:){5}[0-9a-fA-F]{2}$\" || return 1\n+\tip -n ns1 neigh replace 198.51.100.2 lladdr \"$ns2mac\" \\\n+\t\tdev ns1veth.10 nud permanent || return 1\n+\tip -n ns2 neigh replace 198.51.100.1 lladdr \"$ns1veth10mac\" \\\n+\t\tdev ns2veth nud permanent || return 1\n+\n+\t# --- Negative check: fwd without pop_vlan, VLAN tag stays ---\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(1),eth(),eth_type(0x8100),vlan(vid=10),encap(eth_type(0x0800),ipv4(src=198.51.100.1,proto=1),icmp())' \\\n+\t\t'2' || return 1\n+\n+\tlocal pcap_no_pop\n+\tpcap_no_pop=$(mktemp --suffix=.pcap)\n+\ton_exit \"rm -f $pcap_no_pop\"\n+\tip netns exec ns2 tcpdump -nei ns2veth -w \"$pcap_no_pop\" -U &\n+\tlocal tpid_no_pop=$!\n+\ton_exit \"kill $tpid_no_pop 2>/dev/null || true\"\n+\tsleep $((WAIT_TIMEOUT / 5 < 2 ? 2 : WAIT_TIMEOUT / 5))\n+\n+\tip netns exec ns1 ping -I ns1veth.10 -c 3 -W 1 198.51.100.2 \\\n+\t\t>/dev/null 2>&1 || true\n+\tkill $tpid_no_pop 2>/dev/null || true; wait $tpid_no_pop 2>/dev/null || true\n+\n+\t# assert: VLAN tag still present (no pop_vlan in action)\n+\ttcpdump -nr \"$pcap_no_pop\" 'vlan' 2>/dev/null | grep -q . || {\n+\t\tinfo \"FAIL: negative check: no VLAN tag (expected tag present)\"; return 1\n+\t}\n+\n+\tovs_del_flows \"$sbx\" vlandp\n+\n+\t# --- Positive: pop_vlan strips tag ---\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(1),eth(),eth_type(0x8100),vlan(vid=10),encap(eth_type(0x0800),ipv4(src=198.51.100.1,proto=1),icmp())' \\\n+\t\t'pop_vlan,2' || return 1\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(2),eth(),eth_type(0x0800),ipv4()' '1' || return 1\n+\n+\tlocal pcap\n+\tpcap=$(mktemp --suffix=.pcap)\n+\ton_exit \"rm -f $pcap\"\n+\tip netns exec ns2 tcpdump -nei ns2veth -w \"$pcap\" -U &\n+\tlocal tpid=$!\n+\ton_exit \"kill $tpid 2>/dev/null || true\"\n+\tsleep $((WAIT_TIMEOUT / 5 < 2 ? 2 : WAIT_TIMEOUT / 5))\n+\n+\t# ping reply unreachable: ns1veth.10 only accepts tagged frames,\n+\t# ns2 sends untagged reply -> dropped by ns1veth.10.\n+\tlocal ping_rc=0\n+\tip netns exec ns1 ping -I ns1veth.10 -c 3 -W 1 198.51.100.2 \\\n+\t\t>/dev/null 2>&1 || ping_rc=$?\n+\tkill $tpid 2>/dev/null || true; wait $tpid 2>/dev/null || true\n+\n+\t# ping failure is expected (reply path asymmetric)\n+\t[ \"$ping_rc\" -ne 0 ] || \\\n+\t\tinfo \"NOTE: ping succeeded unexpectedly (reply reached ns1veth.10)\"\n+\n+\t# assert: no VLAN tag (POP succeeded), untagged ICMP echo request arrived\n+\ttcpdump -nr \"$pcap\" 'vlan' 2>/dev/null | grep -q . && {\n+\t\tinfo \"FAIL: POP_VLAN: VLAN tag still present\"; return 1\n+\t}\n+\ttcpdump -nr \"$pcap\" 'icmp and icmp[icmptype]=8' \\\n+\t\t2>/dev/null | grep -q . || {\n+\t\tinfo \"FAIL: POP_VLAN: no untagged ICMP echo request\"; return 1\n+\t}\n+\n+\treturn 0\n+}\n+\n run_test() {\n \t(\n \ttname=\"$1\"\n","prefixes":["ovs-dev","2/2"]}