{"id":2228536,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2228536/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ide/patch/20260426190920.2051289-5-philpem@philpem.me.uk/","project":{"id":13,"url":"http://patchwork.ozlabs.org/api/1.2/projects/13/?format=json","name":"Linux IDE development","link_name":"linux-ide","list_id":"linux-ide.vger.kernel.org","list_email":"linux-ide@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260426190920.2051289-5-philpem@philpem.me.uk>","list_archive_url":null,"date":"2026-04-26T19:09:17","name":"[v3,4/7] scsi: add BLIST_NO_LUN_1F blacklist flag","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"71115797945aed39645ee4ea8362724e81171b53","submitter":{"id":93108,"url":"http://patchwork.ozlabs.org/api/1.2/people/93108/?format=json","name":"Phil Pemberton","email":"philpem@philpem.me.uk"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ide/patch/20260426190920.2051289-5-philpem@philpem.me.uk/mbox/","series":[{"id":501551,"url":"http://patchwork.ozlabs.org/api/1.2/series/501551/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ide/list/?series=501551","date":"2026-04-26T19:09:18","name":"ata: libata-scsi: multi-LUN ATAPI device support","version":3,"mbox":"http://patchwork.ozlabs.org/series/501551/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228536/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228536/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ide@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=philpem.me.uk header.i=@philpem.me.uk\n header.a=rsa-sha256 header.s=mail header.b=a/kAFWmx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ide+bounces-5537-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=philpem.me.uk header.i=@philpem.me.uk\n header.b=\"a/kAFWmx\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=178.62.38.78","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=philpem.me.uk","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=philpem.me.uk"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3bvy68W0z1yHg\n\tfor ; Mon, 27 Apr 2026 05:13:50 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 5939C30480F0\n\tfor ; Sun, 26 Apr 2026 19:09:46 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id F09C937C90C;\n\tSun, 26 Apr 2026 19:09:40 +0000 (UTC)","from nick.sneptech.io (nick.sneptech.io [178.62.38.78])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E4D3837BE6A;\n\tSun, 26 Apr 2026 19:09:36 +0000 (UTC)","from wolf.philpem.me.uk (81-187-163-148.ip4.reverse-dns.uk\n [81.187.163.148])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits))\n\t(No client certificate requested)\n\t(Authenticated sender: mailrelay_wolf@philpem.me.uk)\n\tby nick.sneptech.io (Postfix) with ESMTPSA id 83174BE5D7;\n\tSun, 26 Apr 2026 19:09:29 +0000 (UTC)","from cheetah.homenet.philpem.me.uk (cheetah.homenet.philpem.me.uk\n [10.0.0.32])\n\tby wolf.philpem.me.uk (Postfix) with ESMTPSA id 314E25FC56;\n\tSun, 26 Apr 2026 20:09:29 +0100 (BST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777230580; cv=none;\n b=d9SlhErFQFWTWs0GETQj/5xPr88yhBp/sQuzN4/BrMEUqgLdV4ozGQriThWHFIP77fAC0Ye8KX66kAcTVu9XMapWMtcvBHF1IRzWHkeFX58nvtNCHZskQj75OQUrrdMbNdMmnoxVvNPN6Iyg/aeWJAxmSKpE7NPvH7xGEwgyN2M=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777230580; c=relaxed/simple;\n\tbh=f+CG9Amv2WmTE/Mh+QJe3KaJuRDqAPb8S1O+7kMivFU=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=YbRn0/Eq4hvEowZC6YK5EWJUrFiv5Lwhajb2RSaV+EJESkeaPRoQuMCsw0zVnrx0SGDLOfNAxKdEqtuKF+Awh6ZUJdmm477N6JhvCvueh1LWbWcRF1nDz+JxFccxR62Vt2kGF8n7OLlRuPsJKZICuEtfh5xECLEuY9kMAmUvFj4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=philpem.me.uk;\n spf=pass smtp.mailfrom=philpem.me.uk;\n dkim=pass (1024-bit key) header.d=philpem.me.uk header.i=@philpem.me.uk\n header.b=a/kAFWmx; arc=none smtp.client-ip=178.62.38.78","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=philpem.me.uk;\n\ts=mail; t=1777230569;\n\tbh=f+CG9Amv2WmTE/Mh+QJe3KaJuRDqAPb8S1O+7kMivFU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=a/kAFWmxAI3Z5zTkBrwGhzr7Q9QWP/XGAbI2tiv4ahh3E2bY0v2nx56DuN4oS8Ar1\n\t 3iF08x9g6ZbsFRWP9UU3TXHjEQqZqjzLTAegXEf3IVkW9PScMTnjcgEgO04h2S25Ol\n\t LDIg5GANxLDoDm0edCeTjqNmPVXZn65AFysw7Mlw=","From":"Phil Pemberton ","To":"linux-ide@vger.kernel.org,\n\tlinux-scsi@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org,\n\tDamien Le Moal ,\n\tNiklas Cassel ,\n\t\"James E . J . Bottomley\" ,\n\t\"Martin K . Petersen\" ,\n\tHannes Reinecke ,\n\tPhil Pemberton ","Subject":"[PATCH v3 4/7] scsi: add BLIST_NO_LUN_1F blacklist flag","Date":"Sun, 26 Apr 2026 20:09:17 +0100","Message-ID":"<20260426190920.2051289-5-philpem@philpem.me.uk>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260426190920.2051289-1-philpem@philpem.me.uk>","References":"<20260426190920.2051289-1-philpem@philpem.me.uk>","Precedence":"bulk","X-Mailing-List":"linux-ide@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Some multi-LUN devices respond to INQUIRY on unpopulated LUNs with\nPQ=0 / PDT=0x1f instead of the standard PQ=3. The SCSI scan layer\nnormally adds such devices (PQ=0 means \"connected\"), producing\nspurious \"No Device\" entries.\n\nThe scsi_target field pdt_1f_for_no_lun already exists to suppress\nthis, but was previously only set by the USB UFI driver.\n\nAdd BLIST_NO_LUN_1F so the flag can be set per-device from\nscsi_devinfo, and wire it up in scsi_add_lun() to set\nstarget->pdt_1f_for_no_lun from the blacklist flags. This runs\nduring LUN 0 processing, before the sequential LUN scan probes\nhigher LUNs.\n\nSigned-off-by: Phil Pemberton \n---\n drivers/scsi/scsi_scan.c | 3 +++\n include/scsi/scsi_devinfo.h | 6 +++---\n 2 files changed, 6 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c\nindex 7b11bc7de0e3..d3f0540d79a2 100644\n--- a/drivers/scsi/scsi_scan.c\n+++ b/drivers/scsi/scsi_scan.c\n@@ -1070,6 +1070,9 @@ static int scsi_add_lun(struct scsi_device *sdev, unsigned char *inq_result,\n \n \tsdev->sdev_bflags = *bflags;\n \n+\tif (*bflags & BLIST_NO_LUN_1F)\n+\t\tsdev->sdev_target->pdt_1f_for_no_lun = 1;\n+\n \tif (scsi_device_is_pseudo_dev(sdev))\n \t\treturn SCSI_SCAN_LUN_PRESENT;\n \ndiff --git a/include/scsi/scsi_devinfo.h b/include/scsi/scsi_devinfo.h\nindex 1d79a3b536ce..6957b0705510 100644\n--- a/include/scsi/scsi_devinfo.h\n+++ b/include/scsi/scsi_devinfo.h\n@@ -34,7 +34,8 @@\n #define BLIST_NOSTARTONADD\t((__force blist_flags_t)(1ULL << 12))\n /* do not ask for VPD page size first on some broken targets */\n #define BLIST_NO_VPD_SIZE\t((__force blist_flags_t)(1ULL << 13))\n-#define __BLIST_UNUSED_14\t((__force blist_flags_t)(1ULL << 14))\n+/* PDT 0x1f with PQ 0 means no LUN present (e.g. some ATAPI multi-LUN) */\n+#define BLIST_NO_LUN_1F\t\t((__force blist_flags_t)(1ULL << 14))\n #define __BLIST_UNUSED_15\t((__force blist_flags_t)(1ULL << 15))\n #define __BLIST_UNUSED_16\t((__force blist_flags_t)(1ULL << 16))\n /* try REPORT_LUNS even for SCSI-2 devs (if HBA supports more than 8 LUNs) */\n@@ -77,8 +78,7 @@\n #define __BLIST_HIGH_UNUSED (~(__BLIST_LAST_USED | \\\n \t\t\t (__force blist_flags_t) \\\n \t\t\t ((__force __u64)__BLIST_LAST_USED - 1ULL)))\n-#define __BLIST_UNUSED_MASK (__BLIST_UNUSED_14 | \\\n-\t\t\t __BLIST_UNUSED_15 | \\\n+#define __BLIST_UNUSED_MASK (__BLIST_UNUSED_15 | \\\n \t\t\t __BLIST_UNUSED_16 | \\\n \t\t\t __BLIST_UNUSED_24 | \\\n \t\t\t __BLIST_UNUSED_27 | \\\n","prefixes":["v3","4/7"]}