{"id":2228513,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2228513/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260426154054.2040932-4-dario.binacchi@amarulasolutions.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260426154054.2040932-4-dario.binacchi@amarulasolutions.com>","list_archive_url":null,"date":"2026-04-26T15:40:35","name":"[v6,3/8] test: cmd: add unit tests for part command","commit_ref":null,"pull_url":null,"state":"needs-review-ack","archived":true,"hash":"e7817ee5ee678d70bbca5b52ddcd25491374cb49","submitter":{"id":83038,"url":"http://patchwork.ozlabs.org/api/1.2/people/83038/?format=json","name":"Dario Binacchi","email":"dario.binacchi@amarulasolutions.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260426154054.2040932-4-dario.binacchi@amarulasolutions.com/mbox/","series":[{"id":501545,"url":"http://patchwork.ozlabs.org/api/1.2/series/501545/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=501545","date":"2026-04-26T15:40:32","name":"Support metadata-driven A/B boot for STM32MP25","version":6,"mbox":"http://patchwork.ozlabs.org/series/501545/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2228513/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2228513/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com\n header.a=rsa-sha256 header.s=google header.b=djbIriXn;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=amarulasolutions.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com\n header.b=\"djbIriXn\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=none dis=none)\n header.from=amarulasolutions.com","phobos.denx.de; spf=pass\n smtp.mailfrom=dario.binacchi@amarulasolutions.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3WBx0Rf4z1yHg\n\tfor ; Mon, 27 Apr 2026 01:41:29 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 2033984120;\n\tSun, 26 Apr 2026 17:41:09 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 4D0CB84119; Sun, 26 Apr 2026 17:41:06 +0200 (CEST)","from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n [IPv6:2a00:1450:4864:20::334])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2C33584236\n for ; Sun, 26 Apr 2026 17:41:04 +0200 (CEST)","by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-4891e86fabeso99170625e9.1\n for ; Sun, 26 Apr 2026 08:41:04 -0700 (PDT)","from dario-ThinkPad-P14s-Gen-5.amarulasolutions.com\n (host-82-56-22-134.retail.telecomitalia.it. [82.56.22.134])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4891bb3d121sm802593765e9.14.2026.04.26.08.41.02\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 08:41:02 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amarulasolutions.com; s=google; t=1777218063; x=1777822863;\n darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=IVsjyrw/fL525sUdL9iFA9duSvhB3yIwLOw0Mn9NBrE=;\n b=djbIriXn7P94tiDnpkcCPA5PqvgBkqv9ntLn49v7QULXzHOnQEbsZICLTrlilmJaCB\n WkAPZiVpZZtpqE56rPrs+LmksYeskJBLcp9CFSBKIaboOTC9fBambtqmtIyOgzkp5yBJ\n 9WWR1uSl78VNLnNbjE/OohjU7vzhQ4MVx20fE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777218063; x=1777822863;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=IVsjyrw/fL525sUdL9iFA9duSvhB3yIwLOw0Mn9NBrE=;\n b=kr8/1GuB5jKMHS2k4S0wIL7oRJH8mWCUxM+8DHXDrIAU0+cDZsFxqB1tYnCGR/TKSJ\n iYnZzUcOFkmknUY8BVPYcC4zjPRRELi89mXCV9c9AxfTlJNAfQHshkls2EiPWe7kiYHM\n WNaLieQuh1g7tzMb9/soXpJG0cWmZvjBWl8C61pasgX0pG7IJZRz2DGkDgKikwpShtNV\n fM/AfwGT/rQgXOIcCgHlnOUg4WLK0xc5cAEw9mTdfKsBYOQzkgNIUg5hwZBmq/Ut4IHG\n PV9WLBzjsKxS7hmaXtyLz2im0x9KiI2GeBfR+WMuDA/CGzVu233k5yz1ez73q+bLD6X0\n 8crA==","X-Gm-Message-State":"AOJu0YxkRgK77mMLSExEY1hs/s+ikgTaxKFUR6MSDNTZ8h5InEWFTL0a\n ceBsaN1djUa/r82z/aOX6Xjav5ljficK9P1kvj45hIVTqCQaWEztVznz1degk8ImLHe0hi8+4XC\n jR6lN","X-Gm-Gg":"AeBDiev9NxQuS/usZIQQfih3ISQ16ZMgnIf7H1oLxDQa5R9RKQZwhU4FzqsbAL/lh5Q\n 30Vw7Wz3mW7JqgMbsU1EcMDj33Peb6ddjTi8acDD/xF7mzLfr9lYS71q4c7i9BlDXkPfDSMYJy9\n mVc6Yy982/e+lD9Q6Y9ZaOnlUdVvydqhvvurEDRDWZdfwwCOFTckBoUVDNcHnykYyv8L9GBq6BG\n piLNfbGLWabEHXFJzDmTYAtq1lxYwjibDkzH7zt8Fyj1o9hPWVIlRqpn4HiIGRt+GD891hsEXzD\n uzE3dC4Rcx1+I+cTByTz3WkFn5AmT3YtHKd+oCqlvT6t2L6uUKy2shSrCnul6m15vSlx7dnkvBw\n msuNbDRwKl4DOXgcC3UYTu4qlCKRIbMkUQylAXQwae9xTIu6T9I7CDH/eVsjMY/LnLtAGNs88CB\n pytnWdN0eXU1JvriirHdEHbw7HgDigI58rG/b0wb+xwKFb6OekZqTQcBItAJ9G/dlBX8YOT01GY\n dlJazHa96WOrNcrI8/pfai7oQ8BJRYjBSiO6lmwF5bWSs2EjemRgQESOG+8L01mYupIN1fAT3R/\n 6tGWrPhOPrr70BpaF+Uj1zOicS2mWw==","X-Received":"by 2002:a05:600c:444a:b0:487:1520:d107 with SMTP id\n 5b1f17b1804b1-488fb793580mr532118375e9.31.1777218063324;\n Sun, 26 Apr 2026 08:41:03 -0700 (PDT)","From":"Dario Binacchi ","To":"u-boot@lists.denx.de","Cc":"linux-amarula@amarulasolutions.com,\n Dario Binacchi ,\n Simon Glass , Bin Meng ,\n Dinesh Maniyam ,\n Heinrich Schuchardt ,\n Marek Vasut ,\n Mattijs Korpershoek ,\n Tom Rini ","Subject":"[PATCH v6 3/8] test: cmd: add unit tests for part command","Date":"Sun, 26 Apr 2026 17:40:35 +0200","Message-ID":"<20260426154054.2040932-4-dario.binacchi@amarulasolutions.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260426154054.2040932-1-dario.binacchi@amarulasolutions.com>","References":"<20260426154054.2040932-1-dario.binacchi@amarulasolutions.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Add unit tests for the 'part' command, specifically for the 'number',\n'start', and 'size' subcommands.\n\nThese tests establish a baseline for the current partition lookup\nfunctionality by name. This foundation will be used by subsequent\npatches to extend the command, ensuring consistent behavior as new\nfeatures are introduced.\n\nSigned-off-by: Dario Binacchi \nReviewed-by: Simon Glass \n\n---\n\nChanges in v6:\n- Add Reviewed-by of Simon Glass to patch 3/8 \"test: cmd: add unit\n tests for part command\"\n\nChanges in v4:\n- Place the part command tests in the cmd suite rather than the dm\n suite.\n- Order the include files according the U-Boot coding style.\n\nChanges in v3:\n- Wrap the lines exceeding 80 columns\n- Combine run_command() and ut_asserteq() -> ut_asserteq(1, run_command(\n\n test/cmd/Makefile | 1 +\n test/cmd/part.c | 165 ++++++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 166 insertions(+)\n create mode 100644 test/cmd/part.c","diff":"diff --git a/test/cmd/Makefile b/test/cmd/Makefile\nindex 8c9f112782d0..41fe21a4541e 100644\n--- a/test/cmd/Makefile\n+++ b/test/cmd/Makefile\n@@ -26,6 +26,7 @@ obj-$(CONFIG_CMD_LOADM) += loadm.o\n obj-$(CONFIG_CMD_MEMINFO) += meminfo.o\n obj-$(CONFIG_CMD_MEMORY) += mem_copy.o\n obj-$(CONFIG_CMD_MEM_SEARCH) += mem_search.o\n+obj-$(CONFIG_CMD_PART) += part.o\n ifdef CONFIG_CMD_PCI\n obj-$(CONFIG_CMD_PCI_MPS) += pci_mps.o\n endif\ndiff --git a/test/cmd/part.c b/test/cmd/part.c\nnew file mode 100644\nindex 000000000000..5751dd315dd8\n--- /dev/null\n+++ b/test/cmd/part.c\n@@ -0,0 +1,165 @@\n+// SPDX-License-Identifier: GPL-2.0+\n+/*\n+ * Test for part command\n+ *\n+ * Copyright (C) 2026 Amarula Solutions\n+ * Written by Dario Binacchi \n+ */\n+\n+#include \n+#include \n+#include \n+#include \n+#include \n+#include \n+#include \n+#include \n+#include \n+\n+static struct disk_partition gpt_parts[] = {\n+\t{\n+\t\t.start = 48,\n+\t\t.size = 1,\n+\t\t.name = \"test1\",\n+\t\t.uuid = \"c5bce7a2-03f0-4d03-9048-01ff23b9d527\",\n+\t},\n+\t{\n+\t\t.start = 49,\n+\t\t.size = 2,\n+\t\t.name = \"test2\",\n+\t\t.uuid = \"9df346e8-2c53-4cd8-b9ac-3af83f9a9b74\",\n+\t},\n+};\n+\n+static char disk_guid[UUID_STR_LEN + 1] =\n+\t\"8d60b397-1bb6-4d33-80ee-b1587d24c2f8\";\n+\n+static int setup_gpt_partitions(struct unit_test_state *uts,\n+\t\t\t\tunsigned int mmc_dev_num)\n+{\n+\tstruct blk_desc *mmc_dev_desc;\n+\tchar dev_str[10];\n+\tint i;\n+\n+\tsnprintf(dev_str, sizeof(dev_str), \"%u\", mmc_dev_num);\n+\n+\tut_asserteq(mmc_dev_num, blk_get_device_by_str(\"mmc\", dev_str,\n+\t\t\t\t\t\t &mmc_dev_desc));\n+\n+\tif (CONFIG_IS_ENABLED(RANDOM_UUID)) {\n+\t\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++)\n+\t\t\tgen_rand_uuid_str(gpt_parts[i].uuid,\n+\t\t\t\t\t UUID_STR_FORMAT_STD);\n+\n+\t\tgen_rand_uuid_str(disk_guid, UUID_STR_FORMAT_STD);\n+\t}\n+\n+\tut_assertok(gpt_restore(mmc_dev_desc, disk_guid, gpt_parts,\n+\t\t\t\tARRAY_SIZE(gpt_parts)));\n+\treturn 0;\n+}\n+\n+static int cmd_test_part_number(struct unit_test_state *uts)\n+{\n+\tunsigned int mmc_dev_num = 2;\n+\tchar expected[10];\n+\tint i;\n+\n+\tut_assertok(setup_gpt_partitions(uts, mmc_dev_num));\n+\n+\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++) {\n+\t\tenv_set(\"partnum\", NULL);\n+\t\tut_assertok(run_commandf(\"part number mmc %u %s partnum\",\n+\t\t\t\t\t mmc_dev_num, gpt_parts[i].name));\n+\t\tsnprintf(expected, sizeof(expected), \"0x%x\", i + 1);\n+\t\tut_asserteq_str(expected, env_get(\"partnum\"));\n+\t}\n+\n+\tenv_set(\"partnum\", NULL);\n+\tut_asserteq(1, run_commandf(\"part number mmc %u bogus partnum\",\n+\t\t\t\t mmc_dev_num));\n+\tut_assertnull(env_get(\"partnum\"));\n+\n+\treturn 0;\n+}\n+CMD_TEST(cmd_test_part_number, UTF_CONSOLE);\n+\n+static int cmd_test_part_start(struct unit_test_state *uts)\n+{\n+\tunsigned int mmc_dev_num = 2;\n+\tchar expected[32];\n+\tint i;\n+\n+\tut_assertok(setup_gpt_partitions(uts, mmc_dev_num));\n+\n+\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++) {\n+\t\tenv_set(\"partstart\", NULL);\n+\t\tut_assertok(run_commandf(\"part start mmc %u %d partstart\",\n+\t\t\t\t\t mmc_dev_num, i + 1));\n+\t\tsnprintf(expected, sizeof(expected), \"%lx\",\n+\t\t\t (unsigned long)gpt_parts[i].start);\n+\t\tut_asserteq_str(expected, env_get(\"partstart\"));\n+\t}\n+\n+\tenv_set(\"partstart\", NULL);\n+\tut_asserteq(1, run_commandf(\"part start mmc %u 3 partstart\",\n+\t\t\t\t mmc_dev_num));\n+\tut_assertnull(env_get(\"partstart\"));\n+\n+\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++) {\n+\t\tenv_set(\"partstart\", NULL);\n+\t\tut_assertok(run_commandf(\"part start mmc %u %s partstart\",\n+\t\t\t\t\t mmc_dev_num, gpt_parts[i].name));\n+\t\tsnprintf(expected, sizeof(expected), \"%lx\",\n+\t\t\t (unsigned long)gpt_parts[i].start);\n+\t\tut_asserteq_str(expected, env_get(\"partstart\"));\n+\t}\n+\n+\tenv_set(\"partstart\", NULL);\n+\tut_asserteq(1, run_commandf(\"part start mmc %u bogus partstart\",\n+\t\t\t\t mmc_dev_num));\n+\tut_assertnull(env_get(\"partstart\"));\n+\n+\treturn 0;\n+}\n+CMD_TEST(cmd_test_part_start, UTF_CONSOLE);\n+\n+static int cmd_test_part_size(struct unit_test_state *uts)\n+{\n+\tunsigned int mmc_dev_num = 2;\n+\tchar expected[32];\n+\tint i;\n+\n+\tut_assertok(setup_gpt_partitions(uts, mmc_dev_num));\n+\n+\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++) {\n+\t\tenv_set(\"partsize\", NULL);\n+\t\tut_assertok(run_commandf(\"part size mmc %u %d partsize\",\n+\t\t\t\t\t mmc_dev_num, i + 1));\n+\t\tsnprintf(expected, sizeof(expected), \"%lx\",\n+\t\t\t (unsigned long)gpt_parts[i].size);\n+\t\tut_asserteq_str(expected, env_get(\"partsize\"));\n+\t}\n+\n+\tenv_set(\"partsize\", NULL);\n+\tut_asserteq(1, run_commandf(\"part size mmc %u 3 partsize\",\n+\t\t\t\t mmc_dev_num));\n+\tut_assertnull(env_get(\"partsize\"));\n+\n+\tfor (i = 0; i < ARRAY_SIZE(gpt_parts); i++) {\n+\t\tenv_set(\"partsize\", NULL);\n+\t\tut_assertok(run_commandf(\"part size mmc %u %s partsize\",\n+\t\t\t\t\t mmc_dev_num, gpt_parts[i].name));\n+\t\tsnprintf(expected, sizeof(expected), \"%lx\",\n+\t\t\t (unsigned long)gpt_parts[i].size);\n+\t\tut_asserteq_str(expected, env_get(\"partsize\"));\n+\t}\n+\n+\tenv_set(\"partsize\", NULL);\n+\tut_asserteq(1, run_commandf(\"part size mmc %u bogus partsize\",\n+\t\t\t\t mmc_dev_num));\n+\tut_assertnull(env_get(\"partsize\"));\n+\n+\treturn 0;\n+}\n+CMD_TEST(cmd_test_part_size, UTF_CONSOLE);\n","prefixes":["v6","3/8"]}