{"id":2227971,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2227971/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260424154205.364268-15-berrange@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260424154205.364268-15-berrange@redhat.com>","list_archive_url":null,"date":"2026-04-24T15:42:02","name":"[14/16] tests: add QEMU_TEST_IO_SKIP for skipping I/O tests","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"055473d36bfb41b42299140bdd6603f426c6bb81","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/1.2/people/2694/?format=json","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260424154205.364268-15-berrange@redhat.com/mbox/","series":[{"id":501385,"url":"http://patchwork.ozlabs.org/api/1.2/series/501385/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501385","date":"2026-04-24T15:41:48","name":"tests: do more testing of block drivers","version":1,"mbox":"http://patchwork.ozlabs.org/series/501385/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227971/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227971/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=QOVyRjJ7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2HNB5GYdz1yDD\n\tfor ; Sat, 25 Apr 2026 01:45:14 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGIgt-0003r3-2T; Fri, 24 Apr 2026 11:43:39 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGIgT-00033b-Dr\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 11:43:18 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGIgR-0007aV-R7\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 11:43:13 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-f9PxNB7cNAauIfBTgHqajw-1; Fri,\n 24 Apr 2026 11:43:04 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id D313719560B0; Fri, 24 Apr 2026 15:43:03 +0000 (UTC)","from thinkbook.redhat.com (unknown [10.44.32.213])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 62C3E1800348; Fri, 24 Apr 2026 15:43:00 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777045386;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ujhNceZbLZrk0rqVrTeJI7/TEiCjUeSwasyi8BpHUyw=;\n b=QOVyRjJ7v/jO25A8nk8S8lHO3xV+moONxZFSYN7gt2pE7kng4zK5bqR0/dpmNqEbWjFeyi\n Qa6H1Po39CYfGnMNoopwRJAVyGMdWAW5iOkWpyHHY1Y/wdxVISUthUSEtZPde8bbmLJ/yk\n CQbQ76XdYRS92ejdHyiPDsYpZMUwomY=","X-MC-Unique":"f9PxNB7cNAauIfBTgHqajw-1","X-Mimecast-MFC-AGG-ID":"f9PxNB7cNAauIfBTgHqajw_1777045383","From":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Hanna Reitz ,\n Pierrick Bouvier , =?utf-8?q?Alex_Benn?=\n\t=?utf-8?q?=C3=A9e?= , qemu-block@nongnu.org,\n Cleber Rosa , Kevin Wolf ,\n John Snow , Paolo Bonzini ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Dani?=\n\t=?utf-8?q?el_P=2E_Berrang=C3=A9?= ,\n Thomas Huth ","Subject":"[PATCH 14/16] tests: add QEMU_TEST_IO_SKIP for skipping I/O tests","Date":"Fri, 24 Apr 2026 16:42:02 +0100","Message-ID":"<20260424154205.364268-15-berrange@redhat.com>","In-Reply-To":"<20260424154205.364268-1-berrange@redhat.com>","References":"<20260424154205.364268-1-berrange@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"12","X-Spam_score":"1.2","X-Spam_bar":"+","X-Spam_report":"(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The nature of block I/O tests is such that there can be unexpected false\npositive failures in certain scenarios that have not been encountered\nbefore, and sometimes non-deterministic failures that are hard to\nreproduce.\n\nBefore enabling the I/O tests as gating jobs in CI, there needs to be a\nmechanism to dynamically mark tests as skipped, without having to commit\ncode changes.\n\nThis introduces the QEMU_TEST_IO_SKIP environment variable that is set\nto a list of FORMAT-OR-PROTOCOL:NAME pairs. The intent is that this\nvariable can be set as a GitLab CI pipeline variable to temporarily\ndisable a test while problems are being debugged.\n\nReviewed-by: Thomas Huth \nSigned-off-by: Daniel P. Berrangé \n---\n docs/devel/testing/main.rst | 7 +++++++\n tests/qemu-iotests/testrunner.py | 16 ++++++++++++++++\n 2 files changed, 23 insertions(+)","diff":"diff --git a/docs/devel/testing/main.rst b/docs/devel/testing/main.rst\nindex 797111009a..f779a64415 100644\n--- a/docs/devel/testing/main.rst\n+++ b/docs/devel/testing/main.rst\n@@ -284,6 +284,13 @@ that are specific to certain cache mode.\n More options are supported by the ``./check`` script, run ``./check -h`` for\n help.\n \n+If a test program is known to be broken, it can be disabled by setting\n+the ``QEMU_TEST_IO_SKIP`` environment variable with a list of tests to\n+be skipped. The values are of the form FORMAT-OR-PROTOCOL:NAME, the\n+leading component can be omitted to skip the test for all formats and\n+protocols. For example ``export QEMU_TEST_IO_SKIP=\"luks:149 185 iov-padding``\n+will skip ``149`` for LUKS only, and ``185`` and ``iov-padding`` for all.\n+\n Writing a new test case\n ~~~~~~~~~~~~~~~~~~~~~~~\n \ndiff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu-iotests/testrunner.py\nindex dbe2dddc32..ecb5d4529f 100644\n--- a/tests/qemu-iotests/testrunner.py\n+++ b/tests/qemu-iotests/testrunner.py\n@@ -145,6 +145,18 @@ def __init__(self, env: TestEnv, tap: bool = False,\n \n self._stack: contextlib.ExitStack\n \n+ self.skip = {}\n+ for rule in os.environ.get(\"QEMU_TEST_IO_SKIP\", \"\").split(\" \"):\n+ rule = rule.strip()\n+ if rule == \"\":\n+ continue\n+ if \":\" in rule:\n+ fmt, name = rule.split(\":\")\n+ if fmt in (\"\", env.imgfmt, env.imgproto):\n+ self.skip[name] = True\n+ else:\n+ self.skip[rule] = True\n+\n def __enter__(self) -> 'TestRunner':\n self._stack = contextlib.ExitStack()\n self._stack.enter_context(self.env)\n@@ -251,6 +263,10 @@ def do_run_test(self, test: str) -> TestResult:\n description='No qualified output '\n f'(expected {f_reference})')\n \n+ if f_test.name in self.skip:\n+ return TestResult(status='not run',\n+ description='Listed in QEMU_TEST_IO_SKIP')\n+\n args = [str(f_test.resolve())]\n env = self.env.prepare_subprocess(args)\n \n","prefixes":["14/16"]}