{"id":2227966,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2227966/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260424154205.364268-12-berrange@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260424154205.364268-12-berrange@redhat.com>","list_archive_url":null,"date":"2026-04-24T15:41:59","name":"[11/16] tests: use 'driver' as collective term for either format or protocol","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1d2b611c0d42435ed480b98a5965c9ac8d1f8a1c","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/1.2/people/2694/?format=json","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260424154205.364268-12-berrange@redhat.com/mbox/","series":[{"id":501385,"url":"http://patchwork.ozlabs.org/api/1.2/series/501385/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501385","date":"2026-04-24T15:41:48","name":"tests: do more testing of block drivers","version":1,"mbox":"http://patchwork.ozlabs.org/series/501385/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227966/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227966/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=hbEDOluE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2HMk2Z37z1y2d\n\tfor ; Sat, 25 Apr 2026 01:44:50 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGIgr-0003hw-Id; Fri, 24 Apr 2026 11:43:37 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGIgH-00031W-Iw\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 11:43:05 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGIgE-0007Y1-4J\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 11:42:59 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-251-n5vrdZyCNEm9_P56WF14-w-1; Fri,\n 24 Apr 2026 11:42:53 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 873421956094; Fri, 24 Apr 2026 15:42:52 +0000 (UTC)","from thinkbook.redhat.com (unknown [10.44.32.213])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 724A91800348; Fri, 24 Apr 2026 15:42:49 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777045377;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=uctAltq8QYohBCBr87onunMkAsFCdaYGeXBX/V0+D4s=;\n b=hbEDOluElLnjeaDZ1dGlDP7zxLvGPg3lbY43ck5CJ61muLaETqmiS0jFlxIZPTi5VfzjQj\n wk9NzavgtieJ1ZyFpo76rRtUdFn0Id4OUyI3FtQOPyiyC95Pj1c4koUZeO5f26L9e4OqBn\n F16u4xdj8ZJjz3AArUBrsSFDDwp3jJA=","X-MC-Unique":"n5vrdZyCNEm9_P56WF14-w-1","X-Mimecast-MFC-AGG-ID":"n5vrdZyCNEm9_P56WF14-w_1777045372","From":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Hanna Reitz ,\n Pierrick Bouvier , =?utf-8?q?Alex_Benn?=\n\t=?utf-8?q?=C3=A9e?= , qemu-block@nongnu.org,\n Cleber Rosa , Kevin Wolf ,\n John Snow , Paolo Bonzini ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Dani?=\n\t=?utf-8?q?el_P=2E_Berrang=C3=A9?= ","Subject":"[PATCH 11/16] tests: use 'driver' as collective term for either\n format or protocol","Date":"Fri, 24 Apr 2026 16:41:59 +0100","Message-ID":"<20260424154205.364268-12-berrange@redhat.com>","In-Reply-To":"<20260424154205.364268-1-berrange@redhat.com>","References":"<20260424154205.364268-1-berrange@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"12","X-Spam_score":"1.2","X-Spam_bar":"+","X-Spam_report":"(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The I/O tests integration previously exclusively tested block formats\nand now also covers the NBD protocol. Replace references to 'format'\nwith 'driver', as a generic term to collectively apply to either a\nformat or protocol.\n\nSigned-off-by: Daniel P. Berrangé \n---\n docs/devel/testing/main.rst | 13 +++++++------\n tests/Makefile.include | 4 ++--\n tests/qemu-iotests/meson.build | 6 +++---\n 3 files changed, 12 insertions(+), 11 deletions(-)","diff":"diff --git a/docs/devel/testing/main.rst b/docs/devel/testing/main.rst\nindex 8067d0a3ed..797111009a 100644\n--- a/docs/devel/testing/main.rst\n+++ b/docs/devel/testing/main.rst\n@@ -222,7 +222,8 @@ check-block\n ~~~~~~~~~~~\n \n There are a variety of ways to exercise the block layer I/O tests\n-via make targets.\n+via make targets for a selection of formats / protocols (collectively\n+referred to as ``drivers`` below).\n \n A default ``make check`` or ``make check-block`` command will exercise\n the ``qcow2`` format, using the tests tagged into the ``auto`` group\n@@ -231,14 +232,14 @@ only.\n These targets accept the ``SPEED`` variable to augment the set of tests\n to run. A slightly more comprehensive test plan can be run by defining\n ``SPEED=slow``, which enables all tests for the ``qcow2`` and ``raw``\n-formats. The most comprehensive test plan can be run by defining\n-``SPEED=thorough``, which enables all available tests for the formats\n+drivers. The most comprehensive test plan can be run by defining\n+``SPEED=thorough``, which enables all available tests for the drivers\n ``luks``, ``nbd``, ``parallels``, ``qcow2``, ``qed``, ``raw``, ``vdi``,\n ``vhdx``, ``vmdk``, and ``vpc``.\n \n-Each of formats also has its own dedicated make target, named\n-``make check-block-$FORMAT`` which will run all available tests for\n-the designated format and does not require the ``SPEED`` variable\n+Each of drivers also has its own dedicated make target, named\n+``make check-block-$DRIVER`` which will run all available tests for\n+the designated driver and does not require the ``SPEED`` variable\n to be set.\n \n See the \"QEMU iotests\" section below for more information on the\ndiff --git a/tests/Makefile.include b/tests/Makefile.include\nindex a820980bbe..a063a1d60f 100644\n--- a/tests/Makefile.include\n+++ b/tests/Makefile.include\n@@ -14,8 +14,8 @@ check-help:\n \t@echo \" $(MAKE) check-unit Run qobject tests\"\n \t@echo \" $(MAKE) check-qapi-schema Run QAPI schema tests\"\n \t@echo \" $(MAKE) check-tracetool Run tracetool generator tests\"\n-\t@echo \" $(MAKE) check-block Run block tests (all formats)\"\n-\t@echo \" $(MAKE) check-block-FORMAT Run block tests (only for FORMAT)\"\n+\t@echo \" $(MAKE) check-block Run block tests (all formats/protocols)\"\n+\t@echo \" $(MAKE) check-block-DRIVER Run block tests (only for format/protocol 'DRIVER')\"\n ifneq ($(filter $(all-check-targets), check-softfloat),)\n \t@echo \" $(MAKE) check-softfloat Run FPU emulation tests\"\n \t@echo \" $(MAKE) check-tcg Run TCG tests\"\ndiff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build\nindex 744d0b6e88..5d6b0b5ed9 100644\n--- a/tests/qemu-iotests/meson.build\n+++ b/tests/qemu-iotests/meson.build\n@@ -12,7 +12,7 @@ qemu_iotests_binaries = [qemu_img, qemu_io, qemu_nbd, qsd]\n qemu_iotests_env = {'PYTHON': python.full_path()}\n # If altering this definition, also update docs/devel/testing/main.rst\n # section on 'check-block' targets to reflect the changes\n-qemu_iotests_formats = {\n+qemu_iotests_drivers = {\n 'qcow2': 'quick',\n 'raw': 'slow',\n 'luks': 'thorough',\n@@ -33,8 +33,8 @@ endforeach\n \n qemu_iotests_check_cmd = files('check')\n \n-foreach format, speed: qemu_iotests_formats\n- # Formats tagged 'quick' get the subset of tests in the 'auto'\n+foreach format, speed: qemu_iotests_drivers\n+ # Drivers tagged 'quick' get the subset of tests in the 'auto'\n # group, run by default with 'make check' / 'make check-block'\n seen = []\n if speed == 'quick'\n","prefixes":["11/16"]}