{"id":2227959,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2227959/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260424154205.364268-14-berrange@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260424154205.364268-14-berrange@redhat.com>","list_archive_url":null,"date":"2026-04-24T15:42:01","name":"[13/16] tests: fix check for sudo access in LUKS I/O test","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"62a0faaf2ce5f0d9adb569480482759b29a10eb1","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/1.2/people/2694/?format=json","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260424154205.364268-14-berrange@redhat.com/mbox/","series":[{"id":501385,"url":"http://patchwork.ozlabs.org/api/1.2/series/501385/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501385","date":"2026-04-24T15:41:48","name":"tests: do more testing of block drivers","version":1,"mbox":"http://patchwork.ozlabs.org/series/501385/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227959/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227959/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=MyA2o3Iw;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2HLJ1SdXz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Apr 2026 01:43:36 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wGIgl-0003Rq-Ui; Fri, 24 Apr 2026 11:43:32 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wGIgS-00033S-4A\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 11:43:18 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wGIgL-0007Zv-HD\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 11:43:09 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-246-HEPGlKgQPdKW1MhNn4jDPQ-1; Fri,\n 24 Apr 2026 11:43:01 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E6F9B1956080; Fri, 24 Apr 2026 15:42:59 +0000 (UTC)","from thinkbook.redhat.com (unknown [10.44.32.213])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 8B216180047F; Fri, 24 Apr 2026 15:42:56 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777045384;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=dSyY2gs17CHbTM/spZ5TzyaOpGRwJyz45XfDOslDrhU=;\n b=MyA2o3Iw12H2NcCGjyb5intK2YBZwZGdR+xErMuNEGzePPJBnv7YggvPCRx07wL5rSFEga\n hmT2IZFaZqRqLpowJZqZauvIOxSo1UWmmwvSyAZO4ieDpYPiimPw+kUicSjduKuSiEuwTC\n 25NTG/F0v2n7fFP4MUQ9dh9DircanTg=","X-MC-Unique":"HEPGlKgQPdKW1MhNn4jDPQ-1","X-Mimecast-MFC-AGG-ID":"HEPGlKgQPdKW1MhNn4jDPQ_1777045380","From":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Hanna Reitz <hreitz@redhat.com>,\n Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>, =?utf-8?q?Alex_Benn?=\n\t=?utf-8?q?=C3=A9e?= <alex.bennee@linaro.org>, qemu-block@nongnu.org,\n Cleber Rosa <crosa@redhat.com>, Kevin Wolf <kwolf@redhat.com>,\n John Snow <jsnow@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>, =?utf-8?q?Dani?=\n\t=?utf-8?q?el_P=2E_Berrang=C3=A9?= <berrange@redhat.com>,\n Thomas Huth <thuth@redhat.com>","Subject":"[PATCH 13/16] tests: fix check for sudo access in LUKS I/O test","Date":"Fri, 24 Apr 2026 16:42:01 +0100","Message-ID":"<20260424154205.364268-14-berrange@redhat.com>","In-Reply-To":"<20260424154205.364268-1-berrange@redhat.com>","References":"<20260424154205.364268-1-berrange@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"12","X-Spam_score":"1.2","X-Spam_bar":"+","X-Spam_report":"(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The test did not cope with the possibility that 'sudo' was not installed\nat all, merely that it was not configured. This broke tests in any CI\nenv which lacks 'sudo'.\n\nReviewed-by: Thomas Huth <thuth@redhat.com>\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>\n---\n tests/qemu-iotests/149 | 13 ++++++++-----\n 1 file changed, 8 insertions(+), 5 deletions(-)","diff":"diff --git a/tests/qemu-iotests/149 b/tests/qemu-iotests/149\nindex c13343d7ef..6dff39a28a 100755\n--- a/tests/qemu-iotests/149\n+++ b/tests/qemu-iotests/149\n@@ -95,11 +95,14 @@ def verify_passwordless_sudo():\n \n     args = [\"sudo\", \"-n\", \"/bin/true\"]\n \n-    proc = subprocess.Popen(args,\n-                            stdin=subprocess.PIPE,\n-                            stdout=subprocess.PIPE,\n-                            stderr=subprocess.STDOUT,\n-                            universal_newlines=True)\n+    try:\n+        proc = subprocess.Popen(args,\n+                                stdin=subprocess.PIPE,\n+                                stdout=subprocess.PIPE,\n+                                stderr=subprocess.STDOUT,\n+                                universal_newlines=True)\n+    except FileNotFoundError as e:\n+        iotests.notrun('requires sudo binary: %s' % e)\n \n     msg = proc.communicate()[0]\n \n","prefixes":["13/16"]}