{"id":2227953,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2227953/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/patch/20260424153558.1084949-2-dceara@redhat.com/","project":{"id":68,"url":"http://patchwork.ozlabs.org/api/1.2/projects/68/?format=json","name":"Open Virtual Network development","link_name":"ovn","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260424153558.1084949-2-dceara@redhat.com>","list_archive_url":null,"date":"2026-04-24T15:35:57","name":"[ovs-dev,1/2] northd: Add ls_has_localnet_port() helper.","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f2abd3368bb26b0e3b02286ab6957097b25e05f2","submitter":{"id":76591,"url":"http://patchwork.ozlabs.org/api/1.2/people/76591/?format=json","name":"Dumitru Ceara","email":"dceara@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ovn/patch/20260424153558.1084949-2-dceara@redhat.com/mbox/","series":[{"id":501383,"url":"http://patchwork.ozlabs.org/api/1.2/series/501383/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/list/?series=501383","date":"2026-04-24T15:35:56","name":"Enable ARP/ND responder for localnet-sourced requests","version":1,"mbox":"http://patchwork.ozlabs.org/series/501383/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227953/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2227953/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ovs-dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Lw6fm2Q1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp1.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Lw6fm2Q1","smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2H9s3bpRz1yD5\n\tfor ; Sat, 25 Apr 2026 01:36:17 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 55B5784CCC;\n\tFri, 24 Apr 2026 15:36:15 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id csInQ_VFnNSF; Fri, 24 Apr 2026 15:36:14 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id 6B3AE84CCA;\n\tFri, 24 Apr 2026 15:36:14 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 5369CC04FB;\n\tFri, 24 Apr 2026 15:36:14 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 124C1C04FA\n for ; Fri, 24 Apr 2026 15:36:13 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 0349584CCA\n for ; Fri, 24 Apr 2026 15:36:13 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 6kiIbvdfu3pR for ;\n Fri, 24 Apr 2026 15:36:12 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp1.osuosl.org (Postfix) with ESMTPS id E114184CC4\n for ; Fri, 24 Apr 2026 15:36:11 +0000 (UTC)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-612-FBU9Lr-DNt6Ub3928nXkzw-1; Fri,\n 24 Apr 2026 11:36:06 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id AEDAB1956046; Fri, 24 Apr 2026 15:36:05 +0000 (UTC)","from cecil-rh.redhat.com (unknown [10.44.33.15])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 8F0F01800348; Fri, 24 Apr 2026 15:36:04 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 6B3AE84CCA","OpenDKIM Filter v2.11.0 smtp1.osuosl.org E114184CC4"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=dceara@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org E114184CC4","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777044969;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ALB+fZ0ddq8mcCN0YaQ/pnZjwyYk9co6ISj8is0r88M=;\n b=Lw6fm2Q1K/ADjPE49DlfMY9WePHWd2/iI5zMjCIWkpkceijkoMnEjPKteMkypxqh/HVBwB\n HCzIYwHoDEbiAsoAxVSfYZ2LUpvy3AGKQq8N6EKTXCURyzjGSpesKxeJ3HzITLuO6lt3zb\n XJf3C6XgmEoQQktndtlkZWSeIORiSN0=","X-MC-Unique":"FBU9Lr-DNt6Ub3928nXkzw-1","X-Mimecast-MFC-AGG-ID":"FBU9Lr-DNt6Ub3928nXkzw_1777044965","To":"ovs-dev@openvswitch.org","Date":"Fri, 24 Apr 2026 17:35:57 +0200","Message-ID":"<20260424153558.1084949-2-dceara@redhat.com>","In-Reply-To":"<20260424153558.1084949-1-dceara@redhat.com>","References":"<20260424153558.1084949-1-dceara@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"GSCwXfrheJ0fTZVquk8q704Y8Cqbq_tFMxtwEtQkMHA_1777044965","X-Mimecast-Originator":"redhat.com","Subject":"[ovs-dev] [PATCH ovn 1/2] northd: Add ls_has_localnet_port() helper.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Dumitru Ceara via dev ","Reply-To":"Dumitru Ceara ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"Replace all open-coded vector_is_empty(&od->localnet_ports)\nchecks with a single ls_has_localnet_port() predicate. This\nmakes the intent clearer and provides a single place to change\nif the localnet port tracking ever moves to a different data\nstructure.\n\nNo functional change.\n\nAssisted-by: Claude Opus 4.6, Claude Code\nSigned-off-by: Dumitru Ceara \n---\n northd/en-multicast.c | 2 +-\n northd/northd.c | 16 ++++++++--------\n northd/northd.h | 6 ++++++\n 3 files changed, 15 insertions(+), 9 deletions(-)","diff":"diff --git a/northd/en-multicast.c b/northd/en-multicast.c\nindex a7dfd71c47..b2775516a9 100644\n--- a/northd/en-multicast.c\n+++ b/northd/en-multicast.c\n@@ -710,7 +710,7 @@ ovn_igmp_group_aggregate_ports(struct ovn_igmp_group *igmp_group,\n free(entry);\n }\n \n- if (!vector_is_empty(&igmp_group->datapath->localnet_ports)) {\n+ if (ls_has_localnet_port(igmp_group->datapath)) {\n ovn_multicast_add_ports(mcast_groups, igmp_group->datapath,\n &igmp_group->mcgroup,\n vector_get_array(&igmp_group->datapath->localnet_ports),\ndiff --git a/northd/northd.c b/northd/northd.c\nindex 0b52db6cf6..02c7e7e54e 100644\n--- a/northd/northd.c\n+++ b/northd/northd.c\n@@ -1788,7 +1788,7 @@ peer_needs_cr_port_creation(struct ovn_port *op)\n {\n if ((op->nbrp->n_gateway_chassis || op->nbrp->ha_chassis_group)\n && vector_len(&op->od->l3dgw_ports) == 1 && op->peer && op->peer->nbsp\n- && vector_is_empty(&op->peer->od->localnet_ports)) {\n+ && !ls_has_localnet_port(op->peer->od)) {\n return true;\n }\n \n@@ -2837,7 +2837,7 @@ ovn_port_update_sbrec(struct ovsdb_idl_txn *ovnsb_txn,\n smap_clone(&options, &op->nbsp->options);\n \n if (queue_id) {\n- if (!vector_is_empty(&op->od->localnet_ports)) {\n+ if (ls_has_localnet_port(op->od)) {\n struct ovn_port *port = vector_get(&op->od->localnet_ports,\n 0, struct ovn_port *);\n const char *physical_network = smap_get(\n@@ -3954,7 +3954,7 @@ should_add_router_port_garp(const struct ovn_port *op, const char *chassis)\n vector_len(&op->peer->od->l3dgw_ports));\n }\n }\n- } else if (chassis && !vector_is_empty(&op->od->localnet_ports)) {\n+ } else if (chassis && ls_has_localnet_port(op->od)) {\n add_router_port_garp = true;\n }\n \n@@ -6263,7 +6263,7 @@ build_lswitch_port_sec_op(struct ovn_port *op, struct lflow_table *lflows,\n WITH_IO_PORT(op->key), WITH_HINT(&op->nbsp->header_));\n \n if (!lsp_is_localnet(op->nbsp) &&\n- vector_is_empty(&op->od->localnet_ports)) {\n+ !ls_has_localnet_port(op->od)) {\n return;\n }\n \n@@ -6277,7 +6277,7 @@ build_lswitch_port_sec_op(struct ovn_port *op, struct lflow_table *lflows,\n ds_cstr(match), ds_cstr(actions), op->lflow_ref,\n WITH_IO_PORT(op->key),\n WITH_HINT(&op->nbsp->header_));\n- } else if (!vector_is_empty(&op->od->localnet_ports)) {\n+ } else if (ls_has_localnet_port(op->od)) {\n const struct ovn_port *lp = vector_get(&op->od->localnet_ports, 0,\n struct ovn_port *);\n ds_put_format(match, \"outport == %s && inport == %s\",\n@@ -10897,7 +10897,7 @@ build_lswitch_dhcp_options_and_response(struct ovn_port *op,\n }\n \n bool is_external = lsp_is_external(op->nbsp);\n- if (is_external && (vector_is_empty(&op->od->localnet_ports) ||\n+ if (is_external && (!ls_has_localnet_port(op->od) ||\n !op->nbsp->ha_chassis_group)) {\n /* If it's an external port and there are no localnet ports\n * and if it doesn't belong to an HA chassis group ignore it. */\n@@ -11322,7 +11322,7 @@ build_lswitch_ip_unicast_lookup(struct ovn_port *op,\n \n if (peer_lrp_is_centralized &&\n !vector_is_empty(&op->peer->od->l3dgw_ports) &&\n- !vector_is_empty(&op->od->localnet_ports)) {\n+ ls_has_localnet_port(op->od)) {\n add_lrp_chassis_resident_check(op->peer, match);\n } else if (op->cr_port) {\n /* If the op has a chassis resident port, it means\n@@ -17226,7 +17226,7 @@ build_lrouter_ipv4_ip_input(struct ovn_port *op,\n \n if (od_is_centralized(op->od) &&\n !vector_is_empty(&op->od->l3dgw_ports) && op->peer\n- && !vector_is_empty(&op->peer->od->localnet_ports)) {\n+ && ls_has_localnet_port(op->peer->od)) {\n add_lrp_chassis_resident_check(op, match);\n }\n \ndiff --git a/northd/northd.h b/northd/northd.h\nindex e86d39f9aa..80f8e76870 100644\n--- a/northd/northd.h\n+++ b/northd/northd.h\n@@ -507,6 +507,12 @@ ovn_datapath_is_stale(const struct ovn_datapath *od)\n return !od->nbr && !od->nbs;\n };\n \n+static inline bool\n+ls_has_localnet_port(const struct ovn_datapath *od)\n+{\n+ return !vector_is_empty(&od->localnet_ports);\n+}\n+\n /* Pipeline stages. */\n #define PIPELINE_STAGES \\\n /* Logical switch ingress stages. */ \\\n","prefixes":["ovs-dev","1/2"]}