{"id":2227490,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2227490/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-42-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423191958.1440-42-farosas@suse.de>","list_archive_url":null,"date":"2026-04-23T19:19:55","name":"[PULL,41/43] migration/qemu-file: switch buffer_at functions to positioned I/O _all helpers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2d18a8ef86d1a34155434511f5d009ab39b5d8cc","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/1.2/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-42-farosas@suse.de/mbox/","series":[{"id":501236,"url":"http://patchwork.ozlabs.org/api/1.2/series/501236/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501236","date":"2026-04-23T19:19:14","name":"[PULL,01/43] checkpatch: Allow spaces after all coroutine annotations","version":1,"mbox":"http://patchwork.ozlabs.org/series/501236/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227490/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227490/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=n4AyYiEL;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=MOUWPl3/;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=CnbQcL8a;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=FK4YCewq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1mJy0lnNz1yGs\n\tfor ; Fri, 24 Apr 2026 05:25:38 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFzdE-0005qA-8C; Thu, 23 Apr 2026 15:22:36 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFzck-0004gu-4f\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:22:07 -0400","from smtp-out2.suse.de ([195.135.223.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFzch-0002JX-55\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:22:04 -0400","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 9BDE55BD8A;\n Thu, 23 Apr 2026 19:21:04 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 909E9593B0;\n Thu, 23 Apr 2026 19:21:03 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id aGQXFx9x6mlJCwAAD6G6ig\n (envelope-from ); Thu, 23 Apr 2026 19:21:03 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972065;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=gFYc2iCcctX8eeRxlptNc9/OtgMtLaoHlJzTpnV+VcY=;\n b=n4AyYiELDz/FFkSMrQniN+ZTzZEh7D8T9+yzNsPtwnPCogy/FAVZA7x7OPS87kHzsBVKQY\n zMBrL8Bu+1GKt9iMq25WwtBOLm+ByGpreAwiRUGl98q5PlfHau0YWdQrZ+MleCEQ3/UeQY\n 1dtrvsh+8RH+Tj+lKDxKquHSojzvuRM=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972065;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=gFYc2iCcctX8eeRxlptNc9/OtgMtLaoHlJzTpnV+VcY=;\n b=MOUWPl3/ZruAXhn2++qOKJsbE7lCy0pottxt3D8OqG9eMfw7TN9Ws+CK9j877o73Tsofug\n Grk1i+UclYhPkxCg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972064;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=gFYc2iCcctX8eeRxlptNc9/OtgMtLaoHlJzTpnV+VcY=;\n b=CnbQcL8ax7SGnm4qeZD15ZiFS8U3b3EKe9ZIJyPFgg1vXQYh7ma1jXhT/Gngk08UcMD1Ru\n Z/Gt769BFvjMxcXvYeSv39mcULK5WaPKmAn0IoBk9F8kkRkYcBGy9rewxQUFYiZF3Pc6lG\n cAM9bRgQOiZ2t8buErBPp8C5xvYKzeI=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972064;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=gFYc2iCcctX8eeRxlptNc9/OtgMtLaoHlJzTpnV+VcY=;\n b=FK4YCewqlUjnBBmhtsLWV4kfkjPPvqC1SH3li7oY06CN2PI8hB9Y5zSsrt8XEjnF6iQUe5\n JD69D8ZY960AYdAw=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu ,\n\tJunjie Cao ","Subject":"[PULL 41/43] migration/qemu-file: switch buffer_at functions to\n positioned I/O _all helpers","Date":"Thu, 23 Apr 2026 16:19:55 -0300","Message-ID":"<20260423191958.1440-42-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260423191958.1440-1-farosas@suse.de>","References":"<20260423191958.1440-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spamd-Result":"default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000];\n MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_SOME(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email,intel.com:email,imap1.dmz-prg2.suse.org:helo];\n RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RCPT_COUNT_THREE(0.00)[3]; RCVD_TLS_ALL(0.00)[]","X-Spam-Score":"-2.80","Received-SPF":"pass client-ip=195.135.223.131; envelope-from=farosas@suse.de;\n helo=smtp-out2.suse.de","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Junjie Cao \n\nqemu_put_buffer_at() and qemu_get_buffer_at() have the same pattern as\nthe bug fixed in multifd_file_recv_data(): the ssize_t return value from\nthe channel layer is stored in a size_t variable, and a short transfer\nwould be mishandled rather than retried.\n\nSwitch to qio_channel_pwrite_all() / qio_channel_pread_all() which\nhandle short transfers internally and make the code more robust and\nconsistent with the rest of the positioned I/O call sites.\n\nFixes: 7f5b50a401 (\"migration/qemu-file: add utility methods for working with seekable channels\")\nSigned-off-by: Junjie Cao \nReviewed-by: Peter Xu \nLink: https://lore.kernel.org/qemu-devel/20260420201317.30199-2-junjie.cao@intel.com\nSigned-off-by: Fabiano Rosas \n---\n migration/qemu-file.c | 35 +++--------------------------------\n 1 file changed, 3 insertions(+), 32 deletions(-)","diff":"diff --git a/migration/qemu-file.c b/migration/qemu-file.c\nindex 9cf7dc3bd5..9dfb202203 100644\n--- a/migration/qemu-file.c\n+++ b/migration/qemu-file.c\n@@ -535,28 +535,13 @@ void qemu_put_buffer_at(QEMUFile *f, const uint8_t *buf, size_t buflen,\n off_t pos)\n {\n Error *err = NULL;\n- size_t ret;\n \n if (f->last_error) {\n return;\n }\n \n qemu_fflush(f);\n- ret = qio_channel_pwrite(f->ioc, (char *)buf, buflen, pos, &err);\n-\n- if (err) {\n- qemu_file_set_error_obj(f, -EIO, err);\n- return;\n- }\n-\n- if ((ssize_t)ret == QIO_CHANNEL_ERR_BLOCK) {\n- qemu_file_set_error_obj(f, -EAGAIN, NULL);\n- return;\n- }\n-\n- if (ret != buflen) {\n- error_setg(&err, \"Partial write of size %zu, expected %zu\", ret,\n- buflen);\n+ if (qio_channel_pwrite_all(f->ioc, buf, buflen, pos, &err) < 0) {\n qemu_file_set_error_obj(f, -EIO, err);\n return;\n }\n@@ -569,31 +554,17 @@ size_t qemu_get_buffer_at(QEMUFile *f, const uint8_t *buf, size_t buflen,\n off_t pos)\n {\n Error *err = NULL;\n- size_t ret;\n \n if (f->last_error) {\n return 0;\n }\n \n- ret = qio_channel_pread(f->ioc, (char *)buf, buflen, pos, &err);\n-\n- if ((ssize_t)ret == -1 || err) {\n- qemu_file_set_error_obj(f, -EIO, err);\n- return 0;\n- }\n-\n- if ((ssize_t)ret == QIO_CHANNEL_ERR_BLOCK) {\n- qemu_file_set_error_obj(f, -EAGAIN, NULL);\n- return 0;\n- }\n-\n- if (ret != buflen) {\n- error_setg(&err, \"Partial read of size %zu, expected %zu\", ret, buflen);\n+ if (qio_channel_pread_all(f->ioc, (char *)buf, buflen, pos, &err) < 0) {\n qemu_file_set_error_obj(f, -EIO, err);\n return 0;\n }\n \n- return ret;\n+ return buflen;\n }\n \n void qemu_set_offset(QEMUFile *f, off_t off, int whence)\n","prefixes":["PULL","41/43"]}