{"id":2227485,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2227485/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-39-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423191958.1440-39-farosas@suse.de>","list_archive_url":null,"date":"2026-04-23T19:19:52","name":"[PULL,38/43] migration/file: fix type mismatch and NULL deref in multifd_file_recv_data","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cab439379d07cdfb6d7f13ba6e02db5c52239260","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/1.2/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-39-farosas@suse.de/mbox/","series":[{"id":501236,"url":"http://patchwork.ozlabs.org/api/1.2/series/501236/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501236","date":"2026-04-23T19:19:14","name":"[PULL,01/43] checkpatch: Allow spaces after all coroutine annotations","version":1,"mbox":"http://patchwork.ozlabs.org/series/501236/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227485/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227485/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=pcUfbC2a;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=3jwYFQsD;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=pcUfbC2a;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=3jwYFQsD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1mJX3VDHz1yDD\n\tfor ; Fri, 24 Apr 2026 05:25:16 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFzdN-0006gQ-3K; Thu, 23 Apr 2026 15:22:45 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFzdK-0006Om-5M\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:22:42 -0400","from smtp-out1.suse.de ([195.135.223.130])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFzdI-0002Vw-4h\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:22:41 -0400","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 182176A8A0;\n Thu, 23 Apr 2026 19:21:00 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CEDC7593A3;\n Thu, 23 Apr 2026 19:20:58 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id iDU6Jhpx6mlJCwAAD6G6ig\n (envelope-from ); Thu, 23 Apr 2026 19:20:58 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972060;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=/FKBYTvXSGjAZfvLVAh1z1tx4IgLgeuK7f7Tnrh6f+4=;\n b=pcUfbC2a+AG2sgMrsWDueQc4p513eGgT8sZPE1139usEC/F/BzhC/YRMKlXS94xbY9Dc6z\n T1GGBLSVfKUpYj0+v7wvKrsSTbA52BAuRejeD+jFWGS0i29/VeS7WNkIVn+sZ1jOpSegRD\n LU2efdJ/AWS3GCeRjX56L8+EOHQjdAk=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972060;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=/FKBYTvXSGjAZfvLVAh1z1tx4IgLgeuK7f7Tnrh6f+4=;\n b=3jwYFQsDTiJa9Bk0MGRYLr8wAKu+lie4+KdfvRtE8mZCKVw8dLT8xINbp29Y5ECnoKAUwN\n yFrJ8PR0kJXGUlDA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972060;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=/FKBYTvXSGjAZfvLVAh1z1tx4IgLgeuK7f7Tnrh6f+4=;\n b=pcUfbC2a+AG2sgMrsWDueQc4p513eGgT8sZPE1139usEC/F/BzhC/YRMKlXS94xbY9Dc6z\n T1GGBLSVfKUpYj0+v7wvKrsSTbA52BAuRejeD+jFWGS0i29/VeS7WNkIVn+sZ1jOpSegRD\n LU2efdJ/AWS3GCeRjX56L8+EOHQjdAk=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972060;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=/FKBYTvXSGjAZfvLVAh1z1tx4IgLgeuK7f7Tnrh6f+4=;\n b=3jwYFQsDTiJa9Bk0MGRYLr8wAKu+lie4+KdfvRtE8mZCKVw8dLT8xINbp29Y5ECnoKAUwN\n yFrJ8PR0kJXGUlDA=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu , Junjie Cao ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","Subject":"[PULL 38/43] migration/file: fix type mismatch and NULL deref in\n multifd_file_recv_data","Date":"Thu, 23 Apr 2026 16:19:52 -0300","Message-ID":"<20260423191958.1440-39-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260423191958.1440-1-farosas@suse.de>","References":"<20260423191958.1440-1-farosas@suse.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Spamd-Result":"default: False [-3.30 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[];\n RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[];\n MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[];\n RCPT_COUNT_THREE(0.00)[4]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_TWO(0.00)[2];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:mid,\n suse.de:email, intel.com:email]","X-Spam-Score":"-3.30","Received-SPF":"pass client-ip=195.135.223.130; envelope-from=farosas@suse.de;\n helo=smtp-out1.suse.de","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Junjie Cao \n\nmultifd_file_recv_data() stores the return value of qio_channel_pread()\n(ssize_t) in a size_t variable. On I/O error the -1 return value wraps\nto SIZE_MAX, producing a nonsensical read size in the error message.\n\nMore critically, a short read (0 <= ret < data->size) is possible when\nthe migration file is truncated. In that case qio_channel_pread()\nreturns a non-negative value without setting *errp. The function then\ncalls error_prepend(errp, ...) which dereferences *errp -- a NULL\npointer -- crashing QEMU.\n\nFix both issues by switching to qio_channel_pread_all() introduced in\na previous patch, which retries on short reads and treats end-of-file\nas an error, so the caller no longer needs to check the byte count\nmanually. Add ERRP_GUARD() so that error_prepend() works correctly\neven when errp is &error_fatal or NULL.\n\nFixes: a49d15a38d3d (\"migration/multifd: Support incoming mapped-ram stream format\")\nSuggested-by: Peter Xu \nReviewed-by: Daniel P. Berrangé \nSigned-off-by: Junjie Cao \nReviewed-by: Fabiano Rosas \nLink: https://lore.kernel.org/qemu-devel/20260413214549.926435-4-junjie.cao@intel.com\nSigned-off-by: Fabiano Rosas \n---\n migration/file.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)","diff":"diff --git a/migration/file.c b/migration/file.c\nindex 962b4b3a1b..4e2524e548 100644\n--- a/migration/file.c\n+++ b/migration/file.c\n@@ -256,15 +256,16 @@ int file_write_ramblock_iov(QIOChannel *ioc, const struct iovec *iov,\n \n int multifd_file_recv_data(MultiFDRecvParams *p, Error **errp)\n {\n+ ERRP_GUARD();\n MultiFDRecvData *data = p->data;\n- size_t ret;\n+ int ret;\n \n- ret = qio_channel_pread(p->c, (char *) data->opaque,\n- data->size, data->file_offset, errp);\n- if (ret != data->size) {\n+ ret = qio_channel_pread_all(p->c, (char *) data->opaque,\n+ data->size, data->file_offset, errp);\n+ if (ret != 0) {\n error_prepend(errp,\n- \"multifd recv (%u): read 0x%zx, expected 0x%zx\",\n- p->id, ret, data->size);\n+ \"multifd recv (%u): \",\n+ p->id);\n return -1;\n }\n \n","prefixes":["PULL","38/43"]}