{"id":2227477,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2227477/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-35-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423191958.1440-35-farosas@suse.de>","list_archive_url":null,"date":"2026-04-23T19:19:48","name":"[PULL,34/43] tests/unit/test-vmstate: add tests for VMS_ARRAY_OF_POINTER_AUTO_ALLOC","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"89bcfc78366e09990fcb9c2e4850a62762436102","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/1.2/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-35-farosas@suse.de/mbox/","series":[{"id":501236,"url":"http://patchwork.ozlabs.org/api/1.2/series/501236/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501236","date":"2026-04-23T19:19:14","name":"[PULL,01/43] checkpatch: Allow spaces after all coroutine annotations","version":1,"mbox":"http://patchwork.ozlabs.org/series/501236/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227477/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227477/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=HfWpPyWV;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=84as9E81;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=D5MXxWtp;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=kaYG5hGs;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1mHZ2VKtz1y2d\n\tfor ; Fri, 24 Apr 2026 05:24:26 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFzdL-0006a4-Ts; Thu, 23 Apr 2026 15:22:44 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFzd0-0005FA-7z\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:22:25 -0400","from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFzcx-0002TE-E6\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:22:20 -0400","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id DC3C86A89D;\n Thu, 23 Apr 2026 19:20:53 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9D43C593A3;\n Thu, 23 Apr 2026 19:20:52 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id qLgRGhRx6mlJCwAAD6G6ig\n (envelope-from ); Thu, 23 Apr 2026 19:20:52 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972054;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=HvefdpONNcFqysntqs+juTRcEx4K1r24uMyjySuc3B4=;\n b=HfWpPyWVopg946KlLkNC1v7DYtrHkvWa4ki5W0wM6JfeCCs9ofHdWwSPjdjlgdd+ps5aS8\n hA7dhLokseSV2vO//1ZLc5uorLB8ueB+iFsfNCz3UdZQcyQ9phZ9KxQgaSnYsdjrhR8Wwl\n yfmLnPkyEmsz+WgxYqkFLxcaXaUQMDo=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972054;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=HvefdpONNcFqysntqs+juTRcEx4K1r24uMyjySuc3B4=;\n b=84as9E81YOdwTP+XnBXGo3NLp0/8jnLyIVKjzEnmaC5DQnJSe+sOChWe3pv6tbbxJ/GkTN\n 0q/XwawXza4rz+Dg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972053;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=HvefdpONNcFqysntqs+juTRcEx4K1r24uMyjySuc3B4=;\n b=D5MXxWtpZy2xg66vILptiBg1Fu9LBzIAuB4o8Sm9gsW+b81v5JK+mlll83TOSED0yzI582\n TY7mpqpF1+YDuzg552/Exq+VmDXhq8hnMdHuIdYUMK0sAwLzW4fJhI1QzbYoTxKh3PQH8L\n kOKF5N7J+nRKw6G9KEt+992IAcq2xsM=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972053;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=HvefdpONNcFqysntqs+juTRcEx4K1r24uMyjySuc3B4=;\n b=kaYG5hGsYumIMgGwvSyaM2G8b+1iYKZ+7wRXyswl+Zi9697hZqtsm1HeM+30fu67hOjUh7\n AsazX5xdDbXh6iBQ=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu ,\n Alexander Mikhalitsyn ,\n Juraj Marcin ","Subject":"[PULL 34/43] tests/unit/test-vmstate: add tests for\n VMS_ARRAY_OF_POINTER_AUTO_ALLOC","Date":"Thu, 23 Apr 2026 16:19:48 -0300","Message-ID":"<20260423191958.1440-35-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260423191958.1440-1-farosas@suse.de>","References":"<20260423191958.1440-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Score":"-2.80","X-Spamd-Result":"default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000];\n MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_SOME(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo];\n RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_ALL(0.00)[]","Received-SPF":"pass client-ip=2a07:de40:b251:101:10:150:64:1;\n envelope-from=farosas@suse.de; helo=smtp-out1.suse.de","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Alexander Mikhalitsyn \n\nAdd tests for VMSTATE_VARRAY_OF_POINTER_TO_STRUCT_UINT32_ALLOC.\n\nSigned-off-by: Alexander Mikhalitsyn \n[peterx: Removed two tests due to macro not used, rebase, fix warning]\nSigned-off-by: Peter Xu \nReviewed-by: Juraj Marcin \nLink: https://lore.kernel.org/qemu-devel/20260401202844.673494-12-peterx@redhat.com\nSigned-off-by: Fabiano Rosas \n---\n tests/unit/test-vmstate.c | 86 +++++++++++++++++++++++++++++++++++++++\n 1 file changed, 86 insertions(+)","diff":"diff --git a/tests/unit/test-vmstate.c b/tests/unit/test-vmstate.c\nindex dae15786aa..df1fb4c778 100644\n--- a/tests/unit/test-vmstate.c\n+++ b/tests/unit/test-vmstate.c\n@@ -702,6 +702,88 @@ static void test_arr_ptr_prim_0_load(void)\n }\n }\n \n+static uint8_t wire_arr_ptr_with_nulls[] = {\n+ VMS_MARKER_PTR_VALID,\n+ 0x00, 0x00, 0x00, 0x00,\n+ VMS_MARKER_PTR_NULL,\n+ VMS_MARKER_PTR_VALID,\n+ 0x00, 0x00, 0x00, 0x02,\n+ VMS_MARKER_PTR_VALID,\n+ 0x00, 0x00, 0x00, 0x03,\n+ QEMU_VM_EOF\n+};\n+\n+typedef struct {\n+ uint32_t ar_items_num;\n+ TestStructTriv **ar;\n+} TestVArrayOfPtrToStuctWithNULLs;\n+\n+const VMStateDescription vmsd_arps_with_nulls = {\n+ .name = \"test/arps_with_nulls\",\n+ .version_id = 1,\n+ .minimum_version_id = 1,\n+ .fields = (const VMStateField[]) {\n+ VMSTATE_VARRAY_OF_POINTER_TO_STRUCT_UINT32_ALLOC(\n+ ar, TestVArrayOfPtrToStuctWithNULLs, ar_items_num,\n+ 0, vmsd_tst, TestStructTriv),\n+ VMSTATE_END_OF_LIST()\n+ }\n+};\n+\n+static void test_arr_ptr_nulls_str_save(void)\n+{\n+ TestStructTriv ar[AR_SIZE] = { {.i = 0}, {.i = 1}, {.i = 2}, {.i = 3} };\n+ TestVArrayOfPtrToStuctWithNULLs sample = {};\n+ int idx;\n+\n+ sample.ar_items_num = AR_SIZE;\n+ sample.ar = g_new0(TestStructTriv*, sample.ar_items_num);\n+ sample.ar[0] = g_new0(TestStructTriv, 1);\n+ *sample.ar[0] = ar[0];\n+ /* note, sample.ar[1] remains NULL */\n+ sample.ar[2] = g_new0(TestStructTriv, 1);\n+ *sample.ar[2] = ar[2];\n+ sample.ar[3] = g_new0(TestStructTriv, 1);\n+ *sample.ar[3] = ar[3];\n+\n+ save_vmstate(&vmsd_arps_with_nulls, &sample);\n+ compare_vmstate(wire_arr_ptr_with_nulls, sizeof(wire_arr_ptr_with_nulls));\n+\n+ for (idx = 0; idx < AR_SIZE; ++idx) {\n+ g_free(sample.ar[idx]);\n+ }\n+ g_free(sample.ar);\n+}\n+\n+static void test_arr_ptr_nulls_str_load(void)\n+{\n+ TestStructTriv ar_gt[AR_SIZE] = {{.i = 0}, {.i = 0}, {.i = 2}, {.i = 3} };\n+ TestVArrayOfPtrToStuctWithNULLs obj = {};\n+ int idx;\n+\n+ obj.ar_items_num = AR_SIZE;\n+ obj.ar = g_new0(TestStructTriv*, obj.ar_items_num);\n+\n+ save_buffer(wire_arr_ptr_with_nulls, sizeof(wire_arr_ptr_with_nulls));\n+ SUCCESS(load_vmstate_one(\n+ &vmsd_arps_with_nulls, &obj, 1,\n+ wire_arr_ptr_with_nulls, sizeof(wire_arr_ptr_with_nulls)));\n+\n+ for (idx = 0; idx < AR_SIZE; ++idx) {\n+ if (idx == 1) {\n+ g_assert_cmpint((uintptr_t)(obj.ar[idx]), ==, 0);\n+ } else {\n+ /* compare the target array ar with the ground truth array ar_gt */\n+ g_assert_cmpint(ar_gt[idx].i, ==, obj.ar[idx]->i);\n+ }\n+ }\n+\n+ for (idx = 0; idx < AR_SIZE; ++idx) {\n+ g_free(obj.ar[idx]);\n+ }\n+ g_free(obj.ar);\n+}\n+\n /* test QTAILQ migration */\n typedef struct TestQtailqElement TestQtailqElement;\n \n@@ -1568,6 +1650,10 @@ int main(int argc, char **argv)\n test_arr_ptr_prim_0_save);\n g_test_add_func(\"/vmstate/array/ptr/prim/0/load\",\n test_arr_ptr_prim_0_load);\n+ g_test_add_func(\"/vmstate/array/ptr-nulls/str/save\",\n+ test_arr_ptr_nulls_str_save);\n+ g_test_add_func(\"/vmstate/array/ptr-nulls/str/load\",\n+ test_arr_ptr_nulls_str_load);\n g_test_add_func(\"/vmstate/qtailq/save/saveq\", test_save_q);\n g_test_add_func(\"/vmstate/qtailq/load/loadq\", test_load_q);\n g_test_add_func(\"/vmstate/gtree/save/savedomain\", test_gtree_save_domain);\n","prefixes":["PULL","34/43"]}