{"id":2227475,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2227475/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-44-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423191958.1440-44-farosas@suse.de>","list_archive_url":null,"date":"2026-04-23T19:19:57","name":"[PULL,43/43] migration/qemu-file: drop incorrect const from qemu_get_buffer_at buf","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"58e37159a67fa4e43565796eefdb249f794f6204","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/1.2/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-44-farosas@suse.de/mbox/","series":[{"id":501236,"url":"http://patchwork.ozlabs.org/api/1.2/series/501236/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501236","date":"2026-04-23T19:19:14","name":"[PULL,01/43] checkpatch: Allow spaces after all coroutine annotations","version":1,"mbox":"http://patchwork.ozlabs.org/series/501236/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227475/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227475/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=XFUu2ywj;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=tFJF+hjX;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=XFUu2ywj;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=tFJF+hjX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1mHX2RwTz1yCv\n\tfor ; Fri, 24 Apr 2026 05:24:24 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFzdN-0006kJ-KF; Thu, 23 Apr 2026 15:22:45 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFzcw-0005CZ-Ix\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:22:20 -0400","from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFzct-0002Rz-Ch\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:22:16 -0400","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id B10605BD92;\n Thu, 23 Apr 2026 19:21:07 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7375C593A3;\n Thu, 23 Apr 2026 19:21:06 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id aFDxDyJx6mlJCwAAD6G6ig\n (envelope-from ); Thu, 23 Apr 2026 19:21:06 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972067;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=M3UDVOPUiWpobauA+2TDTDMQ+HGhvLbgz+74mugUk44=;\n b=XFUu2ywjfRqSIgmNBD8FBYE0YTyZbxhdv+4Y0cm6UJZUSwy/nzhRHj3g0oJIeafW2M/K2V\n sjugS/zEV9fdrnTHWKY41Oe/TCfxQtJMlqnWNuMvBQV9knwulo3RuI3vKhtvjv/IPRj+Da\n PZmdHUuGt2UcLyXpCMBbPHq435uE+kg=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972067;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=M3UDVOPUiWpobauA+2TDTDMQ+HGhvLbgz+74mugUk44=;\n b=tFJF+hjX4aaxmfYLFjRmwu2CO7wJBQhV7bvLAGBY5g/dzlIhieb+n3MzHrAPXSqcROTB/z\n r53KmAcsin/ThyBw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972067;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=M3UDVOPUiWpobauA+2TDTDMQ+HGhvLbgz+74mugUk44=;\n b=XFUu2ywjfRqSIgmNBD8FBYE0YTyZbxhdv+4Y0cm6UJZUSwy/nzhRHj3g0oJIeafW2M/K2V\n sjugS/zEV9fdrnTHWKY41Oe/TCfxQtJMlqnWNuMvBQV9knwulo3RuI3vKhtvjv/IPRj+Da\n PZmdHUuGt2UcLyXpCMBbPHq435uE+kg=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972067;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=M3UDVOPUiWpobauA+2TDTDMQ+HGhvLbgz+74mugUk44=;\n b=tFJF+hjX4aaxmfYLFjRmwu2CO7wJBQhV7bvLAGBY5g/dzlIhieb+n3MzHrAPXSqcROTB/z\n r53KmAcsin/ThyBw=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu , Junjie Cao ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PULL 43/43] migration/qemu-file: drop incorrect const from\n qemu_get_buffer_at buf","Date":"Thu, 23 Apr 2026 16:19:57 -0300","Message-ID":"<20260423191958.1440-44-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260423191958.1440-1-farosas@suse.de>","References":"<20260423191958.1440-1-farosas@suse.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Spamd-Result":"default: False [-3.30 / 50.00]; BAYES_HAM(-3.00)[99.99%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[];\n RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[];\n MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[];\n RCPT_COUNT_THREE(0.00)[4]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_TWO(0.00)[2];\n DBL_BLOCKED_OPENRESOLVER(0.00)[linaro.org:email, suse.de:mid, suse.de:email,\n imap1.dmz-prg2.suse.org:helo, intel.com:email]","X-Spam-Score":"-3.30","Received-SPF":"pass client-ip=2a07:de40:b251:101:10:150:64:2;\n envelope-from=farosas@suse.de; helo=smtp-out2.suse.de","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Junjie Cao \n\nqemu_get_buffer_at() reads data *into* buf -- it should not be const.\nDrop the qualifier and remove the now-unnecessary cast.\n\nSigned-off-by: Junjie Cao \nReviewed-by: Philippe Mathieu-Daudé \nReviewed-by: Peter Xu \nLink: https://lore.kernel.org/qemu-devel/20260420201317.30199-4-junjie.cao@intel.com\nSigned-off-by: Fabiano Rosas \n---\n migration/qemu-file.c | 4 ++--\n migration/qemu-file.h | 2 +-\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/migration/qemu-file.c b/migration/qemu-file.c\nindex 9dfb202203..d5a48115bd 100644\n--- a/migration/qemu-file.c\n+++ b/migration/qemu-file.c\n@@ -550,7 +550,7 @@ void qemu_put_buffer_at(QEMUFile *f, const uint8_t *buf, size_t buflen,\n }\n \n \n-size_t qemu_get_buffer_at(QEMUFile *f, const uint8_t *buf, size_t buflen,\n+size_t qemu_get_buffer_at(QEMUFile *f, uint8_t *buf, size_t buflen,\n off_t pos)\n {\n Error *err = NULL;\n@@ -559,7 +559,7 @@ size_t qemu_get_buffer_at(QEMUFile *f, const uint8_t *buf, size_t buflen,\n return 0;\n }\n \n- if (qio_channel_pread_all(f->ioc, (char *)buf, buflen, pos, &err) < 0) {\n+ if (qio_channel_pread_all(f->ioc, buf, buflen, pos, &err) < 0) {\n qemu_file_set_error_obj(f, -EIO, err);\n return 0;\n }\ndiff --git a/migration/qemu-file.h b/migration/qemu-file.h\nindex a390554208..8f824c124d 100644\n--- a/migration/qemu-file.h\n+++ b/migration/qemu-file.h\n@@ -76,7 +76,7 @@ void qemu_set_offset(QEMUFile *f, off_t off, int whence);\n off_t qemu_get_offset(QEMUFile *f);\n void qemu_put_buffer_at(QEMUFile *f, const uint8_t *buf, size_t buflen,\n off_t pos);\n-size_t qemu_get_buffer_at(QEMUFile *f, const uint8_t *buf, size_t buflen,\n+size_t qemu_get_buffer_at(QEMUFile *f, uint8_t *buf, size_t buflen,\n off_t pos);\n \n QIOChannel *qemu_file_get_ioc(QEMUFile *file);\n","prefixes":["PULL","43/43"]}