{"id":2227474,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2227474/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-25-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423191958.1440-25-farosas@suse.de>","list_archive_url":null,"date":"2026-04-23T19:19:38","name":"[PULL,24/43] vmstate: Pass in struct itself for VMSTATE_ARRAY_OF_POINTER","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7404bbb2564e8d6ffdc9e511323a562f4243bfb6","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/1.2/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-25-farosas@suse.de/mbox/","series":[{"id":501236,"url":"http://patchwork.ozlabs.org/api/1.2/series/501236/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501236","date":"2026-04-23T19:19:14","name":"[PULL,01/43] checkpatch: Allow spaces after all coroutine annotations","version":1,"mbox":"http://patchwork.ozlabs.org/series/501236/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227474/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227474/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=b9vUtcWz;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=/WqziteL;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=tAuNIMlS;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=VzP1gKTO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=tAuNIMlS;\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VzP1gKTO"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1mHX1DmVz1y2d\n\tfor ; Fri, 24 Apr 2026 05:24:24 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFzcK-00031Y-7k; Thu, 23 Apr 2026 15:21:40 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFzc5-0002KX-1K\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:21:29 -0400","from smtp-out2.suse.de ([195.135.223.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFzc3-0001xF-A6\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:21:24 -0400","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id F1C785BD84;\n Thu, 23 Apr 2026 19:20:36 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8A6CF593A3;\n Thu, 23 Apr 2026 19:20:35 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id qMLUFQNx6mlJCwAAD6G6ig\n (envelope-from ); Thu, 23 Apr 2026 19:20:35 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972037;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Zv0ZUnC0KXVCWHLwyLSI86WolEvBSu09bCwPnFXhLdI=;\n b=b9vUtcWzSzbWIpFdUY4lUidO1UiuiHIgLSLYOXQxQipZ9Sqi9UXncFycTitvUOIUKT4ilh\n N7dODebk5hAiGR/YSVTW+7bhybCYcT7tRTUNkoJwWJawuRpme/Kgl0NQSb9+gpoLzbRa9T\n 4nDzCREXC33rABgLQddFOhw7YyIeRSs=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972037;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Zv0ZUnC0KXVCWHLwyLSI86WolEvBSu09bCwPnFXhLdI=;\n b=/WqziteLmD8zx4LX780jqxO65EqwXwttc1+SwmPmpbjb9Zz7FIXF9ZqvN1KLOOAxnMu64z\n 5NsVsEo/ujv+s0Cw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972036;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Zv0ZUnC0KXVCWHLwyLSI86WolEvBSu09bCwPnFXhLdI=;\n b=tAuNIMlS7F7LPFSz4kBpL1HWJ7AE4vj1hqngLyRfLjLOm0mvr57kL0DcecFtXH6/ioutS0\n d5TWUfk0yxV+leR9jwSWJ1RObWEGQgTv7Ci2xJoW34REDregnzbrrgHE7j3/uXlfyP7amm\n EU6UaljjeftWVyfdOfYUCFIR/+62rqY=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972036;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Zv0ZUnC0KXVCWHLwyLSI86WolEvBSu09bCwPnFXhLdI=;\n b=VzP1gKTO8l62aMbyR1WfBMPcJFCXQao/z1HfZYaI4llMlVRwtKLAGX3Hz8KHQpHHPo8rJt\n TisLYiADujLCTKDA=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu ,\n Alexander Mikhalitsyn , =?utf-8?q?Phi?=\n\t=?utf-8?q?lippe_Mathieu-Daud=C3=A9?= ,\n Juraj Marcin ","Subject":"[PULL 24/43] vmstate: Pass in struct itself for\n VMSTATE_ARRAY_OF_POINTER","Date":"Thu, 23 Apr 2026 16:19:38 -0300","Message-ID":"<20260423191958.1440-25-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260423191958.1440-1-farosas@suse.de>","References":"<20260423191958.1440-1-farosas@suse.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Rspamd-Action":"no action","X-Rspamd-Server":"rspamd2.dmz-prg2.suse.org","X-Spamd-Result":"default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[];\n MIME_TRACE(0.00)[0:+];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_FIVE(0.00)[5];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[linaro.org:email,suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n DKIM_TRACE(0.00)[suse.de:+]","X-Rspamd-Queue-Id":"F1C785BD84","X-Spam-Score":"-3.51","Received-SPF":"pass client-ip=195.135.223.131; envelope-from=farosas@suse.de;\n helo=smtp-out2.suse.de","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Peter Xu \n\nPassing in a pointer almost never helps. Convert it to pass in struct for\nfurther refactoring on VMS_ARRAY_OF_POINTER.\n\nReviewed-by: Alexander Mikhalitsyn \nReviewed-by: Fabiano Rosas \nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Peter Xu \nReviewed-by: Juraj Marcin \nLink: https://lore.kernel.org/qemu-devel/20260401202844.673494-2-peterx@redhat.com\n[delete spurious hunk touching roms/seabios]\nSigned-off-by: Fabiano Rosas \n---\n include/migration/vmstate.h | 6 +++---\n tests/unit/test-vmstate.c | 2 +-\n 2 files changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h\nindex d4a39aa794..d4880e75c2 100644\n--- a/include/migration/vmstate.h\n+++ b/include/migration/vmstate.h\n@@ -547,9 +547,9 @@ extern const VMStateInfo vmstate_info_qlist;\n .version_id = (_version), \\\n .num = (_num), \\\n .info = &(_info), \\\n- .size = sizeof(_type), \\\n+ .size = sizeof(_type *), \\\n .flags = VMS_ARRAY|VMS_ARRAY_OF_POINTER, \\\n- .offset = vmstate_offset_array(_state, _field, _type, _num), \\\n+ .offset = vmstate_offset_array(_state, _field, _type *, _num), \\\n }\n \n #define VMSTATE_ARRAY_OF_POINTER_TO_STRUCT(_f, _s, _n, _v, _vmsd, _type) { \\\n@@ -1093,7 +1093,7 @@ extern const VMStateInfo vmstate_info_qlist;\n VMSTATE_TIMER_PTR_V(_f, _s, 0)\n \n #define VMSTATE_TIMER_PTR_ARRAY(_f, _s, _n) \\\n- VMSTATE_ARRAY_OF_POINTER(_f, _s, _n, 0, vmstate_info_timer, QEMUTimer *)\n+ VMSTATE_ARRAY_OF_POINTER(_f, _s, _n, 0, vmstate_info_timer, QEMUTimer)\n \n #define VMSTATE_TIMER_TEST(_f, _s, _test) \\\n VMSTATE_SINGLE_TEST(_f, _s, _test, 0, vmstate_info_timer, QEMUTimer)\ndiff --git a/tests/unit/test-vmstate.c b/tests/unit/test-vmstate.c\nindex cadbab3c5e..6a42cc1a4e 100644\n--- a/tests/unit/test-vmstate.c\n+++ b/tests/unit/test-vmstate.c\n@@ -668,7 +668,7 @@ const VMStateDescription vmsd_arpp = {\n .minimum_version_id = 1,\n .fields = (const VMStateField[]) {\n VMSTATE_ARRAY_OF_POINTER(ar, TestArrayOfPtrToInt,\n- AR_SIZE, 0, vmstate_info_int32, int32_t*),\n+ AR_SIZE, 0, vmstate_info_int32, int32_t),\n VMSTATE_END_OF_LIST()\n }\n };\n","prefixes":["PULL","24/43"]}