{"id":2227473,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2227473/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-41-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423191958.1440-41-farosas@suse.de>","list_archive_url":null,"date":"2026-04-23T19:19:54","name":"[PULL,40/43] tests/qtest/migration: fix fd leak in ufd_version_check","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"abf0418a2ad4c5fc5bbf895d8b81d237c0efb40d","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/1.2/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-41-farosas@suse.de/mbox/","series":[{"id":501236,"url":"http://patchwork.ozlabs.org/api/1.2/series/501236/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501236","date":"2026-04-23T19:19:14","name":"[PULL,01/43] checkpatch: Allow spaces after all coroutine annotations","version":1,"mbox":"http://patchwork.ozlabs.org/series/501236/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227473/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227473/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=qeLvomiv;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=/4WgRbAI;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=qeLvomiv;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=/4WgRbAI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=qeLvomiv;\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=\"/4WgRbAI\""],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1mHP2HDpz1y2d\n\tfor ; Fri, 24 Apr 2026 05:24:17 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFzdJ-0006C1-TW; Thu, 23 Apr 2026 15:22:42 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFzcd-0004V3-7m\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:22:00 -0400","from smtp-out2.suse.de ([195.135.223.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFzcb-0002Do-GN\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:21:58 -0400","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 300B95BD8D;\n Thu, 23 Apr 2026 19:21:03 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 23ED1593A3;\n Thu, 23 Apr 2026 19:21:01 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id QNcyOB1x6mlJCwAAD6G6ig\n (envelope-from ); Thu, 23 Apr 2026 19:21:01 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972063;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=d4jlPyOZ8Zi5EadVdmpm+/KWV1+vkRA9+hUwNZBEYHc=;\n b=qeLvomivfcmLUz9c8WihzNcKmI6h1Mmh5PtCeCk9QWUpf22Fa+HcjfYgZ3/WescZtoVEJB\n NEv4KTeYmUQeBIyHqG5uVOSRfldDALFi+gxLMxOqpqPEFqrBIjN6yvLhGSy+xeGs2O9mQh\n QmOkn9BVEh2LnFOfOTM625ea5rmxK4Y=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972063;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=d4jlPyOZ8Zi5EadVdmpm+/KWV1+vkRA9+hUwNZBEYHc=;\n b=/4WgRbAIWjDdihoZ0+vld5QjX5rhJLzI2LhBSTfw+n0upisnaWuiCveeFv/dz4QjaaLbTa\n Kjqnb8X6BlKBMoAg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972063;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=d4jlPyOZ8Zi5EadVdmpm+/KWV1+vkRA9+hUwNZBEYHc=;\n b=qeLvomivfcmLUz9c8WihzNcKmI6h1Mmh5PtCeCk9QWUpf22Fa+HcjfYgZ3/WescZtoVEJB\n NEv4KTeYmUQeBIyHqG5uVOSRfldDALFi+gxLMxOqpqPEFqrBIjN6yvLhGSy+xeGs2O9mQh\n QmOkn9BVEh2LnFOfOTM625ea5rmxK4Y=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972063;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=d4jlPyOZ8Zi5EadVdmpm+/KWV1+vkRA9+hUwNZBEYHc=;\n b=/4WgRbAIWjDdihoZ0+vld5QjX5rhJLzI2LhBSTfw+n0upisnaWuiCveeFv/dz4QjaaLbTa\n Kjqnb8X6BlKBMoAg=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu ,\n\tTrieu Huynh ","Subject":"[PULL 40/43] tests/qtest/migration: fix fd leak in ufd_version_check","Date":"Thu, 23 Apr 2026 16:19:54 -0300","Message-ID":"<20260423191958.1440-41-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260423191958.1440-1-farosas@suse.de>","References":"<20260423191958.1440-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spamd-Result":"default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_MISSING_CHARSET(0.50)[];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n FREEMAIL_CC(0.00)[redhat.com,gmail.com]; RCVD_TLS_ALL(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[];\n FROM_HAS_DN(0.00)[];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:dkim,suse.de:email];\n RCVD_VIA_SMTP_AUTH(0.00)[];\n RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_THREE(0.00)[3];\n FREEMAIL_ENVRCPT(0.00)[gmail.com]","X-Rspamd-Action":"no action","X-Spam-Score":"-3.01","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Rspamd-Queue-Id":"300B95BD8D","Received-SPF":"pass client-ip=195.135.223.131; envelope-from=farosas@suse.de;\n helo=smtp-out2.suse.de","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Trieu Huynh \n\nufd_version_check() opens a userfaultfd via uffd_open() but never closes\nit on any path where the open succeeded: the UFFDIO_API failure path,\nthe missing-ioctls path, and the success path all returned without\ncalling close(ufd).\n\nConvert to a goto-out pattern consistent with uffd_open() used in\nutil/userfaultfd.c and migration/postcopy-ram.c, ensuring the fd is\nalways closed before returning.\n\nSigned-off-by: Trieu Huynh \nReviewed-by: Peter Xu \nLink: https://lore.kernel.org/qemu-devel/20260419110304.8661-1-viking4@gmail.com\nSigned-off-by: Fabiano Rosas \n---\n tests/qtest/migration/migration-util.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/tests/qtest/migration/migration-util.c b/tests/qtest/migration/migration-util.c\nindex 2648ad7f61..db66d8b24f 100644\n--- a/tests/qtest/migration/migration-util.c\n+++ b/tests/qtest/migration/migration-util.c\n@@ -343,6 +343,7 @@ bool ufd_version_check(bool *uffd_feature_thread_id)\n {\n struct uffdio_api api_struct;\n uint64_t ioctl_mask;\n+ bool ret = false;\n \n int ufd = uffd_open(O_CLOEXEC);\n \n@@ -355,7 +356,7 @@ bool ufd_version_check(bool *uffd_feature_thread_id)\n api_struct.features = 0;\n if (ioctl(ufd, UFFDIO_API, &api_struct)) {\n g_test_message(\"Skipping test: UFFDIO_API failed\");\n- return false;\n+ goto release_ufd;\n }\n \n if (uffd_feature_thread_id) {\n@@ -366,10 +367,13 @@ bool ufd_version_check(bool *uffd_feature_thread_id)\n 1ULL << _UFFDIO_UNREGISTER);\n if ((api_struct.ioctls & ioctl_mask) != ioctl_mask) {\n g_test_message(\"Skipping test: Missing userfault feature\");\n- return false;\n+ goto release_ufd;\n }\n \n- return true;\n+ ret = true;\n+release_ufd:\n+ close(ufd);\n+ return ret;\n }\n #else\n bool ufd_version_check(bool *uffd_feature_thread_id)\n","prefixes":["PULL","40/43"]}