{"id":2227471,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2227471/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-40-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423191958.1440-40-farosas@suse.de>","list_archive_url":null,"date":"2026-04-23T19:19:53","name":"[PULL,39/43] tests/unit: add pread/pwrite _all tests for io channel file","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"141797663369e7bb547cfec4bb4702d9514a143f","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/1.2/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-40-farosas@suse.de/mbox/","series":[{"id":501236,"url":"http://patchwork.ozlabs.org/api/1.2/series/501236/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501236","date":"2026-04-23T19:19:14","name":"[PULL,01/43] checkpatch: Allow spaces after all coroutine annotations","version":1,"mbox":"http://patchwork.ozlabs.org/series/501236/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227471/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227471/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=EdCwKYCg;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=cverKs2V;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=EdCwKYCg;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=cverKs2V;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EdCwKYCg;\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=cverKs2V"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1mHB4MBdz1yCv\n\tfor ; Fri, 24 Apr 2026 05:24:06 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFzdo-0008Mp-NM; Thu, 23 Apr 2026 15:23:12 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFzdR-0007Qr-Qe\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:22:52 -0400","from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFzdO-0002XA-2o\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:22:49 -0400","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id B817A6A8A3;\n Thu, 23 Apr 2026 19:21:01 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 79FAA593A3;\n Thu, 23 Apr 2026 19:21:00 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id iJJqERxx6mlJCwAAD6G6ig\n (envelope-from ); Thu, 23 Apr 2026 19:21:00 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972061;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=K9h1RGVUintiLczHJ0lwPb10uCyBb8GYOF4K4VgEEz8=;\n b=EdCwKYCgQjR+c33467V+ig3utSpZYmBrd0q/iD96a1C0x/Sj0OT0omZdmIbvcN2MB4RNat\n U54zTVWn01ExSxrB7Gx4AqpV36jmtFUX9mOqr/wzjfQTtOHiFZOxgakPUQTPXKOi7H0d4u\n EUC2d+Zng0Oh7cg0ZwzSP+BOSGzmlXc=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972061;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=K9h1RGVUintiLczHJ0lwPb10uCyBb8GYOF4K4VgEEz8=;\n b=cverKs2VFUC8JfINeXVaQpIculdj1jx9LVmCnxniTlrIXg8+v5DZC4qUdbVliDSni/di1n\n JmTLnAMS1hx0diCw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972061;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=K9h1RGVUintiLczHJ0lwPb10uCyBb8GYOF4K4VgEEz8=;\n b=EdCwKYCgQjR+c33467V+ig3utSpZYmBrd0q/iD96a1C0x/Sj0OT0omZdmIbvcN2MB4RNat\n U54zTVWn01ExSxrB7Gx4AqpV36jmtFUX9mOqr/wzjfQTtOHiFZOxgakPUQTPXKOi7H0d4u\n EUC2d+Zng0Oh7cg0ZwzSP+BOSGzmlXc=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972061;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=K9h1RGVUintiLczHJ0lwPb10uCyBb8GYOF4K4VgEEz8=;\n b=cverKs2VFUC8JfINeXVaQpIculdj1jx9LVmCnxniTlrIXg8+v5DZC4qUdbVliDSni/di1n\n JmTLnAMS1hx0diCw=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu , Junjie Cao ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","Subject":"[PULL 39/43] tests/unit: add pread/pwrite _all tests for io channel\n file","Date":"Thu, 23 Apr 2026 16:19:53 -0300","Message-ID":"<20260423191958.1440-40-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260423191958.1440-1-farosas@suse.de>","References":"<20260423191958.1440-1-farosas@suse.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Rspamd-Action":"no action","X-Rspamd-Server":"rspamd2.dmz-prg2.suse.org","X-Spamd-Result":"default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[];\n RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[];\n RCPT_COUNT_THREE(0.00)[4]; FROM_EQ_ENVFROM(0.00)[];\n FROM_HAS_DN(0.00)[];\n RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,intel.com:email];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n DKIM_TRACE(0.00)[suse.de:+]","X-Rspamd-Queue-Id":"B817A6A8A3","X-Spam-Score":"-3.51","Received-SPF":"pass client-ip=2a07:de40:b251:101:10:150:64:1;\n envelope-from=farosas@suse.de; helo=smtp-out1.suse.de","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Junjie Cao \n\nAdd unit tests for the new qio_channel_pread{v,}_all{,_eof}() and\nqio_channel_pwrite{v,}_all() APIs.\n\nThe basic tests write data to a file channel, then read it back at\nvarious offsets using both the single-buffer and iovec variants to\nmake sure the round-trip produces identical content. The _eof tests\nverify all three return cases -- full read (1), clean EOF (0), and\npartial-then-EOF (-1 with error set) -- and check that the strict\nwrappers (preadv_all / pread_all) treat a clean EOF as an error.\n\nAll tests are guarded by CONFIG_PREADV since the underlying channel\nmethods require preadv(2).\n\nSigned-off-by: Junjie Cao \nReviewed-by: Fabiano Rosas \nReviewed-by: Daniel P. Berrangé \nAcked-by: Daniel P. Berrangé \nLink: https://lore.kernel.org/qemu-devel/20260413214549.926435-5-junjie.cao@intel.com\nSigned-off-by: Fabiano Rosas \n---\n tests/unit/test-io-channel-file.c | 207 ++++++++++++++++++++++++++++++\n 1 file changed, 207 insertions(+)","diff":"diff --git a/tests/unit/test-io-channel-file.c b/tests/unit/test-io-channel-file.c\nindex 1977006ce9..b597350dca 100644\n--- a/tests/unit/test-io-channel-file.c\n+++ b/tests/unit/test-io-channel-file.c\n@@ -102,6 +102,203 @@ static void test_io_channel_fd(void)\n }\n \n \n+#ifdef CONFIG_PREADV\n+static void test_io_channel_pread_all(void)\n+{\n+ QIOChannel *ioc;\n+ char write_buf[] = \"Hello World, pread_all\";\n+ char read_buf[sizeof(write_buf)] = {0};\n+ int ret;\n+\n+ unlink(TEST_FILE);\n+ ioc = QIO_CHANNEL(qio_channel_file_new_path(\n+ TEST_FILE,\n+ O_RDWR | O_CREAT | O_TRUNC | O_BINARY,\n+ TEST_MASK,\n+ &error_abort));\n+\n+ ret = qio_channel_pwrite_all(ioc, write_buf, sizeof(write_buf),\n+ 0, &error_abort);\n+ g_assert_cmpint(ret, ==, 0);\n+\n+ /* Read back at offset 0 */\n+ ret = qio_channel_pread_all(ioc, read_buf, sizeof(read_buf),\n+ 0, &error_abort);\n+ g_assert_cmpint(ret, ==, 0);\n+ g_assert_cmpmem(write_buf, sizeof(write_buf),\n+ read_buf, sizeof(read_buf));\n+\n+ /* Read at a non-zero offset */\n+ memset(read_buf, 0, sizeof(read_buf));\n+ ret = qio_channel_pread_all(ioc, read_buf, sizeof(write_buf) - 7,\n+ 7, &error_abort);\n+ g_assert_cmpint(ret, ==, 0);\n+ g_assert_cmpmem(write_buf + 7, sizeof(write_buf) - 7,\n+ read_buf, sizeof(write_buf) - 7);\n+\n+ unlink(TEST_FILE);\n+ object_unref(OBJECT(ioc));\n+}\n+\n+static void test_io_channel_preadv_all(void)\n+{\n+ QIOChannel *ioc;\n+ char write_buf[256];\n+ char read_buf[256] = {0};\n+ struct iovec write_iov[2];\n+ struct iovec read_iov[2];\n+ int ret;\n+ size_t i;\n+\n+ for (i = 0; i < sizeof(write_buf); i++) {\n+ write_buf[i] = i & 0xff;\n+ }\n+\n+ unlink(TEST_FILE);\n+ ioc = QIO_CHANNEL(qio_channel_file_new_path(\n+ TEST_FILE,\n+ O_RDWR | O_CREAT | O_TRUNC | O_BINARY,\n+ TEST_MASK,\n+ &error_abort));\n+\n+ /* Write using pwritev_all with 2 iovecs */\n+ write_iov[0].iov_base = write_buf;\n+ write_iov[0].iov_len = 128;\n+ write_iov[1].iov_base = write_buf + 128;\n+ write_iov[1].iov_len = 128;\n+ ret = qio_channel_pwritev_all(ioc, write_iov, 2, 0, &error_abort);\n+ g_assert_cmpint(ret, ==, 0);\n+\n+ /* Read back using preadv_all with 2 iovecs */\n+ read_iov[0].iov_base = read_buf;\n+ read_iov[0].iov_len = 128;\n+ read_iov[1].iov_base = read_buf + 128;\n+ read_iov[1].iov_len = 128;\n+ ret = qio_channel_preadv_all(ioc, read_iov, 2, 0, &error_abort);\n+ g_assert_cmpint(ret, ==, 0);\n+\n+ g_assert_cmpmem(write_buf, sizeof(write_buf),\n+ read_buf, sizeof(read_buf));\n+\n+ /* Read at non-zero offset with preadv_all */\n+ memset(read_buf, 0, sizeof(read_buf));\n+ read_iov[0].iov_base = read_buf;\n+ read_iov[0].iov_len = 64;\n+ read_iov[1].iov_base = read_buf + 64;\n+ read_iov[1].iov_len = 64;\n+ ret = qio_channel_preadv_all(ioc, read_iov, 2, 128, &error_abort);\n+ g_assert_cmpint(ret, ==, 0);\n+\n+ g_assert_cmpmem(write_buf + 128, 128,\n+ read_buf, 128);\n+\n+ unlink(TEST_FILE);\n+ object_unref(OBJECT(ioc));\n+}\n+\n+static void test_io_channel_preadv_all_eof(void)\n+{\n+ QIOChannel *ioc;\n+ char write_buf[] = \"Hello World, preadv_all_eof\";\n+ char read_buf[sizeof(write_buf)] = {0};\n+ struct iovec iov;\n+ int ret;\n+ Error *err = NULL;\n+\n+ unlink(TEST_FILE);\n+ ioc = QIO_CHANNEL(qio_channel_file_new_path(\n+ TEST_FILE,\n+ O_RDWR | O_CREAT | O_TRUNC | O_BINARY,\n+ TEST_MASK,\n+ &error_abort));\n+\n+ ret = qio_channel_pwrite_all(ioc, write_buf, sizeof(write_buf),\n+ 0, &error_abort);\n+ g_assert_cmpint(ret, ==, 0);\n+\n+ /* Full read succeeds: should return 1 */\n+ iov.iov_base = read_buf;\n+ iov.iov_len = sizeof(read_buf);\n+ ret = qio_channel_preadv_all_eof(ioc, &iov, 1, 0, &error_abort);\n+ g_assert_cmpint(ret, ==, 1);\n+ g_assert_cmpmem(write_buf, sizeof(write_buf),\n+ read_buf, sizeof(read_buf));\n+\n+ /* Clean EOF: offset at file end, should return 0 */\n+ iov.iov_base = read_buf;\n+ iov.iov_len = 1;\n+ ret = qio_channel_preadv_all_eof(ioc, &iov, 1,\n+ sizeof(write_buf), &err);\n+ g_assert_cmpint(ret, ==, 0);\n+ g_assert_null(err);\n+\n+ /* Partial EOF: start before end, request extends past */\n+ iov.iov_base = read_buf;\n+ iov.iov_len = 8;\n+ ret = qio_channel_preadv_all_eof(ioc, &iov, 1,\n+ sizeof(write_buf) - 4, &err);\n+ g_assert_cmpint(ret, ==, -1);\n+ g_assert_nonnull(err);\n+ error_free(err);\n+ err = NULL;\n+\n+ /* Strict wrapper (preadv_all) treats clean EOF as error */\n+ iov.iov_base = read_buf;\n+ iov.iov_len = 1;\n+ ret = qio_channel_preadv_all(ioc, &iov, 1,\n+ sizeof(write_buf), &err);\n+ g_assert_cmpint(ret, ==, -1);\n+ g_assert_nonnull(err);\n+ error_free(err);\n+\n+ unlink(TEST_FILE);\n+ object_unref(OBJECT(ioc));\n+}\n+\n+static void test_io_channel_pread_all_eof(void)\n+{\n+ QIOChannel *ioc;\n+ char write_buf[] = \"Hello World, pread_all_eof\";\n+ char read_buf[sizeof(write_buf)] = {0};\n+ int ret;\n+ Error *err = NULL;\n+\n+ unlink(TEST_FILE);\n+ ioc = QIO_CHANNEL(qio_channel_file_new_path(\n+ TEST_FILE,\n+ O_RDWR | O_CREAT | O_TRUNC | O_BINARY,\n+ TEST_MASK,\n+ &error_abort));\n+\n+ ret = qio_channel_pwrite_all(ioc, write_buf, sizeof(write_buf),\n+ 0, &error_abort);\n+ g_assert_cmpint(ret, ==, 0);\n+\n+ /* Full read succeeds: should return 1 */\n+ ret = qio_channel_pread_all_eof(ioc, read_buf, sizeof(read_buf),\n+ 0, &error_abort);\n+ g_assert_cmpint(ret, ==, 1);\n+ g_assert_cmpmem(write_buf, sizeof(write_buf),\n+ read_buf, sizeof(read_buf));\n+\n+ /* Clean EOF: should return 0 */\n+ ret = qio_channel_pread_all_eof(ioc, read_buf, 1,\n+ sizeof(write_buf), &err);\n+ g_assert_cmpint(ret, ==, 0);\n+ g_assert_null(err);\n+\n+ /* Partial EOF: should return -1 */\n+ ret = qio_channel_pread_all_eof(ioc, read_buf, 8,\n+ sizeof(write_buf) - 4, &err);\n+ g_assert_cmpint(ret, ==, -1);\n+ g_assert_nonnull(err);\n+ error_free(err);\n+\n+ unlink(TEST_FILE);\n+ object_unref(OBJECT(ioc));\n+}\n+#endif /* CONFIG_PREADV */\n+\n #ifndef _WIN32\n static void test_io_channel_pipe(bool async)\n {\n@@ -147,6 +344,16 @@ int main(int argc, char **argv)\n g_test_add_func(\"/io/channel/file\", test_io_channel_file);\n g_test_add_func(\"/io/channel/file/rdwr\", test_io_channel_file_rdwr);\n g_test_add_func(\"/io/channel/file/fd\", test_io_channel_fd);\n+#ifdef CONFIG_PREADV\n+ g_test_add_func(\"/io/channel/file/pread-all\",\n+ test_io_channel_pread_all);\n+ g_test_add_func(\"/io/channel/file/preadv-all\",\n+ test_io_channel_preadv_all);\n+ g_test_add_func(\"/io/channel/file/preadv-all-eof\",\n+ test_io_channel_preadv_all_eof);\n+ g_test_add_func(\"/io/channel/file/pread-all-eof\",\n+ test_io_channel_pread_all_eof);\n+#endif\n #ifndef _WIN32\n g_test_add_func(\"/io/channel/pipe/sync\", test_io_channel_pipe_sync);\n g_test_add_func(\"/io/channel/pipe/async\", test_io_channel_pipe_async);\n","prefixes":["PULL","39/43"]}