{"id":2227470,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2227470/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-36-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423191958.1440-36-farosas@suse.de>","list_archive_url":null,"date":"2026-04-23T19:19:49","name":"[PULL,35/43] migration: validate page_size in mapped-ram header before use","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"eab37cac1012aac36280c3ead42b8bff38c99a57","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/1.2/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-36-farosas@suse.de/mbox/","series":[{"id":501236,"url":"http://patchwork.ozlabs.org/api/1.2/series/501236/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501236","date":"2026-04-23T19:19:14","name":"[PULL,01/43] checkpatch: Allow spaces after all coroutine annotations","version":1,"mbox":"http://patchwork.ozlabs.org/series/501236/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227470/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227470/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=JpIV7OW1;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=zyolQZB/;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=JpIV7OW1;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=zyolQZB/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=JpIV7OW1;\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=\"zyolQZB/\""],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1mHB4zj3z1yHy\n\tfor ; Fri, 24 Apr 2026 05:24:06 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFzdK-0006Qa-JI; Thu, 23 Apr 2026 15:22:42 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFzd7-0005PX-Vr\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:22:31 -0400","from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFzd5-0002Tv-Ay\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:22:28 -0400","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 566AB6A8B0;\n Thu, 23 Apr 2026 19:20:55 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 49699593A3;\n Thu, 23 Apr 2026 19:20:54 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id kCaoBRZx6mlJCwAAD6G6ig\n (envelope-from ); Thu, 23 Apr 2026 19:20:54 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972055;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=bsC0tAJU0vPUAdnXpmAN2YzSuLZ8Ne5Etd51mKJ9OnE=;\n b=JpIV7OW1MnIZkmAFwYZOyVotq/KrMRFP2Dk9JMty+LMdFKiKKWpm7EvkWFnG9Ixpw7XqKS\n GNqg0rZ7MquIlSWh2juHkP7zdUD8WioEZVHgE/pA8pRJn4+BLy2jzJQsOjNviqXFhkwQKu\n pfUlYJPBwuxz0PGYVw/0E5poccUmR1Y=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972055;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=bsC0tAJU0vPUAdnXpmAN2YzSuLZ8Ne5Etd51mKJ9OnE=;\n b=zyolQZB/q8PtIQk5sdD1mJbyuuqDzQ0/hB7BfbTrBnkQdzfdjaXmrDEQK7cSu6ui2c1V/y\n 5fZaZ5HzjOZ1D2DA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972055;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=bsC0tAJU0vPUAdnXpmAN2YzSuLZ8Ne5Etd51mKJ9OnE=;\n b=JpIV7OW1MnIZkmAFwYZOyVotq/KrMRFP2Dk9JMty+LMdFKiKKWpm7EvkWFnG9Ixpw7XqKS\n GNqg0rZ7MquIlSWh2juHkP7zdUD8WioEZVHgE/pA8pRJn4+BLy2jzJQsOjNviqXFhkwQKu\n pfUlYJPBwuxz0PGYVw/0E5poccUmR1Y=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972055;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=bsC0tAJU0vPUAdnXpmAN2YzSuLZ8Ne5Etd51mKJ9OnE=;\n b=zyolQZB/q8PtIQk5sdD1mJbyuuqDzQ0/hB7BfbTrBnkQdzfdjaXmrDEQK7cSu6ui2c1V/y\n 5fZaZ5HzjOZ1D2DA=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu ,\n\tTrieu Huynh ","Subject":"[PULL 35/43] migration: validate page_size in mapped-ram header\n before use","Date":"Thu, 23 Apr 2026 16:19:49 -0300","Message-ID":"<20260423191958.1440-36-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260423191958.1440-1-farosas@suse.de>","References":"<20260423191958.1440-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spamd-Result":"default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_MISSING_CHARSET(0.50)[];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n FREEMAIL_CC(0.00)[redhat.com,gmail.com]; RCVD_TLS_ALL(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[];\n FROM_HAS_DN(0.00)[];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:dkim,suse.de:email];\n RCVD_VIA_SMTP_AUTH(0.00)[];\n RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_THREE(0.00)[3];\n FREEMAIL_ENVRCPT(0.00)[gmail.com]","X-Rspamd-Action":"no action","X-Spam-Score":"-3.01","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Rspamd-Queue-Id":"566AB6A8B0","Received-SPF":"pass client-ip=2a07:de40:b251:101:10:150:64:1;\n envelope-from=farosas@suse.de; helo=smtp-out1.suse.de","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Trieu Huynh \n\nmapped_ram_read_header() reads page_size from the migration stream and\nstores it in MappedRamHeader, but does not validate that the value is\nnon-zero before it is later used in parse_ramblock_mapped_ram():\n\nnum_pages = length / header.page_size;\n\nIf a corrupted or malformed migration stream provides invalid, guest\nresumes either with corrupted memory or crashes unexpectedly (eg.\npage_size = 0)\n\nAdd validation in mapped_ram_read_header() to reject invalid page_size\nvalues early and return an error instead of continuing with an invalid\nheader.\n\nSteps to reproduce:\n\nCreate a migration snapshot with mapped-ram enabled:\n(qemu) migrate_set_capability mapped-ram on\n(qemu) migrate file:/tmp/qemu-snapshots/snapshot.bin\nModify the snapshot so that MappedRamHeader.page_size becomes diff with\ntarget psize. (0/512/8192/1GB).\nRestore the snapshot:\n(qemu) migrate_set_capability mapped-ram on\n(qemu) migrate_incoming file:/tmp/qemu-snapshots/snapshot.bin\n\nAs-is:\n* [0]: Floating point exception (core dumped)\n* [512/8192]: Silent corruption\n* [1GB]: \"post load hook failed for: kvm-tpr-opt\" (EPERM)\nTo-be:\n* All: qemu-system-x86_64: Migration mapped-ram header has invalid\n page_size [val] (expected 4096)\n\nSigned-off-by: Trieu Huynh \nReviewed-by: Fabiano Rosas \nReviewed-by: Peter Xu \nLink: https://lore.kernel.org/qemu-devel/20260405094447.11347-1-viking4@gmail.com\nSigned-off-by: Fabiano Rosas \n---\n migration/ram.c | 6 ++++++\n 1 file changed, 6 insertions(+)","diff":"diff --git a/migration/ram.c b/migration/ram.c\nindex 979751f61b..2046f16caa 100644\n--- a/migration/ram.c\n+++ b/migration/ram.c\n@@ -3088,6 +3088,12 @@ static bool mapped_ram_read_header(QEMUFile *file, MappedRamHeader *header,\n }\n \n header->page_size = be64_to_cpu(header->page_size);\n+ if (header->page_size != TARGET_PAGE_SIZE) {\n+ error_setg(errp, \"Migration mapped-ram header has invalid \"\n+ \"page_size %\" PRIu64 \" (expected %d)\",\n+ header->page_size, TARGET_PAGE_SIZE);\n+ return false;\n+ }\n header->bitmap_offset = be64_to_cpu(header->bitmap_offset);\n header->pages_offset = be64_to_cpu(header->pages_offset);\n \n","prefixes":["PULL","35/43"]}