{"id":2227464,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2227464/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-7-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423191958.1440-7-farosas@suse.de>","list_archive_url":null,"date":"2026-04-23T19:19:20","name":"[PULL,06/43] migration: vmstate_load_state(): add some newlines","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8b3fac07b93830c938f76c589e18cbe8c8f19f20","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/1.2/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-7-farosas@suse.de/mbox/","series":[{"id":501236,"url":"http://patchwork.ozlabs.org/api/1.2/series/501236/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501236","date":"2026-04-23T19:19:14","name":"[PULL,01/43] checkpatch: Allow spaces after all coroutine annotations","version":1,"mbox":"http://patchwork.ozlabs.org/series/501236/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227464/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227464/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=H7RPSn4f;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=YILaJC44;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=H7RPSn4f;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=YILaJC44;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=H7RPSn4f;\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=YILaJC44"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1mFk3S6Vz1y2d\n\tfor ; Fri, 24 Apr 2026 05:22:50 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFzb8-0001q5-Mi; Thu, 23 Apr 2026 15:20:26 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFzb6-0001pp-UG\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:20:24 -0400","from smtp-out1.suse.de ([195.135.223.130])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFzb5-0001mI-3v\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:20:24 -0400","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 5AB1D6A894;\n Thu, 23 Apr 2026 19:20:10 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 54B2C593B0;\n Thu, 23 Apr 2026 19:20:09 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id eCjACOlw6mlJCwAAD6G6ig\n (envelope-from ); Thu, 23 Apr 2026 19:20:09 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972010;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=xNu+6SUCFbQGXOQhLmMux0cecIlR+BfYVaYKEuipyCA=;\n b=H7RPSn4fRav4CznEyxhAXNcVZdfxIaxQQ2i2VJiB/WW0r8Rio8eWSvgNPMe/L7Sg2d5BI3\n zmN5zruBui79nMP+sRZl5FyJulYcrKGHO5f5UHtKkRtypKIfIizUduOdgnSg6dTWX6tZep\n TLKGzCO3ZrWvIQmNFNUQd+rWhMKn0oA=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972010;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=xNu+6SUCFbQGXOQhLmMux0cecIlR+BfYVaYKEuipyCA=;\n b=YILaJC44/jH0bti1B3RAPgL4h1+22OtfcAszH/W3adaJbaVbhFpMYvlgoFSuIabrELioeK\n N6UK7+le58OAI7CA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972010;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=xNu+6SUCFbQGXOQhLmMux0cecIlR+BfYVaYKEuipyCA=;\n b=H7RPSn4fRav4CznEyxhAXNcVZdfxIaxQQ2i2VJiB/WW0r8Rio8eWSvgNPMe/L7Sg2d5BI3\n zmN5zruBui79nMP+sRZl5FyJulYcrKGHO5f5UHtKkRtypKIfIizUduOdgnSg6dTWX6tZep\n TLKGzCO3ZrWvIQmNFNUQd+rWhMKn0oA=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972010;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=xNu+6SUCFbQGXOQhLmMux0cecIlR+BfYVaYKEuipyCA=;\n b=YILaJC44/jH0bti1B3RAPgL4h1+22OtfcAszH/W3adaJbaVbhFpMYvlgoFSuIabrELioeK\n N6UK7+le58OAI7CA=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu ,\n Vladimir Sementsov-Ogievskiy ","Subject":"[PULL 06/43] migration: vmstate_load_state(): add some newlines","Date":"Thu, 23 Apr 2026 16:19:20 -0300","Message-ID":"<20260423191958.1440-7-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260423191958.1440-1-farosas@suse.de>","References":"<20260423191958.1440-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Rspamd-Action":"no action","X-Rspamd-Server":"rspamd2.dmz-prg2.suse.org","X-Spamd-Result":"default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns];\n ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_MATCH_ENVRCPT_ALL(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RCPT_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]","X-Rspamd-Queue-Id":"5AB1D6A894","X-Spam-Score":"-3.01","Received-SPF":"pass client-ip=195.135.223.130; envelope-from=farosas@suse.de;\n helo=smtp-out1.suse.de","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Vladimir Sementsov-Ogievskiy \n\nSplit logical blocks by newlines, that simplify reading the code.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy \nReviewed-by: Fabiano Rosas \nReviewed-by: Peter Xu \nLink: https://lore.kernel.org/qemu-devel/20260304212303.667141-5-vsementsov@yandex-team.ru\nSigned-off-by: Fabiano Rosas \n---\n migration/vmstate.c | 12 ++++++++++++\n 1 file changed, 12 insertions(+)","diff":"diff --git a/migration/vmstate.c b/migration/vmstate.c\nindex 5111e7a141..dd7cd27993 100644\n--- a/migration/vmstate.c\n+++ b/migration/vmstate.c\n@@ -139,6 +139,7 @@ int vmstate_load_state(QEMUFile *f, const VMStateDescription *vmsd,\n int ret = 0;\n \n trace_vmstate_load_state(vmsd->name, version_id);\n+\n if (version_id > vmsd->version_id) {\n error_setg(errp, \"%s: incoming version_id %d is too new \"\n \"for local version_id %d\",\n@@ -146,6 +147,7 @@ int vmstate_load_state(QEMUFile *f, const VMStateDescription *vmsd,\n trace_vmstate_load_state_end(vmsd->name, \"too new\", -EINVAL);\n return -EINVAL;\n }\n+\n if (version_id < vmsd->minimum_version_id) {\n error_setg(errp, \"%s: incoming version_id %d is too old \"\n \"for local minimum version_id %d\",\n@@ -153,6 +155,7 @@ int vmstate_load_state(QEMUFile *f, const VMStateDescription *vmsd,\n trace_vmstate_load_state_end(vmsd->name, \"too old\", -EINVAL);\n return -EINVAL;\n }\n+\n if (vmsd->pre_load_errp) {\n if (!vmsd->pre_load_errp(opaque, errp)) {\n error_prepend(errp, \"pre load hook failed for: '%s', \"\n@@ -171,9 +174,12 @@ int vmstate_load_state(QEMUFile *f, const VMStateDescription *vmsd,\n return ret;\n }\n }\n+\n while (field->name) {\n bool exists = vmstate_field_exists(vmsd, field, opaque, version_id);\n+\n trace_vmstate_load_state_field(vmsd->name, field->name, exists);\n+\n if (exists) {\n void *first_elem = opaque + field->offset;\n int i, n_elems = vmstate_n_elems(opaque, field);\n@@ -184,6 +190,7 @@ int vmstate_load_state(QEMUFile *f, const VMStateDescription *vmsd,\n first_elem = *(void **)first_elem;\n assert(first_elem || !n_elems || !size);\n }\n+\n for (i = 0; i < n_elems; i++) {\n void *curr_elem = first_elem + size * i;\n const VMStateField *inner_field;\n@@ -235,6 +242,7 @@ int vmstate_load_state(QEMUFile *f, const VMStateDescription *vmsd,\n vmsd->name, ret);\n }\n }\n+\n if (ret < 0) {\n qemu_file_set_error(f, ret);\n trace_vmstate_load_field_error(field->name, ret);\n@@ -249,11 +257,13 @@ int vmstate_load_state(QEMUFile *f, const VMStateDescription *vmsd,\n field++;\n }\n assert(field->flags == VMS_END);\n+\n ret = vmstate_subsection_load(f, vmsd, opaque, errp);\n if (ret != 0) {\n qemu_file_set_error(f, ret);\n return ret;\n }\n+\n if (vmsd->post_load_errp) {\n if (!vmsd->post_load_errp(opaque, version_id, errp)) {\n error_prepend(errp, \"post load hook failed for: %s, version_id: \"\n@@ -271,7 +281,9 @@ int vmstate_load_state(QEMUFile *f, const VMStateDescription *vmsd,\n ret);\n }\n }\n+\n trace_vmstate_load_state_end(vmsd->name, \"end\", ret);\n+\n return ret;\n }\n \n","prefixes":["PULL","06/43"]}