{"id":2227454,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2227454/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-10-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423191958.1440-10-farosas@suse.de>","list_archive_url":null,"date":"2026-04-23T19:19:23","name":"[PULL,09/43] migration: factor out vmstate_save_field() from vmstate_save_state()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1501e29ab4b20523eecd6c619570846e7cbce61b","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/1.2/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-10-farosas@suse.de/mbox/","series":[{"id":501236,"url":"http://patchwork.ozlabs.org/api/1.2/series/501236/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501236","date":"2026-04-23T19:19:14","name":"[PULL,01/43] checkpatch: Allow spaces after all coroutine annotations","version":1,"mbox":"http://patchwork.ozlabs.org/series/501236/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227454/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227454/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=wEdSQ1+6;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=5/lCWhPZ;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=wEdSQ1+6;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=5/lCWhPZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wEdSQ1+6;\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=\"5/lCWhPZ\""],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1mDH6nVmz1y2d\n\tfor ; Fri, 24 Apr 2026 05:21:35 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFzbv-00022X-UM; Thu, 23 Apr 2026 15:21:19 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFzbO-0001sT-Dq\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:20:45 -0400","from smtp-out1.suse.de ([195.135.223.130])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFzbM-0001pw-NI\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:20:42 -0400","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 93D866A8A0;\n Thu, 23 Apr 2026 19:20:14 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8F19C593A3;\n Thu, 23 Apr 2026 19:20:13 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id qJqrFu1w6mlJCwAAD6G6ig\n (envelope-from ); Thu, 23 Apr 2026 19:20:13 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972014;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=18fjL14Ng1FIiFptO1WgrOoN/4au2W6z2AZR18y3h0A=;\n b=wEdSQ1+6XsyBH56KSUgfuubFhNmA6gSIN4pJPwwDZqlmWgP+n0R1WmYxh7uajY+htFdz+R\n Lp2m21eDXIU1LNDr6AZ6PTp2/U+6Uo5TNH6VHsdA78TjbbmmIb2RGcOYfo552AXCgiT5u/\n 2GuK/BqDqcLmVKGr/7PPlxGtDRli76Q=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972014;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=18fjL14Ng1FIiFptO1WgrOoN/4au2W6z2AZR18y3h0A=;\n b=5/lCWhPZliylw5RcGqx6QdpSzFGSzKuJJhA/O0/p+fiVNQ9WXkFnKucNH3ZOHaViaWrZQg\n bZ1WQKBmkwLBNEDA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972014;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=18fjL14Ng1FIiFptO1WgrOoN/4au2W6z2AZR18y3h0A=;\n b=wEdSQ1+6XsyBH56KSUgfuubFhNmA6gSIN4pJPwwDZqlmWgP+n0R1WmYxh7uajY+htFdz+R\n Lp2m21eDXIU1LNDr6AZ6PTp2/U+6Uo5TNH6VHsdA78TjbbmmIb2RGcOYfo552AXCgiT5u/\n 2GuK/BqDqcLmVKGr/7PPlxGtDRli76Q=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972014;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=18fjL14Ng1FIiFptO1WgrOoN/4au2W6z2AZR18y3h0A=;\n b=5/lCWhPZliylw5RcGqx6QdpSzFGSzKuJJhA/O0/p+fiVNQ9WXkFnKucNH3ZOHaViaWrZQg\n bZ1WQKBmkwLBNEDA=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu ,\n Vladimir Sementsov-Ogievskiy ","Subject":"[PULL 09/43] migration: factor out vmstate_save_field() from\n vmstate_save_state()","Date":"Thu, 23 Apr 2026 16:19:23 -0300","Message-ID":"<20260423191958.1440-10-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260423191958.1440-1-farosas@suse.de>","References":"<20260423191958.1440-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spamd-Result":"default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; ARC_NA(0.00)[];\n RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n RCVD_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[];\n RCVD_VIA_SMTP_AUTH(0.00)[];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns];\n RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCPT_COUNT_THREE(0.00)[3];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n DKIM_TRACE(0.00)[suse.de:+]","X-Rspamd-Action":"no action","X-Spam-Score":"-3.01","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Rspamd-Queue-Id":"93D866A8A0","Received-SPF":"pass client-ip=195.135.223.130; envelope-from=farosas@suse.de;\n helo=smtp-out1.suse.de","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Vladimir Sementsov-Ogievskiy \n\nSimplify vmstate_save_state() which is rather big, and simplify further\nrefactoring.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy \nReviewed-by: Peter Xu \nLink: https://lore.kernel.org/qemu-devel/20260304212303.667141-8-vsementsov@yandex-team.ru\nSigned-off-by: Fabiano Rosas \n---\n migration/vmstate.c | 40 +++++++++++++++++++++++++---------------\n 1 file changed, 25 insertions(+), 15 deletions(-)","diff":"diff --git a/migration/vmstate.c b/migration/vmstate.c\nindex 605b5c59c7..2ce2652712 100644\n--- a/migration/vmstate.c\n+++ b/migration/vmstate.c\n@@ -26,6 +26,9 @@ static int vmstate_subsection_save(QEMUFile *f, const VMStateDescription *vmsd,\n Error **errp);\n static int vmstate_subsection_load(QEMUFile *f, const VMStateDescription *vmsd,\n void *opaque, Error **errp);\n+static int vmstate_save_state_v(QEMUFile *f, const VMStateDescription *vmsd,\n+ void *opaque, JSONWriter *vmdesc,\n+ int version_id, Error **errp);\n \n /* Whether this field should exist for either save or load the VM? */\n static bool\n@@ -455,6 +458,26 @@ static bool vmstate_pre_save(const VMStateDescription *vmsd, void *opaque,\n return true;\n }\n \n+static bool vmstate_save_field(QEMUFile *f, void *pv, size_t size,\n+ const VMStateField *field,\n+ JSONWriter *vmdesc, Error **errp)\n+{\n+ if (field->flags & VMS_STRUCT) {\n+ return vmstate_save_state(f, field->vmsd, pv, vmdesc, errp) >= 0;\n+ } else if (field->flags & VMS_VSTRUCT) {\n+ return vmstate_save_state_v(f, field->vmsd, pv, vmdesc,\n+ field->struct_version_id,\n+ errp) >= 0;\n+ }\n+\n+ if (field->info->put(f, pv, size, field, vmdesc) < 0) {\n+ error_setg(errp, \"put failed\");\n+ return false;\n+ }\n+\n+ return true;\n+}\n+\n static int vmstate_save_state_v(QEMUFile *f, const VMStateDescription *vmsd,\n void *opaque, JSONWriter *vmdesc,\n int version_id, Error **errp)\n@@ -548,21 +571,8 @@ static int vmstate_save_state_v(QEMUFile *f, const VMStateDescription *vmsd,\n vmsd_desc_field_start(vmsd, vmdesc_loop, inner_field,\n i, max_elems);\n \n- if (inner_field->flags & VMS_STRUCT) {\n- ret = vmstate_save_state(f, inner_field->vmsd,\n- curr_elem, vmdesc_loop, errp);\n- } else if (inner_field->flags & VMS_VSTRUCT) {\n- ret = vmstate_save_state_v(f, inner_field->vmsd,\n- curr_elem, vmdesc_loop,\n- inner_field->struct_version_id,\n- errp);\n- } else {\n- ret = inner_field->info->put(f, curr_elem, size,\n- inner_field, vmdesc_loop);\n- if (ret < 0) {\n- error_setg(errp, \"put failed\");\n- }\n- }\n+ ret = vmstate_save_field(f, curr_elem, size, inner_field,\n+ vmdesc_loop, errp) ? 0 : -EINVAL;\n \n written_bytes = qemu_file_transferred(f) - old_offset;\n vmsd_desc_field_end(vmsd, vmdesc_loop, inner_field,\n","prefixes":["PULL","09/43"]}