{"id":2227453,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2227453/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-19-farosas@suse.de/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260423191958.1440-19-farosas@suse.de>","list_archive_url":null,"date":"2026-04-23T19:19:32","name":"[PULL,18/43] hw/s390x/css: drop use of .err_hint for vmstate","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8a2f44f0063650d9e89c71c01ed0e1681795115a","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/1.2/people/85343/?format=json","name":"Fabiano Rosas","email":"farosas@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-19-farosas@suse.de/mbox/","series":[{"id":501236,"url":"http://patchwork.ozlabs.org/api/1.2/series/501236/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501236","date":"2026-04-23T19:19:14","name":"[PULL,01/43] checkpatch: Allow spaces after all coroutine annotations","version":1,"mbox":"http://patchwork.ozlabs.org/series/501236/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2227453/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2227453/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=BN71xsWw;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=bjcJ9gfG;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=BN71xsWw;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=bjcJ9gfG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1mDG4yWsz1y2d\n\tfor ; Fri, 24 Apr 2026 05:21:34 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFzbS-0001sM-Fp; Thu, 23 Apr 2026 15:20:46 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wFzbJ-0001rp-VY\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:20:38 -0400","from smtp-out2.suse.de ([195.135.223.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wFzbH-0001ol-OL\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:20:37 -0400","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 7CCB45BD62;\n Thu, 23 Apr 2026 19:20:27 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4666A593A3;\n Thu, 23 Apr 2026 19:20:26 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id sElHBfpw6mlJCwAAD6G6ig\n (envelope-from ); Thu, 23 Apr 2026 19:20:26 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972027;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Yxq0LxrbCY14GhKOCjKifdrJXwZdHE2lOdV7GNZfWs4=;\n b=BN71xsWwAQ8pN3eHB7sY+LKBlJ+F55ln1ldFXop2XMh9PB8KKwHROdkqv5zmc8WF+bNsxr\n bn/NJPwjcYN5I+j6rmO9q8DrAWksmBdP/dfAq8jYmGiIBsAN2fggqJpBDddJaJkIW8E/WX\n srUjdmTtfqVEzI8KT5ufJ96NyCpATeE=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972027;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Yxq0LxrbCY14GhKOCjKifdrJXwZdHE2lOdV7GNZfWs4=;\n b=bjcJ9gfGxKkT9LddZlItAnGUSTEnB04IqfJUgKkTe2VLi+uMHB5hJtIAVuGCAaazz/3oZ1\n rGSOvr5RSJdVYwAw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972027;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Yxq0LxrbCY14GhKOCjKifdrJXwZdHE2lOdV7GNZfWs4=;\n b=BN71xsWwAQ8pN3eHB7sY+LKBlJ+F55ln1ldFXop2XMh9PB8KKwHROdkqv5zmc8WF+bNsxr\n bn/NJPwjcYN5I+j6rmO9q8DrAWksmBdP/dfAq8jYmGiIBsAN2fggqJpBDddJaJkIW8E/WX\n srUjdmTtfqVEzI8KT5ufJ96NyCpATeE=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972027;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Yxq0LxrbCY14GhKOCjKifdrJXwZdHE2lOdV7GNZfWs4=;\n b=bjcJ9gfGxKkT9LddZlItAnGUSTEnB04IqfJUgKkTe2VLi+uMHB5hJtIAVuGCAaazz/3oZ1\n rGSOvr5RSJdVYwAw=="],"From":"Fabiano Rosas ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu ,\n Vladimir Sementsov-Ogievskiy ,\n Eric Farman ","Subject":"[PULL 18/43] hw/s390x/css: drop use of .err_hint for vmstate","Date":"Thu, 23 Apr 2026 16:19:32 -0300","Message-ID":"<20260423191958.1440-19-farosas@suse.de>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260423191958.1440-1-farosas@suse.de>","References":"<20260423191958.1440-1-farosas@suse.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spamd-Result":"default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000];\n MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_SOME(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo];\n RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_ALL(0.00)[]","X-Spam-Score":"-2.80","Received-SPF":"pass client-ip=195.135.223.131; envelope-from=farosas@suse.de;\n helo=smtp-out2.suse.de","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Vladimir Sementsov-Ogievskiy \n\nThat's the only usage through the whole base. Doesn't\nworth keeping the whole complexity. And 2.7 machines were\nlong ago.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy \nReviewed-by: Eric Farman \nReviewed-by: Peter Xu \nLink: https://lore.kernel.org/qemu-devel/20260304212303.667141-17-vsementsov@yandex-team.ru\nSigned-off-by: Fabiano Rosas \n---\n hw/s390x/css.c | 15 ++++++++-------\n 1 file changed, 8 insertions(+), 7 deletions(-)","diff":"diff --git a/hw/s390x/css.c b/hw/s390x/css.c\nindex 04ce3178a0..df5f0bc27f 100644\n--- a/hw/s390x/css.c\n+++ b/hw/s390x/css.c\n@@ -192,10 +192,6 @@ static const VMStateDescription vmstate_schdev_orb = {\n static int subch_dev_post_load(void *opaque, int version_id);\n static int subch_dev_pre_save(void *opaque);\n \n-const char err_hint_devno[] = \"Devno mismatch, tried to load wrong section!\"\n- \" Likely reason: some sequences of plug and unplug can break\"\n- \" migration for machine versions prior to 2.7 (known design flaw).\";\n-\n const VMStateDescription vmstate_subch_dev = {\n .name = \"s390_subch_dev\",\n .version_id = 1,\n@@ -203,10 +199,15 @@ const VMStateDescription vmstate_subch_dev = {\n .post_load = subch_dev_post_load,\n .pre_save = subch_dev_pre_save,\n .fields = (const VMStateField[]) {\n- VMSTATE_UINT8_EQUAL(cssid, SubchDev, \"Bug!\"),\n- VMSTATE_UINT8_EQUAL(ssid, SubchDev, \"Bug!\"),\n+ VMSTATE_UINT8_EQUAL(cssid, SubchDev, NULL),\n+ VMSTATE_UINT8_EQUAL(ssid, SubchDev, NULL),\n VMSTATE_UINT16(migrated_schid, SubchDev),\n- VMSTATE_UINT16_EQUAL(devno, SubchDev, err_hint_devno),\n+ /*\n+ * If devno mismatch on target, it may be due to some\n+ * sequences of plug and unplug breaks migration for\n+ * machine versions prior to 2.7 (known design flaw).\n+ */\n+ VMSTATE_UINT16_EQUAL(devno, SubchDev, NULL),\n VMSTATE_BOOL(thinint_active, SubchDev),\n VMSTATE_STRUCT(curr_status, SubchDev, 0, vmstate_schib, SCHIB),\n VMSTATE_UINT8_ARRAY(sense_data, SubchDev, 32),\n","prefixes":["PULL","18/43"]}