{"id":2226495,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2226495/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/patch/20260422141234.632195-3-pvorel@suse.cz/","project":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.2/projects/59/?format=json","name":"Linux Test Project development","link_name":"ltp","list_id":"ltp.lists.linux.it","list_email":"ltp@lists.linux.it","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422141234.632195-3-pvorel@suse.cz>","list_archive_url":null,"date":"2026-04-22T14:12:31","name":"[v4,2/5] lib: Rename variable LTP_ENABLE_DEBUG => LTP_DEBUG","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"df601758b87cd855e795824ffbb4ad3472c1c574","submitter":{"id":70792,"url":"http://patchwork.ozlabs.org/api/1.2/people/70792/?format=json","name":"Petr Vorel","email":"pvorel@suse.cz"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ltp/patch/20260422141234.632195-3-pvorel@suse.cz/mbox/","series":[{"id":501017,"url":"http://patchwork.ozlabs.org/api/1.2/series/501017/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/list/?series=501017","date":"2026-04-22T14:12:31","name":"lib: LTP_DEBUG cleanup","version":4,"mbox":"http://patchwork.ozlabs.org/series/501017/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226495/comments/","check":"warning","checks":"http://patchwork.ozlabs.org/api/patches/2226495/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=qdZuNtSc;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=2Q2SJ+z3;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=qdZuNtSc;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=2Q2SJ+z3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g11QQ5JTzz1yCv\n\tfor ; Thu, 23 Apr 2026 00:12:46 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 45EA63E270E\n\tfor ; Wed, 22 Apr 2026 16:12:44 +0200 (CEST)","from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id D35D43C054A\n for ; Wed, 22 Apr 2026 16:12:40 +0200 (CEST)","from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 0E389600696\n for ; Wed, 22 Apr 2026 16:12:39 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 807665BD5C;\n Wed, 22 Apr 2026 14:12:39 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E1DBC593B1;\n Wed, 22 Apr 2026 14:12:38 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id yLL6NFbX6GnqUwAAD6G6ig\n (envelope-from ); Wed, 22 Apr 2026 14:12:38 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776867159;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=bNjw4sBufMBg598T/qzoANemJq101BaMJwzT18Nt3pM=;\n b=qdZuNtScyN8qBD/UkXuUfOu+2BajntpBV2V4vCSOjJYH5pdzLwMbeA08x5+D8xImFXvccs\n vKGg0tcoSM3FLzleJfQodJdj5iT35X9VtmRKwudrcVN4aAXY+5U+wxtgHRv29Vt1hoYSLk\n dYVrmqiMKiFsFxLQnbPPSSKsnRh3m8k=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776867159;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=bNjw4sBufMBg598T/qzoANemJq101BaMJwzT18Nt3pM=;\n b=2Q2SJ+z3Gs2y5+9QlhrpFQZcxbjlhutXwpsWtrYlaMh3TKWcqOCgJAq/Ic/DcwZj3AfJBn\n U1CcrpBXyDSrhFBA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776867159;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=bNjw4sBufMBg598T/qzoANemJq101BaMJwzT18Nt3pM=;\n b=qdZuNtScyN8qBD/UkXuUfOu+2BajntpBV2V4vCSOjJYH5pdzLwMbeA08x5+D8xImFXvccs\n vKGg0tcoSM3FLzleJfQodJdj5iT35X9VtmRKwudrcVN4aAXY+5U+wxtgHRv29Vt1hoYSLk\n dYVrmqiMKiFsFxLQnbPPSSKsnRh3m8k=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776867159;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=bNjw4sBufMBg598T/qzoANemJq101BaMJwzT18Nt3pM=;\n b=2Q2SJ+z3Gs2y5+9QlhrpFQZcxbjlhutXwpsWtrYlaMh3TKWcqOCgJAq/Ic/DcwZj3AfJBn\n U1CcrpBXyDSrhFBA=="],"From":"Petr Vorel ","To":"ltp@lists.linux.it","Date":"Wed, 22 Apr 2026 16:12:31 +0200","Message-ID":"<20260422141234.632195-3-pvorel@suse.cz>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260422141234.632195-1-pvorel@suse.cz>","References":"<20260422141234.632195-1-pvorel@suse.cz>","MIME-Version":"1.0","X-Spam-Score":"-1.30","X-Spam-Level":"","X-Spamd-Result":"default: False [-1.30 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n TAGGED_RCPT(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[];\n RCPT_COUNT_SEVEN(0.00)[7];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n FROM_HAS_DN(0.00)[];\n FREEMAIL_CC(0.00)[suse.cz,gmail.com,suse.com,redhat.com];\n TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n TO_MATCH_ENVRCPT_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.cz:mid,suse.cz:email,suse.com:email];\n RCVD_COUNT_TWO(0.00)[2]; FREEMAIL_ENVRCPT(0.00)[gmail.com]","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,DMARC_MISSING,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-2.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-2.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"[LTP] [PATCH v4 2/5] lib: Rename variable LTP_ENABLE_DEBUG =>\n LTP_DEBUG","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Martin Cermak ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "},"content":"1) LTP_DEBUG is shorter to write.\n2) Enable is usually meant as boolean (on/off), that hides possible 2\nvalue even more.\n\nReviewed-by: Li Wang \nReviewed-by: Andrea Cervesato \nSigned-off-by: Petr Vorel \n---\n doc/developers/debugging.rst | 2 +-\n doc/old/C-Test-API.asciidoc | 2 +-\n doc/users/setup_tests.rst | 2 +-\n lib/newlib_tests/tst_res_flags.c | 2 +-\n lib/tst_test.c | 6 +++---\n 5 files changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/doc/developers/debugging.rst b/doc/developers/debugging.rst\nindex 52f881c5c8..36dda0d90f 100644\n--- a/doc/developers/debugging.rst\n+++ b/doc/developers/debugging.rst\n@@ -9,7 +9,7 @@ Debug messages\n --------------\n \n The LTP framework supports ``TDEBUG`` flag test debug messages. These\n-messages can be enabled using the ``-D[1,2]`` parameter or setting ``LTP_ENABLE_DEBUG=1,2``\n+messages can be enabled using the ``-D[1,2]`` parameter or setting ``LTP_DEBUG=1,2``\n environment variable (see :doc:`../users/setup_tests`).\n \n The ``-D`` parameter also supports the following verbosity levels:\ndiff --git a/doc/old/C-Test-API.asciidoc b/doc/old/C-Test-API.asciidoc\nindex 44cc4e863b..7c5ad923dd 100644\n--- a/doc/old/C-Test-API.asciidoc\n+++ b/doc/old/C-Test-API.asciidoc\n@@ -232,7 +232,7 @@ Printf-like function to report test result, it's mostly used with ttype:\n | 'TPASS' | Test has passed.\n | 'TFAIL' | Test has failed.\n | 'TINFO' | General message.\n-| 'TDEBUG' | Debug message (new C API only, printed with '-D' or via 'LTP_ENABLE_DEBUG=1' or 'y'\n+| 'TDEBUG' | Debug message (new C API only, printed with '-D' or via 'LTP_DEBUG=1' or 'y'\n environment variable), only for messages which would be too verbose for normal run.\n | 'TWARN' | Something went wrong but we decided to continue. Mostly used in cleanup functions.\n |==============================\ndiff --git a/doc/users/setup_tests.rst b/doc/users/setup_tests.rst\nindex 95d4d9e380..a42c397feb 100644\n--- a/doc/users/setup_tests.rst\n+++ b/doc/users/setup_tests.rst\n@@ -90,7 +90,7 @@ users.\n - Disable running test cleanup (defined in ``TST_CLEANUP``).\n Shell API only.\n \n- * - LTP_ENABLE_DEBUG\n+ * - LTP_DEBUG\n - Enable debug info (value ``1`` (``y``) or ``2`` for more verbose level).\n Equivalent of ``-D`` parameter.\n \ndiff --git a/lib/newlib_tests/tst_res_flags.c b/lib/newlib_tests/tst_res_flags.c\nindex 21637a472b..9993d0f87d 100644\n--- a/lib/newlib_tests/tst_res_flags.c\n+++ b/lib/newlib_tests/tst_res_flags.c\n@@ -21,7 +21,7 @@ static struct tcase {\n \t{FLAG(TCONF)},\n \t{FLAG(TWARN)},\n \t{FLAG(TINFO)},\n-\t{FLAG(TDEBUG), \" (printed only with -D[1,2] or LTP_ENABLE_DEBUG=1,2)\"},\n+\t{FLAG(TDEBUG), \" (printed only with -D[1,2] or LTP_DEBUG=1,2)\"},\n };\n \n static void do_cleanup(void)\ndiff --git a/lib/tst_test.c b/lib/tst_test.c\nindex 229da669fa..c79cabcd7a 100644\n--- a/lib/tst_test.c\n+++ b/lib/tst_test.c\n@@ -675,7 +675,7 @@ static void print_help(void)\n \tfprintf(stderr, \"LTP_COLORIZE_OUTPUT Force colorized output behaviour (y/1 always, n/0: never)\\n\");\n \tfprintf(stderr, \"LTP_DEV Path to the block device to be used (for .needs_device)\\n\");\n \tfprintf(stderr, \"LTP_DEV_FS_TYPE Filesystem used for testing (default: %s)\\n\", DEFAULT_FS_TYPE);\n-\tfprintf(stderr, \"LTP_ENABLE_DEBUG Print debug messages (set 1(y) or 2)\\n\");\n+\tfprintf(stderr, \"LTP_DEBUG Print debug messages (set 1(y) or 2)\\n\");\n \tfprintf(stderr, \"LTP_REPRODUCIBLE_OUTPUT Values 1 or y discard the actual content of the messages printed by the test\\n\");\n \tfprintf(stderr, \"LTP_QUIET Values 1 or y will suppress printing TCONF, TWARN, TINFO, and TDEBUG messages\\n\");\n \tfprintf(stderr, \"LTP_SINGLE_FS_TYPE Specifies filesystem instead all supported (for .all_filesystems)\\n\");\n@@ -1400,7 +1400,7 @@ bool tst_cmd_present(const char *cmd)\n \n static void do_setup(int argc, char *argv[])\n {\n-\tchar *tdebug_env = getenv(\"LTP_ENABLE_DEBUG\");\n+\tchar *tdebug_env = getenv(\"LTP_DEBUG\");\n \tchar *reproducible_env = getenv(\"LTP_REPRODUCIBLE_OUTPUT\");\n \tchar *quiet_env = getenv(\"LTP_QUIET\");\n \n@@ -1451,7 +1451,7 @@ static void do_setup(int argc, char *argv[])\n \t\telse if (!strcmp(tdebug_env, \"1\") || !strcmp(tdebug_env, \"y\"))\n \t\t\tcontext->tdebug = 1;\n \t\telse\n-\t\t\ttst_res(TWARN, \"Invalid LTP_ENABLE_DEBUG value: '%s'\", tdebug_env);\n+\t\t\ttst_res(TWARN, \"Invalid LTP_DEBUG value: '%s'\", tdebug_env);\n \n \t\tif (context->tdebug)\n \t\t\ttst_res(TINFO, \"Enabling debug info (level %d)\", context->tdebug);\n","prefixes":["v4","2/5"]}