{"id":2226404,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2226404/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/patch/20260422122424.43776-63-andrei.otcheretianski@intel.com/","project":{"id":22,"url":"http://patchwork.ozlabs.org/api/1.2/projects/22/?format=json","name":"HostAP Development","link_name":"hostap","list_id":"hostap.lists.infradead.org","list_email":"hostap@lists.infradead.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422122424.43776-63-andrei.otcheretianski@intel.com>","list_archive_url":null,"date":"2026-04-22T12:23:53","name":"[62/92] nl80211: Support key operations (new/set/del) on non-netdev interfaces","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f37c82047d53cbca4a551c195aec236f0d53b5b1","submitter":{"id":62065,"url":"http://patchwork.ozlabs.org/api/1.2/people/62065/?format=json","name":"Andrei Otcheretianski","email":"andrei.otcheretianski@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/hostap/patch/20260422122424.43776-63-andrei.otcheretianski@intel.com/mbox/","series":[{"id":501001,"url":"http://patchwork.ozlabs.org/api/1.2/series/501001/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/list/?series=501001","date":"2026-04-22T12:23:05","name":"Add NAN PASN pairing support","version":1,"mbox":"http://patchwork.ozlabs.org/series/501001/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226404/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226404/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=s+GZUYXO;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=desiato.20200630 header.b=TfnQctwQ;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=dQLbdOuO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0z7H4Dzfz1yCv\n\tfor ; Wed, 22 Apr 2026 22:29:31 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wFWhO-0000000A89B-2qFi;\n\tWed, 22 Apr 2026 12:28:58 +0000","from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wFWfS-0000000A5NK-1tSx\n\tfor hostap@bombadil.infradead.org;\n\tWed, 22 Apr 2026 12:26:58 +0000","from mgamail.intel.com ([192.198.163.17])\n\tby desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wFWfP-0000000BKYa-0SgU\n\tfor hostap@lists.infradead.org;\n\tWed, 22 Apr 2026 12:26:57 +0000","from orviesa010.jf.intel.com ([10.64.159.150])\n by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Apr 2026 05:26:15 -0700","from iapp347.iil.intel.com (HELO 87c02287900a.iil.intel.com)\n ([10.167.28.6])\n by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Apr 2026 05:26:14 -0700"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=BW78wJqeZTE39O6T7NZy84el6sNUY/LinMx8UfEnirI=; b=s+GZUYXOBswrcb\n\tUc3yqRCj9TF6vmcCTGhqMSxMparkPVu4NsWoe/qIJwQcXiFLZRGreXU9zYEiydlGWEPfS6JVAYRlr\n\t5o6D8eMm69q7zrkMwUuwZOrU3ykJU//ghKqI/6OV+VQiE0E4nnIX8NRkfmEpuk1XVyumkefmTWQ8L\n\tsbDVOQ+jwul5Yc6Q5iIU6VGodNI3jRbke2rM+ufY9d4oEscVd47gmTu0ItcrSGr4HJXs+xjFf4OCU\n\tKZPP+y787SgJIXejpaY+BEnlrq1UnlGgqAfeYezvz9MinTwOs8gNlZYdYeAK1c5XDgFrlQrlAnhBa\n\toRU/nkjhhTV9K/6CZ82Q==;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version\n\t:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:\n\tContent-Type:Content-ID:Content-Description;\n\tbh=O87FMni20o6mG2pykDLcuUsYkHL9StSzmvq3f15Nbyk=; b=TfnQctwQff9m3uelFfoY3urzmH\n\taguxPsUxxCFErXMVZu7y9SbGE0J3cauEqPAU+o4S0mG+1KqysPzC7+yPL60R6sfd0sJitMsinsNnT\n\tga9OO4QO7s+2MN9NdfEDdA8/pErrel7hrHYksBaIgJI9ohQC9ixG1XdS1y4MybNmTBDKNOxH94p8e\n\t7bcMNKgmd2XJ2l7Yooxm+LvfHnN9dpuyZCsTXLE2NI+9MrMnRPPreh+I/E60j/k0G25Fnzmn7cImf\n\tryvEP+VLLiiP4Ly6fDedYXHjTlZPbcOYd81lZ37yFLr8833k/OzzGHiPO0LbPws3z5g3+XK8pSeEt\n\tJitGsA0A==;","v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776860815; x=1808396815;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=GWt91FT8BVaz/0Bc09/rtrY7s6lh9XHlaXNyYyvc2EY=;\n b=dQLbdOuO8TV4ydTTqDmR/mGvr7EkPW2NdZNZ1c/dteKTPNRSRQ65vaK+\n wT/0V+UQOBLYljbYgr3LuikGC44/gNMnd/Lxl6NtjN7ee33FloojS56yI\n oiUeXaF39kYS+QAuk9MOiqH1OYyCMd2vRcxGrn3EDi04oJAqL17U8Z2DG\n HeWU4BByq07xOIqdDa5DN6QSv7vtd50DIZB5g9gVz+A3wL0eQSDJ9//OA\n BD+ameULAMIWq5HtpNJ4AAd8XHe4fbXWUi7yjrQCFi0C8sfaOuOWefCnH\n xrBj4cRiALgxf9BCASdTwDCTqiD0l96k8yulry4SLY1N4oridbhWVj+bn\n Q==;"],"X-CSE-ConnectionGUID":["52AEtFY/RqO0xeFoB98iRA==","TIHhtly9T3GQpT5qm0k/tQ=="],"X-CSE-MsgGUID":["lA9QivKiTla+Sbk+kQiKxw==","NBYAsVmzRcWazh0In7diHA=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11764\"; a=\"77687470\"","E=Sophos;i=\"6.23,192,1770624000\";\n d=\"scan'208\";a=\"77687470\"","E=Sophos;i=\"6.23,192,1770624000\";\n d=\"scan'208\";a=\"231445179\""],"X-ExtLoop1":"1","From":"Andrei Otcheretianski ","To":"hostap@lists.infradead.org","Cc":"vamsin@qti.qualcomm.com,\n\tmaheshkkv@google.com,\n\tAvraham Stern ","Subject":"[PATCH 62/92] nl80211: Support key operations (new/set/del) on\n non-netdev interfaces","Date":"Wed, 22 Apr 2026 15:23:53 +0300","Message-ID":"<20260422122424.43776-63-andrei.otcheretianski@intel.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260422122424.43776-1-andrei.otcheretianski@intel.com>","References":"<20260422122424.43776-1-andrei.otcheretianski@intel.com>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260422_132655_514740_44D19557 ","X-CRM114-Status":"GOOD ( 11.93 )","X-Spam-Score":"-2.5 (--)","X-Spam-Report":"Spam detection software,\n running on the system \"desiato.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Avraham Stern The kernel\n added\n support for setting a key on non-netdev interfaces (like the NAN device\n interface).\n Non-netdev interfaces are identified. Use nl80211_cmd_msg() for building\n the command for non-netdev [...]\n Content analysis details: (-2.5 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,\n medium trust\n [192.198.163.17 listed in list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender","X-BeenThere":"hostap@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Hostap\" ","Errors-To":"hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"From: Avraham Stern \n\nThe kernel added support for setting a key on non-netdev interfaces\n(like the NAN device interface). Non-netdev interfaces are identified.\nUse nl80211_cmd_msg() for building the command for non-netdev devices.\n\nSigned-off-by: Avraham Stern \n---\n src/drivers/driver_nl80211.c | 27 ++++++++++++++++++++++-----\n 1 file changed, 22 insertions(+), 5 deletions(-)","diff":"diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c\nindex 62fa9fe6f4..5ca18ee71e 100644\n--- a/src/drivers/driver_nl80211.c\n+++ b/src/drivers/driver_nl80211.c\n@@ -3983,7 +3983,11 @@ static int wpa_driver_nl80211_set_key(struct i802_bss *bss,\n \t\tgoto fail2;\n \t} else if (alg == WPA_ALG_NONE) {\n \t\twpa_printf(MSG_DEBUG, \"nl80211: DEL_KEY\");\n-\t\tmsg = nl80211_ifindex_msg(drv, ifindex, 0, NL80211_CMD_DEL_KEY);\n+\t\tif (!nl80211_is_netdev_iftype(drv->nlmode))\n+\t\t\tmsg = nl80211_cmd_msg(bss, 0, NL80211_CMD_DEL_KEY);\n+\t\telse\n+\t\t\tmsg = nl80211_ifindex_msg(drv, ifindex, 0,\n+\t\t\t\t\t\t NL80211_CMD_DEL_KEY);\n \t\tif (!msg)\n \t\t\tgoto fail2;\n \t} else {\n@@ -3995,7 +3999,13 @@ static int wpa_driver_nl80211_set_key(struct i802_bss *bss,\n \t\t\tgoto fail2;\n \t\t}\n \t\twpa_printf(MSG_DEBUG, \"nl80211: NEW_KEY\");\n-\t\tmsg = nl80211_ifindex_msg(drv, ifindex, 0, NL80211_CMD_NEW_KEY);\n+\n+\t\tif (!nl80211_is_netdev_iftype(drv->nlmode))\n+\t\t\tmsg = nl80211_cmd_msg(bss, 0, NL80211_CMD_NEW_KEY);\n+\t\telse\n+\t\t\tmsg = nl80211_ifindex_msg(drv, ifindex, 0,\n+\t\t\t\t\t\t NL80211_CMD_NEW_KEY);\n+\n \t\tif (!msg)\n \t\t\tgoto fail2;\n \t\tif (nla_put(key_msg, NL80211_KEY_DATA, key_len, key) ||\n@@ -4092,7 +4102,10 @@ static int wpa_driver_nl80211_set_key(struct i802_bss *bss,\n \tif (!key_msg)\n \t\treturn ret;\n \n-\tmsg = nl80211_ifindex_msg(drv, ifindex, 0, NL80211_CMD_SET_KEY);\n+\tif (!nl80211_is_netdev_iftype(drv->nlmode))\n+\t\tmsg = nl80211_cmd_msg(bss, 0, NL80211_CMD_SET_KEY);\n+\telse\n+\t\tmsg = nl80211_ifindex_msg(drv, ifindex, 0, NL80211_CMD_SET_KEY);\n \tif (!msg)\n \t\tgoto fail2;\n \tif (!key_msg ||\n@@ -8346,8 +8359,12 @@ static int i802_get_seqnum(const char *iface, void *priv, const u8 *addr,\n \tstruct nl_msg *msg;\n \tint res;\n \n-\tmsg = nl80211_ifindex_msg(drv, if_nametoindex(iface), 0,\n-\t\t\t\t NL80211_CMD_GET_KEY);\n+\tif (!nl80211_is_netdev_iftype(drv->nlmode))\n+\t\tmsg = nl80211_cmd_msg(bss, 0, NL80211_CMD_GET_KEY);\n+\telse\n+\t\tmsg = nl80211_ifindex_msg(drv, if_nametoindex(iface), 0,\n+\t\t\t\t\t NL80211_CMD_GET_KEY);\n+\n \tif (!msg ||\n \t (addr && nla_put(msg, NL80211_ATTR_MAC, ETH_ALEN, addr)) ||\n \t (link_id != NL80211_DRV_LINK_ID_NA &&\n","prefixes":["62/92"]}