{"id":2226350,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2226350/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/patch/20260422122424.43776-9-andrei.otcheretianski@intel.com/","project":{"id":22,"url":"http://patchwork.ozlabs.org/api/1.2/projects/22/?format=json","name":"HostAP Development","link_name":"hostap","list_id":"hostap.lists.infradead.org","list_email":"hostap@lists.infradead.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422122424.43776-9-andrei.otcheretianski@intel.com>","list_archive_url":null,"date":"2026-04-22T12:22:59","name":"[08/92] PASN: Remove an unused variable","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1ff6407c2e5f215c29c7f8469d02a5d8b99a8964","submitter":{"id":62065,"url":"http://patchwork.ozlabs.org/api/1.2/people/62065/?format=json","name":"Andrei Otcheretianski","email":"andrei.otcheretianski@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/hostap/patch/20260422122424.43776-9-andrei.otcheretianski@intel.com/mbox/","series":[{"id":501001,"url":"http://patchwork.ozlabs.org/api/1.2/series/501001/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/list/?series=501001","date":"2026-04-22T12:23:05","name":"Add NAN PASN pairing support","version":1,"mbox":"http://patchwork.ozlabs.org/series/501001/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226350/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226350/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=hSFCtz7x;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=LMEJZZCU;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0z2h6FZfz23Zc\n\tfor ; Wed, 22 Apr 2026 22:25:29 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wFWdP-0000000A2Sk-0gqo;\n\tWed, 22 Apr 2026 12:24:51 +0000","from mgamail.intel.com ([192.198.163.17])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wFWdL-0000000A2MF-2Exq\n\tfor hostap@lists.infradead.org;\n\tWed, 22 Apr 2026 12:24:49 +0000","from orviesa010.jf.intel.com ([10.64.159.150])\n by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Apr 2026 05:24:47 -0700","from iapp347.iil.intel.com (HELO 87c02287900a.iil.intel.com)\n ([10.167.28.6])\n by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Apr 2026 05:24:46 -0700"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=0IvIyTH3Bu5OqoJge1RDEm4nnEX4ocQn33K5CL9iHIE=; b=hSFCtz7xpLNUa6\n\tFoE6794fbCD+z61EFTbSPX5o50DpXp2SDLtUEVTsgA8BtQcBykxZoZyFqgI9CiHCnaGwGAKIQaSWQ\n\tykPPE+MqLumPyenA95LtnWbul1j7HZLCscsQEoMMv+GNY/PwAejqvnRmB/GbCXR2Lb8/KSyREtm2s\n\taXukhWOSg22Tr3A9guCVW8mHX0k8nPixv99Q1lggBWlkVgmVaWFE9LUE/MVshDIRbbTMo3hohmMxP\n\txYBEez1/ddy4lUcepqOiXxv3yQ5lE8Jf6M8+iMCb4X10acEKj5AU3O27SMDF4vK5i9kJ7lUjfPKbD\n\tvafysvdwuJsC1BL8F3fA==;","v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776860687; x=1808396687;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=b+nizVk5V3ftJAtClzrN+tomF01J4ajIklHjMvwVnjA=;\n b=LMEJZZCUfbyuFjdeSsvZqzVgLMqn/g0t1n0fUmqUCvVf64teMrVPIjtd\n lKr3/+WUBkqWZJIqvZd4bllwVFvk4YJd6tc3HXIg6CJv1e6/kyCkwbuGI\n HkJi/ULmWyFjVdV/P9hX2wIcsYflXQuobiVhyCaZawx1mQAxokIR6Xyvz\n tpwCR12TIR/t9gXrf4XhSkqWx8a/28RahcJkrvkpHx/IHSiqPBHQSp63l\n B8vGG0jVUeCRLcnYwLJ2Css9zuMeAf+JXEgcLpUJTGx+sUl/dbOpBvJC+\n 2PYR2ZT78hOvw2Oiu4Vt8OcSMw9JHkIYL8gRGDJRyYKjywDgZCebiG9ma\n A==;"],"X-CSE-ConnectionGUID":["+QsZRC/VRXW/Vkem8qP18Q==","JCxw1qQ5RX6/UVQC9inLww=="],"X-CSE-MsgGUID":["kYgQeQ9YTpy5405mGqzBeA==","Mi4X7yq+R0aVjxeBMWKnRQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11764\"; a=\"77687130\"","E=Sophos;i=\"6.23,192,1770624000\";\n d=\"scan'208\";a=\"77687130\"","E=Sophos;i=\"6.23,192,1770624000\";\n d=\"scan'208\";a=\"231444851\""],"X-ExtLoop1":"1","From":"Andrei Otcheretianski ","To":"hostap@lists.infradead.org","Cc":"vamsin@qti.qualcomm.com,\n\tmaheshkkv@google.com,\n\tAvraham Stern ","Subject":"[PATCH 08/92] PASN: Remove an unused variable","Date":"Wed, 22 Apr 2026 15:22:59 +0300","Message-ID":"<20260422122424.43776-9-andrei.otcheretianski@intel.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260422122424.43776-1-andrei.otcheretianski@intel.com>","References":"<20260422122424.43776-1-andrei.otcheretianski@intel.com>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260422_052448_535800_6C548E82 ","X-CRM114-Status":"GOOD ( 13.47 )","X-Spam-Score":"-4.4 (----)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Avraham Stern The password\n variable in the PASN data is never used. Remove it. Signed-off-by: Avraham\n Stern --- src/ap/ieee802_11.c | 3 +--\n src/common/proximity_ranging.c\n | 2 -- src/p2p/p2p.c | 2 -- src/pasn/pasn_common.c | 8 --------\n src/pasn/pasn_comm\n [...]\n Content analysis details: (-4.4 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,\n medium trust\n [192.198.163.17 listed in list.dnswl.org]\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender","X-BeenThere":"hostap@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Hostap\" ","Errors-To":"hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"From: Avraham Stern \n\nThe password variable in the PASN data is never used. Remove it.\n\nSigned-off-by: Avraham Stern \n---\n src/ap/ieee802_11.c | 3 +--\n src/common/proximity_ranging.c | 2 --\n src/p2p/p2p.c | 2 --\n src/pasn/pasn_common.c | 8 --------\n src/pasn/pasn_common.h | 2 --\n src/pasn/pasn_responder.c | 4 +---\n 6 files changed, 2 insertions(+), 19 deletions(-)","diff":"diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c\nindex de2702eb14..985423cd53 100644\n--- a/src/ap/ieee802_11.c\n+++ b/src/ap/ieee802_11.c\n@@ -3921,8 +3921,7 @@ static void hapd_initialize_pasn(struct hostapd_data *hapd,\n \t\tpasn_enable_kdk_derivation(pasn);\n #endif /* CONFIG_TESTING_OPTIONS */\n \tpasn->use_anti_clogging = use_anti_clogging(hapd);\n-\tpasn_set_password(pasn, sae_get_password(hapd, sta, NULL, 0, NULL,\n-\t\t\t\t\t\t &pasn->pt, NULL));\n+\tsae_get_password(hapd, sta, NULL, 0, NULL, &pasn->pt, NULL);\n #ifdef CONFIG_SAE\n \t/* Register a callback so the PASN responder can look up the correct\n \t * SAE PT when the STA's commit frame contains a password identifier\ndiff --git a/src/common/proximity_ranging.c b/src/common/proximity_ranging.c\nindex 8d5fb3a4a8..96cb8194dc 100644\n--- a/src/common/proximity_ranging.c\n+++ b/src/common/proximity_ranging.c\n@@ -1679,8 +1679,6 @@ static void pr_pasn_set_password(struct pasn_data *pasn, u8 pasn_type,\n \tpasn->pt = sae_derive_pt(pasn_groups, (const u8 *) PR_PASN_SSID,\n \t\t\t\t os_strlen(PR_PASN_SSID),\n \t\t\t\t (const u8 *) passphrase, len, NULL, 0);\n-\t/* Set passphrase for PASN responder to validate Auth 1 frame */\n-\tpasn->password = passphrase;\n }\n \n \ndiff --git a/src/p2p/p2p.c b/src/p2p/p2p.c\nindex cf0b4236c5..e477d6993c 100644\n--- a/src/p2p/p2p.c\n+++ b/src/p2p/p2p.c\n@@ -6403,8 +6403,6 @@ static void p2p_pairing_set_password(struct pasn_data *pasn, u8 pasn_type,\n \tpasn->pt = sae_derive_pt(pasn_groups, (const u8 *) P2P_PAIRING_SSID,\n \t\t\t\t os_strlen(P2P_PAIRING_SSID),\n \t\t\t\t (const u8 *) passphrase, len, NULL, 0);\n-\t/* Set passphrase for pairing responder to validate PASN auth 1 frame */\n-\tpasn->password = passphrase;\n }\n \n \ndiff --git a/src/pasn/pasn_common.c b/src/pasn/pasn_common.c\nindex dc6cec1023..ab9e551bb8 100644\n--- a/src/pasn/pasn_common.c\n+++ b/src/pasn/pasn_common.c\n@@ -152,14 +152,6 @@ int pasn_set_pt(struct pasn_data *pasn, struct sae_pt *pt)\n }\n \n \n-void pasn_set_password(struct pasn_data *pasn, const char *password)\n-{\n-\tif (!pasn)\n-\t\treturn;\n-\tpasn->password = password;\n-}\n-\n-\n void pasn_set_wpa_key_mgmt(struct pasn_data *pasn, int key_mgmt)\n {\n \tif (!pasn)\ndiff --git a/src/pasn/pasn_common.h b/src/pasn/pasn_common.h\nindex 910cdf5919..d74720eccc 100644\n--- a/src/pasn/pasn_common.h\n+++ b/src/pasn/pasn_common.h\n@@ -64,7 +64,6 @@ struct pasn_data {\n #endif /* CONFIG_SAE */\n \n \t/* Responder */\n-\tconst char *password;\n \tint wpa_key_mgmt;\n \tint rsn_pairwise;\n \tu64 rsnxe_capab;\n@@ -327,7 +326,6 @@ void pasn_initiator_pmksa_cache_flush(struct rsn_pmksa_cache *pmksa);\n \n /* Responder */\n void pasn_set_noauth(struct pasn_data *pasn, bool noauth);\n-void pasn_set_password(struct pasn_data *pasn, const char *password);\n void pasn_set_wpa_key_mgmt(struct pasn_data *pasn, int key_mgmt);\n void pasn_set_rsn_pairwise(struct pasn_data *pasn, int rsn_pairwise);\n void pasn_set_rsne(struct pasn_data *pasn, const u8 *rsne);\ndiff --git a/src/pasn/pasn_responder.c b/src/pasn/pasn_responder.c\nindex faf57dc6ed..84487c34e7 100644\n--- a/src/pasn/pasn_responder.c\n+++ b/src/pasn/pasn_responder.c\n@@ -187,11 +187,9 @@ static int pasn_wd_handle_sae_commit(struct pasn_data *pasn,\n \t\tos_free(pasn->dec_pw_id);\n \t\tpasn->dec_pw_id = dec_pw_id;\n \t\tpasn->dec_pw_id_len = dec_pw_id_len;\n-\t\tif (pw)\n-\t\t\tpasn_set_password(pasn, pw);\n \t}\n \n-\tif (!pasn->password || (!pt && !pasn->pt)) {\n+\tif (!pt && !pasn->pt) {\n \t\twpa_printf(MSG_DEBUG, \"PASN: No SAE PT found\");\n \t\treturn -1;\n \t}\n","prefixes":["08/92"]}