{"id":2226341,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2226341/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260422-fix-pinconf-v1-1-abb4d2e0da55@amlogic.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.2/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422-fix-pinconf-v1-1-abb4d2e0da55@amlogic.com>","list_archive_url":null,"date":"2026-04-22T11:44:13","name":"pinctrl: meson: amlogic-a4: fix deadlock issue","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7f3c6be28af63fbf453a42beede68a4637c5367a","submitter":{"id":87655,"url":"http://patchwork.ozlabs.org/api/1.2/people/87655/?format=json","name":"Xianwei Zhao via B4 Relay","email":"devnull+xianwei.zhao.amlogic.com@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260422-fix-pinconf-v1-1-abb4d2e0da55@amlogic.com/mbox/","series":[{"id":500996,"url":"http://patchwork.ozlabs.org/api/1.2/series/500996/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=500996","date":"2026-04-22T11:44:13","name":"pinctrl: meson: amlogic-a4: fix deadlock issue","version":1,"mbox":"http://patchwork.ozlabs.org/series/500996/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226341/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226341/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n <linux-gpio+bounces-35351-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ktOEzpdU;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35351-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"ktOEzpdU\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0y7y6VzGz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 21:45:02 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id E70B53045236\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 11:44:21 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 25C913D091F;\n\tWed, 22 Apr 2026 11:44:21 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DA3834F483;\n\tWed, 22 Apr 2026 11:44:20 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPS id BCF58C19425;\n\tWed, 22 Apr 2026 11:44:19 +0000 (UTC)","from aws-us-west-2-korg-lkml-1.web.codeaurora.org\n (localhost.localdomain [127.0.0.1])\n\tby smtp.lore.kernel.org (Postfix) with ESMTP id B1B70F94CBE;\n\tWed, 22 Apr 2026 11:44:19 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776858260; cv=none;\n b=Nq8ZUzTR5qRR9a/VnsC9xWViOrIK8HSKxJ7cib0sbjz+UjV4eK6lKO1C4HVLOxq0n81SEdQoSn9a+GBLg0ztUFr73xozEAQMz6glV+oJ9IG6kT2ROZDYSjNyOGa3UnKkvL9lEOtUSKyUWpXB395ACNzp4yMiUJDU0thwKEupqEM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776858260; c=relaxed/simple;\n\tbh=jhptRH9NwVJexkC7VbAUXdVKvsP7WnTfWca81DZoqAs=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc;\n b=Ozs50aPlydTa6dGYMd/AwMFLRtNme7uZEcGyE3NK3KidstSGtGQ5TdFf4kCbV6VpZPQTsoGtIsYwQBhmc2vVYZAVUbctbBYzjZCFXanwrhUWKJd8pz14fwmkqfpBtUS29ZxHPr3lksM2bizREHeFDd9hj0F6BGXYRUBRrxz2nus=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=ktOEzpdU; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776858259;\n\tbh=jhptRH9NwVJexkC7VbAUXdVKvsP7WnTfWca81DZoqAs=;\n\th=From:Date:Subject:To:Cc:Reply-To:From;\n\tb=ktOEzpdUCP6JYApKumRzkyw9A55BDaNe2JPGU3uIYBglVVivVPROgbLfsXGzM2Xy+\n\t Mxl3PnO5dFL9h6QevTzuBGa0CxQTXj4jrs4Y+JAJ3Pfj1X/agxRoPOBuUKs3x/RqXM\n\t Hh4aI6kerDPAjte21w3No4CF6WbrMSKXgD45leMEdN2XMlBMYfa0vsDjcgKJ8whnho\n\t shGzNpyIxet2vpdkF2rXmYfvPhy5LU5dFayMCuL4w4OWS2pIKmEezp1aiCeFxeUD/b\n\t l6/4kpRyEfvse7z1UwnCv/lnPQbuKfmZLtZwmxl/Uf6fxisytXCQhlg2iqP3RyM3Xn\n\t I/1HQvS82UaRg==","From":"Xianwei Zhao via B4 Relay <devnull+xianwei.zhao.amlogic.com@kernel.org>","Date":"Wed, 22 Apr 2026 11:44:13 +0000","Subject":"[PATCH] pinctrl: meson: amlogic-a4: fix deadlock issue","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260422-fix-pinconf-v1-1-abb4d2e0da55@amlogic.com>","X-B4-Tracking":"v=1; b=H4sIAIy06GkC/x3NQQqDQAyF4atI1gY02C68inQxkyY1m4xkigji3\n Tt2+fP4eCdUCZMKc3dCyG7VircY+w54Tf4RtHdroIGew0SEagdu5lxccaIsIzPpIyk0kVMVzJG\n c19toCXQ5vve0hTT5P1pe1/UD9QwM4XgAAAA=","X-Change-ID":"20260422-fix-pinconf-42be1cc2f5af","To":"Linus Walleij <linusw@kernel.org>,\n Neil Armstrong <neil.armstrong@linaro.org>,\n Kevin Hilman <khilman@baylibre.com>, Jerome Brunet <jbrunet@baylibre.com>,\n Martin Blumenstingl <martin.blumenstingl@googlemail.com>","Cc":"linux-amlogic@lists.infradead.org, linux-gpio@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n Xianwei Zhao <xianwei.zhao@amlogic.com>","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1776858256; l=2200;\n i=xianwei.zhao@amlogic.com; s=20251216; h=from:subject:message-id;\n bh=Ss1NSqKaiC5N5QiCWkTV2uRyv5Uo42HRnPH2RlMwg5E=;\n b=fr7u9d+eLFEa7sccl3XsNIMQoaiZ7WblPDxAAp4bIzh/HrYB6ydQXMiU1Ec+47fQmUWfWWegx\n Yj1u23N8KyqBcB7KMBYSwEMnn8XKl/x0IRNVvlYw3sfzP8B5LsRUsqG","X-Developer-Key":"i=xianwei.zhao@amlogic.com; a=ed25519;\n pk=dWwxtWCxC6FHRurOmxEtr34SuBYU+WJowV/ZmRJ7H+k=","X-Endpoint-Received":"by B4 Relay for xianwei.zhao@amlogic.com/20251216 with\n auth_id=578","X-Original-From":"Xianwei Zhao <xianwei.zhao@amlogic.com>","Reply-To":"xianwei.zhao@amlogic.com"},"content":"From: Xianwei Zhao <xianwei.zhao@amlogic.com>\n\nAccessing the pinconf-pins sysfs node may deadlock.\n\npinconf_pins_show() holds pctldev->mutex, and the platform driver\ncalls pinctrl_find_gpio_range_from_pin(), which tries to acquire\nthe same mutex again, leading to a deadlock.\n\nUse pinctrl_find_gpio_range_from_pin_nolock() to fix this issue.\n\nFixes: 6e9be3abb78c (\"pinctrl: Add driver support for Amlogic SoCs\")\nSigned-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>\n---\nFix deadlock issue.\n---\n drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\n\n---\nbase-commit: bd7fd288490c64835a74c05e631c102ce056d5e1\nchange-id: 20260422-fix-pinconf-42be1cc2f5af\n\nBest regards,","diff":"diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c\nindex e2293a872dcb..35d27626a336 100644\n--- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c\n+++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c\n@@ -292,7 +292,7 @@ static int aml_calc_reg_and_bit(struct pinctrl_gpio_range *range,\n static int aml_pinconf_get_pull(struct aml_pinctrl *info, unsigned int pin)\n {\n \tstruct pinctrl_gpio_range *range =\n-\t\t\t pinctrl_find_gpio_range_from_pin(info->pctl, pin);\n+\t\t\t pinctrl_find_gpio_range_from_pin_nolock(info->pctl, pin);\n \tstruct aml_gpio_bank *bank = gpio_chip_to_bank(range->gc);\n \tunsigned int reg, bit, val;\n \tint ret, conf;\n@@ -326,7 +326,7 @@ static int aml_pinconf_get_drive_strength(struct aml_pinctrl *info,\n \t\t\t\t\t  u16 *drive_strength_ua)\n {\n \tstruct pinctrl_gpio_range *range =\n-\t\t\t pinctrl_find_gpio_range_from_pin(info->pctl, pin);\n+\t\t\t pinctrl_find_gpio_range_from_pin_nolock(info->pctl, pin);\n \tstruct aml_gpio_bank *bank = gpio_chip_to_bank(range->gc);\n \tunsigned int reg, bit;\n \tunsigned int val;\n@@ -365,7 +365,7 @@ static int aml_pinconf_get_gpio_bit(struct aml_pinctrl *info,\n \t\t\t\t    unsigned int reg_type)\n {\n \tstruct pinctrl_gpio_range *range =\n-\t\t\t pinctrl_find_gpio_range_from_pin(info->pctl, pin);\n+\t\t\t pinctrl_find_gpio_range_from_pin_nolock(info->pctl, pin);\n \tstruct aml_gpio_bank *bank = gpio_chip_to_bank(range->gc);\n \tunsigned int reg, bit, val;\n \tint ret;\n","prefixes":[]}