{"id":2226265,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2226265/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260422104859.2599422-2-mmakassikis@freebox.fr/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.2/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422104859.2599422-2-mmakassikis@freebox.fr>","list_archive_url":null,"date":"2026-04-22T10:49:00","name":"fs: smb: server: handle readdir_info_level_struct_sz() error","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9034a8f7469e8850fea4ea58ee64d0cb33d64b5b","submitter":{"id":82633,"url":"http://patchwork.ozlabs.org/api/1.2/people/82633/?format=json","name":"Marios Makassikis","email":"mmakassikis@freebox.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260422104859.2599422-2-mmakassikis@freebox.fr/mbox/","series":[{"id":500981,"url":"http://patchwork.ozlabs.org/api/1.2/series/500981/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=500981","date":"2026-04-22T10:49:00","name":"fs: smb: server: handle readdir_info_level_struct_sz() error","version":1,"mbox":"http://patchwork.ozlabs.org/series/500981/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226265/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226265/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=freebox-fr.20251104.gappssmtp.com\n header.i=@freebox-fr.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=VfTPc5ni;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11004-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=freebox-fr.20251104.gappssmtp.com\n header.i=@freebox-fr.20251104.gappssmtp.com header.b=\"VfTPc5ni\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.46","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=freebox.fr","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=freebox.fr"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0x1171w2z1yD5\n\tfor ; Wed, 22 Apr 2026 20:53:57 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 453683037D68\n\tfor ; Wed, 22 Apr 2026 10:49:52 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D35C93CAE61;\n\tWed, 22 Apr 2026 10:49:51 +0000 (UTC)","from mail-wm1-f46.google.com (mail-wm1-f46.google.com\n [209.85.128.46])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 58A443C13E2\n\tfor ; Wed, 22 Apr 2026 10:49:48 +0000 (UTC)","by mail-wm1-f46.google.com with SMTP id\n 5b1f17b1804b1-48334ee0aeaso54633225e9.1\n for ;\n Wed, 22 Apr 2026 03:49:48 -0700 (PDT)","from odysseia.iliad.local (freebox.vlq16.iliad.fr. [213.36.7.13])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4cb135asm49131895f8f.6.2026.04.22.03.49.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 03:49:46 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776854991; cv=none;\n b=eZVUF575/Mml5yX5AuvVCYDriMJhcpg5vuX44612iw4pN//Wb2cStSqSl8Kf2TJ0buabsZZ1XAxV9pmvBjHiX0MqzAKEwNplroc2MVQqN5MGMIVlMWaf1G0hQ6BaQC+Hd9fMCLPMCQoGaJvLMgbzsoNCPG2VCG84GP9zMo9Oycs=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776854991; c=relaxed/simple;\n\tbh=vlgiSEfORgkql2UA0Sg6MobmjNDmnhEkC2HKKZhBBCI=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=Ks/PTsSoqTP/QDixXGvbupqQskvMg1L4DkKBJsWKP37ZfnqIyxIM5EtIwnD1MhUwPA+JjHEjs4oL8ospno+Io37+jzjpcObJSQnPzigscmAgcy0lP2BG+5H66m+HM13ASvO9xJjSbuMxiIhTT9VV9POqMniSZeCsEqbXOmFSvio=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=freebox.fr;\n spf=pass smtp.mailfrom=freebox.fr;\n dkim=pass (2048-bit key) header.d=freebox-fr.20251104.gappssmtp.com\n header.i=@freebox-fr.20251104.gappssmtp.com header.b=VfTPc5ni;\n arc=none smtp.client-ip=209.85.128.46","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=freebox-fr.20251104.gappssmtp.com; s=20251104; t=1776854987;\n x=1777459787; darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=xKMCEhO2nnV4Zt7oDc/aEFo4lI6O5EgQJeaAOAvTaT8=;\n b=VfTPc5ni8g0bJTv/37q9DeoaewEQARxA/gjbtNXDP8vvs2f8uX1ggheMLHyi7aEUS8\n 44yDI3vw3fKS9uVdl/Az6BEfA8SL0mGtjvK7HNsGRf8aJuvawGfsi0iVpB1tvEmU/x6Z\n ZujMDxJs7O+5DysCnZGErXylftIpxHjCgt6azQ0sTs2FyQcyHPLXQhCqDskFHz+M51F/\n 9QuIgcNZlUGzzJQIS8WpMCq9V6/qrtTRqAmEPF7fnv46NvFXt9WSBVxuEOIoSHMZCcyT\n NauwIwiEV4l052C80cMtTfj0N7Rlu5s189a5G/bLukLIzUF8qB36k/mngqNxVOS6Aksh\n qx6g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776854987; x=1777459787;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=xKMCEhO2nnV4Zt7oDc/aEFo4lI6O5EgQJeaAOAvTaT8=;\n b=QH21RXBE87r/4ml5w3RRYWDpAvJAGZA8mj61TUoRnTL3XfVqUoVI2LIAc4nReMfBuU\n UmPV3frpe31M5skYOuK3vZzJZ/Kex2eA2phfGp8W5IQO6H4Kk+zL3ZYy25W7/gARICQJ\n 2sqhR3Uv/a8Muzl1jr6fkK4iE4pjQI81yHS3eyR9NxaEZtfUAFbFK3W+Oa8bwN9wtUvB\n x77n4CGuk/uq7kqqyG+9uNQFznu92nvEsXp4q7+iCIIoGltDln1/5izeTOvjETLm4fEC\n LpKcElqXCuNhApSJqPTVFB6++GUAIEi1jG758WH9/iLtEDdrdKUTlHMBjPGZ+sgc0XMZ\n P29Q==","X-Gm-Message-State":"AOJu0YwGzTZkXU3RkO4Y/wofu8DynTLoSYkti1dZ6d3XlN8oPt0Kwf3b\n\tsfBCi8vql5DDO/bwlay2fxSWXMSFG9CdH+A/z6yQ/WXjR2ZCzdzCtVGHIaPAymfc3bEvPJDSk9a\n\ti2Ie915E=","X-Gm-Gg":"AeBDiesDzXm/8QOrPRwq+Quh6zKcZyFE8to9rAIT/XgJEOMaUFk2edsq1yGxnrzN2vE\n\tyvOEPGKIksTZ+UxzGTtZHK93IkqOmWr8A3xAHb18xXg/i6cP1Hrnb7fb90sGB5f6P2w/CIqcmMl\n\toLpcDCnwbJdMlweTdJfVyxn0dPC3oIhuXL+f/CkIn8NAkEHsvtVsv0Jycs1pqIvGzOQWz+KfrHq\n\tQqINIYEb75rL3mD96ZD9wPQlwndgjb9uCtg6grJaxhm0erqPMnPhxMxe/ebZcSv03VtTLCw84AJ\n\t1bMywXh+CAHO8RSToPA8ArBubDNiPFHTzgjlV0M7GAEmfNA9j9s8uaoxYwEo+DeYDK2gES5vfxz\n\tDNkb0iOm9RBBNI6d/CxKS9ZeEaTXKDSr3n6nbVL8WKnJvLYn7rI6ckSu/XD2qGxPMClfxayxwMS\n\t2wFr8n8V/VlH6QjlZFl11CGtg+cXzPkudi+QTkYWDCR+NlEDYrQdFPcvzWZI0dikVr1+BlOgF1U\n\tOFNpgaFCzgvHL9Y+T/sTnqu/FafM4SASVf8sFRPpNg5czGz3dT9avY=","X-Received":"by 2002:a05:600c:c082:b0:488:b043:5efd with SMTP id\n 5b1f17b1804b1-488fb75f7a6mr240468285e9.13.1776854986793;\n Wed, 22 Apr 2026 03:49:46 -0700 (PDT)","From":"Marios Makassikis ","To":"linux-cifs@vger.kernel.org,\n\tlinkinjeon@kernel.org","Cc":"smfrench@gmail.com,\n\ttom@talpey.com,\n\tsenozhatsky@chromium.org,\n\tMarios Makassikis ","Subject":"[PATCH] fs: smb: server: handle readdir_info_level_struct_sz() error","Date":"Wed, 22 Apr 2026 12:49:00 +0200","Message-ID":"<20260422104859.2599422-2-mmakassikis@freebox.fr>","X-Mailer":"git-send-email 2.51.1","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"early exit in smb2_populate_readdir_entry() if the requested info_level\nis unknown.\n\nSigned-off-by: Marios Makassikis \n---\n fs/smb/server/smb2pdu.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c\nindex 6622efdd55e3..07782f7205dc 100644\n--- a/fs/smb/server/smb2pdu.c\n+++ b/fs/smb/server/smb2pdu.c\n@@ -3947,7 +3947,13 @@ static int smb2_populate_readdir_entry(struct ksmbd_conn *conn, int info_level,\n \t\tgoto free_conv_name;\n \t}\n \n-\tstruct_sz = readdir_info_level_struct_sz(info_level) + conv_len;\n+\tstruct_sz = readdir_info_level_struct_sz(info_level);\n+\tif (struct_sz == -EOPNOTSUPP) {\n+\t\trc = -EINVAL;\n+\t\tgoto free_conv_name;\n+\t}\n+\n+\tstruct_sz += conv_len;\n \tnext_entry_offset = ALIGN(struct_sz, KSMBD_DIR_INFO_ALIGNMENT);\n \td_info->last_entry_off_align = next_entry_offset - struct_sz;\n \n","prefixes":[]}