{"id":2226092,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2226092/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422082214.10390-3-armenon@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422082214.10390-3-armenon@redhat.com>","list_archive_url":null,"date":"2026-04-22T08:22:14","name":"[v3,2/2] ui/vdagent: Use VMSTATE_GBYTEARRAY to safely migrate outbuf","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"12c3a1c0a90a3ac6fbcdbcbaec971e4d5cc6f58b","submitter":{"id":91136,"url":"http://patchwork.ozlabs.org/api/1.2/people/91136/?format=json","name":"Arun Menon","email":"armenon@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422082214.10390-3-armenon@redhat.com/mbox/","series":[{"id":500941,"url":"http://patchwork.ozlabs.org/api/1.2/series/500941/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500941","date":"2026-04-22T08:22:13","name":"migration/vmstate: Add VMState support to safely migrate GByteArray","version":3,"mbox":"http://patchwork.ozlabs.org/series/500941/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2226092/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2226092/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Met57qBA;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=HonL48Kz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0sfl48n7z1yHB\n\tfor ; Wed, 22 Apr 2026 18:22:55 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFSr4-0006Qf-07; Wed, 22 Apr 2026 04:22:42 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFSqu-0006NN-Hs\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 04:22:34 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFSqs-0006bK-5V\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 04:22:31 -0400","from mail-pj1-f71.google.com (mail-pj1-f71.google.com\n [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-421-8mVpl7kRMCOAdd1UbmSdNw-1; Wed, 22 Apr 2026 04:22:27 -0400","by mail-pj1-f71.google.com with SMTP id\n 98e67ed59e1d1-35da1c703d1so6380603a91.1\n for ; Wed, 22 Apr 2026 01:22:27 -0700 (PDT)","from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.36.110.202])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-3613fabeccesm5991459a91.6.2026.04.22.01.22.23\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 01:22:25 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776846149;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=LGW6d9MttlD6p2S8pWbgXC+RAAlUoZve1q7FzTGw8jA=;\n b=Met57qBAdzwS1SkoopqTLc+qruefMDP6rNJvgjed1uZmY5XIwJhGI/nYVvt1zjNGKOZPux\n A5EHTuI3jZxHKIvDs9P0bVTDfxHgZawdT0jTVDBd6aAHjbhfUGTYT0lfPGfGBZgQkt7zNq\n /v45XCLRqTXK+8pwwCi4t6udo8v8AnU=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776846146; x=1777450946; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=LGW6d9MttlD6p2S8pWbgXC+RAAlUoZve1q7FzTGw8jA=;\n b=HonL48KzdTGZCHkQ5j5aXNfcpn4jGfipPi92OEmPZ4DWQo2tfbn8mXjK6a2yqgUwjM\n 3N6FnT/GwudpMuf410Asl4rjjXK0r9zPFGaj+7KYrKhb9FWlYIPfQP+4ywTNT7rIT3Ad\n YuDXhMmHxLVrHmp1GyebjLZk5LjLCkGcCvaduXrVyU5WHtzY4vFUUPvQ+t2Kr7vNx/DL\n 1hjIgqjh9HVYpzFeNs00gtbb6+JMPIZLQU/aXV2w48YjmakEiCUZ+LrKJoJber+ZMHCX\n P0cEPusKxzBLTlAPCGaSbkPISpXLXPTYnvAayQJUxUHNdIrkCsFyK/MqDnEjlyMxZYEL\n LRbw=="],"X-MC-Unique":"8mVpl7kRMCOAdd1UbmSdNw-1","X-Mimecast-MFC-AGG-ID":"8mVpl7kRMCOAdd1UbmSdNw_1776846147","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776846146; x=1777450946;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=LGW6d9MttlD6p2S8pWbgXC+RAAlUoZve1q7FzTGw8jA=;\n b=XvxNOHN1tXIjfsE1r79z53DDb+68OY7Itgn1UyCsIAhQKNACy4re6ggxKQcr3XO2Ka\n +bKWJAxoVafuEftXfsEkQPqMJ2VD4++ZaCki1wz98cMoomJYZPOW9hgZkyaxGIIefEV7\n cyUd3lrxPr4SfLLPoFYlYzvIdFILHaTAvfhWQcZoc4C5fidu5I9SD4yYQMovfnupI7LU\n u9m3RW8EQHtpOZtTDe2qBose++RxmS8Duk6FnaWhHYljkmezpvPe6evwfpGQXwMBskYX\n o2goPBzoDSGbd26FqdvTsMlC3CF7O5lODlhQ4hdXjmyVn1klAt+pm5Eey2qYmhSw98HZ\n 1guw==","X-Gm-Message-State":"AOJu0Yy3yGrI+HFDCO14LqSlwRn8rXbozYoocy7AYB/v3qE1Vb8CbiKr\n hk33SrzjN7dCu9v0muZTjCpzWOe/0bEXUFrCev39ab2p/5V9QKTuIdu9pmpvWt64iondQC7VytH\n zxm9UJAYncQ2gfd46UcnQ/LTm0KcV9XVhCn1IWYjnsjxxN0qfrdPWHhWSuK+j8wyHV126eE5skE\n 32ovtJgw+8OuvTq1hWMRzouKHEBcU+3bqV02O/sXM=","X-Gm-Gg":"AeBDies0YFXtoVmzwSRqWlMba2U8oGUbpUvk8Nl26mQ3yvaqKyLJ86YbY+5hqu7Sp4l\n a6XXHDFzJqO/LsRhQWPyGYZvrMGkFPwBldb+2lk2XWJfxFDTX5bnv8uK6ShesnqxaRgvVCvjKaC\n lVyfynjvdaOBuW4dxFh4PE22P2ZNHCfPvEH0aBXLd6qAwDT6M9MvkrfxsF8C9NLuK3h4eybKMG7\n KUTv/qpTh7mNN7nhkAsWki+mteds3YEsnyu61sP4CMP+sb0kMzGgmYRL8eVXgcrLG3ejoyfETLv\n LuRMEvATzP48LVkgE47SA+F9W7e92pm9kiJuEXCtFCij9QnAMgpgcbStgUivGUbQVeZct8gUdAa\n 0Gh270JtWp6gNsuI21H00ubbt5vlZtBRM+kMUSuDk1f4LCMaYtilPn9f8ebDEndsyqgfoJe1pQQ\n ==","X-Received":["by 2002:a17:90b:5865:b0:35b:929f:7e8d with SMTP id\n 98e67ed59e1d1-3614046cdb7mr22915034a91.14.1776846146519;\n Wed, 22 Apr 2026 01:22:26 -0700 (PDT)","by 2002:a17:90b:5865:b0:35b:929f:7e8d with SMTP id\n 98e67ed59e1d1-3614046cdb7mr22915002a91.14.1776846145877;\n Wed, 22 Apr 2026 01:22:25 -0700 (PDT)"],"From":"Arun Menon ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu , Fabiano Rosas ,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Arun Menon ","Subject":"[PATCH v3 2/2] ui/vdagent: Use VMSTATE_GBYTEARRAY to safely migrate\n outbuf","Date":"Wed, 22 Apr 2026 13:52:14 +0530","Message-ID":"<20260422082214.10390-3-armenon@redhat.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260422082214.10390-1-armenon@redhat.com>","References":"<20260422082214.10390-1-armenon@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Arun Menon \n\nMigrating a GLib GByteArray is now possible directly using the newly\nintroduced VMSTATE_GBYTEARRAY. It uses the standard GLib API calls to\ncreate the array, or resize it.\n\nThis is safer than implementing a C struct and manually updating the\ndata and len fields. This commit uses the VMSTATE_GBYTEARRAY in vdagent\nto store the outbuf variable.\n\nSigned-off-by: Arun Menon \nFix-Suggested-by: Marc-André Lureau \nReviewed-by: Marc-André Lureau \n---\n ui/vdagent.c | 13 +------------\n 1 file changed, 1 insertion(+), 12 deletions(-)","diff":"diff --git a/ui/vdagent.c b/ui/vdagent.c\nindex bb0c4aa14c..9206e47000 100644\n--- a/ui/vdagent.c\n+++ b/ui/vdagent.c\n@@ -967,17 +967,6 @@ static const VMStateDescription vmstate_chunk = {\n }\n };\n \n-static const VMStateDescription vmstate_vdba = {\n- .name = \"vdagent/bytearray\",\n- .version_id = 0,\n- .minimum_version_id = 0,\n- .fields = (const VMStateField[]) {\n- VMSTATE_UINT32(len, GByteArray),\n- VMSTATE_VBUFFER_ALLOC_UINT32(data, GByteArray, 0, 0, len),\n- VMSTATE_END_OF_LIST()\n- }\n-};\n-\n struct CBInfoArray {\n uint32_t n;\n QemuClipboardInfo cbinfo[QEMU_CLIPBOARD_SELECTION__COUNT];\n@@ -1067,7 +1056,7 @@ static const VMStateDescription vmstate_vdagent = {\n VMSTATE_UINT32(xsize, VDAgentChardev),\n VMSTATE_UINT32(xoff, VDAgentChardev),\n VMSTATE_VBUFFER_ALLOC_UINT32(xbuf, VDAgentChardev, 0, 0, xsize),\n- VMSTATE_STRUCT_POINTER(outbuf, VDAgentChardev, vmstate_vdba, GByteArray),\n+ VMSTATE_GBYTEARRAY(outbuf, VDAgentChardev, 0),\n VMSTATE_UINT32(mouse_x, VDAgentChardev),\n VMSTATE_UINT32(mouse_y, VDAgentChardev),\n VMSTATE_UINT32(mouse_btn, VDAgentChardev),\n","prefixes":["v3","2/2"]}