{"id":2225983,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2225983/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260422012041.39933-2-vfazio@gmail.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.2/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260422012041.39933-2-vfazio@gmail.com>","list_archive_url":null,"date":"2026-04-22T01:20:33","name":"[libgpiod,1/9] bindings: python: use Py_RETURN_NONE in chip_get_line_name","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ae15d0251522ae447bf92600e30365ecc2c84620","submitter":{"id":78694,"url":"http://patchwork.ozlabs.org/api/1.2/people/78694/?format=json","name":"Vincent Fazio","email":"vfazio@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260422012041.39933-2-vfazio@gmail.com/mbox/","series":[{"id":500906,"url":"http://patchwork.ozlabs.org/api/1.2/series/500906/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=500906","date":"2026-04-22T01:20:32","name":"bindings: python: modernize C extensions","version":1,"mbox":"http://patchwork.ozlabs.org/series/500906/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225983/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225983/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=GEIfBZF+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35322-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"GEIfBZF+\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.161.46","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0hJf1xbDz1yD5\n\tfor ; Wed, 22 Apr 2026 11:21:38 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id B409F3024502\n\tfor ; Wed, 22 Apr 2026 01:20:59 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 3ACBD282F1C;\n\tWed, 22 Apr 2026 01:20:59 +0000 (UTC)","from mail-oo1-f46.google.com (mail-oo1-f46.google.com\n [209.85.161.46])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B836317BED0\n\tfor ; Wed, 22 Apr 2026 01:20:57 +0000 (UTC)","by mail-oo1-f46.google.com with SMTP id\n 006d021491bc7-6948b5b1c53so1436117eaf.1\n for ;\n Tue, 21 Apr 2026 18:20:57 -0700 (PDT)","from Zephyrus.localdomain ([131.93.209.211])\n by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-69464eeee56sm9876036eaf.8.2026.04.21.18.20.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Apr 2026 18:20:55 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776820859; cv=none;\n b=pMbU1F76Jm3FGzNqg5YEf+ba6pd5deqYcjg4jdMg/fSlglnlRQmrDLH4aLSITVlZoGg8Pijal1lzbEiD2wEn+feiyQlXJ3IFBrWmKxDxqQ1/RZX3yc9WcanbqnxGRQ3Og98kBi8wKhOdlMexskNaaH8f2TyjgU0UGg/xTRQ1Uao=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776820859; c=relaxed/simple;\n\tbh=i5zZUaKexs+Xza5nnpMyD890+7oJXC4MAm4TG0N5b4M=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=Tjst/+jnBMSNi0e2wLiWVkfhFuSEe0lieKt37HHPEjdDqhTeUzg4RgFaw7tPEK4hpD2MYj6Lcd0GtEAUf3rzuzk2qQ866byZyh6CjYbjb993MoQKFcZXDg+MXRo0gYXKuRJ5rj251wMRAIq3Uwcsi22B2PydSrMqnF0WrlIkBCg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=GEIfBZF+; arc=none smtp.client-ip=209.85.161.46","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776820856; x=1777425656;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=2Qkd49djOm7CHVanzxICHpkmRbKW8wdEns/fRNw6+3c=;\n b=GEIfBZF+oWVboMB8KKYJJDCE+3pKifXESuHp4Dd5LHZpqm+vfljJPSXMgoLs9unYHp\n RGzVSKCVOZVgRa4abPsxBF3lYBaVpZLlgMqTxzGIGUeGUy3C2Nj2jE0W8n84+09LFBFT\n 4YCr4L5s0KzVFySDRU6tPpSnEa8OlikwfvUxoFp+BBwzObP5zhC0n9yC/KGt2RB4xEKn\n g5eOYJpl9sUfFoB1bo/HG6LPOLij4rOIEdLAChI9SZCLyuipqUGPefZKd+N0wZO4ZOgT\n u4Bc78jjA8EmwdY/ZRDsxUkoZqJQa96qk3DNRHgpe/O3Yb7494Toh+qaKGRVVmG/CWuY\n xT+Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776820856; x=1777425656;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=2Qkd49djOm7CHVanzxICHpkmRbKW8wdEns/fRNw6+3c=;\n b=ITaqlCFMJoyoaGkH4lj7q3o3qfhHj1laZ4MDrOKrTcWOADcjlmuIunXtdm7zbuhadV\n h+gfTtXVnDUTEw4YpZ1T4Zkey9Y3GFA32UL3ghVRTM+MCfFUEmPHgBNGfLPH6OLaUtJI\n TQZ8+KEhz5BYB9OOPOaF+1Ik94tYzThUVfGKZ8MVOfPHq4KhlbgTFYXdBWB6BbuTGt/b\n lrAi+ETs12YWW+CrXEphBQmADLNmMAEIj+fV5W/lOhJrmuce+5/nzCYUp+8If1zTgfkv\n 8CoiQqw3W2C/E6hXpi9+LHuCQ+Nk+a9v8lI63fYCw0kGKNGcBGpTPyLjczR6uGRrBZRc\n xyXA==","X-Gm-Message-State":"AOJu0YxSjoUsIRO6AHSoUCvh3udlwlZOSuQRLD6+jdsmBQjNgDSE5BX7\n\tS/oS16/FD/V6ABfRtaLfOfAi2BI61YF1kPzDvliSBnXZrq7ZZTf9NrmhXr7N8w==","X-Gm-Gg":"AeBDieu0OyDizH/LCV0LsPcWuofg5mT7Z//d/D/2/Xa57qWIjA1ijA5G79mfaNBKray\n\tDiHYgxR5VbA1vLrPNeVmJXUY5XUWSo0eC1vb2NDMQEiBlxMcae6SdY3eigkaZMsTvtj3VTn1Tmb\n\t6NkG8wwdeYc0eIoug7sWov4uIvUQxAzQWbTjvNAKONcZPI71vluOay0KYiaep9XrUnUDKdTaO6f\n\t7pXN3SzSExKNmNmgFfyL2DsLqnvUSMKgFfce0/0NFkiCXlLQ1E+D9gmD8v2rkLCesCz1XBKSuOE\n\tDIGS0PNWADCut5pZs1MLlNsJ06H6tLDvRy+e190HG/99xbfliq5sSroY7mvpBIRyZMhi4lgwGZk\n\tHl3683WvZhEY0/vPwGBbhT18Qg6OMCWI55OVOvdbSLFRtBH6qayC/oTCC1uoBSObbJu1eDh1QHr\n\tBrgyedu4+Hm+D8JlfVfUR74OFLTE2Bm4GAqT+Ft8jdSVc6cNQCaVzmNRNesxVtnnOGeREjJzmI","X-Received":"by 2002:a05:6820:82a:b0:685:5300:f1c2 with SMTP id\n 006d021491bc7-69462ebb6a5mr12023866eaf.28.1776820856433;\n Tue, 21 Apr 2026 18:20:56 -0700 (PDT)","From":"Vincent Fazio ","To":"linux-gpio@vger.kernel.org","Cc":"Vincent Fazio ","Subject":"[libgpiod][PATCH 1/9] bindings: python: use Py_RETURN_NONE in\n chip_get_line_name","Date":"Tue, 21 Apr 2026 20:20:33 -0500","Message-ID":"<20260422012041.39933-2-vfazio@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260422012041.39933-1-vfazio@gmail.com>","References":"<20260422012041.39933-1-vfazio@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"When commit 0c0993569c54 introduced `chip_get_line_name`, it failed to\nutilize the standard `Py_RETURN_NONE` macro used throughout the rest of\nthe extension.\n\nWhile commit fbc0a4471215 fixed the underlying reference counting issue,\nutilizing the macro is the standard way of managing reference counts,\nworks across all CPython versions, and brings the function in line with\nothers in the extension.\n\nSigned-off-by: Vincent Fazio \n---\n bindings/python/gpiod/ext/chip.c | 13 ++++++-------\n 1 file changed, 6 insertions(+), 7 deletions(-)","diff":"diff --git a/bindings/python/gpiod/ext/chip.c b/bindings/python/gpiod/ext/chip.c\nindex 53c4b80..19b3a4f 100644\n--- a/bindings/python/gpiod/ext/chip.c\n+++ b/bindings/python/gpiod/ext/chip.c\n@@ -152,7 +152,7 @@ static PyObject *chip_get_line_name(chip_object *self, PyObject *args)\n \tint ret;\n \tunsigned int offset;\n \tstruct gpiod_line_info *info;\n-\tPyObject *line_name;\n+\tPyObject *line_name = NULL;\n \tconst char *name;\n \n \tret = PyArg_ParseTuple(args, \"I\", &offset);\n@@ -166,16 +166,15 @@ static PyObject *chip_get_line_name(chip_object *self, PyObject *args)\n \t\treturn Py_gpiod_SetErrFromErrno();\n \n \tname = gpiod_line_info_get_name(info);\n-\tif (!name) {\n-\t\tPy_INCREF(Py_None);\n-\t\tline_name = Py_None;\n-\t} else {\n+\tif (name)\n \t\tline_name = PyUnicode_FromString(name);\n-\t}\n \n \tgpiod_line_info_free(info);\n \n-\treturn line_name;\n+\tif (line_name)\n+\t\treturn line_name;\n+\n+\tPy_RETURN_NONE;\n }\n \n static PyObject *\n","prefixes":["libgpiod","1/9"]}