{"id":2225959,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2225959/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/patch/20260421211155.1974219-1-lucas.vdias@luizalabs.com/","project":{"id":68,"url":"http://patchwork.ozlabs.org/api/1.2/projects/68/?format=json","name":"Open Virtual Network development","link_name":"ovn","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260421211155.1974219-1-lucas.vdias@luizalabs.com>","list_archive_url":null,"date":"2026-04-21T21:11:55","name":"[ovs-dev,v2,1/2] northd: Use uuid hash from source of parsed route.","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3f231443df32a0dd89c26a2f31f3087b221a5a11","submitter":{"id":90169,"url":"http://patchwork.ozlabs.org/api/1.2/people/90169/?format=json","name":"Lucas Vargas Dias","email":"lucas.vdias@luizalabs.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ovn/patch/20260421211155.1974219-1-lucas.vdias@luizalabs.com/mbox/","series":[{"id":500896,"url":"http://patchwork.ozlabs.org/api/1.2/series/500896/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/list/?series=500896","date":"2026-04-21T21:11:55","name":"[ovs-dev,v2,1/2] northd: Use uuid hash from source of parsed route.","version":2,"mbox":"http://patchwork.ozlabs.org/series/500896/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225959/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2225959/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=luizalabs.com header.i=@luizalabs.com\n header.a=rsa-sha256 header.s=google header.b=ArysjVn5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp4.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=luizalabs.com header.i=@luizalabs.com header.a=rsa-sha256\n header.s=google header.b=ArysjVn5","smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=luizalabs.com"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0Zmm4tFXz1yHm\n\tfor ; Wed, 22 Apr 2026 07:12:08 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 0435B40AB9;\n\tTue, 21 Apr 2026 21:12:07 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id dearjZOLzU7H; Tue, 21 Apr 2026 21:12:06 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp4.osuosl.org (Postfix) with ESMTPS id DCA6540A19;\n\tTue, 21 Apr 2026 21:12:05 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id B48C4C058E;\n\tTue, 21 Apr 2026 21:12:05 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 7C7FDC058D\n for ; Tue, 21 Apr 2026 21:12:04 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 5C76940A2D\n for ; Tue, 21 Apr 2026 21:12:04 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id rAmz6yrkDff7 for ;\n Tue, 21 Apr 2026 21:12:03 +0000 (UTC)","from mail-dl1-x122d.google.com (mail-dl1-x122d.google.com\n [IPv6:2607:f8b0:4864:20::122d])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 977C640A19\n for ; Tue, 21 Apr 2026 21:12:03 +0000 (UTC)","by mail-dl1-x122d.google.com with SMTP id\n a92af1059eb24-12c8f9846c8so3522769c88.0\n for ; Tue, 21 Apr 2026 14:12:03 -0700 (PDT)","from WNEC-73GS814.. ([186.237.124.211])\n by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12c8caecebfsm10680261c88.5.2026.04.21.14.12.00\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Apr 2026 14:12:01 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org DCA6540A19","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 977C640A19"],"Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::122d; helo=mail-dl1-x122d.google.com;\n envelope-from=lucas.vdias@luizalabs.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 977C640A19","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=luizalabs.com; s=google; t=1776805922; x=1777410722; darn=openvswitch.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=/A0Sa+2KkPlHc0dv53qCvz5zgHmDbGvA8Lp2aqgvSlY=;\n b=ArysjVn5qUQtHPmyshFC54mwyQJXeRj/P66vQqn/57ho8/iAzHH5IJ1HVbyxOUp+Sv\n END+yEV1YbkTMGKK3BaqAOb4SW5NNX0lJZjaWU4wanX3o/IweoEBQdgaX6W1Thi3ej+6\n TU+SekIJEUU0au+kafVXL1sADDWY8FlSyy2f4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776805922; x=1777410722;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=/A0Sa+2KkPlHc0dv53qCvz5zgHmDbGvA8Lp2aqgvSlY=;\n b=UrW7LL5wiSznoP6qspFOkZyR1gF7nvOUDktpiPLQf3/mL8DA0USzxVl8Y68nM1LxJc\n FKikH74/Y5vjG3XbMWvz9zgVi7IoEwakCmDreRXyR40cV3skYfaj4eX+BM2X6TfxhP6X\n F/6G+aAORYp80MBiWSMZm1NmZ5h4oDXiYUAnF+2Sj2dM52j/LKYevyOXY8rg1FxgYF+2\n M1fKpEGSGbgWft0HdkqlqZlTi1BKUVo/Q2wQ0XRqU5c2yWXvnfP4BVAD6ZDWpbE3jqXS\n 2ZgLoS8nO3HwA/GGY6L7t9+AG/hdbEoMXB8AdxSh6XBftDyVkbA1iIzKlBynC2J6jM13\n X3mg==","X-Gm-Message-State":"AOJu0YyFxhrxjitUssitdqq3uDyoMerEw/IRPSm/vcYJppNEaKwkx+Cy\n kOvGcSVnsqAJhxe8BG7pIrAhV7n1pji1wMl1VBWRrG8pA2DtxQVrSP65ZxmgBwOOlEuGt6/9xaB\n Q183dLv9vChW/qXaONp2U65/ENkVjOQ5k0OAh8l1RFjWDsrVmNx1335tdZIbT","X-Gm-Gg":"AeBDiethP2q1wMA+ctZGMaLK3cmwFcbBINlwIiGzb/YsMepOVhxctE9ET1FRRLkdQOg\n Re2ZkSvk89VQhQh4cjgH8H5fQIM6qeZUXhPYHH+YBCSGdxvq23j1ydldIcvQ7/WksnH5wqFvbRc\n oTUHWjrEfy7VPtVpI1Ul19CSgsEpT9NGkJdMMYJm3j+7dhRKFtPvyXlXCDsBeGhnATPPJc2Hhit\n w9C+bv+BLOfJ82Yg9t0MaNNdDYsSNt0DdfWYNlWL23wSe8qdDj/55+ga2kIUrz2Gnf8jf1/prTr\n MlqDbUnoAA7Epi1LiPgs0exy3b8EYbKqwDm/3Cig9mGrPVIu88did4Mlv0R1voB7IEiuTpyG9Vv\n +OGSTo2kw3ecIu01cHdEWFHnQlxS3lYRqKDTAaVulpXa/99o9fTJlxeXLn9bGbCfRmCZDdfXJg7\n xBBW6R9JCKgy74GEqgoWWdqjv02XLCEvPlTupMZC1eTvHO5a4=","X-Received":"by 2002:a05:7022:6886:b0:12a:6e97:c21f with SMTP id\n a92af1059eb24-12c73d32ce4mr10576107c88.0.1776805921959;\n Tue, 21 Apr 2026 14:12:01 -0700 (PDT)","To":"dev@openvswitch.org","Date":"Tue, 21 Apr 2026 18:11:55 -0300","Message-ID":"<20260421211155.1974219-1-lucas.vdias@luizalabs.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Subject":"[ovs-dev] [PATCH ovn v2 1/2] northd: Use uuid hash from source of\n parsed route.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Lucas Vargas Dias via dev ","Reply-To":"Lucas Vargas Dias ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"Search by parsed route can be direct using uuid hash\nfrom source (static route, learned route, connect\nroute), this avoids the search by ovn_datapath,\nand after, the search for parsed route.\n\nSigned-off-by: Lucas Vargas Dias \n---\n northd/en-learned-route-sync.c | 11 ++---------\n northd/northd.c | 11 +++++------\n northd/northd.h | 4 ++--\n 3 files changed, 9 insertions(+), 17 deletions(-)","diff":"diff --git a/northd/en-learned-route-sync.c b/northd/en-learned-route-sync.c\nindex 4f7a12a28..38bd09739 100644\n--- a/northd/en-learned-route-sync.c\n+++ b/northd/en-learned-route-sync.c\n@@ -230,15 +230,9 @@ routes_table_sync(\n \n static struct parsed_route *\n find_learned_route(const struct sbrec_learned_route *learned_route,\n- const struct ovn_datapaths *lr_datapaths,\n const struct hmap *routes)\n {\n- const struct ovn_datapath *od = ovn_datapath_from_sbrec_(\n- &lr_datapaths->datapaths, learned_route->datapath);\n- if (!od) {\n- return NULL;\n- }\n- return parsed_route_lookup_by_source(od, ROUTE_SOURCE_LEARNED,\n+ return parsed_route_lookup_by_source(ROUTE_SOURCE_LEARNED,\n &learned_route->header_, routes);\n }\n \n@@ -273,8 +267,7 @@ learned_route_sync_sb_learned_route_change_handler(struct engine_node *node,\n \n if (sbrec_learned_route_is_deleted(changed_route)) {\n struct parsed_route *route = find_learned_route(\n- changed_route, &northd_data->lr_datapaths,\n- &data->parsed_routes);\n+ changed_route, &data->parsed_routes);\n if (!route) {\n goto fail;\n }\ndiff --git a/northd/northd.c b/northd/northd.c\nindex 0b52db6cf..4fd4b9de9 100644\n--- a/northd/northd.c\n+++ b/northd/northd.c\n@@ -12225,15 +12225,14 @@ parsed_route_clone(const struct parsed_route *pr)\n return new_pr;\n }\n \n-/* Searches for a parsed_route in a hmap based on datapath, source and\n+/* Searches for a parsed_route in a hmap based on source and\n * source_hint. */\n struct parsed_route *\n-parsed_route_lookup_by_source(const struct ovn_datapath *od,\n- enum route_source source,\n+parsed_route_lookup_by_source(enum route_source source,\n const struct ovsdb_idl_row *source_hint,\n const struct hmap *routes)\n {\n- size_t hash = uuid_hash(&od->key);\n+ size_t hash = uuid_hash(&source_hint->uuid);\n struct parsed_route *route;\n HMAP_FOR_EACH_WITH_HASH (route, key_node, hash, routes) {\n if (route->source == source &&\n@@ -12247,10 +12246,10 @@ parsed_route_lookup_by_source(const struct ovn_datapath *od,\n \n /* This hash needs to be equal to the one used in\n * build_route_flows_for_lrouter to iterate over all routes of a datapath.\n- * This is distinct from route_hash which is stored in parsed_route->hash. */\n+ * This is equal to route_hash which is stored in parsed_route->hash. */\n size_t\n parsed_route_hash(const struct parsed_route *pr) {\n- return uuid_hash(&pr->od->key);\n+ return uuid_hash(&pr->source_hint->uuid);\n }\n \n void\ndiff --git a/northd/northd.h b/northd/northd.h\nindex e86d39f9a..a9070d6f6 100644\n--- a/northd/northd.h\n+++ b/northd/northd.h\n@@ -859,8 +859,8 @@ struct parsed_route {\n \n struct parsed_route *parsed_route_clone(const struct parsed_route *);\n struct parsed_route *parsed_route_lookup_by_source(\n- const struct ovn_datapath *od, enum route_source source,\n- const struct ovsdb_idl_row *source_hint, const struct hmap *routes);\n+ enum route_source source, const struct ovsdb_idl_row *source_hint,\n+ const struct hmap *routes);\n size_t parsed_route_hash(const struct parsed_route *);\n void parsed_route_free(struct parsed_route *);\n \n","prefixes":["ovs-dev","v2","1/2"]}