{"id":2225956,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2225956/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260421210954.1170437-7-philippe.reynes@softathome.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260421210954.1170437-7-philippe.reynes@softathome.com>","list_archive_url":null,"date":"2026-04-21T21:09:45","name":"[v5,06/15] test: dm: ecdsa.c: clean this test as software ecdsa is now implemented","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ef620d131972d1ac646fb35bd6fb4fb724123312","submitter":{"id":74351,"url":"http://patchwork.ozlabs.org/api/1.2/people/74351/?format=json","name":"Philippe Reynes","email":"philippe.reynes@softathome.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260421210954.1170437-7-philippe.reynes@softathome.com/mbox/","series":[{"id":500895,"url":"http://patchwork.ozlabs.org/api/1.2/series/500895/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=500895","date":"2026-04-21T21:09:51","name":"add software ecdsa support","version":5,"mbox":"http://patchwork.ozlabs.org/series/500895/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225956/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225956/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector1-softathome1-onmicrosoft-com\n header.b=EXZ5qXZT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=softathome.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.b=\"EXZ5qXZT\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=softathome.com","phobos.denx.de;\n spf=pass smtp.mailfrom=philippe.reynes@softathome.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0ZmN5tGTz1yGs\n\tfor ; Wed, 22 Apr 2026 07:11:48 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 43C9784366;\n\tTue, 21 Apr 2026 23:10:29 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 6E242839D5; Tue, 21 Apr 2026 23:10:19 +0200 (CEST)","from PAUP264CU001.outbound.protection.outlook.com\n (mail-francecentralazlp170110002.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c20a::2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id D07E98429E\n for ; Tue, 21 Apr 2026 23:10:02 +0200 (CEST)","from PA7P264CA0038.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:34b::14)\n by PAZP264MB2447.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1f1::21)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.16; Tue, 21 Apr\n 2026 21:09:57 +0000","from PA3PEPF000089BA.FRAP264.PROD.OUTLOOK.COM\n (2603:10a6:102:34b:cafe::43) by PA7P264CA0038.outlook.office365.com\n (2603:10a6:102:34b::14) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9791.48 via Frontend Transport; Tue,\n 21 Apr 2026 21:09:57 +0000","from proxy.softathome.com (149.6.166.170) by\n PA3PEPF000089BA.mail.protection.outlook.com (10.167.242.22) with Microsoft\n SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.18\n via Frontend Transport; Tue, 21 Apr 2026 21:09:57 +0000","from sah1lpt726.softathome.com (unknown [192.168.72.32])\n by proxy.softathome.com (Postfix) with ESMTPSA id 541E920EC2;\n Tue, 21 Apr 2026 23:09:57 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=nWUELoyRVTvOjn6046+rkAF/od/qk8YBLDHECkK5AFqRM46uhUN2eWuNMJgf5O8gBkOQAc1SVDj4ddJILCvLxbUIXI6cYU+QufisRneppV9jkhJqRoW0cJKdsLT5RC3GBZdSpx/ZCYDXz3OeTj0eM8yNrXj4OIe3j1gV/7kVmR7Uiu/v3HGRhJuloGzDVMZqgaZEozLrDUYOLegkdeOAYAyTs5XwUDiOo2pbN5RcffA3A96CCAJOpNUilQ3zu4PEL/NuQqhCdqAg1sxkyIBGvJGUplbv8MIwoEfDJz3U8XaFtPVJqfuAuFoBRdYFKkVve6aec+5F9wQlRjityx7orA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=uxQjTm9TohyVkMDfkVgQzYNnyWmqmfMYEnoQXCk0vwQ=;\n b=J+/roPlNuE/OnzpuXQB4awJx9BF1hzKkKcBCoD1PqAF1ZLd1DFBdKshIXRKSTKHN0oCCm6tCTnE5YCQxEQ3Ha7frW5Lco1jghv4vx6DEwDpcOUIzlLGx93nq1QcFQwhwqd0S1tU/eCJU7oz0GSlOB+PExY7307rEyxohyPtn6NT/BkGasISEFQW4n2T3sZZG0JjddiKUZ8+J4vRA73dr/hrUi52WAify+zDGOJ6oLB5m1xNxAwIXmng7F5RfwWJP1BfWsDBgfo78ZuiVFSko6g3p+VaW9pgUffO4/kJjKtUB1j9oegaTvti0sKA3eNIz0iEoLiZ3PBaR5QWqkYU8GA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 149.6.166.170) smtp.rcpttodomain=canonical.com smtp.mailfrom=softathome.com;\n dmarc=bestguesspass action=none header.from=softathome.com; dkim=none\n (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=softathome1.onmicrosoft.com; s=selector1-softathome1-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=uxQjTm9TohyVkMDfkVgQzYNnyWmqmfMYEnoQXCk0vwQ=;\n b=EXZ5qXZT7HEtRxtHvnFwz0E56O9Za2YJ3LI7Y5Ra/UrcYrJY9kIMzFwKzCcaC9UFPKkwfMmld9ldbkbeLdij8rUq9XHIlEu3JUD7BEaK5G4lI0qz/m/lK7JO3AaCYfcko90m5kwzzrDLkpFLeX5gXKsYd8Sd1SkTtMrUI2uKOj2XlEWFUlO27aQTBGtp3g4EURMGehkKfSSWgGEbZYKV1+doD7OUPLDa42yksb91g/joSimT80hm4aDLq1Rt3WQSF/S9SrIff15aewyM7AJ6HkYAbXoDVtKqVgwgmg7QIOoqI6JByUvSnUxVjcZdelVHavEy0wl7fqWr1h8lK8rVLg==","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 149.6.166.170)\n smtp.mailfrom=softathome.com; dkim=none (message not signed)\n header.d=none;dmarc=bestguesspass action=none header.from=softathome.com;","Received-SPF":"Pass (protection.outlook.com: domain of softathome.com\n designates 149.6.166.170 as permitted sender)\n receiver=protection.outlook.com; client-ip=149.6.166.170;\n helo=proxy.softathome.com; pr=C","From":"Philippe Reynes ","To":"marko.makela@iki.fi, jonny.green@keytechinc.com, raymondmaoca@gmail.com,\n trini@konsulko.com, simon.glass@canonical.com","Cc":"u-boot@lists.denx.de,\n\tPhilippe Reynes ","Subject":"[PATCH v5 06/15] test: dm: ecdsa.c: clean this test as software ecdsa\n is now implemented","Date":"Tue, 21 Apr 2026 23:09:45 +0200","Message-ID":"<20260421210954.1170437-7-philippe.reynes@softathome.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260421210954.1170437-1-philippe.reynes@softathome.com>","References":"<20260421210954.1170437-1-philippe.reynes@softathome.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"PA3PEPF000089BA:EE_|PAZP264MB2447:EE_","Content-Type":"text/plain","X-MS-Office365-Filtering-Correlation-Id":"0a208658-3a65-48d9-79ec-08de9fea57b6","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|36860700016|376014|82310400026|1800799024|18002099003|56012099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n g0h9aWGZwqaPGMGTnFrhwryd8FkuMYgPizKN0Uby8m4Rz/cDCG13+I+yFTo8rG9Wiwol01U5h7RuFbsAAhzrHUXNLTgOWu8vKyZMcg0zJtPaCnoNVLijB97VVPKcUgPZclQWxnpsqThNuV8MT0tArkkRppFmautBb8NMh5YLOn56cYUdY/J4T40VP577BK/DM66iRBpmKT8UAeyCYLaRF9KF7YweT6b793IeGXfZ44TqG3K519ZawvwHjDz/lTvRaPBtDh6Rgrw/jE+HOkfi4No/LHP5ZSviE60Dlse8NEvecTYsV7R0G3LjW0PxCKYGEum7vYMjJ8iEc9diJGHIy4Q/RWZU3rhyUwsNYwfgPgtY3+AXWPXWXGvBvuLPeB6EKNH6H/lfl3YTjorAlC2NkL0nK17HQleLhDMftJTUuD+r+UI50OoBfiXwr7qiYF30yEdN9FM49/MKQG8Bi8kZIEQldnkdFe/AGL1uvH8gAOsKVjR9YjW4fJn/c65p/G+O2MHXigJDaixbsI87lAa6xq8fFQiZauiOsolz81HDEKSf7QSB//fAOsMLqgzhkhoJTt58xluIyinDd7v4PUgBUv3jEaDqJdN+RyhMf5bN1OKg/YLSvfVAbNSvb9opDioBUwhSfvmkdyVRf6iQ8W9d/xqrrrWuAhMRWfQxFXTO1GntfTCKXDMC3USv1Nr7Cx7ISDFnwQ2q+9Mh7FQ3n9UI8hZdsy0Gcm8Z0prkZ0k2343hHleRdbsfwKWb3dUEIRUHAlQLS8lK2RfUoygo3+/g5A==","X-Forefront-Antispam-Report":"CIP:149.6.166.170; CTRY:FR; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:proxy.softathome.com; PTR:InfoDomainNonexistent;\n CAT:NONE;\n SFS:(13230040)(36860700016)(376014)(82310400026)(1800799024)(18002099003)(56012099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n dWzoAR4d0BT0kyLgjVbJ1VFl9ehNvQNV7IknFUVITQQS8Xioxh1YBib/N3kkJKNK1QBTePLILl5+67X1OgGXXrcS1gWZC5npMezsE6dtqdeNRIjOB8HvrF9TTWViI/3DOqGi3QyYSGHaeWPa0RKZdjoq/SHNHywy+vSc4DQStNBs/+fyMJ+NP57WH69uF+K+TqpIseZVqG9xo8Usdrch4rD9QGcjKc+weEuDUJihQvvvEUqgHe+3Ep06Q/GIxiXKu+FdHx0VL2L/eTQazKMl+OCLkDhzXxPM/eKhzQ5+38j/jGXdJCTwx7pOF4MyqatNbTShA1+ruYRT0l8sBGUDW37AzjY7MQGl0xVQbZKzcCc042928uTXxbbKBnsG8KpLIMkIfDpEKBKX7SQCNsE4VqaDdaGxYoPWcdJZyQPYDA5LJMdEYns0KJ3nIhrZP6cw","X-OriginatorOrg":"softathome.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"21 Apr 2026 21:09:57.5848 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 0a208658-3a65-48d9-79ec-08de9fea57b6","X-MS-Exchange-CrossTenant-Id":"aa10e044-e405-4c10-8353-36b4d0cce511","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=aa10e044-e405-4c10-8353-36b4d0cce511; Ip=[149.6.166.170];\n Helo=[proxy.softathome.com]","X-MS-Exchange-CrossTenant-AuthSource":"PA3PEPF000089BA.FRAP264.PROD.OUTLOOK.COM","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PAZP264MB2447","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"The test ecdsa was done when ecdsa was only supported by hardware.\nSo it wasn't possible to test ecdsa on sandbox, and there is a test\nto check that ecdsa is not supported on sandbox.\nNow, there is a software implementation of ecdsa. So we remove\nthis outdated test.\n\nSigned-off-by: Philippe Reynes \n---\nv2:\n- initial version\nv3:\n- no change\nv4:\n- add a test that use ecdsa_verify\nv5:\n- change secp256r1 to ecdsa256\n- check that checksum and crypto are not null\n\n test/dm/ecdsa.c | 107 +++++++++++++++++++++++++++++++++++++++++++-----\n 1 file changed, 97 insertions(+), 10 deletions(-)","diff":"diff --git a/test/dm/ecdsa.c b/test/dm/ecdsa.c\nindex d7eac7115f7..1e9d5148400 100644\n--- a/test/dm/ecdsa.c\n+++ b/test/dm/ecdsa.c\n@@ -3,36 +3,123 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n \n+#define CHECK(op) ({\t\t\t\t\t\t\t\\\n+\t\tint err = op;\t\t\t\t\t\t\\\n+\t\tif (err < 0) {\t\t\t\t\t\t\\\n+\t\t\tprintf(\"%s: %s: %s\\n\", __func__, #op,\t\t\\\n+\t\t\t fdt_strerror(err));\t\t\t\\\n+\t\t\treturn err;\t\t\t\t\t\\\n+\t\t}\t\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\terr;\t\t\t\t\t\t\t\\\n+\t})\n+\n+static int set_fdt_ecdsa_point(char *fdt, char *name, const char *data, size_t len)\n+{\n+\tchar *value = NULL;\n+\tint ret = 0;\n+\n+\tif (!fdt || !name || !data) {\n+\t\tret = -EINVAL;\n+\t\tgoto out;\n+\t}\n+\n+\tvalue = malloc(len / 2);\n+\tif (!value) {\n+\t\tret = -EINVAL;\n+\t\tgoto out;\n+\t}\n+\n+\tret = hex2bin(value, data, len / 2);\n+\tif (ret)\n+\t\tgoto out;\n+\n+\tret = fdt_property(fdt, name, value, len / 2);\n+\tif (ret)\n+\t\tgoto out;\n+\n+ out:\n+\tfree(value);\n+\treturn ret;\n+}\n+\n+static int create_fdt_with_ecdsa_key(char *fdt, size_t size,\n+\t\t\t\t const char *name, const char *curve,\n+\t\t\t\t const char *x, const char *y)\n+{\n+\tCHECK(fdt_create(fdt, size));\n+\tCHECK(fdt_finish_reservemap(fdt));\n+\tCHECK(fdt_begin_node(fdt, \"\"));\n+\tCHECK(fdt_begin_node(fdt, \"signature\"));\n+\tCHECK(fdt_begin_node(fdt, name));\n+\tCHECK(fdt_property_string(fdt, \"algo\", \"sha256,ecdsa256\"));\n+\tCHECK(set_fdt_ecdsa_point(fdt, \"ecdsa,y-point\", y, strlen(y)));\n+\tCHECK(set_fdt_ecdsa_point(fdt, \"ecdsa,x-point\", x, strlen(x)));\n+\tCHECK(fdt_property_string(fdt, \"ecdsa,curve\", curve));\n+\tCHECK(fdt_property_string(fdt, \"key-name-hint\", name));\n+\tCHECK(fdt_end_node(fdt)); /* name */\n+\tCHECK(fdt_end_node(fdt)); /* \"signature\" */\n+\tCHECK(fdt_end_node(fdt)); /* \"\" */\n+\tCHECK(fdt_finish(fdt));\n+\tCHECK(fdt_pack(fdt));\n+\n+\treturn 0;\n+}\n+\n /*\n * Basic test of the ECDSA uclass and ecdsa_verify()\n *\n- * ECDSA implementations in u-boot are hardware-dependent. Until we have a\n- * software implementation that can be compiled into the sandbox, all we can\n- * test is the uclass support.\n+ * ECDSA software implementation is tested in another test,\n+ * so we only check that the class UCLASS_ECDSA may be used.\n *\n- * The uclass_get() test is redundant since ecdsa_verify() would also fail. We\n- * run both functions in order to isolate the cause more clearly. i.e. is\n- * ecdsa_verify() failing because the UCLASS is absent/broken?\n+ * The data used in this test come from RFC6979\n */\n static int dm_test_ecdsa_verify(struct unit_test_state *uts)\n {\n \tstruct uclass *ucp;\n+\tconst char *full_name = \"sha256,ecdsa256\";\n+\tconst char *name = \"key-ecdsa-256\";\n+\tconst char *curve = \"prime256v1\";\n+\tconst char *x = \"60FED4BA255A9D31C961EB74C6356D68C049B8923B61FA6CE669622E60F29FB6\";\n+\tconst char *y = \"7903FE1008B8BC99A41AE9E95628BC64F2F1B20C2D7E9F5177A3C294D4462299\";\n+\tconst char *r = \"EFD48B2AACB6A8FD1140DD9CD45E81D69D2C877B56AAF991C34D0EA84EAF3716\";\n+\tconst char *s = \"F7CB1C942D657C41D436C7A1B6E29F65F3E900DBB9AFF4064DC4AB2F843ACDA8\";\n+\tuint8_t sig[64];\n+\tsize_t fdt_size = 512;\n+\tchar fdt[512];\n \n-\tstruct checksum_algo algo = {\n-\t\t.checksum_len = 256,\n+\tstruct image_region region[] = {\n+\t\t{\n+\t\t\t.data = \"sample\",\n+\t\t\t.size = strlen(\"sample\"),\n+\t\t},\n \t};\n \n \tstruct image_sign_info info = {\n-\t\t.checksum = &algo,\n+\t\t.checksum = image_get_checksum_algo(full_name),\n+\t\t.crypto = image_get_crypto_algo(full_name),\n+\t\t.fdt_blob = fdt,\n \t};\n \n+\tut_assertnonnull(info.checksum);\n+\tut_assertnonnull(info.crypto);\n+\n+\t/* create a fdt with the public key */\n+\tut_asserteq(0, create_fdt_with_ecdsa_key(fdt, fdt_size, name, curve, x, y));\n+\n+\t/* prepare the signature */\n+\tut_asserteq(0, hex2bin(sig + 0, r, strlen(r) / 2));\n+\tut_asserteq(0, hex2bin(sig + 32, s, strlen(s) / 2));\n+\n \tut_assertok(uclass_get(UCLASS_ECDSA, &ucp));\n \tut_assertnonnull(ucp);\n-\tut_asserteq(-ENODEV, ecdsa_verify(&info, NULL, 0, NULL, 0));\n+\tut_asserteq(0, ecdsa_verify(&info, region, 1, sig, sizeof(sig)));\n \n \treturn 0;\n }\n+\n DM_TEST(dm_test_ecdsa_verify, UTF_SCAN_PDATA | UTF_SCAN_FDT);\n","prefixes":["v5","06/15"]}