{"id":2225839,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2225839/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260421163031.704-8-alifm@linux.ibm.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.2/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260421163031.704-8-alifm@linux.ibm.com>","list_archive_url":null,"date":"2026-04-21T16:30:31","name":"[v14,7/7] vfio/pci: Remove the pcie check for VFIO_PCI_ERR_IRQ_INDEX","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7edb0e1820a58c686ff3c4e7f6b7837713f55fa8","submitter":{"id":73785,"url":"http://patchwork.ozlabs.org/api/1.2/people/73785/?format=json","name":"Farhan Ali","email":"alifm@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260421163031.704-8-alifm@linux.ibm.com/mbox/","series":[{"id":500852,"url":"http://patchwork.ozlabs.org/api/1.2/series/500852/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=500852","date":"2026-04-21T16:30:25","name":"Error recovery for vfio-pci devices on s390x","version":14,"mbox":"http://patchwork.ozlabs.org/series/500852/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225839/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225839/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=QBbGJc0N;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-52861-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=\"QBbGJc0N\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=148.163.156.1","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.ibm.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0Sdr4Ydtz1yGs\n\tfor ; Wed, 22 Apr 2026 02:35:44 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 771DF3095BA0\n\tfor ; Tue, 21 Apr 2026 16:31:29 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id ABB793876D7;\n\tTue, 21 Apr 2026 16:30:53 +0000 (UTC)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E0A138423D;\n\tTue, 21 Apr 2026 16:30:52 +0000 (UTC)","from pps.filterd (m0353729.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63LC24Kp1685435;\n\tTue, 21 Apr 2026 16:30:46 GMT","from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dm2j6n903-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tTue, 21 Apr 2026 16:30:45 +0000 (GMT)","from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63LGKPTk025434;\n\tTue, 21 Apr 2026 16:30:44 GMT","from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7])\n\tby ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dmn9k1ead-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tTue, 21 Apr 2026 16:30:44 +0000 (GMT)","from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com\n [10.39.53.230])\n\tby smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63LGUhoo29426396\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tTue, 21 Apr 2026 16:30:43 GMT","from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 3CBC458054;\n\tTue, 21 Apr 2026 16:30:43 +0000 (GMT)","from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 0C1045805F;\n\tTue, 21 Apr 2026 16:30:42 +0000 (GMT)","from IBM-D32RQW3.ibm.com (unknown [9.61.248.17])\n\tby smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n\tTue, 21 Apr 2026 16:30:41 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776789053; cv=none;\n b=AChvsXINc7KWVsUJzhn20EfE1mndpMSaAq7Ilz9ruXfrFDwkNp2cnrzMedXnHXoLxZ3Zfi6zdw4FOG7vJdIzZcQmgGJxv7RWBJ8in7mj28vagy/xKYgigtwN5iE0z//2YikHPas4TVVwbw6lmAByksK4xByd3iwSMSbyN5Tpus0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776789053; c=relaxed/simple;\n\tbh=BI37w9SjuKL3yvCM7bDoU4en5ns30NyXBnAazDt1Q0I=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=eneR6aYr4WO33fpSjI92AtdYqh7mQyKMAaUF65+sc671x0tUyOcDO/p0HxP3CYqelvU2QGY7Gr2YHo8v/jZPKzQA4bZGWFukqkxHXJlXrJDcGjTModu/LUCd2XNI9mRcrdxyHdWSe2U26xKvGJs6Fh468/ZXOHT235AGKLQWcbE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n spf=pass smtp.mailfrom=linux.ibm.com;\n dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=QBbGJc0N; arc=none smtp.client-ip=148.163.156.1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=pp1; bh=ptCH11AOccuUefO9O\n\t9jqin/FEkhD0OjCVnd7OxBRv5U=; b=QBbGJc0NlJjwTwaYTcEh1t+OdBhA2dHNb\n\txXtedBucnY6irNrMiLZIcTnun9oPibup2TM+W+LEc9IXZGLsEZ/u8RyMKjPySD4t\n\ttfXYncP/7CGqaRRnyV3UT/ujmBtrPkTiFCDwyGCjwGjigys6WRVrHtrWnkgSzudX\n\t1Fty4UlEwUoB8BOzPwgxhv78Eu4mbX7P6bNqwahZoQakGj3EUToK8hWMOkpdjjn8\n\tS3p0AFLQXtiPAtffKiRtRTYbNH4rz8ZqN6CCRUP2jj46LipOdbqUobe8zNUe3Lan\n\tfn9zArrFTC3z8FKMRr4pJBRDb4EpP/yI5zPDB8ti7CNuWkZgEcIvA==","From":"Farhan Ali ","To":"linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-pci@vger.kernel.org","Cc":"helgaas@kernel.org, lukas@wunner.de, alex@shazbot.org, clg@redhat.com,\n alifm@linux.ibm.com, schnelle@linux.ibm.com, mjrosato@linux.ibm.com,\n Julian Ruess ","Subject":"[PATCH v14 7/7] vfio/pci: Remove the pcie check for\n VFIO_PCI_ERR_IRQ_INDEX","Date":"Tue, 21 Apr 2026 09:30:31 -0700","Message-ID":"<20260421163031.704-8-alifm@linux.ibm.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260421163031.704-1-alifm@linux.ibm.com>","References":"<20260421163031.704-1-alifm@linux.ibm.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIxMDE2MiBTYWx0ZWRfX73/SrHfMXC7Z\n vR/AHEs23GpdaeFjs3gLFcKjKUMhdkVZZj1renW+u+ksgXn5SGswnvsC6e7/V8GrL2cQKJUbISt\n lC0YbzYKaVraWzItQjJG3C6qBPKZJncS+MYWmoOxjcSI2xnlH5xZk/jKvSweNO30OtnKEsfnCHR\n XvnbwOdqnURxNtAVyYcSwcuDrXZ0B3R/Glzt1MZ6NzoeOKaRyaCRMCO+0RnA4pHNyN6UtFpwa97\n IEUle4OsDlwB7grWKW6rQge69XWQGr41DLornjmZo16fKNFbOSQea2e6Iplg1EGYevVpYoLT76f\n xEvd7PB3Mo3Q8ODUOseCdKGV5y002Prfn4gONsFqT3gI9rgt3lC8shgiDCTLlzBURtQWNhtXWni\n zNGeMbdasIT01fojH88jwuI8OaDVJ/YdEsYGFeWIDp/gluBrFSXxU180PJI/0tXMhUA2lG9u07h\n PdanURmORYQ3l5lcRcA==","X-Proofpoint-GUID":"AYj6J4XkIPDisDyKP5fhnW2nJv1-CT-e","X-Authority-Analysis":"v=2.4 cv=SOJykuvH c=1 sm=1 tr=0 ts=69e7a636 cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=uAbxVGIbfxUO_5tXvNgY:22 a=VnNF1IyMAAAA:8 a=r1p2_3pzAAAA:8\n a=bf5i11FZjm5gBOpVircA:9 a=r_pkcD-q9-ctt7trBg_g:22","X-Proofpoint-ORIG-GUID":"AYj6J4XkIPDisDyKP5fhnW2nJv1-CT-e","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-21_03,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n malwarescore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0\n clxscore=1015 phishscore=0 suspectscore=0 adultscore=0 impostorscore=0\n bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000\n definitions=main-2604210162"},"content":"The error signaling is configured for the vast majority of devices and it's\nextremely rare that it fires anyway. Removing the pcie check will allow\nuserspace to be notified on errors for legacy PCI devices. The Internal\nShared Memory (ISM) device on s390 is one such device. For PCI devices on\nIBM s390 error recovery involves platform firmware and notification to\noperating system is done by architecture specific way. So the ISM device\ncan still be recovered when notified of an error.\n\nReviewed-by: Julian Ruess \nReviewed-by: Niklas Schnelle \nReviewed-by: Alex Williamson \nSigned-off-by: Farhan Ali \n---\n drivers/vfio/pci/vfio_pci_core.c | 8 ++------\n drivers/vfio/pci/vfio_pci_intrs.c | 3 +--\n 2 files changed, 3 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c\nindex 4485d85e4419..407be85dd565 100644\n--- a/drivers/vfio/pci/vfio_pci_core.c\n+++ b/drivers/vfio/pci/vfio_pci_core.c\n@@ -786,8 +786,7 @@ static int vfio_pci_get_irq_count(struct vfio_pci_core_device *vdev, int irq_typ\n \t\t\treturn (flags & PCI_MSIX_FLAGS_QSIZE) + 1;\n \t\t}\n \t} else if (irq_type == VFIO_PCI_ERR_IRQ_INDEX) {\n-\t\tif (pci_is_pcie(vdev->pdev))\n-\t\t\treturn 1;\n+\t\treturn 1;\n \t} else if (irq_type == VFIO_PCI_REQ_IRQ_INDEX) {\n \t\treturn 1;\n \t}\n@@ -1163,11 +1162,8 @@ static int vfio_pci_ioctl_get_irq_info(struct vfio_pci_core_device *vdev,\n \tswitch (info.index) {\n \tcase VFIO_PCI_INTX_IRQ_INDEX ... VFIO_PCI_MSIX_IRQ_INDEX:\n \tcase VFIO_PCI_REQ_IRQ_INDEX:\n-\t\tbreak;\n \tcase VFIO_PCI_ERR_IRQ_INDEX:\n-\t\tif (pci_is_pcie(vdev->pdev))\n-\t\t\tbreak;\n-\t\tfallthrough;\n+\t\tbreak;\n \tdefault:\n \t\treturn -EINVAL;\n \t}\ndiff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c\nindex 33944d4d9dc4..64f80f64ff57 100644\n--- a/drivers/vfio/pci/vfio_pci_intrs.c\n+++ b/drivers/vfio/pci/vfio_pci_intrs.c\n@@ -859,8 +859,7 @@ int vfio_pci_set_irqs_ioctl(struct vfio_pci_core_device *vdev, uint32_t flags,\n \tcase VFIO_PCI_ERR_IRQ_INDEX:\n \t\tswitch (flags & VFIO_IRQ_SET_ACTION_TYPE_MASK) {\n \t\tcase VFIO_IRQ_SET_ACTION_TRIGGER:\n-\t\t\tif (pci_is_pcie(vdev->pdev))\n-\t\t\t\tfunc = vfio_pci_set_err_trigger;\n+\t\t\tfunc = vfio_pci_set_err_trigger;\n \t\t\tbreak;\n \t\t}\n \t\tbreak;\n","prefixes":["v14","7/7"]}