{"id":2225584,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2225584/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/f7912b43c018b0a1c9b5d9e75418685782b213d2.1776759754.git.weijie.gao@mediatek.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<f7912b43c018b0a1c9b5d9e75418685782b213d2.1776759754.git.weijie.gao@mediatek.com>","list_archive_url":null,"date":"2026-04-21T08:35:52","name":"[v2,1/8] ubi: remove unnecessary extern directive from function prototypes","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"539f6dcd9a828bcd4800e0385617cb210e3fbdb2","submitter":{"id":75269,"url":"http://patchwork.ozlabs.org/api/1.2/people/75269/?format=json","name":"Weijie Gao","email":"weijie.gao@mediatek.com"},"delegate":{"id":1691,"url":"http://patchwork.ozlabs.org/api/1.2/users/1691/?format=json","username":"hs","first_name":"Heiko","last_name":"Schocher","email":"hs@denx.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/f7912b43c018b0a1c9b5d9e75418685782b213d2.1776759754.git.weijie.gao@mediatek.com/mbox/","series":[{"id":500759,"url":"http://patchwork.ozlabs.org/api/1.2/series/500759/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=500759","date":"2026-04-21T08:35:39","name":"Add support for ubi environment to create volumes","version":2,"mbox":"http://patchwork.ozlabs.org/series/500759/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225584/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225584/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256\n header.s=dk header.b=mtKLHU3N;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=mediatek.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=mediatek.com header.i=@mediatek.com\n header.b=\"mtKLHU3N\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=mediatek.com","phobos.denx.de;\n spf=pass smtp.mailfrom=weijie.gao@mediatek.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0G0R2XJPz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 18:36:07 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 2E47C843A4;\n\tTue, 21 Apr 2026 10:36:05 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 8511284258; Tue, 21 Apr 2026 10:36:04 +0200 (CEST)","from mailgw01.mediatek.com (unknown [60.244.123.138])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 085848439E\n for <u-boot@lists.denx.de>; Tue, 21 Apr 2026 10:36:01 +0200 (CEST)","from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by\n mailgw01.mediatek.com (envelope-from <weijie.gao@mediatek.com>)\n (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256)\n with ESMTP id 1445296538; Tue, 21 Apr 2026 16:35:56 +0800","from mtkmbs13n1.mediatek.inc (172.21.101.193) by\n mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.29; Tue, 21 Apr 2026 16:35:55 +0800","from mcddlt001.gcn.mediatek.inc (10.19.240.15) by\n mtkmbs13n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id\n 15.2.2562.29 via Frontend Transport; Tue, 21 Apr 2026 16:35:54 +0800"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,\n UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.2","X-UUID":["1db986563d5d11f19781c1a04af40193-20260421","1db986563d5d11f19781c1a04af40193-20260421"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n d=mediatek.com;\n s=dk;\n h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From;\n bh=EbpKUPeqjJfUE/mnb7lI+F50LNfZf1pwZlUg6Z2aDww=;\n b=mtKLHU3NKixbzfVMaMBQxmUdiNFpi+ACTsv1wmwpKx2DClD41UIkRo1JMKvWJAUQnwPwDckuL+pazvxgR8WmcQlz9oghna3K8+5ofAyc+xv8VGmiDw3U2Br29l4v2Ijhecyph3QCQ2jHrsll5NRW4kLbJeujH9qMPBj0ZLxDjuI=;","X-CID-P-RULE":"Release_Ham","X-CID-O-INFO":"VERSION:1.3.12, REQID:8962885b-7d6a-4998-ad2b-f7321b88b9a2,\n IP:0,\n U\n RL:0,TC:0,Content:0,EDM:-20,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO\n N:release,TS:-20","X-CID-META":"VersionHash:e7bac3a, CLOUDID:13b5ac8f-6df4-4a3d-a7a4-fbdc42d669ce,\n B\n ulkID:nil,BulkQuantity:0,Recheck:0,SF:81|82|102|836|865|888|898,TC:-5,Cont\n ent:0|15|50,EDM:1,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:-1,COL:0,\n OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0","X-CID-BVR":"2,SSN|SDN","X-CID-BAS":"2,SSN|SDN,0,_","X-CID-FACTOR":"TF_CID_SPAM_SNR","X-CID-RHF":"D41D8CD98F00B204E9800998ECF8427E","From":"Weijie Gao <weijie.gao@mediatek.com>","To":"<u-boot@lists.denx.de>","CC":"GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>, Tom Rini\n <trini@konsulko.com>, Marek Vasut <marek.vasut+renesas@mailbox.org>, Simon\n Glass <sjg@chromium.org>, Weijie Gao <weijie.gao@mediatek.com>","Subject":"[PATCH v2 1/8] ubi: remove unnecessary extern directive from function\n prototypes","Date":"Tue, 21 Apr 2026 16:35:52 +0800","Message-ID":"\n <f7912b43c018b0a1c9b5d9e75418685782b213d2.1776759754.git.weijie.gao@mediatek.com>","X-Mailer":"git-send-email 2.17.0","In-Reply-To":"<cover.1776759754.git.weijie.gao@mediatek.com>","References":"<cover.1776759754.git.weijie.gao@mediatek.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-MTK":"N","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"The extern directive is unnecessary for function declaration and should be\nremoved.\n\nSigned-off-by: Weijie Gao <weijie.gao@mediatek.com>\n---\nv2: new\n---\n include/ubi_uboot.h | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/include/ubi_uboot.h b/include/ubi_uboot.h\nindex ea0db69c72a..05fb9634d81 100644\n--- a/include/ubi_uboot.h\n+++ b/include/ubi_uboot.h\n@@ -44,12 +44,12 @@\n #endif\n \n /* functions */\n-extern int ubi_mtd_param_parse(const char *val, struct kernel_param *kp);\n-extern int ubi_init(void);\n-extern void ubi_exit(void);\n-extern int ubi_part(char *part_name, const char *vid_header_offset);\n-extern int ubi_volume_write(char *volume, void *buf, loff_t offset, size_t size);\n-extern int ubi_volume_read(char *volume, char *buf, loff_t offset, size_t size);\n+int ubi_mtd_param_parse(const char *val, struct kernel_param *kp);\n+int ubi_init(void);\n+void ubi_exit(void);\n+int ubi_part(char *part_name, const char *vid_header_offset);\n+int ubi_volume_write(char *volume, void *buf, loff_t offset, size_t size);\n+int ubi_volume_read(char *volume, char *buf, loff_t offset, size_t size);\n \n extern struct ubi_device *ubi_devices[];\n int cmd_ubifs_mount(char *vol_name);\n","prefixes":["v2","1/8"]}